Re: [edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Redfish common structures are moved to RedfishServiceData.h. Remove
> them from RedfishLib.h
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  RedfishPkg/Include/Library/RedfishLib.h | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishLib.h
> b/RedfishPkg/Include/Library/RedfishLib.h
> index 8309a67c76..fb30ff68f6 100644
> --- a/RedfishPkg/Include/Library/RedfishLib.h
> +++ b/RedfishPkg/Include/Library/RedfishLib.h
> @@ -70,6 +70,7 @@
>  #ifndef REDFISH_LIB_H_
>  #define REDFISH_LIB_H_
>
> +#include <RedfishServiceData.h>
>  #include <Library/JsonLib.h>
>
>  #include <Protocol/Http.h>
> @@ -78,22 +79,6 @@
>  #define ODATA_TYPE_NAME_MAX_SIZE  128
>  #define ODATA_TYPE_MAX_SIZE       128
>
> -///
> -/// Library class public defines
> -///
> -typedef  VOID  *REDFISH_SERVICE;
> -typedef  VOID  *REDFISH_PAYLOAD;
> -
> -///
> -/// Library class public structures/unions
> -///
> -typedef struct {
> -  EFI_HTTP_STATUS_CODE    *StatusCode;
> -  UINTN                   HeaderCount;
> -  EFI_HTTP_HEADER         *Headers;
> -  REDFISH_PAYLOAD         Payload;
> -} REDFISH_RESPONSE;
> -
>  ///
>  /// Odata type-name mapping structure.
>  ///
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115694): https://edk2.groups.io/g/devel/message/115694
Mute This Topic: https://groups.io/mt/104463407/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-