From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6BBB5780091 for ; Wed, 21 Feb 2024 01:55:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RhJfiSeVroy3k9q4tgDbdWZbpC3MoK6nv0habSVCEtg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708480499; v=1; b=r8F1+PqE8cjvv747NTa4uJzbI1UnI0WtgZvWO2DdltVfeDiLo74zP0VRCixgjiQnCsTvy1N2 DgzbL9Fyp1378WFTnDdtqBClQXQDNTNnhUraz1uQ0A2MRW5mJsgva6U0B+6wmyLu5hLFGz5koIr WyF2ajYkyyVl01Fb3w9exz+U= X-Received: by 127.0.0.2 with SMTP id KfW0YY7687511xYM9czusA7O; Tue, 20 Feb 2024 17:54:59 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.52]) by mx.groups.io with SMTP id smtpd.web10.3897.1708480499190282761 for ; Tue, 20 Feb 2024 17:54:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xe0ZqJaD9h8Mx8SaU4eWUZ4MoRv5+LIb7fm+DGuOizh1bBA1fdTn2Rsiije51PWJ+wH9gqVm6CPaEeJHcVjOgqYBf0ca0ih5gAgYy9d7KOZdcrsV+4JonqqCetoNM0k3wBIVadhScP7POIG0bqUdmuXgCunvtUtdVsrbHrRfUzEg9Cd1i2NqDyNw+A45TX7+yhPPK855rMUc8obEY/Zheq86QWLnrmLW+7jgRYSGNeKs/lKrcHthnoVBwhdXQmgMsB2BT7pmtI1+gNb7P3PZ1HwbIYbXjE7TnQ7cemzH1YA8FDF2IZH+h1cYtIA0hJGjA1zXLCFg2LpyzciaQ/rpdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBg9bQNgrHFAb93ZWXSDkZ+wbHVhNNtc3EOSolNU+/E=; b=VYYk4y3+1939JB3UnztuzTw3K6Gm2xWEAd46MpeZOrl+WsNKOwQ59HWMojGB1bkJB8dwrg1gPcQUXw7neiu6YIjb4JsCTLpdz2DdOTYrAiSK3D6FWIrCIRhmmY/lzqz7WPmSKCj7+KP125vl5t7+LQFLJG8oliiLGlWUA0lViVhvrEQHITbG4d8Eif3iW5Fkb7KiJhKrj4RzIAaXCUs7tT66cJ0RiDI8FeV2TJJTy72d3voxX+02OOvdf8wYyWmQ7HD9U8fC3hNIBd+wxPDlOZXsL/RwfmPEsI9wISYQBjnYO0hnHyVRfNThtssWNI6uMHTQkbmKrky56aBEf0K7ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by MW6PR12MB7088.namprd12.prod.outlook.com (2603:10b6:303:238::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 01:54:56 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1%4]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 01:54:56 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h Thread-Topic: [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h Thread-Index: AQHaY8fjuBbuWkAs3kGIKzUg7fgJSbEUCk/A Date: Wed, 21 Feb 2024 01:54:56 +0000 Message-ID: References: <20240220064138.28505-1-nicklew@nvidia.com> In-Reply-To: <20240220064138.28505-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c06934d9-6e46-4ce0-9cff-c8d0c08672e3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T01:54:41Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|MW6PR12MB7088:EE_ x-ms-office365-filtering-correlation-id: 1506b447-9637-4660-0b74-08dc32801aba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: cq5Dw6ZGC2Al2Y1aNF4ttyqtTWVduzaZ/7TVoM/GrkJo9oncCquz8WE7LoXaTn7IyLzq48BXyXQLuv4As4SDfNubimXzoMRCSo8bzQL3BpVR3BymcyBHxQiKbaxnKPplH2y7XnHckX+3AUuteLGNNfHL+YaMe4TxnoxWqPxfI93UXVJ2u3LNrMSeiPIDf4QvYVLpXQZzhZL7uo6XopspfaraJa93wq7NzaokinIm5Xwe3LUjL9H3Mi3l83hIoWA5+eqdX8Af60mn7gpUPCeOGZLmIfB99aVdWa1pD8tyH1c2Emn2pOdKzBuGemH6wSqBLrIPUQLmjo4YXcULuubhU37xwt7mgn1z3boweKg0qIYK8O5ZwkMbGLJxMjzhOABnyKTZUmgHR/SvK6OSwsEplkJXhAPRjhAWxjOefS30XBV0ltuCpIyBKJit0mr06hha8zSuo2BlXqoQ02fEVUvh3cRxpzldoKRXuKVHgZ3v5eFiW7Ab/8R5j1TgBx7PjoTmVHLQo9faaoYr6oTcnh3mJiWZPXmIoqEdP1L1+QjPaAByZzDvobOsN6V5C3EWl73aqj4Y9T33yxduOjl0DmOKkchBjMEcob2Th8VzIm+PlFssY6sOW3iOuE6NS1g+fBg1 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jHGpPNBGrXKXginPn6QuRw8IuojZ5KGToLwP2EpDLTBtSmwz2jh7faDOHHKs?= =?us-ascii?Q?QKPg2FloFSQcnv+XHr3prvMYqRswvlJKqcvuO1LloP6C41587WfwtLIO7Gi1?= =?us-ascii?Q?nq0Ka5Zk8aBbFLnn5pM4qu2lnRDCjQOIQEWI7ao2RU0XWc9icwnIssIw4dBB?= =?us-ascii?Q?jOuo2Xn170LnZlJ3ByFKiqitG2M6X/UvfkM4QnhirwS1tHZtQ8GKJFM2raRP?= =?us-ascii?Q?T6dM9ys4RbROX9+dXOd36YbygvshP3DWS71ovGLyhFPUU5PUX08wzxpvw8Qq?= =?us-ascii?Q?guxlTO9wrnzGL+Y2ONSd5QumMPgio3wlVKNHJfY1s1XO8q8ePcUdFYRh47lx?= =?us-ascii?Q?KnVCng03bR0wO+nq2YH24v1baDXjWeKB4vhpDNIVWHITVSUuUuMjXMorEEhp?= =?us-ascii?Q?6jaXoec89ISKbTWLIMkd/XIt/TLs5hQxzw5NMOgcmBDqpfyTKaVT2FzGEADu?= =?us-ascii?Q?TKsh5jAUFl8XlGJ0krjSCmnXGWn2sDEIkJ2QmiTeAFoGjE96seAuCknIYOzZ?= =?us-ascii?Q?xsbp0Etg35erq6I+MChsPn31nNkMzCGDXqVhSFDFmJ4g1Mg4MZ8PQ8uxD5TP?= =?us-ascii?Q?v+1eQ/KIEq3WEyMkqKq3Mo3z0inj3Em9mo8uKGiSSO7gNHOC8gJeAJFZhiuT?= =?us-ascii?Q?JCXy9IYtThjiUcDGptVb9wCPfdRGtESXW/xpKFsqECHv8ff+fLXHmhuh7iQ3?= =?us-ascii?Q?cBL9NCUHlxpkT5Ps8y2FPBw3pvbtqUGSONPxbj1qKcBq0/PAqye8tka8XdF3?= =?us-ascii?Q?ifK5BeYXndWEuTOLaXQQWpWu3Io6wE/yevh6ius67h3cek45Wl5qCgF8gCWm?= =?us-ascii?Q?aTnvTBbEkrQZeu8vo1pOaeM25dso6oBwbKYldQFByTVWP3qL8IHE9Ytb8jD4?= =?us-ascii?Q?B/50gsOxtVxsECfQPZvtzDCx0FQOWEw5DPlmVD1mDSY/6jchmbpY7C7kFn2w?= =?us-ascii?Q?YBmv6p2anGYJ0Ds2CJCzDPQ1MincRzKt8g0I3fSr29jDUFxngXdg4Q14R5VK?= =?us-ascii?Q?MovRV3wBDjFY3jZT+EVoDfyCFhUdf2TdynoQtWLWeMsFSxRa1h3lyPToPrFC?= =?us-ascii?Q?UrEEllSa40vffNBx1yi5In98B1kInP8kLcc+U4SRRsFZ00ZkWvxr26huJvET?= =?us-ascii?Q?oAiZwYqIgf1NVZnHSITjR0Qi1Ji0i5oBsFricg9UeuDUgDN6ZIOWOTit94CU?= =?us-ascii?Q?LpmRgKjeYWGKE7ir0c6kzP8C0uC4X96lBY+snFDl6YbWDh98//8TOGRi8Kap?= =?us-ascii?Q?vy6LSYR0H0FLp53cA7uVGgMlhbiqYiUtDjCO1YZcwVQnacXzJxnacBr/Tnov?= =?us-ascii?Q?qloGN6/gpHGLM5Jow4kspzmCdeZQMovSyj8I/iR8A4XkaaE4UYzIOcX7MAvJ?= =?us-ascii?Q?nGzuuxs1B/We/Y1GPo9F29mEXmIRhe9eSZEg7dl2m2ufa27ZFSMp8RXYYHYX?= =?us-ascii?Q?5ZbFG9Nf4f1Wi+IfIDvbkGLgzu9dm0HeNrqorid9FmvAkGOPTOOSlALtwsLx?= =?us-ascii?Q?uHY7Spu8UXluYy7HRBC2WKFjOLyyEuNyqmPYHJGTmfrLs/2Bf6OXX/wNY0xq?= =?us-ascii?Q?he48qij0rT8UqybLjng=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1506b447-9637-4660-0b74-08dc32801aba X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 01:54:56.4832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xj6GhYoxKt7H5w3XgyT2OC+lkn1dl6wGz64l5zzvxbAWCVjWHPR5sSj9APMTjLdqLPUV+NKBxAfYXvDjajF5Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7088 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nPdDkEaQQVazqdK4vGeyFhDVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r8F1+PqE; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] As I already reviewed offline on Nickle's personal Git repo, Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, February 20, 2024 2:42 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Redfish common structures are moved to RedfishServiceData.h. Remove > them from RedfishLib.h > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishPkg/Include/Library/RedfishLib.h | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishLib.h > b/RedfishPkg/Include/Library/RedfishLib.h > index 8309a67c76..fb30ff68f6 100644 > --- a/RedfishPkg/Include/Library/RedfishLib.h > +++ b/RedfishPkg/Include/Library/RedfishLib.h > @@ -70,6 +70,7 @@ > #ifndef REDFISH_LIB_H_ > #define REDFISH_LIB_H_ > > +#include > #include > > #include > @@ -78,22 +79,6 @@ > #define ODATA_TYPE_NAME_MAX_SIZE 128 > #define ODATA_TYPE_MAX_SIZE 128 > > -/// > -/// Library class public defines > -/// > -typedef VOID *REDFISH_SERVICE; > -typedef VOID *REDFISH_PAYLOAD; > - > -/// > -/// Library class public structures/unions > -/// > -typedef struct { > - EFI_HTTP_STATUS_CODE *StatusCode; > - UINTN HeaderCount; > - EFI_HTTP_HEADER *Headers; > - REDFISH_PAYLOAD Payload; > -} REDFISH_RESPONSE; > - > /// > /// Odata type-name mapping structure. > /// > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115694): https://edk2.groups.io/g/devel/message/115694 Mute This Topic: https://groups.io/mt/104463407/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-