* [edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h
@ 2024-02-20 6:41 Nickle Wang via groups.io
2024-02-21 1:54 ` Chang, Abner via groups.io
0 siblings, 1 reply; 2+ messages in thread
From: Nickle Wang via groups.io @ 2024-02-20 6:41 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez
Redfish common structures are moved to RedfishServiceData.h. Remove
them from RedfishLib.h
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
RedfishPkg/Include/Library/RedfishLib.h | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/RedfishPkg/Include/Library/RedfishLib.h b/RedfishPkg/Include/Library/RedfishLib.h
index 8309a67c76..fb30ff68f6 100644
--- a/RedfishPkg/Include/Library/RedfishLib.h
+++ b/RedfishPkg/Include/Library/RedfishLib.h
@@ -70,6 +70,7 @@
#ifndef REDFISH_LIB_H_
#define REDFISH_LIB_H_
+#include <RedfishServiceData.h>
#include <Library/JsonLib.h>
#include <Protocol/Http.h>
@@ -78,22 +79,6 @@
#define ODATA_TYPE_NAME_MAX_SIZE 128
#define ODATA_TYPE_MAX_SIZE 128
-///
-/// Library class public defines
-///
-typedef VOID *REDFISH_SERVICE;
-typedef VOID *REDFISH_PAYLOAD;
-
-///
-/// Library class public structures/unions
-///
-typedef struct {
- EFI_HTTP_STATUS_CODE *StatusCode;
- UINTN HeaderCount;
- EFI_HTTP_HEADER *Headers;
- REDFISH_PAYLOAD Payload;
-} REDFISH_RESPONSE;
-
///
/// Odata type-name mapping structure.
///
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115629): https://edk2.groups.io/g/devel/message/115629
Mute This Topic: https://groups.io/mt/104463407/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h
2024-02-20 6:41 [edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h Nickle Wang via groups.io
@ 2024-02-21 1:54 ` Chang, Abner via groups.io
0 siblings, 0 replies; 2+ messages in thread
From: Chang, Abner via groups.io @ 2024-02-21 1:54 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Igor Kulchytskyy, Nick Ramirez
[AMD Official Use Only - General]
As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Redfish common structures are moved to RedfishServiceData.h. Remove
> them from RedfishLib.h
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
> RedfishPkg/Include/Library/RedfishLib.h | 17 +----------------
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishLib.h
> b/RedfishPkg/Include/Library/RedfishLib.h
> index 8309a67c76..fb30ff68f6 100644
> --- a/RedfishPkg/Include/Library/RedfishLib.h
> +++ b/RedfishPkg/Include/Library/RedfishLib.h
> @@ -70,6 +70,7 @@
> #ifndef REDFISH_LIB_H_
> #define REDFISH_LIB_H_
>
> +#include <RedfishServiceData.h>
> #include <Library/JsonLib.h>
>
> #include <Protocol/Http.h>
> @@ -78,22 +79,6 @@
> #define ODATA_TYPE_NAME_MAX_SIZE 128
> #define ODATA_TYPE_MAX_SIZE 128
>
> -///
> -/// Library class public defines
> -///
> -typedef VOID *REDFISH_SERVICE;
> -typedef VOID *REDFISH_PAYLOAD;
> -
> -///
> -/// Library class public structures/unions
> -///
> -typedef struct {
> - EFI_HTTP_STATUS_CODE *StatusCode;
> - UINTN HeaderCount;
> - EFI_HTTP_HEADER *Headers;
> - REDFISH_PAYLOAD Payload;
> -} REDFISH_RESPONSE;
> -
> ///
> /// Odata type-name mapping structure.
> ///
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115694): https://edk2.groups.io/g/devel/message/115694
Mute This Topic: https://groups.io/mt/104463407/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-21 1:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 6:41 [edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h Nickle Wang via groups.io
2024-02-21 1:54 ` Chang, Abner via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox