From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>, Nickle Wang <nicklew@nvidia.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()
Date: Mon, 25 Mar 2024 02:12:37 +0000 [thread overview]
Message-ID: <LV8PR12MB9452C7DB584724BEBBAED1A4EA362@LV8PR12MB9452.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240323120050.53834-1-mike.maslenkin@gmail.com>
[AMD Official Use Only - General]
For this patch set, Reviewed-by: Abner Chang <abner.chang@amd.com>
Hi Nickle, please also take a look at this change. Thanks
Abner
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, March 23, 2024 8:01 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy <igork@ami.com>;
> Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix
> GetRedpathNodeByIndex()
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> This set contains fixes for proper nodes handling in GetRedpathNodeByIndex().
> It fixes handling of nodes with Index different from 0,
> it removes leading '/' returned for section with Index = 0,
> also it fixes return of the last section.
This set does not have any impact to
> existing code,
> because in all places this function is used to obtain the end of the first section.
> And actually returned pointer to the requested section is not used.
> The current usages is:
> GetRedpathNodeByIndex (ConfigLangList.List[0].ConfigureLang, 0,
> &EndOfChar);
>
> and return of EndOfChar value is not affected by this set.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117073): https://edk2.groups.io/g/devel/message/117073
Mute This Topic: https://groups.io/mt/105101990/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-25 2:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 12:00 [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex() Mike Maslenkin
2024-03-23 12:00 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 1/3] RedfishClientPkg: fix nodes count in GetRedpathNodeByIndex() Mike Maslenkin
2024-03-26 12:16 ` Nickle Wang via groups.io
2024-03-23 12:00 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 2/3] RedfishClientPkg: fix the last field processing " Mike Maslenkin
2024-03-26 12:17 ` Nickle Wang via groups.io
2024-03-23 12:00 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node " Mike Maslenkin
2024-03-26 13:39 ` Nickle Wang via groups.io
2024-03-25 2:12 ` Chang, Abner via groups.io [this message]
2024-03-26 13:41 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex() Nickle Wang via groups.io
2024-03-26 21:18 ` Mike Maslenkin
2024-04-01 13:33 ` Nickle Wang via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LV8PR12MB9452C7DB584724BEBBAED1A4EA362@LV8PR12MB9452.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox