Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver:\r ComputerSystem_1_13_0 driver

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

It is no problem. 😊 Thank you Mike for looking into this patch.
Abner

> -----Original Message-----
> From: M M <mike.maslenkin@gmail.com>
> Sent: Friday, January 26, 2024 10:11 PM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V2]
> RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> You are right.
>
> Sorry for the noise!
>
> No problems here.
> I mixed up with tags in my editor while looked into patch.
>
> Regards,
> Mike
>
> > On 26. 1. 2024., at 17:03, Chang, Abner <Abner.Chang@amd.com> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Mike,
> > I can't identify the issue on %s as Private->Uri is defined as EFI_STRING, or I
> miss something?
> >
> > Thanks
> > Abner
> >
> >> -----Original Message-----
> >> From: M M <mike.maslenkin@gmail.com>
> >> Sent: Friday, January 26, 2024 9:55 PM
> >> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> >> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> >> <igork@ami.com>
> >> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V2]
> >> RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver
> >>
> >> Caution: This message originated from an External Source. Use proper
> caution
> >> when opening attachments, clicking links, or responding.
> >>
> >>
> >> Hi Abner,
> >>
> >>> On 26. 1. 2024., at 05:20, Nickle Wang via groups.io
> >> <nicklew=nvidia.com@groups.io> wrote:
> >>>
> >>> Hi Abner,
> >>>
> >>> Same minor issue as 1_5_0. Please add "%a:" to below DEBUG call.
> >>>
> >>>> +      DEBUG ((DEBUG_MANAGEABILITY, "  No platform Redfish
> >> ConfigureLang
> >>>> found for %s\n", __func__, Private->Uri));
> >>>
> >>> Regards,
> >>> Nickle
> >>
> >> There are two issues in this string. The second one is incorrect  %s format
> used
> >> for Private->Uri.
> >> This issue exists in V3 not only in the line mentioned above.
> >>
> >> Regards,
> >> Mike.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114616): https://edk2.groups.io/g/devel/message/114616
Mute This Topic: https://groups.io/mt/103967446/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-