From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B768DAC0D8A for ; Wed, 29 May 2024 08:57:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kggoaMA8Cc7hl1pBj9fTj7RmfcK4Ft27yHIWy77PElg=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716973027; v=1; b=i5nEAXLmcjTPXZcGSQYeQLe5JR+zm0+QuO6flkNNopL/z7b1HT54Pzb/8FdfoXLmTtMlMuef L77r/XUHHh8ov+Q2cKewY7eDBUDG+upTcQoD7dGhfFIPnooaLeCv+vF6orSgkJJtWsUTgLBMr7P RDeSFVuWPcg7MLyFaFLBAEDTeE4BmPEcsuKhPnEyONs02G/ZTanpWlhJQ2TQfcJmIkDbRM0yS34 tF9HT883tzcm5X174riUNpzHT9loaVDQYMSf7TB/0K9BtEgrGVAJ8XPliqi3XLl0Lm2qGd92pgv kCNPvdhR+LZFhOFGIOGEuzDM15NSelhCTEkbk4+YP6Btg== X-Received: by 127.0.0.2 with SMTP id px9MYY7687511xRbaYyOEZCn; Wed, 29 May 2024 01:57:06 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.67]) by mx.groups.io with SMTP id smtpd.web11.9198.1716973025269971178 for ; Wed, 29 May 2024 01:57:05 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by PH7PR12MB8795.namprd12.prod.outlook.com (2603:10b6:510:275::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Wed, 29 May 2024 08:57:00 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08%5]) with mapi id 15.20.7633.017; Wed, 29 May 2024 08:56:59 +0000 From: "Chang, Abner via groups.io" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , "Grimes, Paul" Subject: Re: [edk2-devel] [edk2-platforms 1/3] AmdPlatformPkg: Removes unused gBoardBdsBootFromDevicePathProtocolGuid Thread-Topic: [edk2-platforms 1/3] AmdPlatformPkg: Removes unused gBoardBdsBootFromDevicePathProtocolGuid Thread-Index: AQHasQh3hnpUjKaioEagL43i448hKLGt6iow Date: Wed, 29 May 2024 08:56:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=e8226465-27de-4bbe-9f3b-1ba857dd6f51;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-29T08:56:38Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|PH7PR12MB8795:EE_ x-ms-office365-filtering-correlation-id: bfce8bac-72e9-4068-01ac-08dc7fbd4cee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?Bn0iYIr68prDBM8PJ62cY92C4btJBJJDlDcdn1+nXColLLjZw8lOnxR3cSqQ?= =?us-ascii?Q?7dgBdRe3HJITReLM2WZSwnCtOhio1z2SNgDW+73VLEd47qS1Gg23NezBcPhc?= =?us-ascii?Q?SLj65z2vmXgW3haWU1foZ+w/t339QmNvJIWR2qqm9iXKHnIA2Hgf8IKUPTzy?= =?us-ascii?Q?pWuNCYYWsQYEjSbcV3sXxzGWXJHZs6J2Y1h8Z08+c/7fH0HpBeBEQbX5irqg?= =?us-ascii?Q?r6cpJsFcu7nkN1hvYT7bhbPG0JjQld8Js4WGYM7Id9KeTC/pG8EyRGB1Ri+k?= =?us-ascii?Q?1AebkMqfMD8NwfbI43951oUsWttpnShdsdFIPDYDbBc1F9667P5b/fh5NpeC?= =?us-ascii?Q?shdK27PvDCUzWOJOdLd18FI2cwm817ovsxZxRmxOodX/Zt0pe0ry1D8hAF8O?= =?us-ascii?Q?BzOu+Iqnanm9PKfx9dGQRj/u8jJ/uCkyc6vQt5q2B2tDygWsFfd02ykW2qJ5?= =?us-ascii?Q?lJnxvo1VwkDQlHSEUSYL0ZVEzqwnzb3DCNyBtzhM2Z0Xec89n44snO8ZJhiy?= =?us-ascii?Q?EOnWJ/ozKaB2v1El6LfIe2MuUWqPJkKDvLcX5bYB4S9ygyuZSrzJ7iEYH/vP?= =?us-ascii?Q?1lo9in9+RNxtfl16QmbfEKnqOrk8sQs7MiJPSyexTkmANA3DkU3hgkN6J6Zr?= =?us-ascii?Q?+VvSri9e1PwgVOuUipsid+S1LSYv1MQo+f0suyjFBg+VWTUQPW1/BPoeNj7N?= =?us-ascii?Q?ri/R5A4ISY7AySMf6eW7fpMaKiRhzxBjwZ+z/JU4PT0ThCasP7XPMqTs73F5?= =?us-ascii?Q?uIwJXf2Qu7J3GhTAa+vF+iXmo8g2TyQw7kKTw16ZRExiE7rHUiwsids9cMsy?= =?us-ascii?Q?WEpVvoRn2kDo0KryFYo/5wHsYpTAytfkwXAsZ72O6xJOtiMJQdjsndhtPoKF?= =?us-ascii?Q?hBeW804WpottNt6EMcdPChZ640INJmqbuDOf94+YJNVqawB5vTazbCUZFGJ9?= =?us-ascii?Q?n972h9Wqoj0WopvxSyvGrbkrIxehAFHlUB3tG0VFTFDKT0TCJDWUWDovU50T?= =?us-ascii?Q?tMd6iwNc1lnxrg3CIYFNpc7GiX9Qk419EbwiqNzNtwSJZfMkiC4Kgd/Alapk?= =?us-ascii?Q?gyZ9BlKZUu/y8AJS3I9tCW2rPHtr6jqVvjgtivFs3/zCFAY9L6z9Ap38wUVR?= =?us-ascii?Q?otKH1Dz5G4V4DYIwwPiB8CoAorYVAlb/45o8N6QZo7av9Q+kmKYZ69Us8orH?= =?us-ascii?Q?0OjmQcu53sTqhoSkbWXcACBf8Kr3ZP1tiIVu/WQcl6CvBL346gDzCKHqREPE?= =?us-ascii?Q?FHqFM31QvDq+DkNF6l5u8Iy0tkTqsDo4sUQqAFb6SNggtCDirIf2GgB60dHs?= =?us-ascii?Q?F1YMst1eI9DJgomWmPFB07+AS13T8WVa5mUVYtlVF5Aecg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VkX4DcaVvIv8Z0C3yu7thx+Ee3klgGGejtoqyY9lboBGYZF5WtXb065MzC1l?= =?us-ascii?Q?de4M3s41jV9aFBe7+7YuSH64K21rkNxDy9kyMaM6vxFsutluvQeX5J2aT63Y?= =?us-ascii?Q?YWGxqdrJcfNWQiusQOIYw1PSUKyrrtWZYGXlCJ03vAYm8HnbIksfQinwss8a?= =?us-ascii?Q?H6Nj2x0JmNSFciczzDhLluFEfa4EWt5B7LfN/HwSTVHgOuqjNBGv3rM4du38?= =?us-ascii?Q?uHrj/SsJBXI6Zty7hXAO5KTvHqonzcnh7jdcrdSSxaL0VofQ3dJwbmrk1Z76?= =?us-ascii?Q?0ZpGQE2vACEH/8D4Z7XQEJItw6WN64vORc692/wCmZJzXw1QaQKr5rU354Qz?= =?us-ascii?Q?1gzoe2JpOYC4Q7o2WYnNjz0Oz7oKoPVskSs4cD7hulamyjZfApTCtZApptb9?= =?us-ascii?Q?8d/+zdm0IuFxdK9AGsEtBAmCDah4wHK7n5MH3XWPISIeSkg+RSpLg8bFXB6F?= =?us-ascii?Q?MNNC18tWdl9fPjGcaiD/SuDpgIyuzt9bCTFq0s/B/H9gOOchukmW8oH4VbG3?= =?us-ascii?Q?pG5wVWlQ9MBl2ykyjCjmWoxQzJx+Iqh1fhf4x6HZhknayP9AjJ8rmhQtZ+D7?= =?us-ascii?Q?4uIjE/C0m0Ye5n20g4ItJK61bxHeA+B4+0qmacENjNKdiOACtNSskkfvq+Ux?= =?us-ascii?Q?L9pG1qu1NUe6HIqxAeIz5oJ+/rKS4SJHsTZCc9zLNdYJCsXcvmLgZkF0usAl?= =?us-ascii?Q?KzpiFkxqN5aUOb2YIyqL0sLsfHGwGoiWMz3VJeM62ckRtCGtcrKwuNqNZRLz?= =?us-ascii?Q?ftW7IqkldKae2gjBLd1ZyaXIzOAc/QVBnrmvt1pYS1tjBBX6MPGG0Z0nU1y6?= =?us-ascii?Q?M/JdPrfQXS0QqCVylCw6c4ThMGVCX6YaPqYTVoN80fFy+1vft01mqmazGLFn?= =?us-ascii?Q?OfhtdKDwx5OFIpKl7QSNSPsv+2YFd6wEUVgejvPCks53lcFUQwiJF5NRXe0K?= =?us-ascii?Q?dpyBFrl5EM7kS3lG6JMAtwtC/AIg78pZ1Xvu0yAczJpYLD9GptH/SeICrfmX?= =?us-ascii?Q?8G1q904t0ZuhoZbr4laMHrMQyiC0SilTrO2NHDIfI3iNmPz1/lTR2tVaAlN1?= =?us-ascii?Q?marCZKJ0WgubT8Bxsg+Sd7DIyrdrRmoLGmHdj8NaaA/AlRgRX94BS4MmQhMg?= =?us-ascii?Q?7E8uGOIw15brljwLu1i0EVSQM+HI8/rmoVJ+iwFhvKcMwWpdQI+Y12Nze0Sz?= =?us-ascii?Q?gBbDNr+WALyj7eU71ZlGLr+4gfcLYLaEhDH2BBEAhQ+wHBvopXGEcXheatzk?= =?us-ascii?Q?xw9OT5gntZNLYV7qX6fHVVAlTCPYIAHs1lK1aTKk7csU9GZMFHgPMkt3g3r0?= =?us-ascii?Q?x495UtyXKIy2c7EaG2YgbRGd90djKe7RU5ASmFhP+0bKymLT7K9Z2mNvtbK7?= =?us-ascii?Q?Rr12K3Y4mSO0d7d5Fps3uUhJJ6kZ26Rph+AorTL5GlVjUdU7vXSrGG8m0O1w?= =?us-ascii?Q?lp2dkMRHT60U9B4ebCF0H/eOxQb1/8qTT4PdXJZgJZlZoeHKH7hCSkXBcFMH?= =?us-ascii?Q?RSAc0e8rHM8NZ0tp8iHFGd/L4HtiDSWh1+n+LoPFxak5n2ZUzF56KxX5mzQu?= =?us-ascii?Q?Y9NoiusPo5hVHckInzU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfce8bac-72e9-4068-01ac-08dc7fbd4cee X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 08:56:59.5560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HCq7RqnXM2XSRuZEeuro8waimzj1LeBrYIYe0PxEO3oJQqDLzlovaJ4pmjJfGtiXd1DlJjpjDaPTREH8CRT3Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8795 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 01:57:05 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DDZvofponUTMK5nrO1PNcaugx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=i5nEAXLm; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang > -----Original Message----- > From: Abdul Lateef Attar > Sent: Tuesday, May 28, 2024 10:08 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grimes, Paul > Subject: [edk2-platforms 1/3] AmdPlatformPkg: Removes unused > gBoardBdsBootFromDevicePathProtocolGuid > > Removes unused gBoardBdsBootFromDevicePathProtocolGuid protocol, > and its corresponding code changes. > Adds missing Pcd/SmbiosPcd.h file. > > Cc: Abner Chang > Cc: Paul Grimes > Signed-off-by: Abdul Lateef Attar > --- > .../AmdPlatformPkg/Include/Pcd/SmbiosPcd.h | 58 ++++++++ > .../SmbiosCommonDxe/DefaultLomDevicePath.c | 130 ------------------ > .../Universal/SmbiosCommonDxe/SmbiosCommon.h | 12 -- > .../SmbiosCommonDxe/SmbiosCommonDxe.inf | 3 - > .../SmbiosCommonDxe/SmbiosCommonEntryPoint.c | 2 - > 5 files changed, 58 insertions(+), 147 deletions(-) > create mode 100644 > Platform/AMD/AmdPlatformPkg/Include/Pcd/SmbiosPcd.h > delete mode 100644 > Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/DefaultLom > DevicePath.c > > diff --git a/Platform/AMD/AmdPlatformPkg/Include/Pcd/SmbiosPcd.h > b/Platform/AMD/AmdPlatformPkg/Include/Pcd/SmbiosPcd.h > new file mode 100644 > index 0000000000..2dd0480df9 > --- /dev/null > +++ b/Platform/AMD/AmdPlatformPkg/Include/Pcd/SmbiosPcd.h > @@ -0,0 +1,58 @@ > +/** @file > + Miscellaneous smbios data structures. > + > + Copyright (C) 2023 - 2024 Advanced Micro Devices, Inc. All rights rese= rved. > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef AMD_SMBIOS_PCD_H_ > +#define AMD_SMBIOS_PCD_H_ > + > +#include > +#include > + > +#define AMD_SMBIOS_TYPE8_MAX_PORT_CONNETORS 16 > +#define AMD_SMBIOS_TYPE41_MAX_ONBOARD_DEVICES 16 > + > +typedef struct { > + CHAR8 IntDesignatorStr[SMBIOS_STRING_MAX_LENGTH]; > + CHAR8 ExtDesignatorStr[SMBIOS_STRING_MAX_LENGTH]; > +} PORT_CONNECTOR_STR; > + > +// > +// AMD SMBIOS type 8 record structure. > +// > +typedef struct { > + SMBIOS_TABLE_TYPE8 Type8Data; > + PORT_CONNECTOR_STR DesinatorStr; > +} SMBIOS_PORT_CONNECTOR_RECORD; > + > +// > +// AMD SMBIOS type 8 record structure array. > +// > +typedef struct { > + SMBIOS_PORT_CONNECTOR_RECORD > SmbiosPortConnectorRecords[AMD_SMBIOS_TYPE8_MAX_PORT_CONNETOR > S]; > +} SMBIOS_PORT_CONNECTOR_RECORD_ARRAY; > + > +// > +// AMD SMBIOS type 41 record structure > +// > +typedef struct { > + SMBIOS_TABLE_STRING ReferenceDesignation; > + UINT8 DeviceType; > + UINT8 DeviceEnabled; > + UINT8 DeviceTypeInstance; > + UINT16 VendorId; > + UINT16 DeviceId; > + CHAR8 RefDesignationStr[SMBIOS_STRING_MAX_LENGTH]; > +} SMBIOS_ONBOARD_DEV_EXT_INFO_RECORD; > + > +// > +// AMD SMBIOS type 41 record structure array. > +// > +typedef struct { > + SMBIOS_ONBOARD_DEV_EXT_INFO_RECORD > SmbiosOnboardDevExtInfos[AMD_SMBIOS_TYPE41_MAX_ONBOARD_DEVIC > ES]; > +} SMBIOS_ONBOARD_DEV_EXT_INFO_ARRAY; > + > +#endif // AMD_SMBIOS_PCD_H_ > diff --git > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/DefaultLo > mDevicePath.c > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/DefaultLo > mDevicePath.c > deleted file mode 100644 > index 92c7aa5e07..0000000000 > --- > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/DefaultLo > mDevicePath.c > +++ /dev/null > @@ -1,130 +0,0 @@ > -/** @file > - This file contains the implementation of the DefaultLomDevicePath prot= ocol. > - The DefaultLomDevicePath protocol is used to identify the default LOM > device > - path for the system. The protocol is installed by the SmbiosCommonDxe > driver > - and is used by the BDS to identify the default LOM device path for the > system. > - > - Copyright (C) 2023 - 2024 Advanced Micro Devices, Inc. All rights rese= rved. > - > - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include "SmbiosCommon.h" > -#include > -#include > - > -EFI_HANDLE mBoardBdsHandle =3D NULL; > -BOARD_BDS_BOOT_FROM_DEVICE_PATH_PROTOCOL > mBootDevicePathProtocol; > - > -/** > - Find the Lan-On-Motherboard device path. Installs > BOARD_BDS_BOOT_FROM_DEVICE_PATH_PROTOCOL > - with the LOM device path protocol > - > - @retval EFI NOT_FOUND LOM device path is not found > - @retval EFI_SUCCESS LOM device path found > -**/ > -EFI_STATUS > -EFIAPI > -InstallLomDevicePath ( > - ) > -{ > - SMBIOS_ONBOARD_DEV_EXT_INFO_RECORD *DevExtInfoRecord; > - EFI_STATUS Status; > - EFI_HANDLE *PciHandles; > - UINTN PciHandlesSize; > - UINTN Index; > - EFI_PCI_IO_PROTOCOL *PciProtocol; > - PCI_IO_DEVICE *PciIoDevice; > - UINT8 NumberOfDevices; > - UINT8 DevIdx; > - UINTN SegmentNumber; > - UINTN BusNumber; > - UINTN DeviceNumber; > - UINTN FunctionNumber; > - > - NumberOfDevices =3D PcdGet8 (PcdAmdSmbiosType41Number); > - DevExtInfoRecord =3D (SMBIOS_ONBOARD_DEV_EXT_INFO_RECORD > *)PcdGetPtr (PcdAmdSmbiosType41); > - > - // No device entries found > - if (NumberOfDevices =3D=3D 0) { > - DEBUG ((DEBUG_INFO, "No onboard devices found.\n")); > - return EFI_NOT_FOUND; > - } > - > - // search through present on board devices, look for onboard ethernet > - for (DevIdx =3D 0; DevIdx < NumberOfDevices; DevIdx++) { > - if (AsciiStrCmp (DevExtInfoRecord->RefDesignationStr, "Onboard > Ethernet") =3D=3D 0) { > - break; > - } > - > - DevExtInfoRecord++; > - } > - > - // edge case, no Onboard Ethernet designator > - if (AsciiStrCmp (DevExtInfoRecord->RefDesignationStr, "Onboard > Ethernet") !=3D 0) { > - DEBUG ((DEBUG_INFO, "No Onboard ethernet SMBIOS designator > found!\n")); > - return EFI_NOT_FOUND; > - } > - > - Status =3D gBS->LocateHandleBuffer ( > - ByProtocol, > - &gEfiPciIoProtocolGuid, > - NULL, > - &PciHandlesSize, > - &PciHandles > - ); > - > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_INFO, "Can't locate gEfiPciIoProtocolGuid Protocol: St= atus > =3D %r\n\n", Status)); > - return Status; > - } > - > - for (Index =3D 0; Index < PciHandlesSize; Index++) { > - Status =3D gBS->HandleProtocol ( > - PciHandles[Index], > - &gEfiPciIoProtocolGuid, > - (VOID **)&PciProtocol > - ); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_INFO, "ERROR - Status =3D %r when locating > PciIoProtocol\n", Status)); > - continue; > - } > - > - PciIoDevice =3D PCI_IO_DEVICE_FROM_PCI_IO_THIS (PciProtocol); > - Status =3D PciIoDevice->PciIo.GetLocation (&PciIoDevice->PciIo, > &SegmentNumber, &BusNumber, &DeviceNumber, &FunctionNumber); > - > - if ((PciSegmentRead16 (PCI_SEGMENT_LIB_ADDRESS (SegmentNumber, > BusNumber, DeviceNumber, FunctionNumber, 2)) =3D=3D DevExtInfoRecord- > >DeviceId) && > - (PciSegmentRead16 (PCI_SEGMENT_LIB_ADDRESS (SegmentNumber, > BusNumber, DeviceNumber, FunctionNumber, 0)) =3D=3D DevExtInfoRecord- > >VendorId)) > - { > - // Making Lan0 default for systems with two LANs > - if (FunctionNumber =3D=3D 0) { > - DEBUG ((DEBUG_INFO, "Found Onboard Device with DeviceID=3D0x%X, > VendorID=3D0x%X\n", DevExtInfoRecord->DeviceId, DevExtInfoRecord- > >VendorId)); > - Status =3D EFI_SUCCESS; > - // install device path protocol here > - mBootDevicePathProtocol.Device =3D PciIoDevi= ce->DevicePath; > - mBootDevicePathProtocol.IpmiBootDeviceSelectorType =3D > IPMI_BOOT_DEVICE_SELECTOR_PXE; > - Status =3D gBS->Inst= allProtocolInterface ( > - &mBo= ardBdsHandle, > - > &gBoardBdsBootFromDevicePathProtocolGuid, > - EFI_= NATIVE_INTERFACE, > - &mBo= otDevicePathProtocol > - ); > - if (!EFI_ERROR (Status)) { > - DEBUG ((DEBUG_INFO, "BoardBdsBootFromDevicePathProtocol > installed successfully\n")); > - } > - > - break; > - } > - } > - } > - > - return Status; > -} > diff --git > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmon.h > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmon.h > index 770053e42b..0ea3434916 100644 > --- > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmon.h > +++ > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmon.h > @@ -186,18 +186,6 @@ OnboardDevExtInfoFunction ( > IN EFI_SMBIOS_PROTOCOL *Smbios > ); > > -/** > - Find the Lan-On-Motherboard device path. Installs > BOARD_BDS_BOOT_FROM_DEVICE_PATH_PROTOCOL > - with the LOM device path protocol > - > - @retval EFI NOT_FOUND LOM device path is not found > - @retval EFI_SUCCESS LOM device path found > -**/ > -EFI_STATUS > -EFIAPI > -InstallLomDevicePath ( > - ); > - > typedef > EFI_STATUS > (EFIAPI EFI_COMMON_SMBIOS_DATA_FUNCTION)( > diff --git > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonDxe.inf > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonDxe.inf > index fc407c3bec..548a6b0af4 100644 > --- > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonDxe.inf > +++ > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonDxe.inf > @@ -30,13 +30,11 @@ > Type12SystemCfgOptionsFunction.c > Type13BiosLanguageInfoFunction.c > Type41OnboardDevExtInfoFunction.c > - DefaultLomDevicePath.c > > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > AmdPlatformPkg/AmdPlatformPkg.dec > - BoardModulePkg/BoardModulePkg.dec > > [LibraryClasses] > BaseLib > @@ -54,7 +52,6 @@ > gEfiSmbiosProtocolGuid ## PROTOCOL ALWAYS_CONSUM= ED > gEfiPciEnumerationCompleteProtocolGuid ## CONSUMES > gEfiPciIoProtocolGuid ## CONSUMES > - gBoardBdsBootFromDevicePathProtocolGuid ## PRODUCES > > [Pcd] > gAmdPlatformPkgTokenSpaceGuid.PcdAmdSmbiosType8 = ## > CONSUMES > diff --git > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonEntryPoint.c > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonEntryPoint.c > index eaa66be454..eb3635ca34 100644 > --- > a/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonEntryPoint.c > +++ > b/Platform/AMD/AmdPlatformPkg/Universal/SmbiosCommonDxe/SmbiosCo > mmonEntryPoint.c > @@ -80,8 +80,6 @@ OnPciEnumerationComplete ( > EfiStatus > )); > } > - > - EfiStatus =3D InstallLomDevicePath (); > } > > /** > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119333): https://edk2.groups.io/g/devel/message/119333 Mute This Topic: https://groups.io/mt/106349078/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-