Re: [edk2-devel] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

Thanks Igor. This patch set is merged.

Abner

> -----Original Message-----
> From: Igor Kulchytskyy <igork@ami.com>
> Sent: Thursday, April 4, 2024 9:34 PM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>
> Subject: RE: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm
> enhancement and the bug fixes
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Reviewed-by: Igor Kulchytskyy <igork@ami.com>
>
> Regards,
> Igor
>
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Thursday, April 4, 2024 6:18 AM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm
> enhancement and the bug fixes
>
>
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
>
> From: Abner Chang <abner.chang@amd.com>
>
> PR # 5517
>
> In V3, adddressed comments from Nickle and Igor.
> In V2, add patch 6/6 contibuted by Nvidia for updating BIOS
> menu path implementation based on the performance improvement.
>
> In this patch set,
> 1 We enhance the config language searching algorithm.
>   As the performance of searching config language using HII GetString is
>   pretty slow. For the example, 1800 HII BIOS options takes over 30 mins
>   to build up the metadata required for Redfish BIOS resource. With this
>   improvement, it only takes 4 seconds.
>
> 2.Introduce the Redfish debug framework, there are three edk2 Redfish
>   debug scopes.
>   a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug
> message
>      for edk2 Redfish.
>   b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish
>      component. Currently we only support RedfishPlatformConfigDxe
>      module.
>   c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug
>      scope. This PCD is used by RedfishPlatformConfigDxe debug enablement.
>
> 3 This patch set also fixes an issue that deletes HII string unexpectedly.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Co-authored-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Abner Chang (4):
>   RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro
>   RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support
>   RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted
>     unexpectedly
>   EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs
>
> Nickle Wang (1):
>   RedfishPkg/RedfishPlatformConfigDxe: support menu path report
>
> abnchang (1):
>   RedfishPkg/RedfishPlatformConfigDxe: Config language searching
>     optimization
>
>  RedfishPkg/RedfishPkg.dec                     |  24 +
>  EmulatorPkg/EmulatorPkg.dsc                   |  21 +
>  .../RedfishDebugLib/RedfishDebugLib.inf       |   4 +
>  .../RedfishPlatformConfigDxe.inf              |   8 +
>  RedfishPkg/Include/Library/RedfishDebugLib.h  |  43 +-
>  .../RedfishPlatformConfigDxe.h                |  48 +-
>  .../RedfishPlatformConfigImpl.h               | 135 ++-
>  .../Library/RedfishDebugLib/RedfishDebugLib.c |  55 +-
>  .../RedfishPlatformConfigCapability.c         |  58 ++
>  .../RedfishPlatformConfigDxe.c                |  89 +-
>  .../RedfishPlatformConfigImpl.c               | 927 ++++++++++++++++--
>  11 files changed, 1239 insertions(+), 173 deletions(-)
>  create mode 100644
> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c
>
> --
> 2.37.1.windows.1
>
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117438): https://edk2.groups.io/g/devel/message/117438
Mute This Topic: https://groups.io/mt/105326102/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-