From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BEBA3941A18 for ; Thu, 4 Apr 2024 14:26:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ywyCHeEtxv+EkuheJMU0deGsl5izMgME+l3jNr0Xri8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712240779; v=1; b=giu9kCrwUE7lo+O8qRpWdAN6Ju0+samUtHTdN4pfs7p9RQ5PDmIdlPY+F8vqchnTToO9F/Y2 0skM7zz4DMPJ4HmqH3a/Jj6yqZ2z4Fm4jDA/h82jE2mKVKjoYOPZZ4bYWhqo965zB6y3IvBK6dO COw1A+D61BefSyYT+JK4jpsSalM/ExTR3Rebhg8amVtcZ+GNyDmQ6ZCgMpOCKwzNdcrANa0YwkZ esSgx4kpvyWDc8RVf+ucvMolDH/UgOMXK7runOcMvaA2rZQZnuQLXu5FdZFI00vyqpm5WimTA1B Wl2yNJEBJMpIPiKT/oiFlwh2HQHXuqr6B8yxZNnXZ8woA== X-Received: by 127.0.0.2 with SMTP id KyuWYY7687511xOemHIF1UiO; Thu, 04 Apr 2024 07:26:19 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.115]) by mx.groups.io with SMTP id smtpd.web11.39493.1712240778638200570 for ; Thu, 04 Apr 2024 07:26:18 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by DM4PR12MB6232.namprd12.prod.outlook.com (2603:10b6:8:a5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Thu, 4 Apr 2024 14:26:16 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0%5]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 14:26:16 +0000 From: "Chang, Abner via groups.io" To: Igor Kulchytskyy , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [edk2-devel] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes Thread-Topic: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes Thread-Index: AQHahnlvcGuV9iX6Jku3wtF6yGFJabFYHHLggAAOoLA= Date: Thu, 4 Apr 2024 14:26:16 +0000 Message-ID: References: <20240404101758.84-1-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=4cba775f-e371-4438-81a5-3992ff3d0430;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-04T14:25:58Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|DM4PR12MB6232:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: S5wpenTY1Yc5btMMGQ2Zte6/NwZ1FpsYBIeADF5SFknzF7Hhky8qF6ru/do6lWGmxmU08oIQBdo8VrlYB/GQHlp0H+S9CfzUNc4QIcQghDRG3lNp4+hTRXXMnWrZhf6/jj0VZ9msicfifD0fqP2YQHGBpLjWjRVeBG9vMTnfmjUE4pfqzxhKq9g0MopPC2uYAQ+Tu0N1TDJuqA3l99BfU6kIIgdeMqHfBZBhVpjLeYIY5vdnOB5E44wkvOMaV3CuyHB8d8/ZUtde0TG86a5GqzBoCpLtiMks93+2Ly9iXEfXMbLIL52XFmpdNjBhSQRIvbQPXnvk1ryLLdvH+Th0zO5tYgGJesshQcylHXQ2FW2MM1h5snnIp6ImuvQ3NPGLLiQkj9Z/vJ03Y18ce8jXjOFjMLSi7AMnt4A2TQv5IG/PflUPIydgoi1zKGKzwVBhrxVHRsnVK2SACjFIpVdkIfZy0i72VjVUpbhNmHonn0UdZKaLXeMQ/Y+72ILYUMDeKtgLVJ0VxrUPp2KoEnGYCmyIEAwJQFCNTMU4wLhECxmzsiWZAQh9NlAQA8oQbhBaJE21NBTAYw3rLWePbyNzFxiDkpTKVjEr8P+2QPAW2niAY6MLYJS0a5GpseVuQctydauwKnXRbgev/LASNvie4Y1/Xi4hmymRGDF0FWIvTbs= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yc9jvqlHsmsNrnqcTg3hT+iu3p1q+2u4f4zm7bO/dKnluJ/KzgI/EUN1L8Sb?= =?us-ascii?Q?EwVurDQWZkE5MmlqBCTlQyWUfNj9m1L/Ms6N7zZE5kiKh2YMH49p9RmHYFnB?= =?us-ascii?Q?NZsICGmMNXGTAL4uBY1v/T0msQsA2zE6jxixqAnP+7GcAPUGCTcAm9aA6lMi?= =?us-ascii?Q?nH97QZpInes9PuAEY2fqjXj5VvPOgUiD/YRH+GQt0dy3JpjOf4BCkklbdzWd?= =?us-ascii?Q?MCpgy5lMacIFkiyygInE5qjZlTbo+ObnhBA1IrJMdmPBXOypH+TBkbG927DL?= =?us-ascii?Q?+lh6LF7X/oJOkykGIoOfNZ8PVcEixy3La2jXbDmqGU8y6jrIkUBGCv5egk0w?= =?us-ascii?Q?+G7d5YVB8hI6ld7ITSmCqaQuH40/sT5ryvmBewWGkcPsVedwvkVs8DKuyXA4?= =?us-ascii?Q?awkAifx1fCpUytMI6dHDYobkOaxCNSK4hnPnsVq4HOx8h7wB1lYmHxDUBvBL?= =?us-ascii?Q?uT7pC0m77sK9lExBJVSmV4Oqv7M0eIJbUDPuRfBnVBSnCqtLj5UMC2Le2sxI?= =?us-ascii?Q?/lVGgNhRszEqHcVi3muKJIb4ADLL8B/BOAObErs8ugcWRs7rlDts6uX5dhjG?= =?us-ascii?Q?pMenFvJ6ZE8p5e/3f1m2TOIq+0Og9q9prYaPNFixuwMUNi4Y/GzrcDbTvMKP?= =?us-ascii?Q?36Mp2Tz6np6dS6eogVJB25i3yIvjqZuVyoZLxV1VCGjAvVpMOwFDCNjNB7fI?= =?us-ascii?Q?E0zW6RtHRvgHmKk/6aQcCGBGpeuPs5NAIoJF7Ov1Gn5f/bDgaQt2rj7yhoVc?= =?us-ascii?Q?wnezGIwodKts3AwOMbKKHGZVIXCSXRmmN52cKBLunN0iULsQEUYUXVxCEV7x?= =?us-ascii?Q?jIkxFfmATD9gRbKrXL/etZ+aLvAsU84WLvjARlI5jqtUViB0Oj6ozVgB9dzq?= =?us-ascii?Q?okT6J428Va7D0ofwMpLD8ct0KqM9yxwJbzPCjQDzUInlk6k2To7kBmcmwazh?= =?us-ascii?Q?M3K4OsiBOAU8HUffCBfs+DBVo12OKq3dJPNfQNEh264d9LKrFRkj2PaQQf1E?= =?us-ascii?Q?KOGyU4yT16FlPZPo18tkkAwUaBeczqnjMLgOps51qDKfipr3zRtjPgmFtNEm?= =?us-ascii?Q?eKMVrngBxL1uLuNHtmBDTLonyEEf+y8zZDUJLO2OCr6oU2Xj2zkMX2NNkQ2F?= =?us-ascii?Q?FoqmViaAuCbItCXy26asz/VQKIZMPFy38hxe/Rgols+Zm9i3fy8L4CRRklmC?= =?us-ascii?Q?5rRvWTRsky9QZ1luNIeRirDBpNQxlJ34++viBcMEderoxnyAyZu4idy5obBx?= =?us-ascii?Q?n+Kqelu08ERmNPaDXMM1ZscQJA62w1b4eH5Thq2BzVY2aRnpwWQEprMgIo46?= =?us-ascii?Q?OuT69aiNvRi/SBU6YOCDku4o7FnaAEio9zBAJlcYvYsehSJ1khCt9a17EfbL?= =?us-ascii?Q?UkzxB8X2vmGKrlpNqmkCyplgVPx3jWKoaw5NE1sOj4xapmXxMJWq63NuHq2P?= =?us-ascii?Q?VB3XlZRNA0cL/5As9/w363L3ATI1bV6ohBhLt0sT/6HV6gUpZA1wlxqrhdEZ?= =?us-ascii?Q?k2w6mIAPznz5/utkdds3hmYI9JZD+2ItgKkKo12HKFtqEslRcMAvRWdh3WrI?= =?us-ascii?Q?+D/DDdR3KgZOQFoct/I=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9c8da03-cb19-4ee6-ad48-08dc54b33004 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2024 14:26:16.1040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7RJKGtNsq7DZrZmOFd3WQsoEvJz22tuIz4mrdEWiG9HpKwaH6itDnGfOpHaZopQA71hvySuvg1vXSIWnSec/Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6232 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 04 Apr 2024 07:26:18 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5IWFz6u4lsgS51zpbo42u4tUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=giu9kCrw; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Thanks Igor. This patch set is merged. Abner > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, April 4, 2024 9:34 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Nickle Wang > Subject: RE: [EXTERNAL] [PATCH V3 0/6] Config language searching algorith= m > enhancement and the bug fixes > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Reviewed-by: Igor Kulchytskyy > > Regards, > Igor > > -----Original Message----- > From: abner.chang@amd.com > Sent: Thursday, April 4, 2024 6:18 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm > enhancement and the bug fixes > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** > > From: Abner Chang > > PR # 5517 > > In V3, adddressed comments from Nickle and Igor. > In V2, add patch 6/6 contibuted by Nvidia for updating BIOS > menu path implementation based on the performance improvement. > > In this patch set, > 1 We enhance the config language searching algorithm. > As the performance of searching config language using HII GetString is > pretty slow. For the example, 1800 HII BIOS options takes over 30 mins > to build up the metadata required for Redfish BIOS resource. With this > improvement, it only takes 4 seconds. > > 2.Introduce the Redfish debug framework, there are three edk2 Redfish > debug scopes. > a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug > message > for edk2 Redfish. > b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish > component. Currently we only support RedfishPlatformConfigDxe > module. > c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug > scope. This PCD is used by RedfishPlatformConfigDxe debug enablement= . > > 3 This patch set also fixes an issue that deletes HII string unexpectedly= . > > Signed-off-by: Abner Chang > Co-authored-by: Nickle Wang > Cc: Igor Kulchytskyy > > Abner Chang (4): > RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro > RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support > RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted > unexpectedly > EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs > > Nickle Wang (1): > RedfishPkg/RedfishPlatformConfigDxe: support menu path report > > abnchang (1): > RedfishPkg/RedfishPlatformConfigDxe: Config language searching > optimization > > RedfishPkg/RedfishPkg.dec | 24 + > EmulatorPkg/EmulatorPkg.dsc | 21 + > .../RedfishDebugLib/RedfishDebugLib.inf | 4 + > .../RedfishPlatformConfigDxe.inf | 8 + > RedfishPkg/Include/Library/RedfishDebugLib.h | 43 +- > .../RedfishPlatformConfigDxe.h | 48 +- > .../RedfishPlatformConfigImpl.h | 135 ++- > .../Library/RedfishDebugLib/RedfishDebugLib.c | 55 +- > .../RedfishPlatformConfigCapability.c | 58 ++ > .../RedfishPlatformConfigDxe.c | 89 +- > .../RedfishPlatformConfigImpl.c | 927 ++++++++++++++++-- > 11 files changed, 1239 insertions(+), 173 deletions(-) > create mode 100644 > RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c > > -- > 2.37.1.windows.1 > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telep= hone > at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117438): https://edk2.groups.io/g/devel/message/117438 Mute This Topic: https://groups.io/mt/105326102/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-