From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F1C04941018 for ; Wed, 21 Feb 2024 02:34:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=J8lonL3Vyd8fz8voSA558alj8f4RUAIpqRDkTqsJeIc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708482892; v=1; b=wV3/h02YJ/hO1k6n+CkcjWVFScTFT7YFh6OA5OvqOpT/+UvhTTVxRJtrFpxk62peOpOtDi8M Mh84QpRPpFSe35w6n/XM5A3XoDW81QxaSlDaaTFF/KWbLy0LZmAR/Ff8597cY10ag8CwqvUbJEK l8g6F93Rz/BkpYUB/9M6/I1M= X-Received: by 127.0.0.2 with SMTP id zVuBYY7687511xv0r5vrdquU; Tue, 20 Feb 2024 18:34:52 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.67]) by mx.groups.io with SMTP id smtpd.web10.4535.1708482891885520775 for ; Tue, 20 Feb 2024 18:34:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CwFGYbUpBdSV9qzFbPzXYSoTR7DT5XMD4suHDKoKU6zAJBJbkxU/m5UWZFPGtNAJxPK3kB2te5xlchvEvoq2inBuEHLWaZGIgmx/vPaDmgGWiTvrWWM/AVlEKCGovJYEK8evf7d8q2duGl0zcmtk6fIf/Pnj/ByvBzC6dp6xrXjll3R746slmcsOe+kMKjbo2L4UYYhKAmdb/vl5ytz6oLrdSgwZ2ZQshacGf2HMyb/71RrEk+JAdJ1EFPq/COK2hKTdrhw9vsRCtDLIOjEtg+i5HJnEVH/vPdvNXME9jFwy7NOzQmDKmSYltO1WKKfQqFWSVhduHD9A22YFAA1kvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kq7xqyAEpM73qhD13Vls8YbVlf22aza8LamywDbId3M=; b=GAC0UzYYS5/uMkNfnVF61vI6GJGayIQA7XkkEFxcbIzACV/KQrGWj6TsPkbbH4kNPAYJOktsHd+Yow2KyJ9ydwXh5rIVIHnDZyogEXHZg5i/mA2LwK8EhbYzSiC4C/lPy5X77QcwRu1dsprUmtt8+6oNVFCzu5yf2ejoHcsT7Vpda2WC2GVICS1de/9CTogtov8RCLEq72QLoGDcSufgA9/62OebK2L6EP//19vfEjbxr9koXIcEcTd543a2ROhPh3LN2WxlKm6kQ8Avm0oVMnmVXnwm1lgbnoKH0Q5vutoMPC4gKntLT4LDDxD2XU5S5X+vD6DfyqELcf35GQVp0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SJ1PR12MB6124.namprd12.prod.outlook.com (2603:10b6:a03:459::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Wed, 21 Feb 2024 02:34:48 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1%4]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 02:34:47 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Thread-Topic: [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Thread-Index: AQHaZFrAdsga798TiEmcs2kjvR9mRbEUE0Jg Date: Wed, 21 Feb 2024 02:34:47 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-3-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-3-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=3c5ff8db-446f-4177-b438-b4a7e9c7edb4;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T02:30:50Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SJ1PR12MB6124:EE_ x-ms-office365-filtering-correlation-id: 130bbc89-584b-41de-1a88-08dc3285ac1c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: sdn1GBIP5Z8bMFZiwYxZcehU4hklZHYpMsOwo5pKYbtm1mlXgVkz9yibSkuxWjSE7MOefMUxpqXJkqDx0NuYRFI5V0b5QR2mco/fflnWcko2NGd2JT8T3jwzxGIwDX/hHz4Nf1Y1axVbQ9CA1Osnq3Pj49cUJgjAri+50GhRX5pFXKLerxWEcUal28xGC7cXTRzHgjKt8MhW+a3OtQ0TWH96aZ3N1Mu/wop4xTPUWhgxf2vcCBhMS4VrjhYKVkt0iGg4BdYzeWiL4ynlq734PehbR8Puc2t9yL6PrbZYqAcC8C8ff0sdQ9NbtUQtae8vefxwnnmL/BO7OO9Edpk5vmAOuQsXNrw4RMFHLkIn3OIvSMXbZpCviOE5vrf5kDDPxMdjWDIIiFWCXsFRiv6dYvVpwJpYeMJRuA/GqFhAGNBR9Eoh6PmoPLGv/Sawm21VERgy5+Di85aNCOMfHkWnRwLZuWV1drs+tSo8E6hIPcMC2noMloq1KLvC/kSj5RMuyX3tXLu9No+AmHYSuiGjxYJa3U8VFbXZAv4t7I6TEHqZ22tXchgzRj7RO6QIeLUCoEmHVepCJtYMNuhBbREBZLydh3sX7hBWCzlarEJjXDZrMJ89rALc+ACOpBkWkdlL x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dMjZzPJ3eaM/cjyAN4s2nlMCkl2kqWeNNpVBdxseRoi6MoU0CIPX3HO7aFbb?= =?us-ascii?Q?xJ7VVF2fWJaJZ7BywrUrgZJwLryIA5Mtse7sXXgmBGRT2fP0kAbdsJayHxbd?= =?us-ascii?Q?dSPi4BSVPtmx7NTFtpwafEmlFcYhBPqlfFZDmS/WczvKVpC3BcwYlsvYJgj0?= =?us-ascii?Q?0uagXpBhfomhMChNjDz8JtEQyoPC6UmTL63TRp2GQmurmFyRKLXKm7/DNHcq?= =?us-ascii?Q?snAnZCS0BAu195f1Rez7uEdiKgamFlO1zOXakdLnfP9eWSIycKXucd+xdwJ+?= =?us-ascii?Q?QyGwF5Wui70PF6mR7/pZTVUCpkVA+iscBkXuNHKbxqDcJFXkphARQZD7byKC?= =?us-ascii?Q?4+wn9nIUPONKpMEz4kD0LDVXgLNKRr8eKaTeoWoDXrnTnoi13c0IBcJ0b9VD?= =?us-ascii?Q?L7arkuSeK6dJ9FGP0gnsZ5n8SHLvYQHeBPlRw0JbYogY3gZdttCwkqt3TKHT?= =?us-ascii?Q?n3xSqXUEMRjMx9pjoty4gTeKTemt66GS6IbJMsRcuKLt235Kk/3X0653I1Xj?= =?us-ascii?Q?GCiu+WJNxZ4mRFmDb53/wWG3IfKujNlu4FroaXzhmmHva9vH58USj0iiF+Hx?= =?us-ascii?Q?aB+ZitsXWQGqN+XQEa7shq2wss2GYS/68hHq0uPAchOwxPCLNA1AkU0Ke1QY?= =?us-ascii?Q?hygiXJofjcveDOoWF7CDXbDQ5w5FAGbLSj7s2dSF1rjIdvYBSwQ+ih1D1++S?= =?us-ascii?Q?6n4+Z1YAO96/II1MKRaXUc+jIaDKmayOF57tiaZUxpPcKOchafQBknkHgN6Z?= =?us-ascii?Q?vNILXNlGix+NlIE1+ha8lHBpGkbUCSDGW0rlKpsBkHwaZwPM39rJk/ejLSjv?= =?us-ascii?Q?WFXuex5rEd/pOMN2PtaOHpR4TQt712e3wQaDcvFdtCvsTL3BkgTRhixU53oN?= =?us-ascii?Q?U+1iBC+xSIrkPFWi0eBA+F22YM5WDt0Ftqr8Q45zZ0KGKx6OiRi44vqhmkV5?= =?us-ascii?Q?cMk3UYq39VDjPxayj2eEGPYp/PhQCKboPJX787epqd+LtxXL9sYR9Gi0+4Re?= =?us-ascii?Q?Ay3+Am5EqreCtOIVxGMZse9Nndhah2SBcunOl0n80ULRS9M/HN+Y6WDu17hK?= =?us-ascii?Q?dcwVa9LlrY3TJR3j7mCJktn745R8QZzPa/SRQXgi2NYkezva/4ahTLK2rPoK?= =?us-ascii?Q?Yzl3Rd9xAxcMyGTYUUultwzBkeRBkekQaWrRVIAdK3dJK6NoS6sHzGepDFiP?= =?us-ascii?Q?gooeQ4qoaLONgk4+Bl1psqF9rvnK/2IIZz9R62TMVDprT+fCrwCFUq4H+ArS?= =?us-ascii?Q?punj8KcKm6dovt0GWd5vfNRVB4VZFS2c7o597+j2NYY2pIzrATRZm2Xmz33G?= =?us-ascii?Q?dtw3RjMc1CVGdEenesRg6xmEJ2K6Hhp80VyZbI2R1LHv1KA4amyw4y0cqv+2?= =?us-ascii?Q?GFLlMuk9adLKYgB5jT6jx+5F6lYVJMdvPv0s9JPNT7BDInOz1WFkfNdOp+5g?= =?us-ascii?Q?Svo1z2Y0vIJgvVhk4CHQeZYRAVtCkL1683EoPNTzHz/HTGh2HKuXIiNj7CP5?= =?us-ascii?Q?naIUalCl2N2lI2NVuG9fD24aGX/Gmake4LN1Khl3P5dw6AOWBcMi49kXklBa?= =?us-ascii?Q?tKukfZJ/wrC0wsqe8nmVWPm72BPR2efGK1G06LOy?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 130bbc89-584b-41de-1a88-08dc3285ac1c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 02:34:47.9049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I/Oj3WJn6tokd9f0dmMWZ+F4RRIFRAOZVWYv+ioKqsI8fNfk0Ve0vxW3toVrCsyO+Mr6M8vNf24zxvTMbBb5jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6124 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6S5hP5pmsSnAnkoIm9achFmlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="wV3/h02Y"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Nickle Wang > ; Chang, Abner ; Igor > Kulchytskyy > Subject: [PATCH 2/4] RedfishClientPkg: refine > RedfishExternalResourceResourceFeatureCallback > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Use local variable for CollectionUri passed to HandleResource() to avoid > problems in case of Private->Uri is overriden down the call stack. > > Suggested-by: Nickle Wang > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index f40f2d85af80..396ec22969b5 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback ( > REDFISH_SERVICE RedfishService; > > REDFISH_RESOURCE_COMMON_PRIVATE *Private; > > EFI_STRING ResourceUri; > > + EFI_STRING CollectionUri; > > > > if (FeatureAction !=3D CallbackActionStartOperation) { > > return EFI_UNSUPPORTED; > > @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback > ( > // > > // Initialize collection path > > // > > - Private->Uri =3D RedfishGetUri (ResourceUri); > > - if (Private->Uri =3D=3D NULL) { > > + CollectionUri =3D RedfishGetUri (ResourceUri); I would like to leave this to Nickle to review if there is any impacts of n= ot initializing Private->Uri. Is Private->Uri referred in the later process= ? Apart from above, the naming of CollectionUri is not proper as BiosDxe is n= ot a collection driver. I think the comment of " // Initialize collection p= ath" is a copy & paste error. Thanks Abner > > + if (CollectionUri =3D=3D NULL) { > > ASSERT (FALSE); > > FreePool (ResourceUri); > > return EFI_OUT_OF_RESOURCES; > > } > > > > - Status =3D HandleResource (Private, Private->Uri); > > + Status =3D HandleResource (Private, CollectionUri); > > if (EFI_ERROR (Status)) { > > - DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: %r\n= ", > __func__, Private->Uri, Status)); > > + DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed: %r\n= ", > __func__, CollectionUri, Status)); > > } > > > > - FreePool (Private->Uri); > > + FreePool (CollectionUri); > > FreePool (ResourceUri); > > return Status; > > } > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115700): https://edk2.groups.io/g/devel/message/115700 Mute This Topic: https://groups.io/mt/104479572/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-