From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8B90B740039 for ; Wed, 28 Feb 2024 01:44:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hsklmK7TNB00P1WrVeiGk7G8C3IBASI+k502lfESk28=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709084656; v=1; b=tzyIxwwHLBbJBOkNPQdQ8b3qBRipD4hw1Ro4A/mPRzzQlB4lmXdE6NiIyGh7kpEkHqFjJbDo 4o+DITXoLCuwEotr/ucIKkYvrRxa1wuSmjv2IAKNrbSt7r/cnamvPPnQoyWgBoYK5YGay6EXLAl Ac6Rh8ReYtYuT0fWrjhV+8QI= X-Received: by 127.0.0.2 with SMTP id UpOHYY7687511xhNWVWCjqwY; Tue, 27 Feb 2024 17:44:16 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.65]) by mx.groups.io with SMTP id smtpd.web10.3732.1709084655485084072 for ; Tue, 27 Feb 2024 17:44:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OYmkkm6t07UGvh2VRDao9n1LX3yD5kt+iEjMPY5esz4A0caApd9eiM9L3cAmWeo2zqcx+W2z+OxKrXYiEcZNxWA/iw9R5EYcy/LvmyokBjjVJpT2d23bdZSHJrUXo0wFLqGJhJ5MTIlA35or8qDH5UiyJv7JGcKX0FGJ3YU3L1g3dABr/P9quGa9Lp0Uk59dJ1XessJDteqxFaK+Vy6fYALd5wC9rk3Kk6RzLsWFYeJOxw564ONcg09PSPiLDusw6UUjxH2+YbEHCZOG8fNQTDAmOD7leINeQ/NjM4v3uvk0h3CJMhYVxl9RZRNL/uEl8Il4HXwsC4pjt3gyu+2WDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5sy6M8tRi6L08ux+ukx+M1OqjnYeBu5YdswAtCmWJDI=; b=KYJFAHSach9wiVuoVXRtUrNl53Nz+Yb3I1sKmoXBNmTYNRiemu8NlmI0wFwrWM1Al1ggLtbvkc26+MuBe0yr8FrIzqSrhXMP2/Tct9rFTICNaMZj0n+aU5D9fwVWTZyxAc0FiFeS8Oz1zjiFFd4Hdgg0cGUpPZtlHMznHV5JtkcIe9p4pX/KKByvWIgUSUkhsWLip1/EkmsnfrACMJ0ePxwowiDd4YEZgjCiW8/sAHDcGCqsRtJVslQCiDWYuRBdave6C5EIhWVS7cX+1gh5NLnzir0U1EMbcWNjOpEU9ZEbUZq3y6gr5hCtbkBFz6SoWk5yjhkS3XZL2oL3N+/5xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by DM6PR12MB4041.namprd12.prod.outlook.com (2603:10b6:5:210::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Wed, 28 Feb 2024 01:44:10 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::344:7a67:1886:6b55]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::344:7a67:1886:6b55%4]) with mapi id 15.20.7316.037; Wed, 28 Feb 2024 01:44:10 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: check JSON value type Thread-Topic: [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: check JSON value type Thread-Index: AQHaaXvpcgzV+eMQIkCff1sbQ8vaYLEe+1BA Date: Wed, 28 Feb 2024 01:44:10 +0000 Message-ID: References: <20240227125247.6934-1-nicklew@nvidia.com> In-Reply-To: <20240227125247.6934-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=5b36a380-fc1d-4bfb-ad3a-3a55efd3b2d1;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-28T01:40:42Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|DM6PR12MB4041:EE_ x-ms-office365-filtering-correlation-id: 7c6dfa72-6456-4459-2b97-08dc37fec2aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: D3SjEhrk4lL5bSJeeOxXAuCz6P4wBd1fa6cBls/jlTgnc1WLGDY5QgcA5AXVQxYUGM4nBLx/fiIQuZ3FrLW+CXgAn9Nay+5K7D11OAcxlLjO051hQP6Tytn9lUuz4oB3WWq6tyGawst8Q+3aCA5NVrelEK/RcsUbPfWM+aSGITS1qZ008Rjb0Bz2pjQTWnMm7Z+jkf9hB6Uv0FpEbPWEjppxBr7BKJFLfuuVZtwfWMjfXXJWZqf8xhrtCmKzXdwaqqRFi5c9hP4rvT9mytQYBVCeWoVWb3yUWv4Gzxao0l7dqnEMZlEdyyg3jhl9rBc2V2GDtJbRBjg3/mcImKUpIk7kAFjOUCsBoDzdQ7XlZh/Ux3XO0vBBBpE/GPefhkmCOBBE2FCDOpt/n0ClgbFzjRTWT1Bgsh+iKsPK+h7nCTFuR4oYLS4qL+3sRfQwDB8IIleZhDfMCPl3d48ydis58JvzLZ/0iaC7XuoOo+BCLOQsMW3/q7vi5OKOrzf2H2/qXgQ2XzALrGkvb3LAFCeAdBAjsAyU2ILslxaHkMAiXUuOwe8998hmJCd4lqDJPegr1fsFKiZ1XlFEr01r+FY357i+xFtu+i0RmHquUrSuUWEeOKgwCvWxkHsOS1p/F1MqI9Gjbd74XCXMHQbpvrq7Vt8J0yTkOoRia6e+tiGhqxsZNHXD2fy33ac55wV5a1yS2f/2fiFADBxjyr+XYcKgtg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lZrlYqGvp/8dPOIkFYbXGU3jgMvJAWofCv8zVH3ZyZAdY4mwLF0YM1dGXIJ3?= =?us-ascii?Q?RZKalwzzlOpYp22aUyboFoJd3Qf9U1ZILwNVen5v2UGsPHAePxRMQA2lyjGN?= =?us-ascii?Q?UrxRKN7XZd8o2jd2AZargcafPp/K9KAz33h7pznlZNokaA60UGUYwvuJ6Zl8?= =?us-ascii?Q?5pPJ5h2AL899m1JnHCoIV7+CzlZmxXJO7DdW5eWapZYmTtNMTESWa01LBzdH?= =?us-ascii?Q?4bWRAXWm0s+mnSsoTdgh+CWGW5bmPxCwQVgEksB4pKMN1NFQEx+BJYfhE4DY?= =?us-ascii?Q?GPUggs/gimhtAxhq4QwzDCFwJAGSOSkXAnC1TAP2+OYcTOqwR8Sb4VVUShmF?= =?us-ascii?Q?pGaIVm1gvEue1w4QxAp6nc8WGQcxiBoogp5Kk1CrV+XEVFv5Q/vOuwnYp+dk?= =?us-ascii?Q?YVcHdx+ZqfttF8YT0GrT/gr/E3aX5N/KV4hO2KZJdBxKe+cjgWOX7/evDyzk?= =?us-ascii?Q?R8mYMzTOzkTGeVu5PnK4/ds90NW9r+zluFVMdkIjhKzmkPEvO9b3bv9hTbog?= =?us-ascii?Q?Xr//AyCcBzHHjN1Mz9tEg77yUpRV0e+uIdVrLRwujlH2En2dejToqqtijdVL?= =?us-ascii?Q?+iEdzwspRFiK3k3zNOLMZ7J7ZQkH9bgLAXpr1H1luTPzNDkHspQL1yFiT0+9?= =?us-ascii?Q?iH8qJb6LCRTOaHpOwW2rk5JoE+9RWe+5X9krcz0jDBrMQdIIyMYhbqfA0XlB?= =?us-ascii?Q?kAXO2UvpMu+P+y3xDhwioPTplYfbZPtAFEBl+6VdRcOusbKMk7BGglXogoHF?= =?us-ascii?Q?8PuS5Z1T5IogvhqYi0oIgVw1G4mDXIaQUtRDmy1b6Di6r9t7vjtDt2k9D32m?= =?us-ascii?Q?zMILEWIooqYVncefrKoITNV6Gi3AiZJhGglc6PgXKd9n/lkJHDBQzWS0DYHd?= =?us-ascii?Q?CZ9f2EK00aT9lfoXvztHSSfJgON3LbBa060+wcQNUzqOVKV1kIpzRdAiVttO?= =?us-ascii?Q?7zvHcJtJYMFmnKmFeCcgQaWLC6QKRnRuaAcRx9fjTKKUM45C82omdqi7Gs+r?= =?us-ascii?Q?5x0uN5zEF7U7ioEEBSqk3WdLV6QOv2og+Rk9IfIGVkmRyG4hHEJk80BXr5x0?= =?us-ascii?Q?YI9eFzSIK9VFt6IT8IZdCv/1tbF5L6eSUWbeHoJODKlUKclpzGlXDs8OJrgj?= =?us-ascii?Q?9GbeNqjKCiKUFGkRLZeLGbN1iWFcREzQm4u5WkSPcoEeM3S1Xu/+EIcwXovV?= =?us-ascii?Q?kAu8o70Fq5ghKgGejtNVjhmTYDnJNs5aXrTus4sqxmQIHbhsMmhu9Ym+72f6?= =?us-ascii?Q?e/JDn6/82CNqRfIcUJg94i5U7opfwlIoxwwzQrv9HQeORK7+DI2a9MVBz8+o?= =?us-ascii?Q?RLIdNELPEAqUivQJ3Ur2+hmtXpDSG2kTIvY1ntDahTqDuhjL6OIp6nkP8frc?= =?us-ascii?Q?/GxIXdr7RVfkL88zOfnhmTZworST2eLIJdIOrIakQQWu6xBD+l04PoIvxeqW?= =?us-ascii?Q?qLffWFUVHyuWv6MvkpCbafsXNkaLuvL8POL53FJorwelcRsq8mcBl1Gcv6Pt?= =?us-ascii?Q?MDUe4pKZRWSiA+rA8gB7RXHMKCM0zqoMRy5lTOR/5Iog8yBZB2PTuveR5Hjw?= =?us-ascii?Q?pS5tulaWtoi64lefKIo=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6dfa72-6456-4459-2b97-08dc37fec2aa X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 01:44:10.6381 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KciKdGXNtVt4YpFekDUQf2PBcjb7varlp8MI5K0mdNBq6MKg/PGrmDTjRedYDzi6flLcG5/1VJd0htawoZmyTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4041 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0sI4wX0F1NKB8uDKwCiFQFPCx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tzyIxwwH; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Hi Nickle, As this change is in the autogenerate source files. We have to update the s= cript here: https://github.com/DMTF/Redfish-Schema-C-Struct-Generator Not sure if you have access to this repo, however I am pleased inviting you= to update the script on DMTF Github. We will not merging this change on edk2-redfish-client repo. Thanks Abner > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, February 27, 2024 8:53 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: chec= k > JSON value type > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Check and see if JSON object type is desired type before > getting its value. According to the Redfish schema, attribute > value can be null value. Add this error handling to avoid > system assertion while getting attribute value. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > index 250ef75e4..7ee3c86e1 100644 > --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > @@ -1,5 +1,7 @@ > /** @file > > + Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > + > Copyright Notice: > Copyright 2019-2024 Distributed Management Task Force, Inc. All rights > reserved. > License: BSD 3-Clause License. For full text see link: > https://github.com/DMTF/Redfish-JSON-C-Struct- > Converter/blob/master/LICENSE.md > @@ -829,6 +831,10 @@ GetRedfishPropertyStr ( > return RedfishCS_status_not_found; > } > > + if (!json_is_string (TempJsonObj)) { > + return RedfishCS_status_not_found; > + } > + > Status =3D allocateDuplicateStr (Cs, (char *)json_string_value (TempJs= onObj), > (void **)DstBuffer); > return Status; > } > @@ -914,6 +920,10 @@ GetRedfishPropertyInt64 ( > return Status; > } > > + if (!json_is_integer (TempJsonObj)) { > + return RedfishCS_status_not_found; > + } > + > **Dst =3D (RedfishCS_int64)json_integer_value (TempJsonObj); > return RedfishCS_status_success; > } > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116070): https://edk2.groups.io/g/devel/message/116070 Mute This Topic: https://groups.io/mt/104601599/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-