From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8DD8CD8095A for ; Wed, 29 May 2024 10:40:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Q9j6eZUehaREEHYdD/LYFn8eey+rYnnd2v3ymmRfmqE=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716979253; v=1; b=mL7TFCuEKqgPOXVtdKHcgtmGQibhzK30E8MJt7zB0Y6F7pjLPwEbSKcAgcGydmCj/dUAHqjN sz2CjSB9VSeL/7B7S0Y5zNAKOSMkc8R9egvc3ljKQfoshArr0ZrPuK5nVTkSbPPzNvfH3HWNdT9 kau/6Ue0XCORSoY0iTuM9KGuNSUplQGCYyi3xPTDZDdjDFtguVKxM7il2H6iacjfLuTBZLSzmDR HIgrSMLKkthu1Ky/b1w+CEWTckLGi4FqWNyBE5u2cU0W4D6F9yDirxXWd5JQ4hNJrnuIkf6vXXq oTbD3nLvCVu0H2W91ziRmYILYZk3SMbdVNEzwPCk/L3hQ== X-Received: by 127.0.0.2 with SMTP id iKyeYY7687511xn9BrROGE0O; Wed, 29 May 2024 03:40:51 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.76]) by mx.groups.io with SMTP id smtpd.web10.10762.1716979250968870850 for ; Wed, 29 May 2024 03:40:51 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by MN6PR12MB8590.namprd12.prod.outlook.com (2603:10b6:208:47c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Wed, 29 May 2024 10:40:48 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08%5]) with mapi id 15.20.7633.017; Wed, 29 May 2024 10:40:48 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" Subject: Re: [edk2-devel] GitHub PR Code Review process now active Thread-Topic: GitHub PR Code Review process now active Thread-Index: AdqxKDms81p5Mq2lRy6LTkfbwilSAQAiifSg Date: Wed, 29 May 2024 10:40:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=da3749d2-fccc-4f65-b971-ef4c17b39889;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-29T10:24:25Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|MN6PR12MB8590:EE_ x-ms-office365-filtering-correlation-id: 82f35e3d-2a79-471d-7fad-08dc7fcbcdbb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?GjyxDOZsS/5NiJuB8bFVTOe5VsrhaAJlkelZ8zrV4JI50VzZcdRXkw2BaSOv?= =?us-ascii?Q?uBRYTHZ0nDc+2HkLT/vXGN6LXY3jdSJ/mwljHHL+J1pp7xRAbQGFDtHoiECk?= =?us-ascii?Q?NhlihkjUZq9oo6y0wfrpbk/kMymKNHKT8WlzdAum1DcZNle1RIJYlK2wslF1?= =?us-ascii?Q?KsKL3b1J6+SrE3k5dm7dVI2JNA5g9Idth/ioM1PGTSc5RxIXzGIAwCp0KoLg?= =?us-ascii?Q?XaqQBHRzKllCxRgFxr+s5A5GO4M84IILBqVFnQ91TVpWdSr7NkYOIuci8My6?= =?us-ascii?Q?UHJ43WLLgK372h6W8hV6yVFY77irZBlRCdRkdNmKTP1pxL7vbONrWtjU8AEi?= =?us-ascii?Q?bxZsscrURHfmKU5HAAXD/aKkuB/MVvr32wNFHugMdGMX1Rjl1UZiZ+wkFXFp?= =?us-ascii?Q?4pMysFfkEAcC+4Av0Jj3tk0F2j4Sy31Ybpj0c/tYSwFx/IZzvPgiyyk6QCaz?= =?us-ascii?Q?IR+TA5u/xEFxY3/I1xgrmgj/zoKK978O/eOaWr3LxZT1cGnFjwf9bGh7PlMI?= =?us-ascii?Q?dlO6TgGQ1/kMn2oamPBvWEd3D88OBvTGkqG51j2WU0KGMnEVQEXB1IYpZeB/?= =?us-ascii?Q?lX4cLWJ5iBn6rnuPXpX0Vz4TEIM3lJFN0KpksLMY0vEMif9UgAc6pPzX9/Ym?= =?us-ascii?Q?wWG99sAS++JfT85GsElkLTUg3oYpNxxXfnhmlmvz+2YZYKV7+B/HahnYg9Y1?= =?us-ascii?Q?dmEcziwiC+LlqoOjz6a5qCObaUwxff/OnR7hBH36LJlciiSJ3f3b16QkMhXP?= =?us-ascii?Q?fIjA66QEUjm13P8QaVlFd9GFNJsU0CWmechgr3Q4lEPMDOlzPoXCZsvR1sXe?= =?us-ascii?Q?t14MZ0QpDRd2ooSqNlb41rTjHIlfqib96kgs00nGfo2ZOb7KKysuVE1y9BcP?= =?us-ascii?Q?rxo2qg/RrXF0BVwtSH7gDC3ULwfMQ2bTG/ro8jKBf5EWahw7jUZm0vKoDvdL?= =?us-ascii?Q?DN2lpvgNc8PQuFH8n5I3lxXJvY76UkNX2cBY1c1pDbycm2+/aKlEAQ16squW?= =?us-ascii?Q?JWY65LD5SaWcr20kJAzs2JuSiF+ri2uY9Xm4+8OnEFpvHvk6Ft2z9JAdkzv4?= =?us-ascii?Q?AwfzL7CQLar0RyVofOZA/zThxe5EGot1NNH57nI5iYJ+w67xpopHnM02S3VG?= =?us-ascii?Q?kgG15Hy760hOi3mAcqDWYUg0vf66t6IJwL8vhJc7yJ2/L8Ej5J7VMXPQ72c0?= =?us-ascii?Q?n7TicVxbOJ8NZ5ouZfzh3ts871gUu6G4jv4A4osdIdGC5UBOz9/x5tFoNMn+?= =?us-ascii?Q?zMSRtCf65HRO9syO5iy5IScFUeFu7ko26XY/7DBrT6l1ovHj9zQXWjnsFLmZ?= =?us-ascii?Q?lWo=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CFYKz4IkAAPLSUTWt6lQerHh/RVFn1vB4Z09hGHW58SDE/6qg/MBh3ePuvyR?= =?us-ascii?Q?ZPlxHsWLLqXQUucyLnAw7LP58OCYKZ/5FaL4Vkggyqa4BFujnAmj1B/nXG8V?= =?us-ascii?Q?59y9w42jQ9dSLYCKU6m06kPvcv198Iv8g4AzQwiKWl76dJ/fwVZ5fTU0IlmP?= =?us-ascii?Q?qfhG4w31PccQhr7Cu07UlpKxuqTwh0wu3vMviGNeVy18e7n5XYjVmw/w469R?= =?us-ascii?Q?m9Lnmw/QR+YuvTucCDQVjq5SRHfGqzu/jV/RSP2ZNl/jb4kpfU78TRPTChu/?= =?us-ascii?Q?an1W2FQAQVAxbi95YePJLl6bS0+MAxWRb25++oGo9y4uls1jN6prXiQxDB7c?= =?us-ascii?Q?ivTLm3Gjk6M42aQrTXw6NNIDyNu2HEA0WwaAhy3dz+M8GETxCU9EJ5xYVt+L?= =?us-ascii?Q?UgJfBghpgodAwXubtXlZUVt2q7eHXK4YecwMIyg4+NbUZm9r9KBhaXLJXGMA?= =?us-ascii?Q?4raYd6gPzGim3PmkezwL1fb5QjGC8waxcuqCXbwo7Rs3o8DIwCF4Ik2CKBop?= =?us-ascii?Q?0HJqnHMY2wwuLJk0nrmZh64W74aMS5BpEJnus9CtEmuXzKQlXkXCQ0NJ8Plp?= =?us-ascii?Q?bcSQ6NKaqJ0G1sa0lKf9ra7E0UWDOoZkVkLZ+/SLEB1EKfw+LSzgTuq35jbP?= =?us-ascii?Q?iOrSfJ+ulXN+8md6H79SzZhahVV0TfdSPFfAQBtMn5IgqBshmzMUh686AecV?= =?us-ascii?Q?4jCFq26TLtYkdNUYp4kUcDHtR2cgKgM4mVyzwS1a/BKgdkoS3gey/D9+utbf?= =?us-ascii?Q?9Eew1Q5Vy5sOO2g2Fg8Y7Ptd36kSipNoOAeS5zcO/JU6EwYORuvfBA3rZFmL?= =?us-ascii?Q?edD1CV1lkSagL7K3S52YcpGYmjPzUaQGM7k8PYE9Gy9P6Eswbsc69mEtiYwe?= =?us-ascii?Q?INrlfDGg2IapccYxl6tj3olfSqaLRmwg67fklOvK72E6e9Qxo/i5oXERXtdd?= =?us-ascii?Q?qXuTVhwpBSRFsI+XdkB/6TNCKW/y+t/WggeHpaGLRBL0RacbG+IuKCDVgatY?= =?us-ascii?Q?mCLgzNNQ1OiYZAJaJMHPrsJwUh70nHmyvFjxcjIiQYEDWNd4CRUANx90Er1c?= =?us-ascii?Q?cUvfvrUE3rVg5lN9jWmVKITOXG6EzlszABwrb2rLm9HUJgTcuvwYNIeS8u8z?= =?us-ascii?Q?Pl8rWIruTizB/uCOOHNV+0oWpIPaaChyvPwPTol1nd7ppVkaXiVnHGkSuPUy?= =?us-ascii?Q?NvM9WQ4+X/fp/NherYmk7T3dB0zgd/vVsNO1os0odIbrZQt9YxKDHEAixQup?= =?us-ascii?Q?rAxLs0QlJD6J19GznPNw7ZzJCXykzhQrKfFaHviyynF3nTy+C02wFm7c3+65?= =?us-ascii?Q?F8l9htmGzX/C8EL5JmaiqFbiBYypumosz667vfV6UpmuuH44k0uWjpZ3rHlR?= =?us-ascii?Q?y2ZSkdCp4oFz3MzqxHVJ5EH2GMS5eBMsUsjG8jHEiiBTRZbRyla8bCepJkPh?= =?us-ascii?Q?Ax4LDIK+HeX3HgpttqTNfNq+qPEJtFX+PeiDgXf7MMTnUM3ixC1av+ZalzzM?= =?us-ascii?Q?UIvNhjpFs4cWl4gqblCUN2g72CJ/+dyNSx7/6QzwDgAnxIKCDd8uVlmxW5C5?= =?us-ascii?Q?rTYD5CTBrJnolURA4sc=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82f35e3d-2a79-471d-7fad-08dc7fcbcdbb X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 10:40:48.6270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PsfW4chu7xoI9cq6VRe1Vc6GOFCm+Klqzi6v1Wef3hX93L8t3CJRaeyn/2nbZ0UhCrvhWNj4R8quQscGctKUZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8590 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 03:40:51 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sMEGwbDyKcUawmG0PpG61nsTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=mL7TFCuE; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io [AMD Official Use Only - AMD Internal Distribution Only] Hi Mike, Wondering if we also plan to apply GitHub PR process on edk2-platforms repo= ? Or other repos under tianocore? I found there is another email thread "En= able GitHub PR, protected branches, and 'push' label" on edk2-platforms, bu= t no further discussions then. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney via groups.io > Sent: Wednesday, May 29, 2024 2:54 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: [edk2-devel] GitHub PR Code Review process now active > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hello, > > The GitHub PR code review process is now active. Please > use the new PR based code review process for all new > submissions starting today. > > * The Wiki has been updated with the process changes. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > Development-Process > > Big thanks to Michael Kubacki for writing up all the > changes based on the RFC proposal and community discussions. > > We will learn by using, so if you see anything missing or > incorrect or clarifications needed, please send feedback > here so the Wiki pages can be updated quickly for everyone. > > * The edk2 repo settings have been updated to require > a GitHub PR code review approval before merging and > all conversations must be resolved before merging. > > * A PR has been opened that removes the requirement for > Cc: tags in the commit messages and is the first PR > that will use the new process. This PR needs to be > reviewed and merged to support the revised commit > message format. > > https://github.com/tianocore/edk2/pull/5688 > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > Format > > * Please use "Draft" PRs to run CI without any reviews. > Once ready for reviews, convert from "Draft" to > "Ready for Review". > > * For active code reviews that are almost complete and will > be ready for merge in the next few days, the submitter may > choose to either complete using the email review process, > or switch to the PR based code review process. > > * For active code reviews that are expected to take more than > a few days to complete, please convert to a PR based code review. > > Thanks, > > Mike > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119337): https://edk2.groups.io/g/devel/message/119337 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-