From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 20A8E740034 for ; Wed, 21 Feb 2024 02:12:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=z6jpSWOV1ZZhz36qgJx7d5iDMilHI/A6xtGrspBnp5c=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708481555; v=1; b=owkFh6NWH40uRvWV49n6vYwPcKbGT1+3qZUxG3E3xMP4eP62DuBalnw9M7tpGauvpAwnzuMe JpjWXPOUxQYC7Y4SU41Kvv3xlHM7cg58214aexb3CFoNQFXjjM+jvAhCDV7pn9Yh8/x8PHVRpTk vqeiDaliK8voy89Swv2NDjhE= X-Received: by 127.0.0.2 with SMTP id Xz6oYY7687511x3VUYOk72im; Tue, 20 Feb 2024 18:12:35 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.88]) by mx.groups.io with SMTP id smtpd.web11.4080.1708481554708158947 for ; Tue, 20 Feb 2024 18:12:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NE85JqZUDiPqpfPlF1CzoBE1gSSUmNBVtE9GAsiCL7JB15jMJumd619mFBe8trtBpJwWjZqVmrxFtSCth/d/faQXmcNM1JUBTgsm3AvdzYV3XNlEYjKEc6NpMgoGxbWJ/Mc68VWd7HRJYL566GC78q7bPBrietq1GX2yrC1I/xEtInZYfTVFmbmXQj3Dpz5K3nXI7j4ZaeuiIc+mXmsl3V2uPLpPhxd1nswZrj5u24FWMrFAUKlrUQI7XVDBp6Rbxxl98cZN1pitRfZmcZMZQSHbl6SdKM30gsdA9SFHuHtSywwow/1nWZpCtbYjJqtNtKzailGVhjKXqjHQuVUwFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EWM7ttJ6Oyeg5il6xXrZbkqijZNz4EKvQL+ecQkha+E=; b=NP2pMhX4M3iexRlNbF99cnsWEwdGga06Ql0PW5aes6gLOMF5DtlTsjf56o1YZ3xikEX5DypJEUfeJRDSASnCG2b4b1gpS9sF22Eu1C9/RYXEajd1v7yFf6Dw7xMIJh/y5kWa6SoBXb/MJ+u+YicbGR1w8OyEjTGE4wlvsLs8bj6p0/re2uiIbd4TKiztxARWiRnyMtVNNBdcL1US0Fa/aXbukS2GDr4iHMkyadJLmtLxiYfrmdaLcXKEF/cN7AqSL5xoVHttEoOMK8EYMhzKH56nmOggYlrgQ9yGxcaTFjjeIkM/0ZfiyOchLjvDz3Tn0GsYEeoh0WlFtGpyzm8XgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by DM4PR12MB5214.namprd12.prod.outlook.com (2603:10b6:5:395::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 02:12:32 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1%4]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 02:12:32 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nickle Wang Subject: Re: [edk2-devel] [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Thread-Topic: [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Thread-Index: AQHaZFrAIBEokCAtHE+bqus8S+dkMLEUDdvQ Date: Wed, 21 Feb 2024 02:12:32 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-2-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-2-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7ef97540-3447-4e8d-8d08-9716954ecdae;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T02:11:30Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|DM4PR12MB5214:EE_ x-ms-office365-filtering-correlation-id: 6649d555-197a-490f-b678-08dc32829009 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: e7aaDfA7ow1qGGe9ZK1E8fDpwwkHayl0zZa3yKg1bFv6ZyD3a6k2Jzq6yyGhMGqaI/x0gDyp8oOFfAhu3GrNuXg+bzuPyvyWMSwuzMb7Im8Xe/ZEIM4zmNoULCCFxIIjP+P6eA8Aq2gp7K+6MmCtViDDHfEVbnrtci+FXyUE9woN+uQdcQtI0zd6aCB/LbbvgHIIFLBA4dSXG3sb/DFnk231pZs9LLEW8G56cm3atJ2orR1OEm1Ik+EroU/EWRho2osvWofAx4AOAFjjp118nXoRGNia81KDG6MQpiVI86t5SgmrSh6BtIrcNr84P/cv2epZgnrTuqIJD5kwiP0uNYVbFgOdUkAnHgfX4RTQ5ApEui8f6W6CkjlzLhKQUZR8A8YcOXJvhuw/w/+IRJs2CuutOmzfsTEnzzmu1yQLplEkyoxKZJzZs3LUFJ+Z4OVPfZf45ii3QI0k8T/XbUffugBf6dkyzjfqYU/nzcWnZt7QxOI9YJKcIoIOa+Xq4ZZTQ4PdndCxo9e1MS5aWAylUprkumKyS1N4ObU5NxqjrlSMES8HqFt+S2qHQaCEzzA12DIYwJnh0tCCdg1T9M2qnl45pax8AayCUradHezze3+6cA7qWaLtq+2lDbJho4aK x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xtevvTi5Kwgnb6nJl6LWXPHycxsRtYpkqjUOelHVj/LFiHvMElnWSCa8rFWo?= =?us-ascii?Q?gLyjx3LeW0HRRl4r4a/xg+ou+mzeA4w9inL2/OAGA4QGC4mRA1LgOBmRk5qs?= =?us-ascii?Q?Y7iuyT4Hj9oU9tq2m/Zoq+qccVF4wXbOp2cBSCRBy9ReS9NWTWpOvR7oXOK0?= =?us-ascii?Q?Ws9ynhDjbfxMtbAutBISfxiLXk7y22U9a/w11/gzM/DS58E3S6L+T3yXMliT?= =?us-ascii?Q?zlkon2umT3DRj9TJ996LOdXSocWj6jJQIB8OkdJ+b3ZpU1ccUfWlR6TgJ4AS?= =?us-ascii?Q?GTtrQxlg66OX4lNPha2Sga/wfSdXCYlVA8qZe3k9lQL23QCUu9SOEn0qnk8X?= =?us-ascii?Q?9F0xskjxMzr4uK9KHwAgNLZdNiSMAGpzRBpb4qhUu2+zXD0mWx+hivaXHLfg?= =?us-ascii?Q?F3B+KG4BCvHK4bnYuLVmGLriboM4IVR2ImDbqrtgZCoV/8b74hcE4+VZnoyb?= =?us-ascii?Q?btaqtbj8IXNfx3q34HMRvhGpZk9Vfmtdh+Ecs9dkUUp5ZRepvRO64lAfjGSB?= =?us-ascii?Q?7mmU1GB3gVITpmF2MZNRXUwqxjfCJuHeKEUiwotaToTGNLWjNI1754j6yJ4b?= =?us-ascii?Q?j7mSfbmARfSJD493SRRxbhymvdbxoFInwM+FFqsH1S8+EaAuVUjmUP0i8Jjq?= =?us-ascii?Q?f+X/2MSp78xquP9jL9GHaIWn3vTYPgimFE9MPSoqgVHrj0kNS4db7pXUxbzE?= =?us-ascii?Q?xfJvocvBGhdkGooM8VvZZGhbo09bVeDclwqcDipxBal2meEic+oE3ESw7zTv?= =?us-ascii?Q?hsPV9oNCBzzEIVYTXV95CTZJpRO5HNLmVypZOaj79JZ28FgINE6rqeQMiMMz?= =?us-ascii?Q?uWmDzfP3uBI1sp+owrhtl/KrYph96ifDCOilZEGji3WKU73TId4e9qGpSK3w?= =?us-ascii?Q?YPJjA9ePXJ9nMYSbqwBTQa3UTL9w9lMl/SlFOgX4xOUZnnCamtyWiDid+SD+?= =?us-ascii?Q?j6+s4if+H6m08hNKMm7jnLeU7rLviWI0bilNCQQ4Oe6uu8dHga41YwCYbC+4?= =?us-ascii?Q?oSAO5SKkPPRTNjIrBixBcw0Pov278/n3gtld+c6nqQo86Ic+ZzIzof1wgGIK?= =?us-ascii?Q?8BohHkpDSlxY9PPUva9/pxKGd53fpaXiDzgWsADMCoe52qGnJVb7OJ5K61UK?= =?us-ascii?Q?I/ZN31LyoSPGG6QIh0UkwR5RduTQawEEeP+ra0Deh5SgARahsF1kMRaz5Ra6?= =?us-ascii?Q?0XdbhiYBJPXWnEFQ4iZWJlpIZgSdi0Nob2R38H4EgJiYWxnFDH4MNxX4uuyI?= =?us-ascii?Q?55cvMsVeIIViz9CWAPX0DUbldutttnz3KS3Zco8vb62RrcrQ6TZ2xR7njDp0?= =?us-ascii?Q?fZ/q5XBUvNibVGM2qilXmKNEA3lJnj7jzjca/NXwQ0KETzcsbyx1oLMZ956c?= =?us-ascii?Q?uKcUpIDUnfSGwVE4tPpoSegD+hcMUYdi9JXe54tv1jvLC9Q8ZfsKK2GJlOJT?= =?us-ascii?Q?UMB1vhCW2H4m0F52EBR7k6gCkVIHq3MaeVsOig2pazHUPb/fI0iopARXwYdw?= =?us-ascii?Q?/1xu3DU/c8kjDvgjWZCMm6nyVWnPxrMLPLr8TS7YKC6YbBDlbpHd+SfM/3Q+?= =?us-ascii?Q?YI7t3eL4yQDe6LxTqC76AGKWwRYNLR1JArAjrXqe?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6649d555-197a-490f-b678-08dc32829009 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 02:12:32.3352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zQN5b53d2cGX0meICRPKErT682Dy3TL+q3cL7sMvnDfw8xluD+kuXP+lgJukWPY9WdGBgcp8v7Ee3/HvZnDmtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5214 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Pmt3mQtBPDMf1fpmI8hDWrArx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=owkFh6NW; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] One comment below, > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Igor Kulchytskyy > ; Nickle Wang ; Chang, Abner > > Subject: [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memor= y > leak on error path > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Igor Kulchytskyy > Cc: Nickle Wang > Signed-off-by: Mike Maslenkin > Reviewed-by: Abner Chang I think my name should be in "Cc:"? Abner > --- > .../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > index e1494471038c..21ce8ddad9d5 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > @@ -4010,6 +4010,7 @@ RedfishRemoveUnchangeableProperties ( > (RedfishCS_uint32)AsciiStrSize (*JsonString) > > ); > > if (Status !=3D RedfishCS_status_success) { > > + FreePool (UpdatedJsonString); > > return EFI_DEVICE_ERROR; > > } > > > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115697): https://edk2.groups.io/g/devel/message/115697 Mute This Topic: https://groups.io/mt/104479571/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-