From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 43E26940F2D for ; Mon, 29 Jan 2024 02:41:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EDD9bsCgY8/6VcJEyYoH6W5nvzlrQUIPs73AshQOyI8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706496081; v=1; b=M5ifk5e9pudAyPYqN7jFhi4GjWyP9oqFer3kh4I4PTDfo1pN9jBfaCilMg9mHqvgEtS5Ttqh YcxTsRL4Lm12WINImDbQkcv06mxbxkAOKgoBmRPMIyVqVyc9UDhJ+dbasCJH8TpMcEkmJSRYFj9 i/ZtlJv88JywfqAL/3CgvAWw= X-Received: by 127.0.0.2 with SMTP id 6MeCYY7687511xUvDdepNQWy; Sun, 28 Jan 2024 18:41:21 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.85]) by mx.groups.io with SMTP id smtpd.web11.5802.1706496080145095702 for ; Sun, 28 Jan 2024 18:41:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iT2mrJKdjHX7xh4DitnBTpvlkqzrTLXyx+avGcp65NqvQBU9jBPN4eok4RbjEmyc/ASkv8vbK3uuWbK7ziCSZxQ2/nhttRLonPv+W592AvAiYyxzohZPWYG0JntORAktEF3EoZAsaU2/+qrUFu0yYcseidHwQoj4G+JaFQc+5qdqUPEMqNHZbUzfDlw+5Ul6SPRZ3uli4PuQYLOvtls6S/Qc8kkr29zx4YtI7fHmTRx8K8VSDj2OQCb9WEYN+eYB23E4lIXsU699+rcMAGP2wMnRQsMGjsyKwGOM6iI/qn2VDV0pVuocjqcOQ9xbaLbz2Rc9xyQ5N/0OGvDOiUmPHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvRpDEZ7c5+G1dWsqvGbmkd++e1X579nTPW4huR5BAU=; b=k8N8TRX0nNa+L5O+tYtaiL/LbGKFChgLvcobwFtxwC5dT7+SET74kg9EINmysQWH88pvNz4lopRgx62TFCMuceNubGdMWVaTGxBIp47Veg/At2ee1jSivL8HWOpnD8397y9mNX+0SbiVtX/gKQ9rcptMxd9PHloukTE2+0d88wNIlqc73FP7uhkp/4xpHZbplzskNq4A9mWrXGnsFvBY6JH1YZMcFT3Nmnak1Mow7ThYuKeQYVnv2hC3//hRVHMUfF/vHcZAW6IVV5pSIRthEqRQS93noQxy7AJlx4VQF4lhPlSbbZGLQ1VoMgNjcnEyRY+whwnf4zg5sYovB3Acrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by MN6PR12MB8542.namprd12.prod.outlook.com (2603:10b6:208:477::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Mon, 29 Jan 2024 02:41:16 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::67bd:f1b9:58a3:d2e6]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::67bd:f1b9:58a3:d2e6%7]) with mapi id 15.20.7228.029; Mon, 29 Jan 2024 02:41:16 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory leak in ConverterLib Thread-Topic: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory leak in ConverterLib Thread-Index: AQHaULP+M7qHeAHyWU2HcKzUhrvIWLDwFtcQ Date: Mon, 29 Jan 2024 02:41:16 +0000 Message-ID: References: <20240127000128.67202-1-mike.maslenkin@gmail.com> <20240127000128.67202-3-mike.maslenkin@gmail.com> In-Reply-To: <20240127000128.67202-3-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a7dc1cf8-f39c-4dd7-b633-8238e1456247;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-01-29T02:37:37Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|MN6PR12MB8542:EE_ x-ms-office365-filtering-correlation-id: 0f2829fe-3cf7-4a3b-4490-08dc2073c410 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7IuIEfbB3qYjf21Y71h+thE7QOC8ES1Mc+OpCCw9SGcsO3PqtnAX8gbR7ZQyICPno18Qxpz1Ddh/MSQ6DcnzK+MQdJV+RVaDJtuECF4c0SnYeZgwScCBWWSni+Txw/PVUK1VXKgKJ23BjSxRbatVhYR1Xk1ola1B1OIGSjvr9TSaFhHxBSEDN7GmmslNzeCdFPYuzIQ1rTi8Qe5CXM2/Zj8GdB9WHyAnDHV8ovLK1UPQ3tq5S2PjZbah+l9xcedkHBr6w884ReSj/rYDmd0n4dy9JIZpdY18OKuRUGcbo1xJvDzjGpfWTU3TQm+jE4X8hH3T3JDbt2Xhu11AAkmaJQumujJfUhBPZFLpLLAnpIkcGysi3HCo5J97JnKir9NKQDZBOzzPIp8xU4NgMM/acRdAO5C0894LgJKh82wayFj1pT43nMlMNxgTbvrgedhYbCySNlLstvIswwLZI6eBxa1nJujWydlQuLqO5lhO881yztdFfXbCVTpKYFDeJzqX82844l5fY/RnpCPbptnWIC5BbsSm8efpSLQZN4zBEK50pxrizgRYNkeS4DWuYliw83HRmU8GlMsP9dK+f7dGiDDTzLn07JdtR6yX4guEBxZo8CXnzaOcWjiby0ubwIpqXBMmz5AZt4zP21x9B1BLrQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zKcA42OrL1eo2ZjvQDYUa53rhXrxhB3l8zCHSqiS2s0Lo8A8fyNj8GZAxVP9?= =?us-ascii?Q?aywvDS+MCgHsIbVRoLL/paJqj6QR4xKJd+GJR8jH3pQ+QKA85G9GkWCr7EJP?= =?us-ascii?Q?BYIk/5b6wy+W84FWHeWbR2NmcgnVSIBgCL9JfWnv0Oe2Wb9WskwFzhTsmfr/?= =?us-ascii?Q?VpTZZYAtCasD6hTqomMzx0pUuTBccz3RsfArdrueSZy3ZGobdhrbXaJgDFYV?= =?us-ascii?Q?s0LCgwtsJChTqDGmiMaI1JZeA7wGQYy+OxW3IVqy8w81dYGgyoXPJxEgMqjc?= =?us-ascii?Q?OHG0FxZVSx7RBhizTpK372O78rAfUPdotoqrCFpURNEt9frkX4p2bn5j6mJs?= =?us-ascii?Q?XPKbtWgCwfXWhDjlKzEQ6n5GipxPyhAZjbhHGmGhWC03VeA24rpg+W08yD6h?= =?us-ascii?Q?Hh9/9f5tsJywAHWKZ6sZfajTkxPfcdQfUGsQNKiS+PqX6wW4yPEoDhGKh755?= =?us-ascii?Q?ypQXeAq96EqXbs7I3M7HLRMKdj1GZWiEmZFKDZlcHBzr2Pu3IDlTz+wZwzX8?= =?us-ascii?Q?bhO6NbJu1VQJMqrfdLB3mncbVzfhmIWg8CBRUvDZtOdsoJv+1z3H5Z2p5RNY?= =?us-ascii?Q?FdJswwTwa2k/uHOLiJrHxhw1rbPwBkfIOJ4oYJxqxGeOIZb2tD7BQM1L9Wt1?= =?us-ascii?Q?xKbVg3jwE4bU/fiknt7WUH7053QDpuQ0GzWWaMHv6g5Gh1z3jOqTqo6kqGZ+?= =?us-ascii?Q?Y/NnB9wnqQMUjOxrozsIfSJTqFIAfQpENSF7JR7mrwj3qpNEXoi4IjVbK1se?= =?us-ascii?Q?bOk1FcAEVu0zinYtxepj1u87TSWrerjNxJy0eLtzc3CGRGx4RWmSdjwEdwEW?= =?us-ascii?Q?tmz417JsQ083UV/A1yNPCU3prJrvZLBs3/uZ/IJHdkQevUOHAhQpdqpKqKfo?= =?us-ascii?Q?zB2zbPzilDY41CRAmC1Yu4fw9bkRkYwMYRrTqNfVC4e4zP1o2LWFSHDtxrUw?= =?us-ascii?Q?gmd2DiYjLJyiZZ5IiIlBsMn8FwL2vnvpgb8zzZ9tprKNsZdMRKuv31db/6/2?= =?us-ascii?Q?xWdbCaHd3LygGi8G5aPO9smTdFlzZE32B/9ffrqeiaQDrXNZao/zZBPkGKeH?= =?us-ascii?Q?rdSJ/4kdFQ/ZiJfu4cTXNph8gurrwUgjME3HPC9AtOaojleqcBXZMk5cLI46?= =?us-ascii?Q?DLKYSMe67+XvCXhZpFUAvo4g2YXVyiDH75CvwahhW5Bnyq5qBfssFhK1TGin?= =?us-ascii?Q?2h2A6EZJ+W0rXELzFjIp6TpyGDWy3fmulrg3/LSazVBKqRStdlcJjf1Y/x8c?= =?us-ascii?Q?KlZ+TiUt2+Ba1hlJARZoRdZfwbhFTdyhvIL7QmqdM8YYT0o49Zv19HU2Jko1?= =?us-ascii?Q?pEBENrElu9PrW5ITRUHf4uWXSSQXHoNhElxjXBdaF6e3bAX1rtNI1Qq/QQI5?= =?us-ascii?Q?5lcnyrAp7STg4iP6K0Ow+WenPtAXO8r0qwCY32/5M/Z65YTRZ1EF5Z5ltwIO?= =?us-ascii?Q?NImluDCVP0ml1vx4qls2PxZ+CJ0vV/vGuu1uzaVPlKq96Kfo2zvK3O9NnJYG?= =?us-ascii?Q?/Gt8pEa8asZwuruSlYZie0TSw/LcbT/ug0Z6FAHXks3p1OIALCJVj3PfHJey?= =?us-ascii?Q?JPfvvTTIFajZAOA3lz8=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f2829fe-3cf7-4a3b-4490-08dc2073c410 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2024 02:41:16.2246 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vnR0Afy56/NZD7yfC9DNGT8c9DaaD1OhK2eABiQUrwvsC0InlRecxAh5su7g1tcsvbleidnXvSjgnXjt02lmcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8542 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FiSBVE6G8IZcPzwl5bDf4dxyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=M5ifk5e9; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang Would you like to create a PR on below repo https://github.com/DMTF/Redfish= -Schema-C-Struct-Generator for the 2/2 patch? As we should fix the issue on= DMTF Github as well. RedfishCsCommon.c is here, https://github.com/DMTF/Re= dfish-Schema-C-Struct-Generator/tree/main/src. I can also help to sync up t= he fix if you are ok with it. Thanks Abner > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, January 27, 2024 8:01 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory le= ak in > ConverterLib > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > The memory returned by json_dumps() must be freed. > > Signed-off-by: Mike Maslenkin > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > index 126200dd019c..250ef75e40de 100644 > --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > @@ -379,15 +379,19 @@ CreateCsJsonByNode ( > if (TempChar !=3D NULL) { > > Status =3D allocateRecordCsMemory (Cs, sizeof > (RedfishCS_Type_JSON_Data), (void **)&CsTypeJson); > > if (Status !=3D RedfishCS_status_success) { > > + free (TempChar); > > return Status; > > } > > > > Status =3D allocateRecordCsMemory (Cs, (RedfishCS_int)strlen (TempCh= ar) + > 1, (void **)&DumpStr); > > if (Status !=3D RedfishCS_status_success) { > > + free (TempChar); > > return Status; > > } > > > > strncpy (DumpStr, TempChar, strlen (TempChar) + 1); > > + free (TempChar); > > + > > InitializeLinkHead (&CsTypeJson->Header.LinkEntry); > > CsTypeJson->Header.ResourceType =3D RedfishCS_Type_JSON; > > CsTypeJson->Header.ThisUri =3D ParentUri; > > @@ -1506,9 +1510,10 @@ RemoveUnchangeableProperties ( > Status =3D RedfishCS_status_insufficient_memory; > > } else { > > memcpy (NewJsonBuffer, TempChar, strlen (TempChar) + 1); > > - free (TempChar); > > Status =3D RedfishCS_status_success; > > } > > + > > + free (TempChar); > > } else { > > Status =3D RedfishCS_status_unknown_error; > > } > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114665): https://edk2.groups.io/g/devel/message/114665 Mute This Topic: https://groups.io/mt/103988340/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-