From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0DC34D800D7 for ; Sat, 13 Jan 2024 14:19:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nz9X4ogZXPvilUNn4vs0q1kosFvsWuArShsjx7Pe57o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705155540; v=1; b=qbLWJnhY3LbqLvI2IfkKvohzJX4fTbdIhtBcLfUpvxuksIaDzXMvJT0CkKNeI07YXdRB0GFm vKxJTBAIVCSu9Ni7rstARpmAlxNr8dApca2Id1ltkbfMU55gwgfGGNxxh3z6Dr9D/eYSUFA1Af1 g/1qCSdF/q8Bv6x3KGWOTo+c= X-Received: by 127.0.0.2 with SMTP id AXhdYY7687511xHXqWOqBLli; Sat, 13 Jan 2024 06:19:00 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.63]) by mx.groups.io with SMTP id smtpd.web11.19375.1705155539722048744 for ; Sat, 13 Jan 2024 06:19:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mj+gNlD5Z4fkLnjz3tHQNl7l0SIsa9ojOflQjIA4Itme0D6LMxypDNdE35hU1uhkaMRF18KQjBMnLoxXlDk2Bgdd0V9gx01rhx5fnBLsbwc2yeylXNfvky/DRGtyuQ/d45A0ol2vDjYuKr4Wzr+YJrZEeE5Q7EUqI9QMF+QzP/x3yRR/q3qgGOu47KdZvQ7DW+vgVLBPENJND0V/vSxd0q+AYmbG65RPCI4q+v366+yUFX1a/QKt1mYj47MfTbD6kV1OLj6EAtfhv5DsiWn4HKMMKKzR+cYtshgSm/tRbdNGOVk7JBC9qLzFnh3v8uIgz5e162S+cxR+mvffAnFpHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SxatK2ZcV3NOigwcxY86+q/4iuiVhbKxKvGWDBJ1UzQ=; b=d8cJy4eGVlGDfARSpmfXv5BeQTckQaIrND/KsKWm1rmLx/ZLBXRbbArNz0x4nbF7Q4HQK8NdOfMPbMfmcm5/RS6iiZFGaqutASiBAqe9dEQZoiQKxgPYl/rqxo/YFvbRWwwYD7hbhjJRwVuwP5TJJIkg1e+48iH1x4mcQc81QP/TsICn663aHOXLhcAqQZ7Oi0bihRRYLqZt8IpH4s9sIYLnlkiwy3nXAbNHUNTg2j47yGOyfvoOHIR11kwN9ar5b8ceNsluawYHYYCj5G1nc/E5GwDacnefu7nhN598gbyYCFlJIF2wWyZWysYiXLiaUIK424uMdvGsP+ZH9bpnBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by PH8PR12MB6721.namprd12.prod.outlook.com (2603:10b6:510:1cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Sat, 13 Jan 2024 14:18:56 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::67bd:f1b9:58a3:d2e6]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::67bd:f1b9:58a3:d2e6%7]) with mapi id 15.20.7159.020; Sat, 13 Jan 2024 14:18:56 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON Thread-Topic: [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON Thread-Index: AQHaRUQVDk94gXr9IU6mI0YeuNHO5LDXzFFQ Date: Sat, 13 Jan 2024 14:18:56 +0000 Message-ID: References: <20240112104228.670-1-nicklew@nvidia.com> In-Reply-To: <20240112104228.670-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=8ab409b5-56b0-4b72-973d-4f6a543d62a6;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-01-13T14:18:48Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|PH8PR12MB6721:EE_ x-ms-office365-filtering-correlation-id: 0e7ca3ba-3eb7-4fd6-5d84-08dc144293fd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SCx7aWixSJxQNzOBf0o33wO6ZiiAw3Y1YnCnFjIyCHCeCV663mF8AG3d30gc5papYYkRpebXKwmTqQzBKlr4ZSslltVRMOh0IIRb9su4DTraA5v61tiemgbxtYKdsQppqVKnnUTzFuEJdngKRbMv02rISNUeHRhh8Bx7QHtRCiZpSGMHXLLE8O0jvAJ+dTnwgrclxCcvTsoK7NvvkcLb4Ktxx+1FsMmAuCQYmDnJbHrGG9MWvB6WN5iLCLjTa6alB12+10bf5RwXvoaxels3zmDDVYYiWcuT+OiJsPLHJJYqbxSMwJEVQ1CWuEi4XN3GYRj1w+GLhkkZ1lz2xhcbDmPqMKrLx9UwfVG/S8+3zIPMx/VEg3Zm5Xh6JHP1AeuKxpD1sOl5sAp01H7qA5ZQsRf1w0tRtGaaoL+UZyiK/O1uIU2TSYg1TsFSV690it0Xa7wW6CAeRXr71mDDNaQrR+VD5kI09zn3xxy4nIwX1AVhL/bn8HVvSWqsj0zMEF3DGVtUc8h6bUbpmtL02+z+NVwvyaMkbVcYq6wVBC06de9C+B6YxNwSUt8iA5tcvS5dXUltajcSe7RcLsRMUxiprrAsjcfIl6oC2rNr7MhMhM1W1t+DzuGlk5rcMwm770ETStka6a/2/HUURJ1N5bn4dJKnt27c8vFUhh7bEK4devU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jDZ5uNNXx3KhQu3OZUAcwg3bJap0mPGToxwu+D5nFhFoz9m7p654SlYSWyPv?= =?us-ascii?Q?8bpacEm0dyxSt22KXdNcdP0q4ML6ztr0Esntuml2zfM0qqkLNL9S83Hs3zOR?= =?us-ascii?Q?8xYE8Ear7xtEPj1GVHkFiGcmv3dZXi+829D3ZhRf8bwNs/tMUv1xqdYY1hVy?= =?us-ascii?Q?5cUEoQP2rGd0ss1xKHIrKI7dFUxKOaoZlbX7THohrwrigQ2v6a+U5mD2PKhB?= =?us-ascii?Q?sfnSRmqZiGf9L35xh1I0v8vadT+zmX6nqKcn/HiQyxLt9pggGv9U2mHSpbpD?= =?us-ascii?Q?T1e0o0OKIF8E0v81+k7oS2MU6dTqPE/3BgBeH15vQ1YuKmPYdNcKN05kpENC?= =?us-ascii?Q?5xVsa1+UUdehrmA4WaIDMQj07Y5Cm66X+yCGD1dJyiWeWdlhaCPkfVDjyK/e?= =?us-ascii?Q?CH18p8iZ16XYzBduv3rSZ2rF+yXyDw0OkX3kbxT7TLh/PiGzppPNDe8lKqZc?= =?us-ascii?Q?ONtdpkHC0ETjkrSxZ2xRuUN86oJ2pHyzIKFGz06FifPENAdeWdiuITDGRQik?= =?us-ascii?Q?dgzunagkYsV6NYbR8hspX/9C20fbeSUj6LEjWpb8UHAvv05xqkmZHJpbt6CZ?= =?us-ascii?Q?jSthoJOfrC4XIUG5btwTuCPmtdEsKDiVq/rub98x/0eBm2jA8y/rMQqvtCO0?= =?us-ascii?Q?btV8KddeYfQGIrDV5LAGdIgwTXOgFcxEn2dAcdmEPv6i+HFkCrctGlPLiBHI?= =?us-ascii?Q?OEdhNg49cAy5M0GvMPwBhcSgsS801ji2CUugSCL9XnYgZZhhlxqKUIyQjc4A?= =?us-ascii?Q?qfPF/cvfTUBuObGNxFO/BIIFKnIxKPtwqXeQgIE6MdDAQubc0+XFTi8zpqEL?= =?us-ascii?Q?KSmxMmUWQx5HkJ4EJS1pZUDXvzrjN5SBhqnxcUvktFEAjW7AGS0yJsNQzSGG?= =?us-ascii?Q?c2cPBg8kcdmpBXo628/I/ELUDmJwAxTsZ6OZL4ry7P9+qqWSq8wF+EhEYy72?= =?us-ascii?Q?D0T33/545ugZVHt2f6B4cr6T/VXsrDQMbk+ELjjx86jenWThIjCEZZxfBCXJ?= =?us-ascii?Q?QWGlqzA3vMG+VAwI+JouTjpWF9f9I9KpiZWwoKjo55lGjMHTNsnUPSDdP1S4?= =?us-ascii?Q?+6AuF2sbqZOIWR3YkaXO3A8RKI6h2GO05kRqVD9aT3QjsscYPYhfJtmeK2M2?= =?us-ascii?Q?Fha3hHMAlBRCEWAyp+KTNCMHj7KyZ5pXkOhH1+CuV4y+vWjyTLpPBF0cCj6J?= =?us-ascii?Q?kuRs4uE2NcVqM6T5DQlOGKIUGOBgHZXCJBVOz/bVM8wc5dW4HnWFsiV6QZn2?= =?us-ascii?Q?Vt3kWsbvFoZhISwXma5H6QzORpnJXtnpKrxgTvhm3OkiCVCZkyvbkplkC46p?= =?us-ascii?Q?OhBr2KoEt3kYVnL9cFUVM1udG0pirOlXyckpAUg3a6o6ZX9cQT+IX+TQ47wU?= =?us-ascii?Q?h+dloI3OXpSMLsUSK/7UtCyTHZlA76houSnVywj/AqJXYVG25dPL1w5Y6gRW?= =?us-ascii?Q?U4N1xYyrqs4RNnyExlYSGxZavA+9NCBOYYbpikww/zO45jzjDLDH3ymiB3OZ?= =?us-ascii?Q?oXenVVW8TALvyW7RmH91tpq8dPa22e6ynWtWFaf8ySIfHIz/mzoa08W+DiuY?= =?us-ascii?Q?vD8cQe2Gr8kv6/L60aQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e7ca3ba-3eb7-4fd6-5d84-08dc144293fd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2024 14:18:56.2925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vQpexKhvvCke8gcQzA2LU29Vp3zwDo6cEL8ouQtLWqgwRJnrz2XXsUpXoNP2taKNUuXKVtnqqJOjUDI27ZfpyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6721 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FSnllUnjL7jLmsoUWZwLLMuYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qbLWJnhY; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Friday, January 12, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number i= n > JSON > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > When the value type is defined as number in Redfish schema, floating > point number is allowed. RedfishCrtLib raises assert without handling > this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS > and handle the floating point number. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c > index 57a997f351..e88d874224 100644 > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c > @@ -4,6 +4,7 @@ > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -519,7 +520,7 @@ strtoull ( > } > > /** > - edk2 Jansson port does not support doubles, simply return 0. > + edk2 Jansson port does not support doubles, simply return integer part= . > > These conversion functions convert the initial portion of the string > pointed to by nptr to double, float, and long double representation, > @@ -540,7 +541,7 @@ strtoull ( > the return value), and ERANGE is stored in errno. If the correct valu= e > would cause underflow, zero is returned and ERANGE is stored in errno. > > - @return Return 0. > + @return Integer part of decimal number. > **/ > double > strtod ( > @@ -548,9 +549,13 @@ strtod ( > char **__restrict endptr > ) > { > - DEBUG ((DEBUG_ERROR, "We don't supprot double type on edk2 yet!")); > - ASSERT (FALSE); > - return (double)0; > + UINTN Data; > + > + Data =3D 0; > + > + AsciiStrDecimalToUintnS (nptr, endptr, &Data); > + DEBUG ((DEBUG_WARN, "%a: We don't support double type on edk2 yet. > Only integer part is returned\n", __func__)); > + return (double)Data; > } > > static UINT8 BitMask[] =3D { > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113779): https://edk2.groups.io/g/devel/message/113779 Mute This Topic: https://groups.io/mt/103680418/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-