From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6D17578003C for ; Mon, 1 Apr 2024 01:24:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/oz/csad+OCBkLCtpjbPdB2REs9In61ir8JVDt35bLw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711934640; v=1; b=OsBwJHlftppF7Pp26poIgKjdTHKN4EKvaIRuEx5o5QJLfkWeLgQIeB37SNsbYOz0MWYhPT33 xud1l0iWYrmig+B235FEkFTY5bTscxO3dYbt8P/TzvT6TTIZpozcApg+avkGKeBSVySspx0guFp cyDFd4/M5V0l39FjLdrSfcsjiGKdxaxI6VsPCC3C7LAgD7NIHuNsu5aNrzZ6owMFPiUozUNNUSe rvWejLD6WFjH0nMxA0GjPo1IDcrbaDH67KNAEIBHjy8bwrGbv1e5Wbc5kuKOu3RooL4ypPOGK3j eEyS+OaOBjGj8RIoOMktOhdh23noh9jgttsCCsLQkrcqQ== X-Received: by 127.0.0.2 with SMTP id ZLzxYY7687511xNMhkYh0Ivt; Sun, 31 Mar 2024 18:24:00 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.123]) by mx.groups.io with SMTP id smtpd.web11.28510.1711934639089851953 for ; Sun, 31 Mar 2024 18:23:59 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SN7PR12MB7883.namprd12.prod.outlook.com (2603:10b6:806:32b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 01:23:55 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0%5]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 01:23:55 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , Nickle Wang , Mike Maslenkin CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language Thread-Topic: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language Thread-Index: AQHafGcZhkEZ/Uk3jkGOazQqRXC/lbFJ9SlAgALLTTCABex0YA== Date: Mon, 1 Apr 2024 01:23:55 +0000 Message-ID: References: <20240322144124.1671-1-abner.chang@amd.com> <17C0DB2F6517C591.6770@groups.io> In-Reply-To: <17C0DB2F6517C591.6770@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b4fbe4ac-c4b1-433a-849e-38cbebf02cae;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-28T06:53:26Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SN7PR12MB7883:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AuqAJE77Wp4CpVWHDz8ztBFQfOTrtwKDA6kpXE3bzTO2WMMx3XFUVJoP3sugClGbf2/ejUIxIlFr8MmzqqiB+LZtLg/vTJ/Qj6CkrtrNQ0DMgPuwpWXqxsJQ0sEMtPjlLKsLkbSO5T2CbDSN+6SgmJjYwnUmiXf8pkyjy3NZgBbP6gkKeMmftMi8UbkkA7o/M3CQdm2+IVCiZ4P8CEhk0NjWOQy96qlBezBBfphDvgiuLHxXrSMGwGedag9pjleIU87Ai4hsaQkoxlXteh4BG2AbCty8jnkbfM3tCQzYD31UX0hhRYqqL7UP+kaDxYLWTgzE/BonFoiI9DfxHbpCISmFyNIBQz/LOhbdl6WCy6c7JERZboOHCms6EparOKfvMMOCUFz+8ikmiueIYJ11I7EDxdsIq1PZPWGL2j7trydQDD6Ws3RyTQJFGM7ZlY0mwUOTm06D/2Vp59IOogk20S4C491R7zhtlT+nIJ8xUzmiD3SAq1QgHBCjPD2PcMMwzwoLYf2vmB7JI8ZxIUulBZqXyln1kvfNpMtAkNThmZ51pSSNbx/5PT3WGbFwy8yd8yXvfmeq+20K9Gz5FtJfb4DKewUvK/6qHHxkFKaKjbM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w9ipPg+/5YsRXZ/c8yuE92gm+jLVbpCNjPoApsjWZ000GMcy2f4KD9fy6qIJ?= =?us-ascii?Q?GfN/T2XUaHmvrBMvnQGNiIYIQaDt1z9uxMzSSq37cPj+GBzSVNlUDziYtDlS?= =?us-ascii?Q?I2icomwVkNJss15Fv2ikhO5BxXbdSR+lu8D6Bur+CGaD5nJmxYQU/jZA4Lj6?= =?us-ascii?Q?XukxiDUfBdWxdJjYZgfiRwLWoJiCsJuIEgNBhznTDOhVq9xTSIN2OlsM7V5Y?= =?us-ascii?Q?A74+KHfsVQU+kYndWcaVWnvER2hKruyuUnv85StZTSTwiUjDJh3HTNCj6iiY?= =?us-ascii?Q?ZBadIRtQjKRD0BMCD75HFIZM3PeVTbPBoKm3YdV2sStxh4gfVY1LPp3S0Lnh?= =?us-ascii?Q?IVAYf8Tk6iJsFZRb8bCVxTzwPQv2DdMN8dEZVLNNZY3CFIMTSHKcPB6eIpT6?= =?us-ascii?Q?dVT4ysITcevZEnoaRlIuMnWvB0fk/Vdy0xt2CQ6Dz2jK0+36AVRdvZg/X1RV?= =?us-ascii?Q?aDh9rI/HjHRk0x8Q6qpx/X1sVp35cmJ5YNazxisa6vRBjgKCSRfjOkS0ulW4?= =?us-ascii?Q?Nqp4CmQ7LHd9IHCEtDI/r2UmC/B2LQyhL7uzVsxXTISLcX7I+OOEfPMLuAVW?= =?us-ascii?Q?2DsdmmCqGXAykZLxLu1mRlyFt2afkKWFf7fQLYqPkCY6iM7RUgW8ZM2Ck/dt?= =?us-ascii?Q?vCMWD7bpTh8VwlPQCW3MEn40oi3Iu8MG4wff4lNl5MvkjQR6gD60zIFtuISE?= =?us-ascii?Q?uqGZwZB8BG/SWIsuWUfRPiwvzO6rB9Jn48DqwhfZOZ/cB/7X9sJMTv9pYf+J?= =?us-ascii?Q?4Ha6DeQnQItXIpY3JAY4hYmaNCJZlQStQhmwRqePhZ6F7PDACfze7Y6HA5ef?= =?us-ascii?Q?UjSojBHz+x34zWe5/gG1UctK/xyAV1opSlVhXTEhHDgwDckXIH3Fu4Bzq/Ne?= =?us-ascii?Q?uASvECepHqnqgR8zkI1ourX2sIIBzEX7QALrBvEJXRxUBy+/0YQ3GYgrhfnE?= =?us-ascii?Q?2zaF/z60hGikyCtydd/9VBHGk39yddDq6VJ2/xuzxsyKRkrKpKKRON4h8zQ6?= =?us-ascii?Q?6cBnvbZxMjj5X2dL1hfOFW+P/j7F0py7ecq6q3D67vVeFeNZFAAa/wCrDsN8?= =?us-ascii?Q?iLEUnoq4hKXIxWp8zAYOzIWiTj8IlxkhzdvmXb4Fx8u/G7B4m+pqW21A7AjB?= =?us-ascii?Q?cqI6jWjUssOUWKh0m+Ds9mFJMBHQsbJIXt3DJWE8sQ2n2I535WwDgxH/HP7p?= =?us-ascii?Q?sMTZ1K86wBQBcu47mbQlk1uGUhsn7tYuN6xbuPFP91dL/+en0tdWELNHiwFl?= =?us-ascii?Q?z/uaA+PQ88391i/G9VLXHa05VtBTvFX7R8SHe24yNVaCnj1kWf+mNCnnaPW4?= =?us-ascii?Q?zRWe7/OeHvqrk8SV7W7UOPH1Rxo7VgnUXuWMLIek1A/+QWRXjVK7HCAzgFgX?= =?us-ascii?Q?gQ33y6yWwsLZNmDcfUK5ai9TOm273zh41PZhHej/83VyOkOfsY5x33EcdE1h?= =?us-ascii?Q?1r2FEJ+B32fEHQKZ8iQfxfwo1W7SO79chFwAMNLnDh3S3EEHtnOQKigxjQfi?= =?us-ascii?Q?R1SfsifIncbtfhDAEjIX1xmG9NuL6/nsxBoYWAsIqQsGYx5uUNlsrHh5NgRN?= =?us-ascii?Q?ngJHoaxh3YXf5NFn4iU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8ee1175-8fd4-4f7a-5931-08dc51ea65c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2024 01:23:55.0563 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DIM0AW6mmXiWCULGsdIiYZTl9O5V98S3OXlHGjJj0/Z1VNVQc9lc38VT5hZ9hnpt2KIEOZmdebi1prK+s/tTfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7883 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 18:23:59 -0700 Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: L8ixO9JaUmiwYubuIqf1j1CVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OsBwJHlf; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Mike, Just letting you know that I merged this patch set to clean up the backlogs= . I believe your comment was addressed in V5. Just let me know if you still= find any improper code. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Thursday, March 28, 2024 2:54 PM > To: Nickle Wang ; devel@edk2.groups.io; Mike > Maslenkin > Cc: Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] > RedfishClientPkg: Set SettingsObject URI as the config language > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > [AMD Official Use Only - General] > > Hi @Mike Maslenkin, would you like to review this patch again as I addres= sed > your comments in V5 patch set. > Thanks > Abner > > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, March 26, 2024 8:14 PM > > To: Chang, Abner ; devel@edk2.groups.io > > Cc: Igor Kulchytskyy > > Subject: RE: [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set > > SettingsObject URI as the config language > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Thanks for working on this, Abner. > > > > > > Reviewed-by: Nickle Wang > > > > Regards, > > Nickle > > > > > -----Original Message----- > > > From: abner.chang@amd.com > > > Sent: Friday, March 22, 2024 10:41 PM > > > To: devel@edk2.groups.io > > > Cc: Igor Kulchytskyy ; Nickle Wang > > > > Subject: [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set > > SettingsObject > > > URI as the config language > > > > > > External email: Use caution opening links or attachments > > > > > > > > > From: Abner Chang > > > > > > Set SettingsObject URI in @Redfish.Settings resource as the config > language > > > which is the same as the config language of parent URI that mandates > > > @Redfish.Settings. > > > With this, we can find the config language of the properties in > SettingsObject > > URI. > > > > > > Signed-off-by: Abner Chang > > > Cc: Igor Kulchytskyy > > > Co-authored-by: Nickle Wang > > > --- > > > .../Library/RedfishFeatureUtilityLib.h | 17 ++++ > > > .../RedfishFeatureUtilityLib.c | 89 ++++++++++++++++-= -- > > > .../RedfishConfigLangMapDxe.c | 15 +++- > > > 3 files changed, 104 insertions(+), 17 deletions(-) > > > > > > diff --git a/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLi= b.h > > > b/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h > > > index ba9ea01501..3c5f248eb7 100644 > > > --- a/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h > > > +++ b/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h > > > @@ -369,6 +369,23 @@ RedfishSetRedfishUri ( > > > IN EFI_STRING Uri > > > ); > > > > > > +/** > > > + > > > + Save Redfish SettingsObject URI in database for further use. > > > + > > > + @param[in] ParentUri Parent URI of @Redfish.Settings pr= operty. > > > + @param[in] SettingObjectUri Redfish SettingsObject Uri to save= . > > > + > > > + @retval EFI_INVALID_PARAMETER SystemId is NULL or EMPTY > > > + @retval EFI_SUCCESS Redfish uri is saved > > > + > > > +**/ > > > +EFI_STATUS > > > +SetRedfishSettingsObjectsUri ( > > > + IN EFI_STRING ParentUri, > > > + IN EFI_STRING SettingObjectUri > > > + ); > > > + > > > /** > > > > > > Get the property name by given Configure Language. > > > diff --git > > > > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > > > > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > > > index cc2b37b796..dda80c4608 100644 > > > --- > > > > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > > > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUt > > > +++ ilityLib.c > > > @@ -2082,7 +2082,6 @@ GetConfigureLang ( > > > EFI_STRING ResultStr; > > > EFI_STRING UnicodeUri; > > > EFI_STATUS Status; > > > - EFI_STRING StrFound; > > > > > > if (IS_EMPTY_STRING (Uri)) { > > > return NULL; > > > @@ -2101,18 +2100,6 @@ GetConfigureLang ( > > > } > > > > > > ConfigLang =3D RedfishGetConfigLanguage (UnicodeUri); > > > - if (ConfigLang =3D=3D NULL) { > > > - // > > > - // @Redfish.Settings share the same schema as its parent. > > > - // Remove "Settings" and try again. > > > - // > > > - StrFound =3D StrStr (UnicodeUri, L"/Settings"); > > > - if (StrFound !=3D NULL) { > > > - StrFound[0] =3D L'\0'; > > > - DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"Settings\" found in URI, t= ry: > > %s\n", > > > __func__, UnicodeUri)); > > > - ConfigLang =3D RedfishGetConfigLanguage (UnicodeUri); > > > - } > > > - } > > > > > > FreePool (UnicodeUri); > > > > > > @@ -2172,6 +2159,64 @@ RedfishSetRedfishUri ( > > > return mConfigLangMapProtocol->Set (mConfigLangMapProtocol, > ConfigLang, > > > Uri); } > > > > > > +/** > > > + > > > + Save Redfish SettingsObject URI in database for further use. > > > + > > > + @param[in] ParentUri Parent URI of @Redfish.Settings pr= operty. > > > + @param[in] SettingObjectUri Redfish SettingsObject Uri to save= . > > > + > > > + @retval EFI_INVALID_PARAMETER ParentUri or SettingObjectUri is > NULL. > > > + @retval EFI_NOT_FOUND Config language for ParentUri is n= ot > found. > > > + @retval EFI_SUCCESS Redfish URI is saved with correspo= nding > > > + config language. > > > + > > > +**/ > > > +EFI_STATUS > > > +SetRedfishSettingsObjectsUri ( > > > + IN EFI_STRING ParentUri, > > > + IN EFI_STRING SettingObjectUri > > > + ) > > > +{ > > > + EFI_STATUS Status; > > > + EFI_STRING ConfigLang; > > > + > > > + if ((ParentUri =3D=3D NULL) || (SettingObjectUri =3D=3D NULL)) { > > > + return EFI_INVALID_PARAMETER; > > > + } > > > + > > > + // > > > + // Check if the SettingsObject URI already in the database. > > > + // > > > + Status =3D EFI_SUCCESS; > > > + ConfigLang =3D RedfishGetConfigLanguage (SettingObjectUri); if > > > + (ConfigLang =3D=3D NULL) { > > > + // > > > + // No config language of SettingsObject URI is found. > > > + // Get the config language of parent URI because the data model = of > > > + // SettingsObject URI resource is the same as the data model of = parent > URI. > > > + // > > > + ConfigLang =3D RedfishGetConfigLanguage (ParentUri); > > > + if (ConfigLang =3D=3D NULL) { > > > + DEBUG ((DEBUG_ERROR, "%a: Failed to get the config language of > parent > > > URI that mandates SettingsObject - %s.\n", __func__, ParentUri)); > > > + Status =3D EFI_NOT_FOUND; > > > + } else { > > > + > > > + // Set the config language of settings URI using parent's URI = config > > language. > > > + Status =3D RedfishSetRedfishUri (ConfigLang, SettingObjectUri)= ; > > > + if (EFI_ERROR (Status)) { > > > + DEBUG ((DEBUG_ERROR, "%a: Fails to set the config language o= f > > > SettingsObject - %s.\n", __func__, SettingObjectUri)); > > > + } else { > > > + DEBUG ((DEBUG_INFO, "%a: Set the config language of > SettingsObject - > > %s: > > > SUCCESS.\n", __func__, SettingObjectUri)); > > > + } > > > + FreePool (ConfigLang); // Free the ConfigLang of parent URI. > > > + } > > > + } else { > > > + FreePool (ConfigLang); // Free the ConfigLang of SettingObject U= RI. > > > + } > > > + return Status; > > > +} > > > + > > > /** > > > > > > Get @odata.id from give HTTP payload. It's call responsibility to = release > > > returned buffer. > > > @@ -3532,6 +3577,7 @@ CompareRedfishBooleanArrayValues ( > > > payload and URI to pending settings. Caller has to release > "SettingPayload" > > and > > > "SettingUri". > > > > > > + @param[in] RedfishService Instance of REDFISH_SERVICE > > > @param[in] Payload Payload that may contain "@Redfish.Set= tings" > > > @param[out] SettingPayload Payload keeps pending settings. > > > @param[out] SettingUri URI to pending settings. > > > @@ -3552,6 +3598,7 @@ GetPendingSettings ( > > > EDKII_JSON_VALUE JsonValue; > > > UINTN Index; > > > EFI_STATUS Status; > > > + EFI_STRING StrFound; > > > > > > if ((RedfishService =3D=3D NULL) || (Payload =3D=3D NULL) || (Sett= ingResponse =3D=3D > > NULL) > > > || (SettingUri =3D=3D NULL)) { > > > return EFI_INVALID_PARAMETER; > > > @@ -3586,6 +3633,22 @@ GetPendingSettings ( > > > return Status; > > > } > > > > > > + // > > > + // Setting URI exists, check if settings URI is valid or not. > > > + // > > > + StrFound =3D StrStr (*SettingUri, L"/Settings"); > > > + if (StrFound !=3D NULL) { > > > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"Settings\" found in URI: > %s\n", > > > __func__, *SettingUri)); > > > + } else { > > > + StrFound =3D StrStr (*SettingUri, L"/SD"); > > > + if (StrFound !=3D NULL) { > > > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"SD\" found in URI: %s\n"= , > > > __func__, *SettingUri)); > > > + } else { > > > + DEBUG ((DEBUG_ERROR, "%a: Not an valid @redfish.settings URI= \n", > > > __func__, *SettingUri)); > > > + ASSERT (FALSE); > > > + } > > > + } > > > + > > > return EFI_SUCCESS; > > > } > > > > > > diff --git > > > > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > > > > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > > > index 8c93044580..4071e30c17 100644 > > > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > > > +++ > > > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > > > @@ -2,6 +2,7 @@ > > > > > > (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> > > Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All righ= ts > > > reserved. > > > + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights > > > + reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -606,10 +607,16 @@ RedfishConfigLangMapSet ( > > > Status =3D EFI_NOT_FOUND; > > > Target =3D FindConfigLangMapRecord (&Private- > >ConfigLangList.ListHeader, > > > ConfigLang, FALSE); > > > if (Target !=3D NULL) { > > > - // > > > - // Remove old one and create new one. > > > - // > > > - Status =3D DeleteConfigLangMapRecord (&Private->ConfigLangList, > Target); > > > + if (Uri !=3D NULL) { > > > + if (StrCmp (Uri, Target->Uri) =3D=3D 0) { > > > + return EFI_SUCCESS; > > > + } > > > + } else { > > > + // > > > + // Remove old one and create new one. > > > + // > > > + Status =3D DeleteConfigLangMapRecord (&Private->ConfigLangList= , > Target); > > > + } > > > } > > > > > > // > > > -- > > > 2.37.1.windows.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117271): https://edk2.groups.io/g/devel/message/117271 Mute This Topic: https://groups.io/mt/105086466/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-