From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3005BAC05CC for ; Thu, 1 Feb 2024 00:42:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2oegiGTritY8TJW95ggkdx7+nBgtkHzS5GISM1XVzyk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706748167; v=1; b=BRJej7jIugkXs3SZla14u97dMN3mJsfN2KydLhdqAtuQgRV4sexq2sw+edA0K5AtBQzNhlYV DIsc1NGoZWH63+3ceO8cXkssl9ZgW+IMdcXrHkuQ6Vy9Kcx1ZzHLYIerc1xm0HCY+aKWAcfGwGG eFxFDXMSt4SLvEPp60xL4XjM= X-Received: by 127.0.0.2 with SMTP id 4CaTYY7687511xSVIigeZBme; Wed, 31 Jan 2024 16:42:47 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.47]) by mx.groups.io with SMTP id smtpd.web10.4675.1706748166797139223 for ; Wed, 31 Jan 2024 16:42:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nk2YLoXOECOlmWwrerGl1O8gtuyb2aOw7V0pV/cBN0LcuNDKhz6bbqEuKfKkoI3EnOnHBARBg7FO73voV5Su4IjJ6D0EYKccrpUjMAIq39BbF/BrE2/jJbkdfBaMFv6Sabfgbo75P8lOSGFy4dvrTvFUUNNnx2qnJaLUtyeKFC8vuV2XhsemYJsgsY7kXXxMI/xbokwdFkAw8AduawHBClF8zjZfk+TrTSHzp00PdCwEg7xSel7OE1WOT2sCSlvEmITYjgcsR7CfF2d31/CMNo3uJJF3nx/gMxF3VTADa2H4Z7WQRON0inuSOoCURwXFmItpYBvIurHwLmzXLLfqgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=clBdG3xdvHM+WKtvCF0sUIdDJt4Evks5OcZDeleCGhc=; b=e+NlGmY2Y/tfE1tnpmI5B0DsVtECuxcATUXXgC/3WeT9ht8cpIqmcMdG9Aen0RwLltP3hVwQFU56bjAoNph9mN750V7CGnzUnAKKCPtpTmyId4fl2POTV+6p5sUeUjvG/ai+PWDKaYnMVhkQ7HPbPfj8ep+0H/2TBjaR2NPxu3stbh32KyucepDz8/HUVTViplao/h8ibmj3bh8Va6Lr9JBbN0kwAzJ0GDYuiqOTaJBMtIqPrZ1+0cVi0uyTvAosBWJEDp/D32DuESDVpfenugaRiKgiqOhlg90Fsc/1LqVzjunQVXhK2bnFRIVmh7KmeS1Q0hzRwFJF7Dz4k6B81w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SN7PR12MB6716.namprd12.prod.outlook.com (2603:10b6:806:270::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Thu, 1 Feb 2024 00:42:43 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::27a4:a992:ba04:829d]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::27a4:a992:ba04:829d%4]) with mapi id 15.20.7249.024; Thu, 1 Feb 2024 00:42:43 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nickle Wang Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Thread-Topic: [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Thread-Index: AQHaVKdrolbsjPyBXEyvUUhe5pZIKbD0pbVw Date: Thu, 1 Feb 2024 00:42:43 +0000 Message-ID: References: <20240201004127.27660-1-mike.maslenkin@gmail.com> In-Reply-To: <20240201004127.27660-1-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=05b3a32c-3341-41b7-8abe-59e8721a2234;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-01T00:42:18Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SN7PR12MB6716:EE_ x-ms-office365-filtering-correlation-id: 5ca16d8d-156d-418d-4b30-08dc22beb3f9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wL2sMAaEXXj+A6f4hPQtaULsuRrAENpMXFvBeye4CHXm7pFTAD4jgi4FzAgOZp9rNO4BqQ/WW2CCFu4/kpncfzxET5aDaRPvKeXnkzHzo9h/ZCmrlY0JGPTxlr7dK/N8aSqY9aOfoOE5SNGWmFUhEPI5P9ro1o7AdAqHS4PErwStHRwpaeJ/yik/bk9Igj9E/uqbL2eIKlcWZ9+Ickr5+JeK6OBRJpCbt/YJnuVPhsWa0rv4J8qIcUuU19tzPGiT0QbZkCfM+0sFadIFj9kwSVD7pZDUoCyt/73w4CiDtC/c+8NtYmucCEqvxFCpjvdoxJn8TON/GPYoYru3utLfVMSCvXcOqcnVFbeUhgfxusO+RVpDcOis9tcsXwhmKKZ6kvInwETh+dcAh53b8HTNXBqEKYI+icAYnGeOHLtHqy/g5HpL1qr/E2DFppL2fPiZ9WAvo2B26kp1v37rOxRj/qDhLLm/AR2rsR+crjCcvm+8kL2KUQVR3dwJtJhEPek4O+T0/1dz5k5BDtQR8hjNCVtGdCy7RnKEAqEy9ZdCnkoKzXXmpBabQHHqa62d661IVg/59X8JNyVxj9UJaNT4chs3bipj8Ber15E8VRKUIhWQYZmlr/9NDWbsPE326CAJn/FIvDDOtU7SW6driilkCQl7z5w+67a9/27XjaoGkGM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fUC+2ek2m7tXg97cFgIzs/IXSUYAqZTydv6nyY3kMsUMGFRsqeNDVfPKDMRD?= =?us-ascii?Q?kSG/P7ZN4tYyyP+2SX4F7DqP/xnnQXnFYZRd9X3iPtJrqkTaQ1WSXDApkFIf?= =?us-ascii?Q?d8Iya8EQ+5PjbtVGj1dz2KqDBxvHSTiSreTfbLqytFE/GPqzXvwgAHUl0g+E?= =?us-ascii?Q?PIClcyjygKf8pM8tVXlcUOHMREslqMnwQBy9nv6BC9WY+oY0dEYaupS/AIZE?= =?us-ascii?Q?Uz2gLZEJE94IvqXnVNV+5mRvkg1LLzT1mL9OhWXIvA/iMe3t1MaKhh6BJ4UN?= =?us-ascii?Q?IMH76vWMgLlOsadObq+lxnBT+fuWx5f97aF33ochfx/iPbsETtG0sDfxHVr7?= =?us-ascii?Q?x1QYig1uVsBfaJ23Z0YkUHoQRDsAIISwtFfe24zHimGWPNQLBcR3sLq6GoGT?= =?us-ascii?Q?eK4/Rg2AwHs1fuE5y4ekIj3XIvpm9TbqU0PeSNIteUDmJuVRHAhNPem7JN64?= =?us-ascii?Q?g/Pga+EJyZ1D7JzlQDDp4BQ5HLcXf9hQZ1sIXECa4wS8DfOVdilihgAKfZDm?= =?us-ascii?Q?krDw3EH/s6njVozPx7yEshKaAk/bVC7Pe1jE2cAh+xAfRUL3j44O4yCQZoal?= =?us-ascii?Q?o8xgYXv6qL+dZO9qXI1Tbtf7QDkbgqhez88jGDV0X9hraxUqBDD6gelPjjqG?= =?us-ascii?Q?WUQkkQiwyTqMQ+BpfBPqmb1NoDLzLw2sut2f8qaaHe50HpAKcZiG1HRQteXf?= =?us-ascii?Q?bBBso2wPuXzjuSUCzAGBfj5kjmOGmQxqLlg1VwxUIRXwcM366iNFhNPBMt2g?= =?us-ascii?Q?A32ikOMY4XljMFm/Jp2EETZHG2y87BfjGYAZvwzTc1Odv4Cf+iyWnYKuM8QV?= =?us-ascii?Q?bA3QGmcYJI9U9VSx8rMlrvxKBvcl8y2p9JrlchmSgYNYkYOwpMY/J7xK/vds?= =?us-ascii?Q?J8rLFfH+p2v2WXdvYTLaBpBI6/9GWRvsQKpWwzbyHyF0kDQkQ0W3tph/T/e8?= =?us-ascii?Q?DgSGctisr9U2Ei/gI52fzayTsJJtOD/MyCIFqJdQhFGNMmnOnJ0kM1mFGlcp?= =?us-ascii?Q?6ZLVXlky5PbtAs8fwXl90mDG0odLQhJVgNZjeZ4aJq7Xt8YRaEPUjTvK4jhU?= =?us-ascii?Q?19JIpp7YrHECbBGF1qL2jt8vTCOUm5oyXvmnF6XX2I1Nt5/RabqL63whXznH?= =?us-ascii?Q?FiN2K6ZUypb07ptvcDS7xasuGnEwjiUmK8sRrsE+3SLdLLbw6pP/VNzBXoGG?= =?us-ascii?Q?jag8OiiOhjcskkoyoUd6rKruf9Y0R+w+jQMbBwhmRcvhKGmuQDBDnP0Hm1Tm?= =?us-ascii?Q?zKebglgFZRem2GsUB9brSMstfNUn9ZbCkz1zUWBoBS0LSi4vsnZSQrX2sEHk?= =?us-ascii?Q?qRe8eZBKNNuS7JDlnAIr8WtJ+cXcdBsQUSRYX0FV9BF2aUwgNuLIKEDOyCha?= =?us-ascii?Q?n5Vsk04nTgm8w5wFqw3saorCaPAXRQaKQvPTsbaYfz6K+gP8ryuDkzPKG+if?= =?us-ascii?Q?cspEe04wZ445seOVXfnAmgO0jKwTTSjOma5zTGmcmWGDdJGax1Gte7PjueDJ?= =?us-ascii?Q?gl+tCt99ibL1jN3K0+mPkUMtSh6aD/7i/fQzq0qM9wicMxQro4dFB5ZTW+Ns?= =?us-ascii?Q?gbgYqCzHVrLpoliFQBs=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca16d8d-156d-418d-4b30-08dc22beb3f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 00:42:43.8151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gfRz+lUQukeRciVfZpgZEUjdEXBaLgkgzdX9A54AWA8EML6YGZHpmpFTOu3f2WkY+asNra+RZzG4MBOhOPR1cQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6716 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VL979iqCGu3Z20if154Xaqagx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BRJej7jI; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, February 1, 2024 8:41 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Chang, Abner > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][PATCH] > RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nickle Wang > --- > .../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > index e1494471038c..21ce8ddad9d5 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > @@ -4010,6 +4010,7 @@ RedfishRemoveUnchangeableProperties ( > (RedfishCS_uint32)AsciiStrSize (*JsonString) > > ); > > if (Status !=3D RedfishCS_status_success) { > > + FreePool (UpdatedJsonString); > > return EFI_DEVICE_ERROR; > > } > > > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114925): https://edk2.groups.io/g/devel/message/114925 Mute This Topic: https://groups.io/mt/104087507/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-