From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Nickle Wang <nicklew@nvidia.com>, Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH 4/4] RedfishClientPkg: use Json value from a function argument
Date: Wed, 21 Feb 2024 02:22:16 +0000 [thread overview]
Message-ID: <LV8PR12MB9452FC5A737C296B145C5153EA572@LV8PR12MB9452.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240221001303.57384-5-mike.maslenkin@gmail.com>
[AMD Official Use Only - General]
Looks good, thank you!
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>; Chang, Abner
> <Abner.Chang@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>
> Subject: [PATCH 4/4] RedfishClientPkg: use Json value from a function
> argument
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> This patch replaces value Private->Json with Json used as second argument
> for RedfishIdentifyResource(). Currently Json argument is not used at all
> and the pattern for caller side is:
> Status = RedfishIdentifyResourceCommon (Private, Private->Json);
>
> So in scope of RedfishIdentifyResourceCommon Json actually is the same
> value as Private->Json. Let's make code a bit cleaner.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
> RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +-
> .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 2 +-
> .../ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c | 2
> +-
> .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 2
> +-
> RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> index 0ae841499692..f3f993c8782e 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon (
> EFI_STRING EndOfChar;
>
> REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;
>
>
>
> - Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
>
> + Supported = RedfishIdentifyResource (Private->Uri, Json);
>
> if (Supported) {
>
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
>
> if (EFI_ERROR (Status)) {
>
> diff --git
> a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.c
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.c
> index 0b9f2bf28434..f471c01c3790 100644
> ---
> a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.c
> +++
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.c
> @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon (
> {
>
> BOOLEAN Supported;
>
>
>
> - Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
>
> + Supported = RedfishIdentifyResource (Private->Uri, Json);
>
> if (Supported) {
>
> return EFI_SUCCESS;
>
> }
>
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.c
> index cee6c8bf9ba1..d69fc176ad94 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.c
> @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon (
> EFI_STRING EndOfChar;
>
> REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;
>
>
>
> - Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
>
> + Supported = RedfishIdentifyResource (Private->Uri, Json);
>
> if (Supported) {
>
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
>
> if (EFI_ERROR (Status)) {
>
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.c
> index a67ef3dac283..11bcb5f76cab 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.c
> @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon (
> EFI_STRING EndOfChar;
>
> REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;
>
>
>
> - Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
>
> + Supported = RedfishIdentifyResource (Private->Uri, Json);
>
> if (Supported) {
>
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
>
> if (EFI_ERROR (Status)) {
>
> diff --git
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.
> c
> index eb52c68c5dcb..00a69f748c3c 100644
> ---
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> +++
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.
> c
> @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon (
> EFI_STRING EndOfChar;
>
> REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;
>
>
>
> - Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
>
> + Supported = RedfishIdentifyResource (Private->Uri, Json);
>
> if (Supported) {
>
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
>
> if (EFI_ERROR (Status)) {
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115699): https://edk2.groups.io/g/devel/message/115699
Mute This Topic: https://groups.io/mt/104479574/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-21 2:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 0:12 [edk2-devel] [edk2-redfish-client][PATCH 0/4] RedfishClientPkg: fix memory leaks and refine code Mike Maslenkin
2024-02-21 0:13 ` [edk2-devel] [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Mike Maslenkin
2024-02-21 2:12 ` Chang, Abner via groups.io
2024-02-21 7:23 ` Nickle Wang via groups.io
2024-02-21 0:13 ` [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Mike Maslenkin
2024-02-21 2:34 ` Chang, Abner via groups.io
2024-02-21 19:46 ` Mike Maslenkin
2024-02-21 7:30 ` Nickle Wang via groups.io
2024-02-21 15:12 ` Chang, Abner via groups.io
2024-02-21 0:13 ` [edk2-devel] [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI Mike Maslenkin
2024-02-21 2:18 ` Chang, Abner via groups.io
2024-02-21 7:30 ` Nickle Wang via groups.io
2024-02-21 0:13 ` [edk2-devel] [PATCH 4/4] RedfishClientPkg: use Json value from a function argument Mike Maslenkin
2024-02-21 2:22 ` Chang, Abner via groups.io [this message]
2024-02-21 7:31 ` Nickle Wang via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LV8PR12MB9452FC5A737C296B145C5153EA572@LV8PR12MB9452.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox