From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2103978003C for ; Wed, 21 Feb 2024 02:22:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pHjbZFvc5BW49hwIPmT63u5cjmC92BJMGSN+N8ZhKBU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708482139; v=1; b=j5Y43IaX2/lXD/tPHNWmzFIlRyXPONsPcJ6+WqEik5Od9fAUy0jSTgdjpjAybKkbvSRoRev/ T3g6m2th4N/QeQKlBekXyLhnYkAgB1Vpa/paQF86s6565Oo8GgLWgQvveEYrV2KG38gAZYKQxAr dCxNvrWXWm8FzBo7w4j9Vccw= X-Received: by 127.0.0.2 with SMTP id mYhDYY7687511x0CGveZ4a49; Tue, 20 Feb 2024 18:22:19 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.87]) by mx.groups.io with SMTP id smtpd.web10.4352.1708482138747110011 for ; Tue, 20 Feb 2024 18:22:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oL1nc4zWRk4Sho+lmlnk+xhYxWMWxhaFQYssOC0EcY1ke246Y9Jd2rtu+9HQhvPj7OkbsfH8T2NB878aU1AoWLMOXXrYOnsUIceczq9DNzdp/j3RTfsEmqAyYiStJ9RR3uQBnL+j8+GfVQT6ntftpqP9uKLAm81V21evKU5z8bcLnJzToaaWPAs9aS+hpFnJs22A14CPSUWNqakPznIt1PO2CccpwTL6jyqn4axDuh7Ta3n+1HHFqkwERM2B2BVsCJ6EB+mRYa4GULptX8K1+U9OSdWh5xgTzSwMJTnnTBVa2sp73s/xS2aeLJE2Bt4tweoCqyHwml1v8EReSLOYDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=joP/pqasIhm6XE0/KugtCzQ9fJApaY21UrLwjOpNpbg=; b=EzPXyf5QiSaOqndQ0YwEYm2+YkqC2eE7GbjGyvw/G2+urCkpzVd1TR3fOGrK9l3DoknNFn83t6ugc23j8U9/tUJiBnQicw6Ic8+xtWXyI7AYrpAab6eDrMb4ZQIOLTGOe0UbwCcfi2IhoEO8q9UUU4jIPz9OWf8/RhOpZxKckBUaarA1+dAI4xupsFaVmdBxdpIazeltk0mUJZ7pGUkFP7FkKEG7kABtFoLnbNyL4SHKI993VtWdbelgYSU967QwXeI4gtbkc1Y9OJX7gQL8cgqHB88zEAUgUYj+kVgh4u1+GLvbeRmnGeKfXCVnYqxSlNChOhixEJA8FMa2Vd6cfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SA1PR12MB7343.namprd12.prod.outlook.com (2603:10b6:806:2b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.19; Wed, 21 Feb 2024 02:22:16 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1%4]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 02:22:16 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 4/4] RedfishClientPkg: use Json value from a function argument Thread-Topic: [PATCH 4/4] RedfishClientPkg: use Json value from a function argument Thread-Index: AQHaZFrDEbfrCNAsfkyc6Yyp2zKXGrEUEM9w Date: Wed, 21 Feb 2024 02:22:16 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-5-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-5-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f781f91e-11b2-4956-b55b-7e2463281503;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T02:22:04Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SA1PR12MB7343:EE_ x-ms-office365-filtering-correlation-id: 4668efdd-5bad-4654-98cd-08dc3283ec0f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mFsvi1QoIO6ommzkZ2PeX89jINJbxEKHDSMZxRkBGFw6NToVW89OfZSXkd5gI6xbAD8SN8trOCb/kR+A2NHMoR+6OLv42oyqfsnTFd8pglRZ221uGaGS7NYMMw0KCyVYu91MBICh0w5+CMJEG8+QXXT1s1f/S4NMWZ5HhLYMesTgikCqyGDROIwewRwNkms34gUE/n2znmpYqYTlKn8SvJ4iCqDn808HvkX5zoGyriDnWT5QbC6iOTKzjCgbgKVOxCrBnhrxL0JEicpDiNjqbYOazb7SEuG5nkmmzSh/UzE6F2OSbZ5WuCRuNSopQvSU5okmSxE69gPpmA8J3iuTR9n54DUJtuGrqzR5XHlxTrrmHHGq7Rbk2pIKTLnWXEEK/0VsvrYlqX2Hgvbx5v3CpgKtW08myLe0vQEmDNNclIf/mb6LmFBMGpiejDkuBI7Bs3UtpMRllKobUrWay5gm8iWjKKq3iSHhaBZkjQq0gN84hEXCXIGCMhA1WK0FAmu70cIAwqzntt0L7OlsJNTR9lz5PmFt3AJnluKKHAMubItLUrPBhNqKe0K/3QB9PAPZeSc9rsta5kk4OUIb44uN1FYehBv59/Tkfmb52H6oxdaKtcwW3i5iDXGN/jd6gx52 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j6LxNgctDd8AFBpWIkqJ330ghJI2EomXibOwEBiMBck8BkKROMwsLeG+N9US?= =?us-ascii?Q?JQgn3rQYRndvUXqGh+56MndqjNUn1Qsj6fG6JW9lKk6R8G5+M04azZ39/NgZ?= =?us-ascii?Q?slQwA0tl+I35RE7cWX9tBbIl2+KD8FYf+KXlnVGCBYVX81W2L019tO1DLe5B?= =?us-ascii?Q?Fu3joMCb+JsjFcG6PBQjrFBdeuoHqS7zlSgfIhVAuPSRpBxFwOoJTJeaDz4n?= =?us-ascii?Q?0dqsEbHKfSv4aCMhLBXQuzqovgwFcr2ITFZiSF6M0o0SqE6/+WEflpxaqATx?= =?us-ascii?Q?pE1KOarKGyBKb+pip9lEE/qunnzqRVds5JHom4GDMa5LQUhqsboJwqIIXWkQ?= =?us-ascii?Q?ekHYdKFWMZpSEQGYeqQp+HPWi309QyaxmgnX3GTvm+s2r2I5n8b+S2pKteKW?= =?us-ascii?Q?KofBpKeK+Dy3dm9jPs02+4HDivmcXGI2P43Y9RRMtsPndMhyi3PUJQAmtxSu?= =?us-ascii?Q?2M4k72Who7GOjBDl4WCFeb1w8LjviweASF4How7hDxX/y52d+tjz3BTn791N?= =?us-ascii?Q?kFtVonRlxtM/wfLQqm/BVoqoM5KgGlNSp7ef767KQYW7ccfcZisLC833J3R5?= =?us-ascii?Q?1HNQjoaRE/DmR6lkt59/tIJxzwJXmd7yzD6adSEeNR59IjziJO7IaiVFv/Db?= =?us-ascii?Q?1V9HjbFNKeLoCj/hlrHKpX+DjjMv8XE+ve+ky0BgmQ9/yRWSBmIjeUqxaD78?= =?us-ascii?Q?PVbaW/GgFzrfB04u901TqNqKDBOBXVj7l7TmqIf9Cfrl7IelcuLN1KkIGakL?= =?us-ascii?Q?+k40MclVcIAiw7OpaVnR0w4rysOOogJHGOV6xSew3uKMhTWh/vpaDZRpjNwM?= =?us-ascii?Q?7fG/noaRDge+hKpwMFkX44CocwRWBXeKOMuJfbiPyDzoFWI210+qwEzDci5h?= =?us-ascii?Q?kxxjHOgXu2v8sohGJpMNyDtSd2y5zVnSY93oOzRz8+tKs9Mqx6nINdl5iuPV?= =?us-ascii?Q?6YeBlchxXePKAHpouKw+B0WCHa5qUdOeb6XMWNPqB5mDrdQzDfsvezjNZJfu?= =?us-ascii?Q?DrdBngzfRgbWyx4ky9BFOS1r+0ZOYLQLOXnteSx2SQe8DjsxSYocom/6HGrw?= =?us-ascii?Q?vlR2dh0qmJtuP3upalzZmfY+6ICh+lsixO/D7S9ZeDAx/qtEyhX/+q4eobKa?= =?us-ascii?Q?iH5Tyq63X3KkBx18rr90/kPO7e4z/+K80Ne2KVAjookg/pKJbVXabfMfpBd1?= =?us-ascii?Q?tYDzAHSPLA0i65KMF/Z9jtGa0T0dvdoOZKL3NGde/SAZPZjDYBrTFpsV00VC?= =?us-ascii?Q?Om5/Sb2U/p4skqb/Jc+bvCdY8eub7SiCtAtg1+F5HEGhIDDB6HswhdDW6nHH?= =?us-ascii?Q?h3UNhdu0cbnBlUx46TO/btkgGzUb61VY/jikAy9IZ0O58N5RAj6dvytWxqyo?= =?us-ascii?Q?6eqKQ5x6VG9A0Rl3hG+d4z9OYbq1KwISRtKfYr/ANip4fLhhd0v+YH6YHV6W?= =?us-ascii?Q?k36rAm/bUqU5iKoo++qegq1DBVLuS4xsKY9NzxGcrN1leKgjX9ZwC3PsV0kA?= =?us-ascii?Q?qOq9rDUnYi+0QzSdxcdXy1viArVvBehHnfSwP+GpVX2LEBeNvS3j7UIr6C5g?= =?us-ascii?Q?S3K/STKLf+OK35apAe0vgyvGqsF+BpohoP0OC/LU?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4668efdd-5bad-4654-98cd-08dc3283ec0f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 02:22:16.1997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cTqqj5evCluLOZsTjJU860vFNgjfCvwd4WyCeQvcrQwqtU+RZuk/EzvAfu3gRHP3dncoIOsQgml5sqMbVsNwPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7343 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jmB1nIdeJ2HzseDyInsXXrXzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=j5Y43IaX; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Looks good, thank you! Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Chang, Abner > ; Nickle Wang ; Igor > Kulchytskyy > Subject: [PATCH 4/4] RedfishClientPkg: use Json value from a function > argument > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This patch replaces value Private->Json with Json used as second argument > for RedfishIdentifyResource(). Currently Json argument is not used at all > and the pattern for caller side is: > Status =3D RedfishIdentifyResourceCommon (Private, Private->Json); > > So in scope of RedfishIdentifyResourceCommon Json actually is the same > value as Private->Json. Let's make code a bit cleaner. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- > .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 2 +- > .../ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c | 2 > +- > .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 2 > +- > RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index 0ae841499692..f3f993c8782e 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > diff --git > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > index 0b9f2bf28434..f471c01c3790 100644 > --- > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > +++ > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom > mon.c > @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon ( > { > > BOOLEAN Supported; > > > > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > return EFI_SUCCESS; > > } > > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > index cee6c8bf9ba1..d69fc176ad94 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute > rSystemCommon.c > @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > index a67ef3dac283..11bcb5f76cab 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer > SystemCommon.c > @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > diff --git > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon. > c > index eb52c68c5dcb..00a69f748c3c 100644 > --- > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > +++ > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon. > c > @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; > > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > > > > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); > > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); > > if (Supported) { > > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > > if (EFI_ERROR (Status)) { > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115699): https://edk2.groups.io/g/devel/message/115699 Mute This Topic: https://groups.io/mt/104479574/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-