From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: [PATCH] SecurityPkg/Tcg/Tcg2Config: Fix REVERSE_INULL Coverity issue
To: devel@edk2.groups.io
From: "Ranbir Singh" <Ranbir.Singh3@Dell.com>
X-Originating-Location: Bengaluru, Karnataka, IN (122.172.85.38)
X-Originating-Platform: Windows Chrome 108
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Wed, 04 Jan 2023 02:50:11 -0800
Message-ID: <MI95.1672829411506179868.2gWP@groups.io>
Content-Type: multipart/alternative; boundary="0h9tUeihhw572Cz0XfsO"

--0h9tUeihhw572Cz0XfsO
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

The function Tcg2ConfigDriverEntryPoint at the point of creating a
private data structure makes a call to AllocateCopyPool and stores
the return value in PrivateData. Thereafter it does a check

ASSERT (PrivateData !=3D NULL);

but this is applicable only in DEBUG mode. In Release mode, the code
continues further and will dereference "PrivateData" which will lead
to CRASH if PrivateData is NULL.

Hence, for safety add PrivateData NULL pointer check and return from
there saying EFI_OUT_OF_RESOURCES when PrivateData is NULL.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4229
Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com>
---
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityPkg/Tc=
g/Tcg2Config/Tcg2ConfigDriver.c
index edf5f0fc77..f023b3ccb8 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
@@ -283,6 +283,10 @@ Tcg2ConfigDriverEntryPoint (
//
PrivateData =3D AllocateCopyPool (sizeof (TCG2_CONFIG_PRIVATE_DATA), &mTcg2=
ConfigPrivateDateTemplate);
ASSERT (PrivateData !=3D NULL);
+=C2=A0 if (PrivateData =3D=3D NULL) {
+=C2=A0 =C2=A0 return EFI_OUT_OF_RESOURCES;
+=C2=A0 }
+
mTcg2ConfigPrivateDate =3D PrivateData;
//
// Install private GUID.
--
2.36.1.windows.1

--0h9tUeihhw572Cz0XfsO
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<div>The function Tcg2ConfigDriverEntryPoint at the point of creating a</di=
v>
<div>private data structure makes a call to AllocateCopyPool and stores</di=
v>
<div>the return value in PrivateData. Thereafter it does a check</div>
<div>&nbsp;</div>
<div>&nbsp; &nbsp; ASSERT (PrivateData !=3D NULL);</div>
<div>&nbsp;</div>
<div>but this is applicable only in DEBUG mode. In Release mode, the code</=
div>
<div>continues further and will dereference "PrivateData" which will lead</=
div>
<div>to CRASH if PrivateData is NULL.</div>
<div>&nbsp;</div>
<div>Hence, for safety add PrivateData NULL pointer check and return from</=
div>
<div>there saying EFI_OUT_OF_RESOURCES when PrivateData is NULL.</div>
<div>&nbsp;</div>
<div>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4229</div>
<div>Signed-off-by: Ranbir Singh &lt;Ranbir.Singh3@Dell.com&gt;</div>
<div>---</div>
<div>&nbsp;SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 4 ++++</div>
<div>&nbsp;1 file changed, 4 insertions(+)</div>
<div>&nbsp;</div>
<div>diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityP=
kg/Tcg/Tcg2Config/Tcg2ConfigDriver.c</div>
<div>index edf5f0fc77..f023b3ccb8 100644</div>
<div>--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c</div>
<div>+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c</div>
<div>@@ -283,6 +283,10 @@ Tcg2ConfigDriverEntryPoint (</div>
<div>&nbsp; &nbsp;//</div>
<div>&nbsp; &nbsp;PrivateData =3D AllocateCopyPool (sizeof (TCG2_CONFIG_PRI=
VATE_DATA), &amp;mTcg2ConfigPrivateDateTemplate);</div>
<div>&nbsp; &nbsp;ASSERT (PrivateData !=3D NULL);</div>
<div>+&nbsp; if (PrivateData =3D=3D NULL) {</div>
<div>+&nbsp; &nbsp; return EFI_OUT_OF_RESOURCES;</div>
<div>+&nbsp; }</div>
<div>+</div>
<div>&nbsp; &nbsp;mTcg2ConfigPrivateDate =3D PrivateData;</div>
<div>&nbsp; &nbsp;//</div>
<div>&nbsp; &nbsp;// Install private GUID.</div>
<div>--</div>
<div>2.36.1.windows.1</div>

--0h9tUeihhw572Cz0XfsO--