From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id EF113AC0548 for ; Fri, 12 Apr 2024 01:53:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=I3xpC2LIzdOcy0eqSO9tuYPH7Et7Tzxmz6ieRJpXiL8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1712886810; v=1; b=3K2g8Mp0/Noyjxi2MxAZAw4Pc7j7jqwufS0R0dwkTu4ML45VEXO5IyX2cMcoeOtgNTGX9KTk uLmGU5E1gMtKtlbb7Dh4UqzjFF5eWhmjl1Zacd6Z896n10YAwE8NI8/I5MXD01FHLEsCVDdGP+p UYElpJTNBiaotLrp03qEupzWKAWeh8jUbqgh27quOJ7dnqsa/ZMZPpWuDXR8BsOBEEHa/8fbjVf BE3CWvBEUvoziMAc81vL5sORToT2/LLQw+5Ng0RGIk35gRlF0s3Ku6c5bOqyq0c9tUVNOw6Okgh I4UCizSyOKJRE/aHn7aSqKm0My/qSFVpONyMOuNYZAooQ== X-Received: by 127.0.0.2 with SMTP id SJZ1YY7687511xky6brmir74; Thu, 11 Apr 2024 18:53:30 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mx.groups.io with SMTP id smtpd.web10.37315.1712886809613689373 for ; Thu, 11 Apr 2024 18:53:29 -0700 X-CSE-ConnectionGUID: tApMqJtZQKem61kWsBkEFg== X-CSE-MsgGUID: jjxNYUcpTCmOLF9Cxch0GA== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8505955" X-IronPort-AV: E=Sophos;i="6.07,194,1708416000"; d="scan'208,217";a="8505955" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 18:53:29 -0700 X-CSE-ConnectionGUID: uZJM7N2FTLGussVNn2impw== X-CSE-MsgGUID: UqAkhle6RrSuwGGy79bHiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,194,1708416000"; d="scan'208,217";a="25873642" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Apr 2024 18:53:30 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Apr 2024 18:53:28 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 11 Apr 2024 18:53:28 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Apr 2024 18:53:28 -0700 X-Received: from MN0PR11MB6034.namprd11.prod.outlook.com (2603:10b6:208:375::17) by SJ2PR11MB8449.namprd11.prod.outlook.com (2603:10b6:a03:56f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.27; Fri, 12 Apr 2024 01:53:26 +0000 X-Received: from MN0PR11MB6034.namprd11.prod.outlook.com ([fe80::f91f:3355:add2:3216]) by MN0PR11MB6034.namprd11.prod.outlook.com ([fe80::f91f:3355:add2:3216%3]) with mapi id 15.20.7452.019; Fri, 12 Apr 2024 01:53:26 +0000 From: "Xianglei Cai" To: "Lewandowski, Krzysztof" , "devel@edk2.groups.io" , "Ni, Ray" , Liming Gao CC: "Huang, Jenny" , "Shih, More" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error Thread-Topic: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error Thread-Index: AQHadDwIf2tyGjoQhEqIk0Rxr/uogbFjRF+AgADLSbA= Date: Fri, 12 Apr 2024 01:53:26 +0000 Message-ID: References: <2ef49d5cd3593dc573f3fac9db533b4a93ef04b5.1710220024.git.xianglei.cai@intel.com> In-Reply-To: Accept-Language: en-US X-Mentions: ray.ni@intel.com,gaoliming@byosoft.com.cn X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6034:EE_|SJ2PR11MB8449:EE_ x-ms-office365-filtering-correlation-id: 23403ef2-0785-47f3-a660-08dc5a9357e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1wI9pL7GNbBkL2/l8BBHeT8gDnnEGne0XX5UGby6kJXUJU5x3EZfpJYGX/qEUf2YadY8X5Bp5FgmJTx+sPH4RjUliL3zeh18Nz76Of/KY3wRfvWF7zqgDB42VCViE3GTmItKg63Xib3KTDdaX9tRvSU/rOC1pbdpbKBcyII6CrauVzLEju9tjOU8uQeGqoAYsuJnjyThSaGe5jY7rAcXuJfbUree8ITF3ws+LPV0tkh6iNbCzmj6tG2gza9Jrc4NO6GJ/Z/3nYZd5oP+oYg9DjGYKLnDiqhuAVArJz8VDFiELG6wAeWNIww8NSaP2KVS1W6mzVRdvTLmqpThTyFyN3AL7dZHCqXGvKSRDOlMk7M+ikNLvtivVk+Ys+l8Xv0EzBNZItdrQCd158eF+F3w7zqR9QudlEiRTekrE0M0/vcW4P9Tv4dB3tDViOJGfMlBP46CHsQu7OZm6HuiOH/PSkCY4s2SFrD1FPXVTyukaz/PBnCfAtkBxxHRfVdjKNp/2NdufP68QpxFp5hP9xDADOHK/Ruk2h+g2WK09nQor39D6SvqnLgvVhK+pOQ4OBiu0NEHMcUSUHSaz/gWsxl4a1pw/lUkYSodZb1nyHlsSeinGyb7XTf/msz/KaTgqEO6Cxi1Q8H7OYAWxMLZk/VbYi+xjQxjcGmLUMMHyMEIBYo= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CeKIuue2Bd3hb+w8bnRXO4BF9s6kytcQJxsMJExuKccfenLFV8ErTwogl/m1?= =?us-ascii?Q?OwjxCt7g4syUWCB/yCSliXaN2URlb2BZXq2nJXsPGTtu1rAeQ86HDbpEzM/C?= =?us-ascii?Q?ldIxW8XWTgQhNidL+NIjprR0n1jxqXjx9FB/nREGmp4CoiSisrTHzndjc7n5?= =?us-ascii?Q?OY0cXWsgIov40p+eNTKYRpLeakcl1+C5G74dp0K9bAupbLrhA0qAFbodh3n6?= =?us-ascii?Q?6Q9QNFqlpfeyqDIZZioVFOS2pHRb223du1MHZoTmyQizT8BjFFTEPEzbWPQe?= =?us-ascii?Q?fwvxUB3mo/C3UO7C/V36gz3UmvJ7u6uCVcxhBvBUThZR3jjsKZ/Azi+kCeSl?= =?us-ascii?Q?7k/j6KKEAacEC0Nece01Z89scGTQLDLLt+ldnRGFQ01hpcioTrgeKvKft9Ct?= =?us-ascii?Q?N/Azpp08N4wJdYnSpfBVTBDB0IPQBKcmIpzj6ndOuC27aDiYnQO3rI0+J1ZY?= =?us-ascii?Q?y9+Lh6eQnyVBScUeLPmYCZhtn/grqYdwA07XDjWm/wmiiymuGo7BoRXLbCZp?= =?us-ascii?Q?5lyd0U6SpdLQuSPgTOpaZFu+N526UizNQJ1J3W2ppriL5B9l9XVTRQhGX2vc?= =?us-ascii?Q?xnxW6UU4HFD5goNZdy7gS2+ZhuEYoDwVvv73Q+URrUe3EYJRdGFU3peOXJgK?= =?us-ascii?Q?6Gw1L1px4oVPjP0lCfKcAUkSAK3XXMQHd6nPIZ4TlfZJXytKfViAqBNaeT+r?= =?us-ascii?Q?EgeTi01BZslu9JZ7ZQQtkxRMVRA6uidEYauo0CZZvKHlQHySwKKJm5bnNjjs?= =?us-ascii?Q?qLbyOpb8iz2DzspwY7aeHDseHME4Q2yhENf4ePbdprvNdj/x+WBKcp6Yurn9?= =?us-ascii?Q?2C1xcX/fmE4xp5TikPX/Iac8PCh0y7XEZfVv4AuIv0hb+wR7cddFJJrK1jKZ?= =?us-ascii?Q?Ef+5MsCNhQHsrgXN5eLt1lGz4gqexsOwMPLQoCsW3ktzPhAm+ZsCv1Co67Ze?= =?us-ascii?Q?/nDPAS8Sud8VATaJ1LO2SSzcXYKmO6h8ta0X2nNofxstYePM0FxJ0IxtYevc?= =?us-ascii?Q?U4VIqFoLYcDuf8ojAt8rYfFiYIwb90DI0tayD2dvU+DoFM1Sisub5efwavOJ?= =?us-ascii?Q?bUX4kqtCkHeg8jAMw12G1rHD+V2Aa6m0rkvlQfSTD1FKp8Lih2Chxo2bYmJH?= =?us-ascii?Q?Cc66qYzS9/SXMLnIkcDEtz+VWsWmmGLaqjIHA6tXjrNLP20rvmuZV48HRLKN?= =?us-ascii?Q?1o7ZhWVtzy3ruU07u4AcNgH5YqjEaF/aP3sO8ZKTj0eq6tWmdMzgsESBmPA9?= =?us-ascii?Q?rS7gQ+8mEyxLK/d2lD/rbcVULzqIMCUWWMB1P+nwz/WKmEL4z8ZT23hlqy5s?= =?us-ascii?Q?Rr/hKtdHt8b+66TPlwrZP3GDZHGhCZUxQM5e5RjZgbMRNIl5gtkuzy71qjqD?= =?us-ascii?Q?3I0VpS4WXU0giISul2qGpPd/+Fb6+qG38WNqcvMwBLbRXO1DXc81YP+JSO5+?= =?us-ascii?Q?Q9O1022PPrM0FnUqqnfYvvK+leH5LxLDm078GWxCtJJNWh3Iiza/Y8niXvYX?= =?us-ascii?Q?GCzXptq9I4RhhZ9TduMvxAKdBjB50Eg8/hWNrSLxF61d8iKmZhCaSD0AXKoo?= =?us-ascii?Q?9H9pdE0MlDiRdZV3BiH8iRV2D1dGwnuAlh0lp1Ea?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6034.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23403ef2-0785-47f3-a660-08dc5a9357e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2024 01:53:26.0644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XGMmK/t4O2Bm4MfocTetwWGbJCuUx3qQupPK2C5tuO5X++kFzWX6TsZmiJSB6oMoFOU/+MOuxsYWL9lNuiSnVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8449 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 11 Apr 2024 18:53:29 -0700 Resent-From: xianglei.cai@intel.com Reply-To: devel@edk2.groups.io,xianglei.cai@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: a3xLwAT61B3AdMthtiHnR6SGx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN0PR11MB603459B375E1B564AB11D43593042MN0PR11MB6034namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=3K2g8Mp0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN0PR11MB603459B375E1B564AB11D43593042MN0PR11MB6034namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable @Ni, Ray @Liming GaoWould you like to merge the patch to upstream? Thanks, Xianglei From: Lewandowski, Krzysztof Sent: Thursday, April 11, 2024 9:45 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Liming Gao ; Huan= g, Jenny ; Shih, More ; Cai, Xi= anglei Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Tra= nsaction error Looks good to me. Reviewed-by: Krzysztof Lewandowski > ________________________________ From: Cai, Xianglei > Sent: Wednesday, April 10, 2024 09:02 To: devel@edk2.groups.io > Cc: Cai, Xianglei >; = Ni, Ray >; Liming Gao >; Lewandowski, Krzysztof >; Hu= ang, Jenny >; Shih, Mor= e > Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transac= tion error https://bugzilla.tianocore.org/show_bug.cgi?id=3D4556 Based on XHCI spec 4.8.3, software should do the reset endpoint while USB Transaction occur. Also add the error code for USB Transaction error since UEFI spec don't have the related definition. Cc: Ray Ni > Cc: Liming Gao > Cc: Krzysztof Lewandowski > Cc: Jenny Huang > Cc: More Shih > Signed-off-by: Xianglei Cai > --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 2 +- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 2 +- MdePkg/Include/Protocol/UsbIo.h | 21 +++++++++++---------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c b/MdeModulePkg/Bus/Pci/Xhc= iDxe/Xhci.c index f4e61d223c1b..63cc29b26536 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c @@ -825,7 +825,7 @@ XhcTransfer ( *TransferResult =3D Urb->Result; *DataLength =3D Urb->Completed; - if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D= =3D EFI_USB_ERR_BABBLE)) { + if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D= =3D EFI_USB_ERR_BABBLE) || (*TransferResult =3D=3D EFI_USB_ERR_TRANSACTION)= ) { ASSERT (Status =3D=3D EFI_DEVICE_ERROR); RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, Urb); if (EFI_ERROR (RecoveryStatus)) { diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c index 05528a478baf..e77852f62f10 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c @@ -1193,7 +1193,7 @@ XhcCheckUrbResult ( goto EXIT; case TRB_COMPLETION_USB_TRANSACTION_ERROR: - CheckedUrb->Result |=3D EFI_USB_ERR_TIMEOUT; + CheckedUrb->Result |=3D EFI_USB_ERR_TRANSACTION; CheckedUrb->Finished =3D TRUE; DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: TRANSACTION_ERROR! Comple= tecode =3D %x\n", EvtTrb->Completecode)); goto EXIT; diff --git a/MdePkg/Include/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbI= o.h index a780b4e07b44..211ef0c94156 100644 --- a/MdePkg/Include/Protocol/UsbIo.h +++ b/MdePkg/Include/Protocol/UsbIo.h @@ -50,16 +50,17 @@ typedef enum { // // USB Transfer Results // -#define EFI_USB_NOERROR 0x00 -#define EFI_USB_ERR_NOTEXECUTE 0x01 -#define EFI_USB_ERR_STALL 0x02 -#define EFI_USB_ERR_BUFFER 0x04 -#define EFI_USB_ERR_BABBLE 0x08 -#define EFI_USB_ERR_NAK 0x10 -#define EFI_USB_ERR_CRC 0x20 -#define EFI_USB_ERR_TIMEOUT 0x40 -#define EFI_USB_ERR_BITSTUFF 0x80 -#define EFI_USB_ERR_SYSTEM 0x100 +#define EFI_USB_NOERROR 0x00 +#define EFI_USB_ERR_NOTEXECUTE 0x01 +#define EFI_USB_ERR_STALL 0x02 +#define EFI_USB_ERR_BUFFER 0x04 +#define EFI_USB_ERR_BABBLE 0x08 +#define EFI_USB_ERR_NAK 0x10 +#define EFI_USB_ERR_CRC 0x20 +#define EFI_USB_ERR_TIMEOUT 0x40 +#define EFI_USB_ERR_BITSTUFF 0x80 +#define EFI_USB_ERR_SYSTEM 0x100 +#define EFI_USB_ERR_TRANSACTION 0x200 /** Async USB transfer callback routine. -- 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117637): https://edk2.groups.io/g/devel/message/117637 Mute This Topic: https://groups.io/mt/104879589/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN0PR11MB603459B375E1B564AB11D43593042MN0PR11MB6034namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

@Ni, Ray @Liming GaoWould you like to merge the patch to upstream?

 

Thanks,

Xianglei

 

From: Lewandowski, Krzysztof <krzysztof.le= wandowski@intel.com>
Sent: Thursday, April 11, 2024 9:45 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Liming Gao <gaoliming@byoso= ft.com.cn>; Huang, Jenny <jenny.huang@intel.com>; Shih, More <m= ore.shih@intel.com>; Cai, Xianglei <xianglei.cai@intel.com>
Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while = USB Transaction error

 

Looks good to me.

Reviewed-by: Krzysztof Lewandowski <krzysztof.lewandowski@intel.com>

From: Cai, Xianglei <xianglei.cai@intel.com>
Sent: Wednesday, April 10, 2024 09:02
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: Cai, Xianglei <xian= glei.cai@intel.com>; Ni, Ray <ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Lewandowski, Krzysztof <krzysztof= .lewandowski@intel.com>; Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>
Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB = Transaction error

 

https://bugzilla.tianocore.org= /show_bug.cgi?id=3D4556

Based on XHCI spec 4.8.3, software should do the
reset endpoint while USB Transaction occur.
Also add the error code for USB Transaction error
since UEFI spec don't have the related definition.

Cc: Ray Ni           = ;            &n= bsp;        <ray.ni@intel.com>
Cc: Liming Gao          &= nbsp;           &nbs= p;     <= gaoliming@byosoft.com.cn>
Cc: Krzysztof Lewandowski    <krzysztof.lewandowski@intel.com>
Cc: Jenny Huang          =             &nb= sp;    <jenny.hu= ang@intel.com>
Cc: More Shih          &n= bsp;            = ;      <= more.shih@intel.com>

Signed-off-by: Xianglei Cai <x= ianglei.cai@intel.com>
---
 MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c      |&n= bsp; 2 +-
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c |  2 +-
 MdePkg/Include/Protocol/UsbIo.h      &n= bsp;   | 21 +++++++++++----------
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c b/MdeModulePkg/Bus/Pci/Xhc= iDxe/Xhci.c
index f4e61d223c1b..63cc29b26536 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
@@ -825,7 +825,7 @@ XhcTransfer (
   *TransferResult =3D Urb->Result;
   *DataLength     =3D Urb->Completed;
 
-  if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult = =3D=3D EFI_USB_ERR_BABBLE)) {
+  if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult = =3D=3D EFI_USB_ERR_BABBLE) || (*TransferResult =3D=3D EFI_USB_ERR_TRANSACTI= ON)) {
     ASSERT (Status =3D=3D EFI_DEVICE_ERROR);
     RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, = Urb);
     if (EFI_ERROR (RecoveryStatus)) {
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c
index 05528a478baf..e77852f62f10 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -1193,7 +1193,7 @@ XhcCheckUrbResult (
         goto EXIT;
 
       case TRB_COMPLETION_USB_TRANSACTION_ER= ROR:
-        CheckedUrb->Result  |= =3D EFI_USB_ERR_TIMEOUT;
+        CheckedUrb->Result  |= =3D EFI_USB_ERR_TRANSACTION;
         CheckedUrb->Finished = =3D TRUE;
         DEBUG ((DEBUG_ERROR, "= ;XhcCheckUrbResult: TRANSACTION_ERROR! Completecode =3D %x\n", EvtTrb-= >Completecode));
         goto EXIT;
diff --git a/MdePkg/Include/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbI= o.h
index a780b4e07b44..211ef0c94156 100644
--- a/MdePkg/Include/Protocol/UsbIo.h
+++ b/MdePkg/Include/Protocol/UsbIo.h
@@ -50,16 +50,17 @@ typedef enum {
 //
 // USB Transfer Results
 //
-#define EFI_USB_NOERROR         0x= 00
-#define EFI_USB_ERR_NOTEXECUTE  0x01
-#define EFI_USB_ERR_STALL       0x02
-#define EFI_USB_ERR_BUFFER      0x04
-#define EFI_USB_ERR_BABBLE      0x08
-#define EFI_USB_ERR_NAK         0x= 10
-#define EFI_USB_ERR_CRC         0x= 20
-#define EFI_USB_ERR_TIMEOUT     0x40
-#define EFI_USB_ERR_BITSTUFF    0x80
-#define EFI_USB_ERR_SYSTEM      0x100
+#define EFI_USB_NOERROR        &nb= sp; 0x00
+#define EFI_USB_ERR_NOTEXECUTE   0x01
+#define EFI_USB_ERR_STALL        0x02 +#define EFI_USB_ERR_BUFFER       0x04
+#define EFI_USB_ERR_BABBLE       0x08
+#define EFI_USB_ERR_NAK        &nb= sp; 0x10
+#define EFI_USB_ERR_CRC        &nb= sp; 0x20
+#define EFI_USB_ERR_TIMEOUT      0x40
+#define EFI_USB_ERR_BITSTUFF     0x80
+#define EFI_USB_ERR_SYSTEM       0x100
+#define EFI_USB_ERR_TRANSACTION  0x200
 
 /**
   Async USB transfer callback routine.
--
2.42.0.windows.2

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117637) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN0PR11MB603459B375E1B564AB11D43593042MN0PR11MB6034namp_--