From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B7B96740035 for ; Fri, 24 May 2024 03:08:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZVsqapS7rNSad6ubRCNNLIl+FvTGAhmfK9561EDM7ig=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716520080; v=1; b=2AW34/40dj5JxbHgXCI+LHrtMHCib2CeYvGrxt8SC3csO9pZrmjJLDMcbA+SxxVu4Ut7ufAq dvhXuOHDQ+oP01r5zI0cE9bhsfuYsfno/qhSvVZOxoyZf+faAHJXvM9WeyOysiTei6r6OO0Nr0G ULkSb7k+4f9q1kLZC/QbaDfIcaKONXUr5QG6/fqCqQpcO2dnkjTKLrzPYhpz9M525URINya9a8H 9CLK+3BGMKu2U8l6djnb/PeJJaeH7WpUEloNViJUtx+BOoAwCM+aUNnkykRj8fBVursd39MdN7n Icx8p2T7OHSPG4Z9Z6RztPRk7hgSChbD0I1B4tgw6Q+gg== X-Received: by 127.0.0.2 with SMTP id nQeUYY7687511xaFnYQcS6Vq; Thu, 23 May 2024 20:08:00 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web10.7624.1716520078967682781 for ; Thu, 23 May 2024 20:07:59 -0700 X-CSE-ConnectionGUID: 9wKoE+pQTH6flsbZ5C/lAA== X-CSE-MsgGUID: qhAAu27sQ9Ogs0ErMqx43w== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="30412310" X-IronPort-AV: E=Sophos;i="6.08,184,1712646000"; d="scan'208";a="30412310" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 20:07:59 -0700 X-CSE-ConnectionGUID: PNfFVLEDSH+0OEhSTjNePA== X-CSE-MsgGUID: jAeSPpNIRzSv9RzHatEm1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,184,1712646000"; d="scan'208";a="33895877" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 May 2024 20:07:58 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 May 2024 20:07:58 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 23 May 2024 20:07:58 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 23 May 2024 20:07:57 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by BL3PR11MB6386.namprd11.prod.outlook.com (2603:10b6:208:3b6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 03:07:56 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::13cf:47a8:4737:84e9]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::13cf:47a8:4737:84e9%3]) with mapi id 15.20.7611.016; Fri, 24 May 2024 03:07:56 +0000 From: "Wu, Jiaxin" To: "Tan, Dun" , "devel@edk2.groups.io" CC: Liming Gao , "Ni, Ray" , "Ard Biesheuvel" , "Yao, Jiewen" , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Thread-Topic: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Thread-Index: AQHaqD8luLpaai+EaU2831OAZfX/grGlvkjw Date: Fri, 24 May 2024 03:07:56 +0000 Message-ID: References: <20240517094610.533-1-dun.tan@intel.com> In-Reply-To: <20240517094610.533-1-dun.tan@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|BL3PR11MB6386:EE_ x-ms-office365-filtering-correlation-id: 29773332-7257-499d-249c-08dc7b9eb5a3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?hpZ+I0bnRsyoSe9u7BPrQzf3Zcdk5OqbOEi6xtLrjGRq1jjd4/9tYBHRHGpT?= =?us-ascii?Q?fGfnFlEEM8/HpnkrkLC7m5JG4AH0SYZCu+Ca4h8mhFnEoQtZADu4KjvRotIS?= =?us-ascii?Q?VZBC3sFiwJYylrlUIcsLwpkLviSbQQeDsEdKArZfs2iDRVUwdnjjkXhndqNb?= =?us-ascii?Q?iV3e6E2EbEsPl3wse2rnj68iGC8W+x/BnPxHmrrB0LPvZn7zxAnJ5xWHvMou?= =?us-ascii?Q?mzh8Z+BQlJmcefaRilUP7tuNt9GvqdtNJsYs3yZKJFIE+PjiMqERIjKeXq89?= =?us-ascii?Q?YO5ZuY2aiNUbthiFjXLuOZyM8Bp/dU4QcCq6wRUZCwVtIeLeY18UqwIYhgXz?= =?us-ascii?Q?rUcPOGkgEAnbD+GtX7NoVD/Um+kaILVmoehHETknRwIV9Z4rMkUxnQxvq9Y/?= =?us-ascii?Q?bGow+Qookm+yTemiCD1YvLdqmKyRut+MIVqxuj9/QoBR5xZeYj4+G2aZnar1?= =?us-ascii?Q?flRaWej+Yp0kYTUQq/SYWkowBr1IxB9El7mSw9Ho2iR2pZ9abb0nPzTIdgmp?= =?us-ascii?Q?d+sgVNzvSHI/tvq/R47rJxA9wjt76TFwkkVjDFfFXrjE1nRl/fvMaidGoqzp?= =?us-ascii?Q?mMLnBrXuDm7xLOm1Vmprdku/bXSMYu2zpHolTqD6Oj1CImm3Id32gYkbyad4?= =?us-ascii?Q?398FX0Siuxph889l0bYi5Kdd2/m0RGQKKTYSxcQp3NgjvpiaOpsb740BKRBl?= =?us-ascii?Q?g1GiflPv7BteRJ3N0P2nWz9UzFa2ShKeE4qAZe+c4nwusEa8Fed5e4T8271w?= =?us-ascii?Q?2dvn5hHE9MeXri9wsT3FCC6vFGqEOf5KX5pjR3c7kMv0Pvfg9Ef+pxSfihaz?= =?us-ascii?Q?zmUAf6TZjlUdYnSfHXq+ag4r7ohj4r9GZEB5hTLEApyZ24Andvw0CtFRlttK?= =?us-ascii?Q?jn9uowsxOyvuJEPA6m/Mqf6Ta7sJc5r9jCME1Nj9qvGP5DiwIK492c+Kye48?= =?us-ascii?Q?FfJrNXZycgk1nxF60gUg+zzORMf4YMYQ4tmxUmB70/zGyh+pAFs9B3FuP9cO?= =?us-ascii?Q?jCEJRDflQkmHNVBK2nvJMZcMsGcyc+dOZ5qoWI7zSYWJS+/0NjtB4pql2KCk?= =?us-ascii?Q?J7E1gv7LkYWz937Uzv4ERpwy7n+nnh2UWSixpIGfw3vcNlYgV7EdPaXXxRyS?= =?us-ascii?Q?7JHSc7bmWlxvffucw/6XVuaV/Te8iHOU1nMnI21mzQhsq62KNGr/2+8upxNo?= =?us-ascii?Q?fHCfm98UWFQt02qU7hQB5AivNBC2w6R5Cmuaq8IDcxxJs5hatDatkydyh/Jt?= =?us-ascii?Q?N91F7zQJ5BY2DKdlVz5VS2ihpebnGK1S3xwri+rwsQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AeXgo47opoXpwsZjR2zkQGkmA7JfUbuZZ7wwv6VDfVQArgPIxmBamWw4y7rA?= =?us-ascii?Q?hM/XZflDxqwUZ0MfHXb2V7RAsTzjrB2BsH++pfSa1nznFxm2X7IQuAjQ8zpm?= =?us-ascii?Q?ieElFlhK6dV81xOEFc1c7TDfn0t1Wv1nfuXIHjVAGB4A+B0tr817IkbZYBgC?= =?us-ascii?Q?Z0pdihRV2x3/U7K8V4IE7Jc5DcKKwaQddOz2QWi2PG8xA6XDofqTFVKgngsD?= =?us-ascii?Q?ZpkIbW0JiL59rcDSeLEYNMyBxjfPBJmHW12912OEDYM+2Whr5/6wrxu9BPEw?= =?us-ascii?Q?SrL3HN9haxOk1GkJvPPOq6BYhzsPiI59CKs7XgCHeE1TaDERJtUojlYs7M5d?= =?us-ascii?Q?W8F/M5OExt6TJXs60lcDXgmPNO73CcmsD7SbDt543v1tTqCmZUn8zW4euYYO?= =?us-ascii?Q?Nk1cmOy/UGlO5jTVX6jiQVfC1+Hw40dFLgEIgmp7Wok6cgXV+foVOofuGGZ6?= =?us-ascii?Q?Az+B3mo4LPlqc9kxm2nfJYbeFo7HRQWfcgSvuCLNFK9mX9xDQFC/wFratTGu?= =?us-ascii?Q?p4Y5omXPz0i3Sv42A8fzItgG6l3hWjQn6VbcsVl5+Yy4Br9tSE57fXoKH6Yv?= =?us-ascii?Q?Nu8Pnliu0oJg+ZY4BZQq6zieg4UhwU+Ie2EDKJzMj9QwehiUsKUrp1epbIoC?= =?us-ascii?Q?hgnNrHfxfqLC5nj/UkfX/NziC8r8cqYlb/C6IRR+d8pBSaxl1HDPxjgeAhrG?= =?us-ascii?Q?CxLfCn5YSUvhix62poiAYEi7z322dfgvCT/38dK4hZ+D+cjjUAcWms5X87vm?= =?us-ascii?Q?tDP9zh04op1XryJ2/1jDR4ey0c2zN3KlcYi3M8/kPj2pzERfGlyJZUrzYg7R?= =?us-ascii?Q?TD5k9nu9xBpgUWZDJ1dNa4pQvQOwWmaxHIBzjTPs1S2MhCtAxMrdTFDxLcQa?= =?us-ascii?Q?xQLWG81IexX3CQ2WLg6b3cJV+ezHVOrkb4HxnGK33UMim579BGgb7cbrFtH4?= =?us-ascii?Q?B5Oz837NljvH2MHxp4UntRDQC0etPu6FTRmsWIBtL4/oHD/pdvqVEltHhEO0?= =?us-ascii?Q?KebmMqO/hqHXdvrF12hF3eN0kpdVObp9MqYAUfDjSSGAsb7p4cn1t4E/q0ij?= =?us-ascii?Q?iSrbV9zgoRjrWEwlSD8I0utakQb0meUw9UyW0yyLFqDM8ul/aYb6IHFPp9t0?= =?us-ascii?Q?4z125GCvG69n1yJQfpSANaasn+9ezA6N//EE/fPe/NX6oo943/GecnQU5n7A?= =?us-ascii?Q?4hS0OajHYZdUqUTB4weCREZ+pqh6nNbMAfPQwb8owQc2Pi9QNMR1nqvKf5Tc?= =?us-ascii?Q?w9AJ+YwACXbVR9H81/5DJULDQScpVub66QwQYa8hRDSrNl2xygtEJWiEiIWT?= =?us-ascii?Q?nsOM2TZcqIlNThRnb+KR1zitcfl9Uw7c7JXvhi6U8ozv1nd1z7h52i/xnvwo?= =?us-ascii?Q?9IT4TdLXcBfcaxDbakhpr5oMhtiNB2s3bv/fDRQdi+ekyiOhf8tTCnfZqTkt?= =?us-ascii?Q?3ns27ZG8ngi1Y4/DMvl5XCdndE1yO6/53arFtpwu8dHkA/awqwytqJBubFJS?= =?us-ascii?Q?4jEixN/rSggWRYShExfuT6o9YiU6UrP3mjvxChkdOTKhSvUUuqswjP1hZWxe?= =?us-ascii?Q?ytLQ/hHrG6O+5v1ht1EbsAPb9so09A9/ZKnRuQ/P?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29773332-7257-499d-249c-08dc7b9eb5a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 03:07:56.1738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zlVquORy25JSpyCxyHe9erXmRFIL0Mga4WjICibfAfKd5RXUrBBVcjbK0XNoKAISxqfIFD4SSF007eCzf1umqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6386 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 23 May 2024 20:07:59 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4ucMv6FC7QWeLRh5jd4YppAWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="2AW34/40"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Series Reviewed-by: Jiaxin Wu The series patches are good to me now. Thanks Dun. Thanks, Jiaxin > -----Original Message----- > From: Tan, Dun > Sent: Friday, May 17, 2024 5:46 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Wu, Jiaxin > ; Ni, Ray ; Ard Biesheuvel > ; Yao, Jiewen ; Gerd > Hoffmann ; Kumar, Rahul R > Subject: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm > cpu driver >=20 > Comparing to V1 patchs set, the V2 patch set only adjusts the commits > ordering and modifies copy right year in some files. > This patch set is to remove some S3 related code in CpuS3.c of smm cpu > driver. It contain commits to: > 1) S3 MTRRs operation: > > MdeModulePkg: Add gEdkiiS3MtrrSettingGuid > > OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe > > UefiCpuPkg: Add locbox lib instance in DSC > > UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe > > UefiCpuPkg: LoadMtrrData for all cpu in S3Resume > > UefiCpuPkg: Remove code to load mtrr setting >=20 > 2) AP page table unavailiable issue fix: > > UefiCpuPkg: Disable PG in IA32 ApLoopCode >=20 > 3) Register table cleanup: > > UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE > > UefiCpuPkg: Remove code to set register table >=20 > 4) S3 ApHltLoopCode Operation: > > UefiCpuPkg:Abstract some DxeMpLib code to function > > UefiCpuPkg:Move some code in DxeMpLib to common place > > UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume > > UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib > > UefiCpuPkg:Remove code to handle APIC setting and Interrupt > > UefiCpuPkg:Rremove code to wakeup AP and relocate ap > > UefiCpuPkg: Remove the duplicated mpservice locate > > MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_STATE >=20 > 5) Remove code to get AcpiCpuData: > > UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c >=20 > With this patch set, CpuS3.c in smm CPU driver can be simplified. > The whole patch set has been reviewed-by Ray. > PR for review: https://github.com/tianocore/edk2/pull/5606 >=20 > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Gerd Hoffmann >=20 > Dun Tan (18): > MdeModulePkg: Add gEdkiiS3MtrrSettingGuid > OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: Add locbox lib instance in DSC > UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: LoadMtrrData for all cpu in S3Resume > UefiCpuPkg: Remove code to load mtrr setting > UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE > UefiCpuPkg: Remove code to set register table > UefiCpuPkg: Disable PG in IA32 ApLoopCode > UefiCpuPkg:Abstract some DxeMpLib code to function > UefiCpuPkg:Move some code in DxeMpLib to common place > UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume > UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib > UefiCpuPkg:Remove code to handle APIC setting and Interrupt > UefiCpuPkg:Remove code to wakeup AP and relocate ap > UefiCpuPkg: Remove unneeded MpService2Ppi assignment > MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE > UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c >=20 > MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- > MdeModulePkg/MdeModulePkg.dec | 5 ++++- > OvmfPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++= ++- > OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- > UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++= ++- > UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 183 > ++++++++++++++++++++++++++++++++++++++++++++++++----------------- > -------------------------------------------------------------------------= --------------------- > -------------- > UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 6 +++++- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 144 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++++++++++++++++++- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 56 > +++++++++++++++++++++++++++++++++++++++++++++++++++-- > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 6 +++++- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 154 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 993 +++++++++-= ------ > -------------------------------------------------------------------------= --------------------- > ----------------------------------------------------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm | 153 ----------= -- > -------------------------------------------------------------------------= --------------------- > --------------------------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 29 +---------= -- > ---------------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 +++----- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 26 +---------= - > -------------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 5 +---- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm | 189 ----------= -- > -------------------------------------------------------------------------= --------------------- > ------------------------------------------------------------------------ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 30 +---------= -- > ----------------- > UefiCpuPkg/UefiCpuPkg.dec | 4 ++-- > UefiCpuPkg/UefiCpuPkg.dsc | 3 ++- > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 78 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +--------------- > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 4 +++- > 24 files changed, 531 insertions(+), 1582 deletions(-) > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm >=20 > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119182): https://edk2.groups.io/g/devel/message/119182 Mute This Topic: https://groups.io/mt/106150757/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-