Re: [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

> +//
> 
> +// The list of all MP procedures that need to be perf-logged.
> 
> +//
> 
> +#define  SMM_MP_PERF_PROCEDURE_LIST(_) \
> 
> +  _(SmmInitHandler), \
> 
> +  _(SmmRendezvousEntry), \
> 
> +  _(PlatformValidSmi), \
> 
> +  _(SmmRendezvousExit), \
> 
> +  _(SmmMpProcedureMax) // Add new entries above this line
> 
> +

SmmRendezvousEntry is for the SmmCpuFeaturesRendezvousEntry
SmmRendezvousExit is for the SmmCpuFeaturesRendezvousExit

Since the name might not be same as function, could we add the function name as the comment after the entries? For example:

_(SmmRendezvousEntry), \     /// Map to SmmCpuFeaturesRendezvousEntry
_(SmmRendezvousExit), \       /// Map to SmmCpuFeaturesRendezvousExit

> 
> +#define  SMM_MP_PERF_PROCEDURE_ID(procedure)
> SmmMpProcedureId ## procedure
> 
> +enum {
> 
> +  SMM_MP_PERF_PROCEDURE_LIST (SMM_MP_PERF_PROCEDURE_ID)
> 
> +};


Could we add the comments to this enum? It defines the ID of the MP procedure. For MP procedure,  it needs call SMM_MP_PERF_PROCEDURE_ID with entries name defined in the SMM_MP_PERF_PROCEDURE_LIST.



Others good to me.

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>