From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.14829.1686320990278656392 for ; Fri, 09 Jun 2023 07:29:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HsR/NJVf; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686320990; x=1717856990; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HnH0Mh6n0UUkCDpj78GktPgjvzUd8pMYZ9Q9ofZQlIM=; b=HsR/NJVfr+9nXtliFnkUfrhmHuExQWp8TeycitldgqKkwHZo5TpIkC9X rpwsqdl/SKb54ICkVM7qDf+aE5m+v3VFNNNFAClzOxooDO9Q/uR6OBalX 7RJcmOm3+S3LJv+gwyJXSQIvsK2gS+SffANZy4WvXNnhK+vJw2e2dtnm1 a7uT3zrr7snQXqmP7HBa9BTgDOySO2d2DPWNHvFpb8snFuEVS1ufUojEc IU3xPsGQp3POdPxXkE/Mkeq2zOuhl9TXj4eEvDOYnh0Ej5VgEm9KUukpk zHdrSVRoNfW0IkX0PSNgGgRY+Esf+ZLRAC/6yGckEzn/uihQp7qSxvBI/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="421198805" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="421198805" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 07:29:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="710377285" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="710377285" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 09 Jun 2023 07:29:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 07:29:28 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 07:29:28 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 9 Jun 2023 07:29:28 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 9 Jun 2023 07:29:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WOKDlLKfWppXOqKQA6zibAjYSk74yxTWmMdZkxhqf2iyvU202eu8Fs/jfcY0B705vI69aa5iYcXfXRoJhxIsqlK6+4SfPW9SvYPWnHLWpX5OmBhg4ur40at7W76uzZSNotIX01sLP4yAm1dQIe/eoGJtiGAeCLznHmVvBVozvlL+1tT7NmMGR3C/1BtYJDw1YPynZnkuwyaRdvEnuyT5iV9YDsyp7stOBysxCMzP9v9wJ6BJlk4bpNxn1Bf7e7cEFtKuvWJ/UoWCni75CSnKyNkD8GuY2Ez0gbLF4WKh+e5ZMGc/UhGIHMM/0pnyRV7Ac5alTd3fTurMT3tYmeNrUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=szl9s9MhBnT2FVhHHY4jA9eWg67/8zgTjpwuwxhQB2Q=; b=HKWICRvM0lxiNkdO2vTa2QjnXxnJ3zvYrKc2DFYJoSTOIaUBiVcbWYu5cZ/hUX/pfjEea+FuHQWRU/jN7EZ7HGQx0boZ05rsJQK80s4TIrZxnmgW13yQFOkyHiApl5mkGsnC+1IN/phP9+l5+7DcqATsbmEUN8yZPnH3/+jxvwoZ4E5F+ScuC0gJeMBhSftF4O9eyuakagtmHr7zx61I45gfxSfzQWjGmsI36mt2jVGYmwxl6vsH79RWFdz1HSqnqmzzUTZmciVlZuunIJI5FUgmTBZRyhbPqxWFRnJnR0qWeDbNw2XA+coJr/7y9Aoc2q3N9NRbv2KRD9bSM2cRrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by IA1PR11MB7890.namprd11.prod.outlook.com (2603:10b6:208:3ff::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Fri, 9 Jun 2023 14:29:24 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::a50f:27de:660a:544d]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::a50f:27de:660a:544d%4]) with mapi id 15.20.6455.037; Fri, 9 Jun 2023 14:29:24 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures Thread-Topic: [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures Thread-Index: AQHZk7PtZAR2SSNq3UimxvJC+szyxa+CkzuA Date: Fri, 9 Jun 2023 14:29:24 +0000 Message-ID: References: <20230531113438.1797-1-ray.ni@intel.com> <20230531113438.1797-3-ray.ni@intel.com> In-Reply-To: <20230531113438.1797-3-ray.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|IA1PR11MB7890:EE_ x-ms-office365-filtering-correlation-id: cf7cf643-5b13-4f5a-8a69-08db68f5ec6d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ecmBBLm4aPEXgucAUfIxLNRMkjItoFaGylsm4b3XnJk533kH0+vKfGNooQ5v9pJa3sigeys7SQH64/BHOAdHSFzUlXlxFDmY6xtNHlMiz+6OzKJqA3pK7b5zOV2yWg5UpVu/DsvQCmwqjLseEHCEtYaR95HQRSBlalF3+VlhFqRfhjNuA5SY2jIz9aH4ALkxfetmh1Q+IiXb7vxyEcIkEforQLx+6LmjYy1epyuydsZ2Ihhcbtav9BGQpiKYzWiH6kiB5J0eF4wXqc7019wQGNhnfWVdEumC0S0OE/m1f2nGQtCrnSWD1ITUObsERlp26c4VbgOf3oWyNpT7hQ8eRQmXV4JaTB6Ro8FAG7M53X2cIeBFJGVWUulyIM8vPFXNSCUYvPEB7DNmA+oz6rBjuliUusfxl+USl8n0/mi2/NodqXBgQFe5DiVkKH1C3D7NIL2JmXf9tUeKpVzrVzHm6e9x09Pzk6GZ3DfA3k9CDRCvqVQqUREuMf7SV8ObJPaEuw+Rxyj5FKRQUxETp7ybgr4pjDGdUzMU7xdA+Il6ofiQMFdqmoZGxV0vUGpD9+N6Lz6Al/4F4XicvDTQDNqBu641lGmUv2nHan9C+XOS9HlNp8P1lXy7ToGMUa1gKvwL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199021)(86362001)(8676002)(8936002)(110136005)(7696005)(54906003)(478600001)(41300700001)(55016003)(5660300002)(52536014)(316002)(6506007)(66446008)(26005)(4326008)(66476007)(71200400001)(64756008)(66556008)(76116006)(66946007)(9686003)(186003)(2906002)(122000001)(82960400001)(38100700002)(33656002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2CS/h/GYtT8UrKzBqrjLBRmB+nUTveXJ6Cia7ZrR157k1dzrdzzbNp8qmC9r?= =?us-ascii?Q?+U8DcaLioOeybrDuBiDzXbRI9Px+Dd8mqos602ZJ9Mrg6uo0UqciHhJNLp4L?= =?us-ascii?Q?4MXASrKVoRe3/hlhDKvSBGHuu0Yz5GMoBZmMP8Q1L4u5sTe1iKVxaSQB0S6h?= =?us-ascii?Q?y7bSha/HQldwl6lzwdIiSPcyTkQbK6cScd6vWa9xHKF/pF2/KRVMQkJ6MD3M?= =?us-ascii?Q?6HrYXH4dFy9DbRAr/jt2K18558AZKKI8AM9ZcE4eHYIS+TL0E1fV/NDpRLEZ?= =?us-ascii?Q?3SquiTiLWY0L0ATxWbI9542YB42YWC7pvs6n+ruliWd/yDZz/Yy/Lk/Df1Mh?= =?us-ascii?Q?saDNiT87T+z009OZ8MsmVwcgSj40WZmforoAdS1qFZtBcvpFSm25BoOiQOtn?= =?us-ascii?Q?i2IuIG8raarCiuvMFDH92aCJGrpxsRgPiMQRcGW1Ul9Rw2rd9Mqj/2oalIav?= =?us-ascii?Q?8xyDhdY/zEeLsdz4zivZBJtAHiLnoWEQBqpzwK99q1hIxMEw9/iuOos4pN/o?= =?us-ascii?Q?wjIIp7HuWnNQ3UFRNOQ4FAFoRaImeoxbAtLAYQuA1Ml5D+S4VXFzEYc8d/l9?= =?us-ascii?Q?WiCRtMV+iuVdQqsdsWLW8dw4pxuLdNA4SDH5eVY9Fs6sc20dXfX442w2jwWW?= =?us-ascii?Q?3ke5ZZO7pus6nmmuKXts3HpUqKDnVx7jofVjJyhLio5PBsG/00dbIP46u2nV?= =?us-ascii?Q?MXTf6M0CV9tzzEfOcj0JX41vpkpj6/0j9810fbUbVSO20sZ9lk9fkvPrOp+c?= =?us-ascii?Q?83+fh5m1Zu+YoJduZhyTBHkh0uahSCYLKP799L2//Bv28bdRFjRiu7Om8sxX?= =?us-ascii?Q?5NEYOVarc8KO2kP43LFLvwrgWTOFn+9yYr9bmekUNEEs0nCI7WymrtrvNFuL?= =?us-ascii?Q?RfnWTuGRtNRi3DWmAYSy7LUgdQQqeS9lC0Yi5iNr6bgBl7eSddWTtZeDXH3t?= =?us-ascii?Q?0WN/jp9axcluk049qndkd21q0CJvtwVnjteyTJv5VvsKKhHhKu6gD8mcD2GD?= =?us-ascii?Q?S+TiVg5so94wKkTZBYY0W6616nfAk4rL6dfUKdVCPP7rmHVJMN2l1353JrdH?= =?us-ascii?Q?l/yIs6G/CrBIHro7Vo+txjT0RM8s6SY2Vs892DYAnl+d7pyVKkINNoEUBK0x?= =?us-ascii?Q?ipKKQQLTx296uwyTo+3Ay+34ERoOf5XpxCRjBw+dskZ8cWajV6xMjSx3kSnE?= =?us-ascii?Q?nU+uB6Fq5rHHvRnxSm3eNpahToz6I5hYCoj36TX2wt3mXteujYaUW4eO6jjc?= =?us-ascii?Q?xCqwpmNiWyCpnuCU1W2rFPs8ZcFZb8iRbkH8h9Ey1v1AHyfYBjzWLNPU7Mbd?= =?us-ascii?Q?Ofx44EkzQ9ARLQlBmqowJPF/RPWClYTnqStBPmcrhw4GbDlt08SN5h8sZeVj?= =?us-ascii?Q?ERMoGtIJSOvQQpLI0em2auxZSWbE03DjlcFfPG69rLwj2eXMo+rbQzAiZQ7r?= =?us-ascii?Q?2eeUm6nWVSC37YJywaJb6ov4L8VcleJDi3tp77ACfuAeiKwDZs6AqBdmYLHd?= =?us-ascii?Q?M+a9NtwU2ZlEKjbt5YZKI+btniDHv6SAjRPTk0UKAL6YpI9LQ6M9lTbQOmO6?= =?us-ascii?Q?Wc0J4TYAy9HqKGTxuRR5DVTOTrhAdK34DOd+Y3Ry?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf7cf643-5b13-4f5a-8a69-08db68f5ec6d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 14:29:24.5429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1HuDXaWVVMYQeWOV3j3WT9beW4lidNri6dS2QmhFwPKK/vB/AmU6oN9cx1vMO9SvF+mMt6WDzlNUlqyBvd8wEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7890 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > +// >=20 > +// The list of all MP procedures that need to be perf-logged. >=20 > +// >=20 > +#define SMM_MP_PERF_PROCEDURE_LIST(_) \ >=20 > + _(SmmInitHandler), \ >=20 > + _(SmmRendezvousEntry), \ >=20 > + _(PlatformValidSmi), \ >=20 > + _(SmmRendezvousExit), \ >=20 > + _(SmmMpProcedureMax) // Add new entries above this line >=20 > + SmmRendezvousEntry is for the SmmCpuFeaturesRendezvousEntry SmmRendezvousExit is for the SmmCpuFeaturesRendezvousExit Since the name might not be same as function, could we add the function nam= e as the comment after the entries? For example: _(SmmRendezvousEntry), \ /// Map to SmmCpuFeaturesRendezvousEntry _(SmmRendezvousExit), \ /// Map to SmmCpuFeaturesRendezvousExit >=20 > +#define SMM_MP_PERF_PROCEDURE_ID(procedure) > SmmMpProcedureId ## procedure >=20 > +enum { >=20 > + SMM_MP_PERF_PROCEDURE_LIST (SMM_MP_PERF_PROCEDURE_ID) >=20 > +}; Could we add the comments to this enum? It defines the ID of the MP procedu= re. For MP procedure, it needs call SMM_MP_PERF_PROCEDURE_ID with entries = name defined in the SMM_MP_PERF_PROCEDURE_LIST. Others good to me. Reviewed-by: Jiaxin Wu