From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.82642.1673604621400840542 for ; Fri, 13 Jan 2023 02:10:21 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nREsolY5; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673604621; x=1705140621; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=i5XcSnbPPkwWUmfBuGjau/UPG6VPkGVB6jLknIu+flI=; b=nREsolY5BlBjd6tnqw6iKqOcXt46jXu9Hz9sdnArqz5hpN4zzBou3Jc6 ralUpDEQbOeKe2gVPrbR2sqxQLRrD4xzGyBvPf7O16siie1fBQA81w+XS JdCsgi86/FYkaMZqpQNCSCRJGQ4jsmM6ypaDTi2A5/QnUeHSRo6kOLO0V vOkUoU58FVncvLyVVx8t46b9Mze0yRgWWmdqRDcxkWwm96PIW7lAe/e14 xborJ55gK4mKoX1fpepwgDikjx9qw+lxFaIvIenipqfztmaLKrfCPNX2U OJ/xb1zzAJkDWt8qo05dNUnl3eqOr+/UNRyK0g4XDfo8bufFi89DW0JCW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="303658975" X-IronPort-AV: E=Sophos;i="5.97,213,1669104000"; d="scan'208";a="303658975" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 02:10:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="721470247" X-IronPort-AV: E=Sophos;i="5.97,213,1669104000"; d="scan'208";a="721470247" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 13 Jan 2023 02:10:20 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 13 Jan 2023 02:10:20 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 13 Jan 2023 02:10:19 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 13 Jan 2023 02:10:19 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 13 Jan 2023 02:10:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKF8zW/2O99JykhJR0x7j3lbyztxXy31qVKakSeKkEGeaWFHlA7appGlng/fl0jxkKLCt1rJkyUfR4dlyMXgcYkU52toDnvnc2KJzB3QsgmmTSiA8gz7dr80ZCJLuwJqgGBmS8geIJIS2dPX21Xl/g/juMpMDCMPIgw5FPT41EJ9CtFC20H035VW0YUi5xURfpoXwIyuslmuLyjA7IoIGNnPmuqD/PPYuzooFWcD/5epVQZ9z1wr+AKRleup1mhz16gO8l3JVj9AIKycSOdGN7VnECS7ZF5udUhePg/mGs7lsyeh95pkdRafXnZRyStYeSakyeHomvXUNlEvyduEPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eZhwZZKXGU45reQCLIEZlhfOSjvpDjmf6zbFBlUVmIg=; b=m8QTqBqUFfR6hxg0pdmpupJtpnQTHQql/o5bPHMG6Z5YO2cfKufJdS3UutEqF2DSXuYxJG4ceVo/8ppYdbLFmNMLEt3WU9fRVj3aRlt95VR4pTN5W6q8NPF9ZCH+kkZFku6KT1CVafVGXzIjbh3YXTfZyGttwQyHSWQMGRlCrX+rbmpGGhVFaaQVA9HSRd/z3bHJnojN0kiE8UD1rmXCQ4s97kJ4yDLEEkSM3vwNgCFirma+UMxQLeHFevm0801X6TEctiOtXxsiRVPCLG7mmSKLl+2Qa3J3624A0kuEy98oC/YePmqylBGZgWUliwRoFcHx7trEndG4gW1aRHG1NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by DM4PR11MB6288.namprd11.prod.outlook.com (2603:10b6:8:a5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 10:10:12 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01%4]) with mapi id 15.20.5986.018; Fri, 13 Jan 2023 10:10:12 +0000 From: "Wu, Jiaxin" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Dong, Eric" , "Ni, Ray" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Topic: [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Index: AQHZJzSeIEv1rhKaaE2KHX6jAEpUS66cH+pQ Date: Fri, 13 Jan 2023 10:10:11 +0000 Message-ID: References: <20230113071738.15868-1-jiaxin.wu@intel.com> <20230113071738.15868-3-jiaxin.wu@intel.com> <20230113095112.w7aq6tsebif5ni4l@sirius.home.kraxel.org> In-Reply-To: <20230113095112.w7aq6tsebif5ni4l@sirius.home.kraxel.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|DM4PR11MB6288:EE_ x-ms-office365-filtering-correlation-id: be0f02dc-25c8-43e6-e4ed-08daf54e5b8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WaydBDxMVgfrb0m7eMnNJ7Z/pZhO3lW2fy2w6zIQOIHZ5lCdfRFf97Xbb5NsoQFfyLEn9hB86OEyNPxAJ+eqVbLeAqkSudbuBLF0bxAiD4mpwZQ53XuxyG6FwBWILgfLbA48zHTcwH7KDsUXxC9KttfKous4GjIk6vnrkaMmlaCs2FrJj/NqUUdO+63sUfi9idS0BzgL9WGMYXDHiszNn1u4UzHc+7LIppniCzYrPbHUwE/Kj6k27Y9sIIycf1T3WQ7H/kfOV5LE2WsObCUFmiJ/ODTLVZibq4ynXSPY/DpKWj17CsG2T3eXp7bOT1uHikUWt84+BeLmJc2PMJy6uhdoVuXitYKBsm9lt45B+jvw9nHKKAt3RHTEo/Uom/n7dtQsSlvtX3fifcxiqGwHYSq6tM7k7T2XHCu6GcCFz0bybBolycv2fGOFmSqc95OSV1aIytMZ099/akaHDdjDu5lyjLD36hJJItw3bPX4/HqRZPdgz2sxjjv3OIceVpMWjMtZzpgfo8k+9yu44u23i1Rwn9iyDTMGn74/D8D9X5sGukHIQaFETQyaC46DtpbDCatGvUaWA4Ss2Mm8bVUE/6zK9MXg4GTMFIMOsSI/iac6oOnkgJT10AlyHn1UYGpz6Xe1jFINtG9VCV9RAnQGX54TJwWiu8NJrUR8wEjl80vm3Ef9MuQGgfT7ExqPI63cLkkbUbaaZRjpU+pYytGSVQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199015)(26005)(4744005)(6916009)(186003)(53546011)(122000001)(8936002)(107886003)(7696005)(6506007)(66446008)(9686003)(478600001)(33656002)(5660300002)(66946007)(64756008)(66556008)(52536014)(55016003)(66476007)(316002)(4326008)(71200400001)(38070700005)(41300700001)(38100700002)(82960400001)(76116006)(54906003)(8676002)(86362001)(83380400001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6uOKtUL+rPOEG3jKMYgJ4ND6DJITE9LaUXMfdOnIXydIERPKd9l0CacXNtPS?= =?us-ascii?Q?oQnJIGI8ILE/JVx3tjJMaFZv3r/uDST/Zxay6bf4zH4CKWorIZxojG/87Eup?= =?us-ascii?Q?DvUb4xKh15b11X0V1BeAj7D7CXgkwidi0384uEJ15FYK1je2RBLW2gK/cfnn?= =?us-ascii?Q?QYAH1QuXJ9KtZz9hVUiUsYJTKX/PwK2NHTttL4X/WsFTYVOKLG0EbvTZE4/2?= =?us-ascii?Q?ufvZNXa3TwGXVji+MTtIfaE0UiyInqeUWNgkW3aXQDwEfNJROhOMREuws8ib?= =?us-ascii?Q?MVIdqjZSWMUqldzIlHSvck94DSpF+8fiU43RZh2tl3nqCnFribcAO9SqU4yU?= =?us-ascii?Q?hGvtpZcV9yeVsG9E/yp2VPxc22JxgIVJwDe9n4T4aPjgrGFcGtkSUds8XU9o?= =?us-ascii?Q?m5OylmQtyug3/lmBNBUOW1gbp6iowdo+BWSzuhn2qVZormezJhxArDyvvtwK?= =?us-ascii?Q?pidMLLtAynjIaU87gLnwjFqO5XGx3zeMwN310boR9hiH0hwEreWsii+ovdI/?= =?us-ascii?Q?U1NfK0E+5Uw9Of/PUqsCUp5coeLmS1DyLHlHjfxOcM0iVsDKPt+2igkGQ+b8?= =?us-ascii?Q?IRNnc58PNU2Bs++Rhjj9HMJYm/9uUj93MnWaqeEot4Vt/tS1xew8+0nnj7HG?= =?us-ascii?Q?7cIwS7Ydm/4TTcY4CHW9eKdIXCDpNQhPFBNfNxD82AFYSzpulkAiKlI6fmXG?= =?us-ascii?Q?suosiiAplEJq+AvEr33a3pqNdBVl+QO1cWew4CjnxBOeEd8jsT+yYDI6W13q?= =?us-ascii?Q?0wmhnzT6lpa3a4SteZh9qW+GIKY+jvT9hCZRrpRpn3hl4bZKbLylDgDNOZj3?= =?us-ascii?Q?dLWWOhi7jDk7tuRE0aeeZP9s4tyBAkoQPDtjNxWC9zDR3WJc2id5dE4CTmH/?= =?us-ascii?Q?qYybVJtm8iTZ7UQ4m05lF1FFsxHr7Kzs3QwrEmxmsZ8QTISIq1r9TIyBgsJG?= =?us-ascii?Q?jZXNJnr98DjOCgmYzc28TjtyJ25QxqlwOVRnZuYaqgS/qlFx2BCHj46UPSoe?= =?us-ascii?Q?ZROp9yhFKMSciwbVPstMkcw3GSGHTZOn13ujufRfIlX14sYeHNs28fZtHSMj?= =?us-ascii?Q?0D9gyfHHt820ZRl4aYn9Hj4BFsCII90LsSorLFUyLFm2T/MmpoeDqHI6DZ+q?= =?us-ascii?Q?PTJWnTwLtWK7xFBowMY29LlOBGjhFwIXRbZULXRvXX5cFSIFykVL8uYW7iSF?= =?us-ascii?Q?f2uG1FUSdL5PO1qmiNrOvp101VY8f8RLnAyoSYVrzkjkleZQvj1dbL/QUwpc?= =?us-ascii?Q?eENiQTRbDzd6Dg/tvC3DJpsidqu4hASq7iBaBV+pYOCQnK6dPj29c0EkI03N?= =?us-ascii?Q?WzFgFjPq0wRvXNKVEhOIpVdItuRHgnXmI2/3M/qCGRX0l5dxNBMdcTSiFm0u?= =?us-ascii?Q?BxqqG7xcAg2MMreOGZUsQY4QyS1bKp1zAak5pl9svIklHNXqAlXemhOqe2eG?= =?us-ascii?Q?oLJfa4dQlS3fXUZHi9BoTom26Jw67uAfiek6sGhGSHcexRX9g2GpNQPuj9bK?= =?us-ascii?Q?L6idSW8qrzhMPtfNfkL9o7FymuzwbMsan5MXJ4BB/UR6NAtES5VOvA+L81jk?= =?us-ascii?Q?oqFAFe4nwn496UsWbzQtAAFBhzbpXGnJgKlVebXf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be0f02dc-25c8-43e6-e4ed-08daf54e5b8d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 10:10:11.8001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fEpT971KPSWpxbvXNCNBzuYVxfWYf9Hesy/m6O0N0/0mR9E/gCGeUEYDuVQfpnL5cPmOinpaIg5L0YEW/G0jdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6288 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Gerd, I will refine the code logic. > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, January 13, 2023 5:51 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM > Base Hob for SmBase info >=20 > Hi, >=20 > > + } else { > > + mSmmInitialized =3D (BOOLEAN *)AllocateZeroPool (sizeof (BOOLEAN) = * > mMaxNumberOfCpus); > > + ASSERT (mSmmInitialized !=3D NULL); >=20 > ASSERT is not sufficient error handling. >=20 > take care, > Gerd