From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.6484.1675414751005362226 for ; Fri, 03 Feb 2023 00:59:11 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MhH3yhjz; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675414750; x=1706950750; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=g8rxkj/Cx0KyNXBAfXOLWkVYLKYcpbbS/bc1a1xECe0=; b=MhH3yhjzCBZrPS8OMfukIfXkVw7mH2RDwR0eRpMnHegE7PErhqYefPXh 80XM7q6dK3vIZEuDpQH2P14PGWD5w/wvLzau5s1qYPC/ysxe8IPgSSWSi ZpVjsj1zHgYwXiPd55/t3UibzBOueMf7BOUtBd2lMqktJlrel/68pKnfO XgFLJBbTiIhSdcoM6hYoPLv4+dVBJseKZ8k5VQ1HWWPTkJUxmPFBNnwxg Xg2KVNRPrLyw0jCcLo4XSN8rfVZ4Q3/dPE3OkOgp2GcFV03/8PN0oYn3F q15NAzAkB/S2A5vjXJKsapgZneDeSoVXkVDUqbirJ6BkQZ7WvzLXA62/o w==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="327338194" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="327338194" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2023 00:59:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="994448879" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="994448879" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 03 Feb 2023 00:59:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 00:59:09 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 00:59:09 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 3 Feb 2023 00:59:09 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 3 Feb 2023 00:59:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRNrDLXS499wfCdVBBbNXw84VXcNoTew8gbJsBake6enHZg2Spe0aQSSnPHeVSl4aVG90Y+aJI1/MhiCZCSWfOrDhLce39sLugIC/FM/mAlbxzxU+nv3iX0G5uEYV0hU05YTYSvQz/nBlZeo9TvmkQuu0m9Usn2KCa8U5MF5Unql+2tK2Ahf+XqIXkOpDz0pIPa7QZl8tJGb4Frkj5RPDDBR69Rrq0Es651oBsS8zRC70n6NsnLKvCTTRfg3efKQTIMT6Pf9himQBc1EpnoSu5lRyBUCruY+HqysWB74PouWbjVfZycQimMnwU1TvD/FLj71z8nly+ytqrvuYvsSkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9NaOi8biwYSmqfpPvBvT2jiUZxfLslPXtzmVe7ze9CI=; b=iPIVTiWwMzwKFcMB6PtzVjGv5V8gsg28GaEZMyt60QSZW6QQ1s1xZxj3Bbgsr8BmlVDdHzaHEcDAJ/FI+m1moVIZTpzz23l20GFHK7WozwZjMA1TLqkxIaaSLt/MyAcikgPiUpS+5HvWL7OUG0pNbbLtXCdUKcFrZfw2VDecumkjRoeWdgCTvcQZjWRsSNoTRSQLdQk35fHO/LjUWS3epUvUS9dND0+YC0KQsdljT+dBfA4p39OV6sMtpUe1nu/YQl1OKdVj20bcw/N3PO67YG2G/jwIkCTk+b1CjWq2jlfcjiIKlmi20Jw+XwlYeEQsSj7WRzK/g2EHcFeSWfPQXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by SN7PR11MB8027.namprd11.prod.outlook.com (2603:10b6:806:2de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Fri, 3 Feb 2023 08:59:07 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01%3]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 08:59:07 +0000 From: "Wu, Jiaxin" To: "devel@edk2.groups.io" , "Wu, Jiaxin" CC: "Dong, Eric" , "Ni, Ray" , "Zeng, Star" , Laszlo Ersek , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Topic: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Index: AQHZKyM2DUI+qq5+5Ueu90n5+Edtmq69A4/A Date: Fri, 3 Feb 2023 08:59:06 +0000 Message-ID: References: <20230118095620.9860-1-jiaxin.wu@intel.com> <173B5EAF72B992BD.14781@groups.io> In-Reply-To: <173B5EAF72B992BD.14781@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|SN7PR11MB8027:EE_ x-ms-office365-filtering-correlation-id: 14b386aa-4bff-4466-6596-08db05c4e819 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IokndzxerwQNTe7oaaYXZqXfSdsXg/oSscP9ITf5wQfSbEROpFws6ozzxldjc2ryqS8b7KvK69cuc7S01bD+j43deN3eJw+Q9jZb4xx4krClopyE1lg5tOYR/Rff7TVIpwVb+XVu4DGaP9iJtsFTtPg9TxfZ7r8XksnPjwKMqfBSNMO7Jk4zBMAzXHKYE1XBHENyhr74fT10hKHx82WxjFf4Nb8pfIeUHaC6awm1hfsdYAaP2/qyDQS5XvNxiPqxEApPgwmGOVcSkTgeLUE6FXaCgaI08C8IHHhRgYWYHfBdlvcNyBKyJMCRzMtSHj1lhZcPvbVy1jvowmD9C9UalIa/+Cfj8ijIHx6xmq+VSX0+QQBPWulhXHz+qVgKBSLy6z+srjS69pCNxkgV1F2ffV0337ANck7+gd3/Bj8sLV64r56Hhg0bn4vg2oy27qI1QbJScylwQaR1Ungl9k0cbEIXS5UCVonP/uPajVvC45AKZnmv2oxqctRw1DJcvH5u8tqEVe2Zpy8neyxACKnxoh9fe8fxJzkBvhFXexQjGl/dhjgBOggpZlaTrBfA9jaWCjT4q5XcPaeZiwzioj7gMMdAWso7Yb7xAUZdgfOw8qLUDiIPHt8V/ktKaIBmHBYl79itiynVYMUbR/sT8F12ofoWJckNV7L4A1fPasf7mIXfFo4EiFc8NRtWfJC/2WUbM/pQwzLZMkZVHf17iziToQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199018)(55016003)(38070700005)(66446008)(186003)(9686003)(26005)(6506007)(66946007)(33656002)(76116006)(66556008)(4326008)(8676002)(71200400001)(2906002)(66476007)(110136005)(54906003)(64756008)(4744005)(316002)(5660300002)(107886003)(41300700001)(52536014)(478600001)(8936002)(7696005)(38100700002)(122000001)(82960400001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WblCfRGiTUNQpoc2EHjJYsjvDFFs3JDgZNT1+6vpLzBXfmIC4MqzW6FdHo38?= =?us-ascii?Q?DL3J94FGS+mu1J0aQrg/lPOwBOXTCVu+kUtyfYh3Pvc9elK7EGQ71nlvXFLx?= =?us-ascii?Q?MTTU72z48oyGzlISeZnYKDZVIWAQtK8l0REbG5PeHcJ9+k062Jz2zHORh3xv?= =?us-ascii?Q?jUuG80bpLUOeoa9morQog+x2hFfbld1UMNqt6vrDTs0DVNV7XilEn/lF1BkT?= =?us-ascii?Q?mlMJKWLXH29CcIu3rX1dq61M99U8yh9PZZgVc6LRVPuJof8m6AZJi2bj6nAK?= =?us-ascii?Q?sQJ0T8tJm/iZXx6gN8SNrRLNYofWydWzpAGXIiT9Zpxb8VS9nl/HZmdB09lC?= =?us-ascii?Q?sIgu0SJOzmgQa2aa5eivkzNOeiUBBfdGT7cOk7r9x+g8NwQoRITZbOaRnGrt?= =?us-ascii?Q?ePDPzGZzhV2UYMvwU8Zwr63kkDZpkKGmIFIRdQ9/1gR7B4wjV+S6qhlOjnHl?= =?us-ascii?Q?yzDDwGx3BSf6Bdrx0+5CoCIk5Uafa0jrZbKUtvYBG0qjHnyvf7n4bwl6bT+6?= =?us-ascii?Q?0mmtEsRi6ShIpP31SUhvwRGm0NAlxhtYd+M8AtZ8qfl5gTNKZxVbwkzhiLq1?= =?us-ascii?Q?CvJYdAfX6vNPMOOKSq/dJHUMh77LOADMgdHeBSHm9MNhb703RUkX/wJUrZ2b?= =?us-ascii?Q?xoqJLuHxkPcW0X+5TQSJPp74igcjBUpkrKivBEmNeKmW1pnoy98hUCI4lh+D?= =?us-ascii?Q?4NYfwpLs9jeFn14TPv0DDEcE7DmyPJmd0SGqmYRZsUUy9wAysIdPKHUPF08U?= =?us-ascii?Q?tAOnGVO24BjNcA2IKLzA9mjMwRCAmViXey5uZqr0K7QMaZWTR8t6PW0G52Gb?= =?us-ascii?Q?NWyILZrNO2s88GXK0wdmw43232CXOZ+3NoVVYlRg+OzZ1qK88N9zIXhV8AvG?= =?us-ascii?Q?MZX1VAK6YDQpWzfSkheBej7ueMn7q9dS+OgwdoBLTwo6lxcCpn13D0H0/+71?= =?us-ascii?Q?OGLV+ncSJQX/q9G/26U8jZd8opt7fA1J2TEm3pjucl+nqNqxfN8NUfFzE0Lh?= =?us-ascii?Q?ry1cVpt6eZckdkOdEwGEWxm+A/+GmG6XM0rvO1Y4nN44PvBtqyqBGr9eIzRO?= =?us-ascii?Q?nCn20Uz7b5HOypPCd5S+Gtbta9k8a2YiXdIEehBq+8N/jYFsmsuQBi9OWK0Z?= =?us-ascii?Q?ZLGxzN4jmKiJS84AMnelFUvdTRYTc5I+0npze+kdNFiz14nNobwoa4vvnzIf?= =?us-ascii?Q?ifqY73kP9WUWaBFVdWP+oMQocFZcGq2qPFtgaRK9jBlovni3ppAyqt3Y9k7+?= =?us-ascii?Q?vdQ0uhvD5FukyaTD6QqHoeXtcHGIVGisJbk3/VQOA6S9S3yU1H6eq25Oruql?= =?us-ascii?Q?XjbQNGV4sH0K228f1Puu9CuuFqsxB8S1jgc5G+WKIhOEuQ6DWn3KSl55VGe0?= =?us-ascii?Q?hIsYXdtItwTn6d6gRyresDjdHPYkbD1yrfNHKWdhiP/SD+QSIoydBZy2czoK?= =?us-ascii?Q?+xOWjIML6YtF63dVXVjJJBvZDh8+QlFBRCzTj5ZWsbIBuVf7IdhM7tcCffXe?= =?us-ascii?Q?mtRmC4AP+OgPJ8WJI3JkscFb0qOj+2z0KOrOBYI1C9gootWqskzAdskdUFeG?= =?us-ascii?Q?cevkOcTanFcVfxwstG8Cp2FM3/I92tbpbNpnU5Rh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14b386aa-4bff-4466-6596-08db05c4e819 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 08:59:06.8296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zD8WKM6fFrr4tIAhr8D5S+piudPKBrqvDcAABkZ+zE2cFkYkPGHqpTy/Nz6ulJRg3LI8Cin6isWtb1DU1i93Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8027 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo & Gerd, > SmmCpuFeaturesLibConstructor ( > IN EFI_HANDLE ImageHandle, > IN EFI_SYSTEM_TABLE *SystemTable > ) > { > + // > + // If gSmmBaseHobGuid found, means SmBase info has been relocated and > recorded > + // in the SmBase array. > + // > + mSmmCpuFeaturesSmmRelocated =3D (BOOLEAN)(GetFirstGuidHob > (&gSmmBaseHobGuid) !=3D NULL); > + Do you agree just assert mSmmCpuFeaturesSmmRelocated is the false for OVMF? Thanks, Jiaxin =20