From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 52479740047 for ; Tue, 16 Apr 2024 10:08:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wHdxOCJz3/JOqUoEoTvtKyXbwdUr28Si+GYWitFhuwU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713262107; v=1; b=0ne+AXwsTCpmyouCokrbfZaF5pRWj3vyrtDoJ20QDF6KtnxXLlZxlAcz60gI8sztpGtX6RBp 1LPM3ogoqUCDd/+3buNDKOQ3o23e+eFl7mQBMahzOyFuS63HyOTD2vaHtBfeCccJ7V6PWjcBFmb qyPZcVyG5yFrhryddGEGAQo40Hk14cSWyqXATdwQvi364nZ/OXzAdvfH4E+pRUCiDRo3QdTolXY m9tGTpw5Q71AsdRxPEE8jRSVWBQxIg6N9rAnklid7pcW64jgH/lQ5n6BeX+ITLrxOPDvTli/1J/ 3YLBh19L+OsqyVyEiyEtpGnYWMK/vpA24lSWtY8ahBKzw== X-Received: by 127.0.0.2 with SMTP id BfQiYY7687511xMvwphGIb0L; Tue, 16 Apr 2024 03:08:27 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web10.16695.1713262106297777585 for ; Tue, 16 Apr 2024 03:08:26 -0700 X-CSE-ConnectionGUID: gygbPhAzRCO1UVysblS2eQ== X-CSE-MsgGUID: tTqUNzqyRw6lalqmdxgn0Q== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="12467022" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="12467022" X-Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 03:08:26 -0700 X-CSE-ConnectionGUID: GvVMZlgOTF6UJwgv/otccw== X-CSE-MsgGUID: EgNS5HWdS8KJGMr4/hfeqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="27002370" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 03:08:26 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 03:08:25 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 03:08:24 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 03:08:24 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 03:08:24 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by PH7PR11MB7001.namprd11.prod.outlook.com (2603:10b6:510:208::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.9; Tue, 16 Apr 2024 10:08:22 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99%6]) with mapi id 15.20.7452.049; Tue, 16 Apr 2024 10:08:22 +0000 From: "Wu, Jiaxin" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: "Ni, Ray" , "Zeng, Star" , "Kumar, Rahul R" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Ard Biesheuvel , "Yao, Jiewen" , Abdul Lateef Attar , Abner Chang , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v2 00/10] Add SmmRelocationLib Thread-Topic: [edk2-devel] [PATCH v2 00/10] Add SmmRelocationLib Thread-Index: AQHaj9AocftAQ3mRRE+N7ImDgZdikbFqquTg Date: Tue, 16 Apr 2024 10:08:22 +0000 Message-ID: References: <20240415133021.10516-1-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|PH7PR11MB7001:EE_ x-ms-office365-filtering-correlation-id: c8a32bf5-5aa2-4ecc-18d5-08dc5dfd25cf x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: hg4sxR+WI9Kkyo9fqgv/7mcIfGyQDFdfZcmpo8to69DFDgy16p65bZerWoTdRq+pI5KnkxylsMQnuRaSJayDwK+OSgA3Sv7MTnBmpKQJhgZPUtgUKozyn7nUVLRYxJckzj69n/6MjfoJ4QZWfsOTfSTn+xth15zfiveQPeys9wNDTQiZumEFzUYaYxRdtJI+5y0x4I22UFF/5x/PSfePysfWHxWoWqctdMGlqPxwwdtd5dyfTBVeamOjXTHf8adNVRKKSWkMgtQtHtV3TJWXvUnU4t1jR6Cfyf+Cs82eFuby99+HBvdgKV0Om3y6vi1kOiR/9mvc6pEhS6uuP6fz8+dTiCT1PSrk4hxiUEHcmiitUjYj3JQIfrhbfqKWhBygJdMw+lLvzJEiY0tQ4IHl83QUAuU4Emvw4/v5e+zUdQA80++uV4aZVGjIceQ8V6tyDHPMeRMD3+scoN/P93S/S2cS6S6Gj4tDNfowgf/pH04zmmUhP1rVkHnys9h7EPesPLy2Zq2kpWR0A45P+GgbFWyL8MX+3eqUkcX8xMFsADOicmcCma3Z3tc3IrPIXddDohUiT9ztAAe3p0YYBG2Kdc3KEn65Jcn6zdxCNCP5HiYcXC3UXA+SgF9CD40zP9USPImlmfsq1wR8Jd3pTZXKIwVK0XS/1XsGYcW04dAArSf0LgP+wiQBBvPD0qjqge9bmlUh3zoM3wjvVqjYR2mc/uMf+uX+M1GCA0zOtwKXKqQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bHtpBVpxuNIi0og86+4a3kzEfmltlfjzf6BlDkgtnE+BkYL/WFR+NJow+nDF?= =?us-ascii?Q?FxDXUsq0HiR7q9xJ27JfRhZEe0M4I0HrZ+bNrgtAHORID2Y1anpl8xCRo5y9?= =?us-ascii?Q?QVWH3Bkrwj2VV4jcKZVBek5ZAHoYGKCwzf+OUmua/uvZ7L0HeveV/gBFgbDK?= =?us-ascii?Q?6+fZMsM8ngeui4USdPH3o/lE2VneUdfo1MSA24tSFNgwNFj4iWDoyDZJcmsY?= =?us-ascii?Q?0DTj2R0aPTTRGA8dTdbSV1810vOfBVUSrIVAYDN6+2lUr6D5aMPr1HRPhsTN?= =?us-ascii?Q?+kN14BjNN8OzfLvgvCzOCqfpR7eLJ2cQ/8S8xmBZ11RchnR2rDdz5NdzPRpI?= =?us-ascii?Q?QpqUf86JGbZ2vSIUW9Wc+FDbItxi3CceKoWcRk9761AMdiGUfOwV7jTZ7gr3?= =?us-ascii?Q?i1HhrPRNrmV6yun6JogL1fJ4+gXVlr2xAozELr9qvZJUFnwkNraJaw1ZJL46?= =?us-ascii?Q?xatjCZIvkanSk+YROH7gjJ5/wMvNfoOyirkStj70xvmB36btNbF98g+Gf63L?= =?us-ascii?Q?kIAuKWs7598AxWL7wEJl08HTsaNvKS0rI10RYaDO9/d3WR4pV5pCkI5iwehR?= =?us-ascii?Q?RNqF0LLOXRWGFUbNHlBzyfAvlZTdjFemYejcgClqOtzD46QX0/Xq8X8GQBcI?= =?us-ascii?Q?zvxk7dA6sRuJzcZkSYLGUrZR2udOBhqCjuQW1pXCUV/5NuyogF5+S65HIhFC?= =?us-ascii?Q?3Dawbr9cWO6iIZt3pkG4l8psHzB17ARJSfob2VlLs16wUFysCYmrKR81eOIJ?= =?us-ascii?Q?rTG+tN7XZgzokoFRah6oXI1kkjLWlrf3RfhkHOY6Ie+vGJ7K8eGCtwAy9M47?= =?us-ascii?Q?VNeozI68bB/geEc+Tc3bDVkJHCnhdCBC0y8XwzpAlpdBIBgTNv4goU4rHEGK?= =?us-ascii?Q?WZAhSzfXZBNIc86QjivWQHdx2AluvRPeBSD+57p/c8Xb0fMcrGEvYjDiuFBm?= =?us-ascii?Q?LQnZej2TQuHhdLqxuKzVPZZVws/E65aLTtqepTJtAvgdEGNAMyxUEHHAVn+G?= =?us-ascii?Q?PZKjps8KCrQefqxJv3Rd5+QYVSTU82VbJZiwZqc+zrOUBOLe02Ewfk+i0dmU?= =?us-ascii?Q?+DDqcNV8/AHWHnfzStYc7E0ym7di20zidm34lgajbAo7XpKpsEsC4XQ6hKJL?= =?us-ascii?Q?UljHpkOC3m7xmGwdc+bffROO4UTxkhasHbo+1EqzyPbu05qm/EpuLUKpppzS?= =?us-ascii?Q?OUHqlUaEtMKCFLVlnYeYHP/7EEpApwgkTp1lc/0M6C9P/isHs5/grUSlX7B4?= =?us-ascii?Q?6caExI7I3+WpYshQonGaTaRwOlk/hTaGeTxOlvzLPpMAOEWaqrHbyxHg2TxU?= =?us-ascii?Q?N1g7jRBj9u6JSbScVyZDSXtw1IeSmLo7sLNRnL/h91zV96S9sgISoEhUlXVi?= =?us-ascii?Q?sIVzVJv0aZ6bMdkOi/yLShGvaIV/JzNJTAf7mGD+UXqG7l8v/OV81vyhqL4C?= =?us-ascii?Q?byEpRDmlVaYpRJe4IKhUZDYah18N0VqxkIvjk6AZ85ipqamQ9esigelBsqef?= =?us-ascii?Q?9lTki4dh6GSTOu9dSt+JITwlHFRzyIQfROR18+iWgMgLH+r2BP/a1xNsM6PD?= =?us-ascii?Q?L6h3jP00TKb6zDdj92g/IUSgRldnlA6xcEpg+L1o?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8a32bf5-5aa2-4ecc-18d5-08dc5dfd25cf X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 10:08:22.1707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uZb5VI/zXkZh7HBIfXJFYYrwi34Qg20sczOp6TFl+xiWC3Po6+XVN6DKiObdUiadelHByBOoA5vT7ejmTY4AFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7001 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 03:08:26 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LGN7Dz236fttfZMaK99vqbjtx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0ne+AXws; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Yes, because I moved the SmmRelocationLib within the condition of SMM_REQUI= RE =3D=3D TRUE in the version 2 patch. It should be always included since t= he PlatformPei need consume it. I will fix it in the next version patch. It won't impact the code review & = test with SMM_REQUIRE =3D=3D TRUE build. Thanks, Jiaxin=20 > -----Original Message----- > From: Gerd Hoffmann > Sent: Tuesday, April 16, 2024 3:31 PM > To: devel@edk2.groups.io; Wu, Jiaxin > Cc: Ni, Ray ; Zeng, Star ; Kumar, > Rahul R ; Dong, Guo ; > Rhodes, Sean ; Lu, James ; > Guo, Gua ; Ard Biesheuvel > ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH v2 00/10] Add SmmRelocationLib >=20 > On Mon, Apr 15, 2024 at 09:30:11PM +0800, Wu, Jiaxin wrote: > > Intel plans to separate the smbase relocation logic from > > PiSmmCpuDxeSmm driver, and the related behavior will be > > moved to the new interface defined by the SmmRelocationLib > > class. > > > > The SmmRelocationLib class provides the SmmRelocationInit() > > interface for platform to do the smbase relocation, which > > shall provide below 2 functionalities: > > 1. Relocate smbases for each processor. > > 2. Create the gSmmBaseHobGuid HOB. > > > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > > a later phase) can be simplfied as below for SMM init: > > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > > for each Processor. > > 2. Execute the early SMM Init. >=20 > How this was tested? > I can't even build this (without -D SMM_REQUIRE=3DTRUE). >=20 > /home/kraxel/projects/edk2/OvmfPkg/OvmfPkgX64.dsc(...): error 4000: > Instance of library class [SmmRelocationLib] is not found > in > [/home/kraxel/projects/edk2/OvmfPkg/PlatformPei/PlatformPei.inf] [X64] > consumed by module > [/home/kraxel/projects/edk2/OvmfPkg/PlatformPei/PlatformPei.inf] >=20 > I doubt it passes CI. >=20 > take care, > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117873): https://edk2.groups.io/g/devel/message/117873 Mute This Topic: https://groups.io/mt/105535804/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-