From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1021C941050 for ; Thu, 9 May 2024 03:42:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=POeINlQGqvOz9lwIfSssNIjXxqrOcgIgtRxaYwF0BkU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715226163; v=1; b=AjL/vtqZhJ/ZOtbaZMdTFIzXFdKJoCJyfTQyh+M0u7EL7Qrln/zJKOtUzPaLyKviByasddbM lgfEM5a0jcuUUtQbD/NlOL9xNpGED/a0ZCRmRhQgw4kDzoz4OQji+nOSwuWiPVDGUy4vV3x4zgV zyHirkiguQc2+f+uTfVahOW+//4Bg8Z151iRDwFtR3gRo7kXGzHWTilTaLwh2fsZKpFk2k/WqMR FHPl/wHEbeDCoqcEFNyYh+X3f3A19gtEyWr5RcFMVw/o9pdQzu5T0QHro6wcQffkGyw15RzvHi/ MlmAp4uFX0WWnf04JOpbEnrWuh26I85kLHNn/HdfdqzOA== X-Received: by 127.0.0.2 with SMTP id 1w4jYY7687511xw5d1WpcJAK; Wed, 08 May 2024 20:42:43 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mx.groups.io with SMTP id smtpd.web11.1949.1715226161771719927 for ; Wed, 08 May 2024 20:42:42 -0700 X-CSE-ConnectionGUID: KMCwVQtETkuwzeeWNWi5SQ== X-CSE-MsgGUID: u/JGc8S6S2mSjLdrigs3zw== X-IronPort-AV: E=McAfee;i="6600,9927,11067"; a="14938181" X-IronPort-AV: E=Sophos;i="6.08,146,1712646000"; d="scan'208,217";a="14938181" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2024 20:42:42 -0700 X-CSE-ConnectionGUID: qhqZ7N6DRFqNU5mqXUY3kQ== X-CSE-MsgGUID: kVxw/i2qRYOxTcQ1I5FyMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,146,1712646000"; d="scan'208,217";a="29158024" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 May 2024 20:42:26 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 8 May 2024 20:42:26 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 8 May 2024 20:42:26 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 8 May 2024 20:42:26 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 8 May 2024 20:42:26 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by SN7PR11MB7018.namprd11.prod.outlook.com (2603:10b6:806:2ad::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Thu, 9 May 2024 03:42:21 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::13cf:47a8:4737:84e9]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::13cf:47a8:4737:84e9%3]) with mapi id 15.20.7544.039; Thu, 9 May 2024 03:42:21 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , "Xie, Yuanhao" , "devel@edk2.groups.io" CC: Liming Gao Subject: Re: [edk2-devel] [PATCH 1/3] StandaloneMmPkg: Add LockBox Dependency DXE Driver Thread-Topic: [PATCH 1/3] StandaloneMmPkg: Add LockBox Dependency DXE Driver Thread-Index: AQHaoEUlofkMueUwikK3yXlM6w+jz7GMo1CAgAGh2aA= Date: Thu, 9 May 2024 03:42:21 +0000 Message-ID: References: <20240507060910.1687-1-yuanhao.xie@intel.com> <20240507060910.1687-2-yuanhao.xie@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|SN7PR11MB7018:EE_ x-ms-office365-filtering-correlation-id: 1b153f6e-3605-4e21-f43d-08dc6fda084b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?kcN7qNkVn9FoGqZRro/NztrYykv/KF5yxK9+tHE4p6qMGyxyDCptBqeFFxY8?= =?us-ascii?Q?zKR8sUVG+mBEHRM6mHve0Z5CGQi36DTVCoGbkbyBfJqLxowPkCu/r2iWfwPC?= =?us-ascii?Q?s5tlhW2b7SMVbnHnqIx8kIDB35RLSaH/VIR+bpiaWPPW/JzhoA3K4VyowvjA?= =?us-ascii?Q?DTz0qddIIWl7iKf9reoFAWLcUbdN8L3RTrijY5dSiwxTsIy76m7T+JjnjX9e?= =?us-ascii?Q?YTUkHi6swe1M9DrzQKDaBoJNXs0cpZcWR6rr4ru3fTwq7shvGB6FK2X8lW7r?= =?us-ascii?Q?+zxVllJNrkAgP70JaPCsm8z7fSVjEBxMGgWemPuKHPQcaXaxRkBH2qXM+g1Q?= =?us-ascii?Q?UB+V6EQDj+joT3YKvs/Luy3FdUvLYIWXs5HOOVnfVeaZrCqIrqi17lHs/Cv5?= =?us-ascii?Q?28CRQzq+8tP5uG9GX0YAAbw0ViNGCM8yYuwHRSP2vnsL38GaKCrsWAeZQnU4?= =?us-ascii?Q?cIcgzoJ8YFFbw9R7seRzq1AGaAjzEaRGKebEd4BpTc0vYr3vOTK7258T/fjM?= =?us-ascii?Q?a/c3QHuYjYXRCaquVMDbSqqsm4IizwLcpiU+Odb0TDAJXQhu7uo73HXRNFBu?= =?us-ascii?Q?WglCApaq4h84f1vAMgdQ27tMKVP/YF2Vf2vF91EG8Ynh3YahKBRmUdesjOX9?= =?us-ascii?Q?eMPVQsFWSEc7SRmay0NdsbqvwQtIOqduIbqQ5lnRejoi9uwrtY52rMY36E1h?= =?us-ascii?Q?iPu3mC/Rtllj2qELpUph7gdF6YcVjLpz8pMaDjdfV2Zo9n2Nlb6cWjj4Yype?= =?us-ascii?Q?FQ8p5voH2UbppJkEv4N9jAMGlp1P1MMAssfZkFPQsnXMZH0XQepW5a1/iFXd?= =?us-ascii?Q?WNCF6AdQwjJU6yz/3rNGrWFXGZdllE/JSi9GjNaaitT/VzpcGByAMTwIjE10?= =?us-ascii?Q?WrlDqJYkDTlAfYsNq8GnSUoUnroj8ohqAi5Wk2ht7AKWQcEVAplOilkuim2Y?= =?us-ascii?Q?GcnuDlHtx7JEJS+5o6WhA2dcK7A+SicMQD1RCP3ZKshwEw4l+8L8WX38FfUW?= =?us-ascii?Q?TxBEg9qEG4lPWmx4jb7HrllncMElbhj4Kv0/ti7SAp09OTfeT+TUdjavU3+u?= =?us-ascii?Q?yZSOVDnkGcn8lEmF49/RDOcrQ+Mojq1dNl3F2tfSWbfL9wF3svbfD91js6EP?= =?us-ascii?Q?N6vniSe1CYZBXExaMn66kU3hZ+MCswZNWvBpv5uazgoQpKUr/2LDViPZn+2J?= =?us-ascii?Q?xZsfC8a3dPpzBZvB+CpFpGUt4LhQA6BLsyWlNvkxClx89c2rNKB10Ljsm/jI?= =?us-ascii?Q?RmQqwRplxK9LLIsHhEinGzoIu7Kl2tEKabHfSY2uMmROGmw3Tb15YBetfyfn?= =?us-ascii?Q?LfTIU1jegX4CHrbIFrtw7lq3DQbNMtieuel+HWW+vQs8uA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1lyx3VTbVQyAHru0ozcMuBSCTzqyfrPI3TUUoCcgSCqJGVgwAr3H0KXjyrIK?= =?us-ascii?Q?d1te5M/uxsnrBIZZdJFJLAMmYxieNehET7qh33zByy4FB5bt6noBmN7peMoo?= =?us-ascii?Q?FgGPv4TEqc75VzqMhThua/Q4XzxfYGivJNcs/rsCI7KRSuCjbrpsjRu+WMW7?= =?us-ascii?Q?B5QpdiMYqs7i+IXl/QPCtR2UdaMLFcmyjjI8boatx6HlhmKmEjydkCaKaMm4?= =?us-ascii?Q?ura1IBHCs7hjf3ft6NZ3RzlqZg6XAMYisUlhAGax2DzGcrW3og35kKDq621z?= =?us-ascii?Q?yZSMLhq1VZ5ea61fSiLvCyFou+nz7lAYV1NnG96jCJHMB6wh3NS5VCMl13w9?= =?us-ascii?Q?veeosGgw9Oquc3W+x1NO85rOsieencpuI6kSVaJFHNL017szD9F0ZJLR2bdA?= =?us-ascii?Q?41/UFnBJteGchotrX0rnVVCFUB4p80vkCri+Gx9IKa0QbTEZRJR/Onx/qIfk?= =?us-ascii?Q?iSBpaJxSViitDWmoqqL0BPLoS5Xt9fxHWRDNq9iqexhjfFvbZx8tI0iZHzDP?= =?us-ascii?Q?fy89MvxBtDk5KTImDy8zbk9j1CQtykeU7nY+zdA65fz8y8QxLm8LG7Ozx3+0?= =?us-ascii?Q?S/hNWKjEoGPMWzdVuXu4eZ9dkTDqBTczQpJsey/mhzRMvYmDyDVN+bGSab6G?= =?us-ascii?Q?PXo4YB+iP2VeEnClY9HrJFtp96ZTGLt8UrBt0/lxOqBbA9/IisC9YVK1A2VI?= =?us-ascii?Q?tw2ABg3p4haEzUIufFWmSi/Tc14fLEy8Xcpl5BfPV7SE2z30mNJ86MucN9di?= =?us-ascii?Q?otcw8ewFgE5hE+WLN2VIoSHpX1fzqGhHqJD3aGvVnlEGG8JCb1lBeRNLv8x0?= =?us-ascii?Q?DIFJDPjYh652Kk2RKrX3B7nBsOcakqy4Fy6+gyGRCJQ5aoUItMZz+c6EGxj9?= =?us-ascii?Q?uzBSsbHou5KE5RjJIAP/UlfC0TCkM3UncnQ+7S/1yH+IFqiAAhIeCwPPcpLe?= =?us-ascii?Q?r9by3Hec4dWlpTzWbfCbN4uoehRTKCsrVJHGLOT/xwXktBLPG+BstIInB0Ul?= =?us-ascii?Q?n9CSyG5Kn0K6i4rihiHStmxIo08tG6QRv0YKeNCZjJKCiPozBBfkEUX0BKIj?= =?us-ascii?Q?nGvFhfm0d8OQVexAvY8ieEHSisWGslpOuuQD4E40nNUyW57MbbLBKAUByY6G?= =?us-ascii?Q?+2abfOpgDJR041zGevA/L4fW5CV90JBOsIiHwHbZ6+y8r2zWlNQgmjzA1aoX?= =?us-ascii?Q?Hsq2qIxiKHkMN+nt7K0AJlWRcsL2tjvkmS/7n9LrQ5rGW7+KZ9DlG9vSQngJ?= =?us-ascii?Q?t1Ii8WatOZh2xhKq87UmXYQnfkKDjO66erENW2sXTUmaXfAPJmHqTw1r7kM6?= =?us-ascii?Q?1XrXEWB0CUYGLN1EBi4uMDjL3mxwq+DTjZcZvKv++phXVqbB60MAiq4g6eci?= =?us-ascii?Q?uyDsmt12nqh8sHS/yageViP1qxgr4HkxZHOc3nUiAnPGZEC0l4344c+x+RBx?= =?us-ascii?Q?IQWqRkZsMYF+Ff8HJN61C4n8LK8lygnftZSmuwWkBurN9xY0cfG7aAjfRayP?= =?us-ascii?Q?uCRXL3eyxwMPV0X5ue+cfoOeyg+Pc3VtuBK72iKQ/jbvRyforYKhUO1vGsFi?= =?us-ascii?Q?Q6pqx05km0RhjyNcyp0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b153f6e-3605-4e21-f43d-08dc6fda084b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 03:42:21.2091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UGuBuk7td0l/t3oVzsc0W0OWRCWC+6+uunbtY3kHrtDqlKwsPh84H+v6XrIXa6Px4aW8uO+1olQkJkwIupCQlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7018 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 08 May 2024 20:42:42 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mUXte6lLiumtigMPPNuhPifFx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN0PR11MB61585C075E809B5943BEF78BFEE62MN0PR11MB6158namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="AjL/vtqZ"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN0PR11MB61585C075E809B5943BEF78BFEE62MN0PR11MB6158namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiaxin Wu > af= ter resolve Ray's concern. From: Ni, Ray Sent: Wednesday, May 8, 2024 10:46 AM To: Xie, Yuanhao ; devel@edk2.groups.io Cc: Liming Gao ; Wu, Jiaxin Subject: Re: [PATCH 1/3] StandaloneMmPkg: Add LockBox Dependency DXE Driver +#include [Ray] Can you check if BaseLib is really needed? +#include + +/** + It attempts to install the gEfiLockBoxProtocolGuid protocol into the sys= tem's DXE database + with NULL as the protocol interface to mark the protocol as handled in t= he system or to + act as a trigger. [Ray] "mark the protocol as handled in the system or to act as a trigger", = I don't quite understand it. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118711): https://edk2.groups.io/g/devel/message/118711 Mute This Topic: https://groups.io/mt/105955699/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN0PR11MB61585C075E809B5943BEF78BFEE62MN0PR11MB6158namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com> after resolve Ray’s conc= ern.

 

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Wednesday, May 8, 2024 10:46 AM
To: Xie, Yuanhao <yuanhao.xie@intel.com>; devel@edk2.groups.io=
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Wu, Jiaxin <jiax= in.wu@intel.com>
Subject: Re: [PATCH 1/3] StandaloneMmPkg: Add LockBox Dependency DXE= Driver

 


+#include <Library/BaseLib.h>

 

[Ray] Can you check if B= aseLib is really needed?


+#include <Protocol/LockBox.h>
+
+/**
+  It attempts to install the gEfiLockBoxProtocolGuid protocol into th= e system's DXE database
+  with NULL as the protocol interface to mark the protocol as handled= in the system or to
+  act as a trigger.

[Ray] "mark the pro= tocol as handled in the system or to act as a trigger", I don't quite = understand it.

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118711) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN0PR11MB61585C075E809B5943BEF78BFEE62MN0PR11MB6158namp_--