From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9563A7803E1 for ; Tue, 16 Apr 2024 11:34:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w7lcWnT5vPilnwM/WExwpCXDwyoP+ueXkgDedLDP/Fw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713267248; v=1; b=HMcXJDg/G+oauovJ/gAFfOGY6RuCBcgVQQNFpJKkaQ7r/84SFN0oLEX8emwefxtm00h2LmjO R5rZ1HWi+dn+hsOVIHNm3O5YZtKUk/VBeDuhDCJ8AFFtaLFyOFV7c7/s7mHATdG7CGHAez4a40e ZmzXDsi+VH0Q2KUBlDD03HcCINxA85dCFvcR/xMLz9dmJZKKjhsdAfDabFAMel9aThiDcfVO2yR oa+ujhKGlyA6z/hcO5NvM2i7aHUI6GgBLLZs/vIiVTGKRkwvu9fGHdIQSunSdXTRgBJxB4jyIVj wyG+/h76d9W9yCYdJ0SHyaGAfOUXAfzecsBCvQgvhTgbw== X-Received: by 127.0.0.2 with SMTP id 0Pc0YY7687511xO8MFDFvOG2; Tue, 16 Apr 2024 04:34:08 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web11.18270.1713267246770409438 for ; Tue, 16 Apr 2024 04:34:07 -0700 X-CSE-ConnectionGUID: DdSQsEDzSfuATVe8kblmuQ== X-CSE-MsgGUID: HpMt4OEVRP+DEpoSRFqK9A== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8862015" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="8862015" X-Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 04:34:04 -0700 X-CSE-ConnectionGUID: zW+si4VSQS6uvYg3Zb7/sA== X-CSE-MsgGUID: 1mcA6e+SQdqbamnrzxSUgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="22826960" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 04:34:04 -0700 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 04:34:03 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 04:34:03 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 04:34:03 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by DS0PR11MB7684.namprd11.prod.outlook.com (2603:10b6:8:dd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Tue, 16 Apr 2024 11:34:01 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99%6]) with mapi id 15.20.7452.049; Tue, 16 Apr 2024 11:34:01 +0000 From: "Wu, Jiaxin" To: Gerd Hoffmann CC: "thomas.lendacky@amd.com" , "devel@edk2.groups.io" , "Ni, Ray" , "Zeng, Star" , Ard Biesheuvel , "Yao, Jiewen" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v1 03/13] UefiCpuPkg/SmmRelocationLib: Add library instance for OVMF Thread-Topic: [PATCH v1 03/13] UefiCpuPkg/SmmRelocationLib: Add library instance for OVMF Thread-Index: AQHai99oFIlHXkFAQ0+HiVjxVR3nL7FpUJEwgAE4/gCAACrqMIAABeoAgAAPJpA= Date: Tue, 16 Apr 2024 11:34:00 +0000 Message-ID: References: <20240410135724.15344-1-jiaxin.wu@intel.com> <20240410135724.15344-4-jiaxin.wu@intel.com> <2kd4qwvgbbn4mhlagidemtwfr3uzdgokrf5t3ttsileexkgenf@lmcby5lxm7xs> In-Reply-To: <2kd4qwvgbbn4mhlagidemtwfr3uzdgokrf5t3ttsileexkgenf@lmcby5lxm7xs> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|DS0PR11MB7684:EE_ x-ms-office365-filtering-correlation-id: 9440be45-effa-4540-33de-08dc5e091cba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: WX8AHoWSUef326J2yr0wBfcYTSZ0w2t/1XCyx/ubFTvvKs0s8SOBL5WEjV9+B0MBl5DtfFnnNsq4j/asaoWnEDlyIKUiU5dult8AaIdJJgTGv/jfDQ7COLElOpAYQuIne6PA3hnU7KQoylzMUam2gwqdjQdDjnRFBZ8sgWDVjJGn4ENTGf2ho+XpIJX4zmwNZhFqXtJ8FowBVl1dO5s64JWCty3jyrJCZaNGhrAWSurnwKAbRY4147MFT6jBw5uzkrVDjy0YCexBwB2XG+QEYlvefuxUj8ty1XHrbPjR1dLkvTFgCRp0r+GkJJjdSd5BZUnNItFg/SlHN2efC/tAu9V76BTtTn3JwXa4trkDBGkFw8egUmzCF4Kd/xUm/XAG7dCXTV6RskhkbpZrjdQdRSjMp4ZJGzIU9DTHcU0l24kt7m427tEd8dOvpfKnIj8lj/a1XIL1j9wL7cm+XVOsiIEw6dCFkrNT55SXwkVkn017TS7dWZdjM5gIKT6tVgBTmty2ZXuO1TEpz14U+3G1OR6D/TTp62bcA8DRpHwh3kIMqwZB7c564g2oXJ/4UPPhqnvuyTSNlj4CQKgbJDLR/7HSBNzs+qqFynfvd2DRpOZM1+yJKS473jvNR+JrMF2EPCvrPqwFNTStlaq82Xl56/XlJlS3600x3nDbNvOUfAjT0/2mfyXjLwue8fbsVNl1Tgy4LCzHMHFsDSY6YoTJKfsusd40AJZDRcNsx3ZMEkg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6dGwojaBojTwNuUJ9J2auwXsRW4efLdykwzCxKA157o8JGcKgfQ5iszNulbE?= =?us-ascii?Q?oBoFuzJI5i6Y1CxGL7KF2DFfGmjopC58yb8hN/y2uKElQDxrmfOP/HOy/Y4L?= =?us-ascii?Q?jaMwUBREj8B8SCX4EF4bCadq6Xlbazc2t6DzW0KxcTMDvwzLTC9ms8My/VXi?= =?us-ascii?Q?RTCFV861nZT7tsQmbYo0A5/63AGTwSOhwN0zltYnyc9d1t0uKCPMCBREU3jE?= =?us-ascii?Q?2kJOMvpD7ELB89SWH3ZsYXhMXtYEyUwicXqN1vv3PyVR2bBpvfjIjBxxDjob?= =?us-ascii?Q?81o+znNg7gnTXRViS3QYuYh6Dwet+T6xOinyG9+jvctQ8WQyjlJCpGoMaK32?= =?us-ascii?Q?a6szwxmrLiK8R+IIQQX5Qhw64Q7T+sNbaCwDttFUifXVco8dDFKfvO16nLlv?= =?us-ascii?Q?OfOa6ZsNwIqXWN0nnJwCP3oYnQGJ7A22YUb7bE0Wm/wNTTtKK39+Cqponhwt?= =?us-ascii?Q?9Z4Wu45n4j/7Mwv7MNYSuvrcMeKOBYGt3F6K74Ts+AKaWC3fgEOfMIs1EuOR?= =?us-ascii?Q?fnX6K7CWeNxQorhv2sOBPBS6a7/NRREnw+WgVn4jf7HC4ghXNN4As2CjX5Wf?= =?us-ascii?Q?ODuvScpRjTbIDfXmf+ujsNIZkfDo6g38GjeHTzTprqtvNdkWE2xuiuO2z7Qb?= =?us-ascii?Q?xfMjKedBn9wKV5pJmc2wdmFG3lD8dekDJKUAjiaGNsRfIV822PgR0OPNPIWw?= =?us-ascii?Q?XLApJZbDMEZ5e5JnC+XVIgxqECF6SZ5QwH+3Hc1jYg0YG1FJ/L5/lQViKI/9?= =?us-ascii?Q?zDiKOm2j0ZqYknVM67PdTx74eHWjamHMpkL5+SyfySGB0l5oAuVu1hoX25Ee?= =?us-ascii?Q?Ueb/17MhQu+IqGsfWKPUchU7Yd76WJ0ylq58GnfbVXv1UJdUL5ZFV2aC6Gsg?= =?us-ascii?Q?LGqbXFpJZxcDaLPQKO4UFhBRgxN1mvLLoNvff9wKZKNeuztbHKcEnvG9t9Uz?= =?us-ascii?Q?ydLm6ddAZ1QNrHwqQHNF4S/kywA6tiNHR0DOZgI48pI4heipcT2P8kaJPWVs?= =?us-ascii?Q?zkik92ydVlrp1hyWEc7ugHFr5pZYR4osNr/iGNhUFi9cGzNifaZ/s+EI0Lgm?= =?us-ascii?Q?95zkM0mxVLFCuNG8rHfI/MB+Ll/TxepoYQKrKSBhHXM+IZ8yIRNJKDiCXad0?= =?us-ascii?Q?7Tqb1wEadGVQXlHc7JZCBnPMnjnCWXMFnIl6565atu+4rtYPKjdV5DpvFY63?= =?us-ascii?Q?wFdnqagqnxkCnL5VKpBT36PUyeo9rB0esoY9LpFSzRnGPb1tGoTtTR/KBDsj?= =?us-ascii?Q?QJSyBP8O3JWFVkfdqxlrkNarXZk7FEeSNDa6JdMMyx3kVo1PnY+FEbCJsrGh?= =?us-ascii?Q?zN3Asw07oQwHWLFTK3tJavM4lEpN28C/6TRe5FvWPuHHKtMdn6gIcf0pGgXp?= =?us-ascii?Q?l9Izi+CPFaEMeT9LSAaV82YkHkcoMNTo5y86+Yjv4D3Gx7Asm3rjRAtLlDV5?= =?us-ascii?Q?XI+bhIEl1txhYLIZdZEnsC171g5HVOduIyg0XmTw2UKqhlH+Jv1ZOdDoYs7s?= =?us-ascii?Q?iur8XieOFNIQh+WvDc/5VFKYOl4tOtj/2xygj4tLklelvbHX9n3FPXvzMmZs?= =?us-ascii?Q?I26VtHQ2+079Zr95LQToiSOMNKC/J3u8pvuiBybX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9440be45-effa-4540-33de-08dc5e091cba X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 11:34:00.9197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kdR9fLcBj64iqg+B+zksjqBn++5GdB/WFPmcGlqpYELAopjRcY5PuRHRIZZn0V7Qq68ceOMZy/z7CteOCOOpOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7684 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 04:34:07 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: abP1XmEk2ngHG6aZfUZAzRnbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="HMcXJDg/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Gerd, > > I don't the background why AMD and OVMF has such difference. Maybe > OVFM doesn't not support the MSR "EFER_ADDRESS". >=20 > It surely does, it's a rather essential MSR for x64 CPUs. >=20 > > > The SmBase configuration for OVMF looks suspicious to me. I'm > wondering > > > whenever the OVMF code actually works in Ia32 builds ... >=20 > Tested OvmfPkg/OvmfPkgIa32.dsc with SMM_REQUIRE =3D=3D TRUE (master > branch). > Doesn't boot. The difference above (where the OVMF code does not > consider the 32bit case) could very well explain why 32bit support is > broken. Switching to the AMD code might actually fix that. >=20 > Is the SmmRelocationLib approach supposed to work with mixed mode > firmware where PEI is running in ia32 mode and dxe/smm is running > in x64 mode (i.e. OvmfPkg/OvmfPkgIa32X64.dsc)? >=20 Yes, I passed the test on the both OvmfPkgIa32X64 & OvmfPkgX64 for SMM supp= ort. It does has the problem on OvmfPkgIa32 for smm support (same as master). I = did quick check, it's not only the CpuSaveState->x86 or CpuSaveState->x64 s= tructure issue, but also has some problem to handler the smi hook return. W= e can handle this problem in another topic.=20 Thanks, Jiaxin =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117878): https://edk2.groups.io/g/devel/message/117878 Mute This Topic: https://groups.io/mt/105441992/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-