From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 445EB941047 for ; Fri, 19 Apr 2024 03:55:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y3CbywsJzhKmbte0G/WHCXcm4F45jv//oFFIjETdq2g=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1713498925; v=1; b=M6iDAj5kFRDrNpew4DrFf9d9lkTJ9BJY5WzwEr0uQJIU7N/QhwuGGX2m7yoKsIt8foccb3iD MKpw+xBAwUU4DVwF45ftc1ORCg4eX/5IwnGdkxGN3HdG4SCgb95r9rpwySTXNNq+wZovNISsqsF e/HXo2fISUoHnAS0Z6TuJQgkES0ld8dxRvEV/7W/b5rxxaa9H9vOwSrBcSbXL9arLBzg4j6QcmT jebS96cRta9r/XGRuV+wdrwJUtPyluWhwJFFOnAiw98mSuhD2j4AnIYDQ+bVRsMKf8WUKKbqPJr U3DsS46I7TGO3SCvG20PcCihP/cjIIG/u+csMX74O7RtA== X-Received: by 127.0.0.2 with SMTP id i9wuYY7687511xogOd7fE04Z; Thu, 18 Apr 2024 20:55:25 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mx.groups.io with SMTP id smtpd.web10.12370.1713498924691157322 for ; Thu, 18 Apr 2024 20:55:24 -0700 X-CSE-ConnectionGUID: Y4mM6A2YSya49N2RFuSQNQ== X-CSE-MsgGUID: P9E6uCWlS6ap2wN5kR9ooA== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="9009323" X-IronPort-AV: E=Sophos;i="6.07,213,1708416000"; d="scan'208,217";a="9009323" X-Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 20:55:24 -0700 X-CSE-ConnectionGUID: /5ogyAokSK6Lovvsnip79g== X-CSE-MsgGUID: /QjrFoULTv2uwm3lJ3D37Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,213,1708416000"; d="scan'208,217";a="23648148" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Apr 2024 20:55:24 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Apr 2024 20:55:23 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Apr 2024 20:55:23 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Apr 2024 20:55:23 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 20:55:22 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by PH7PR11MB8480.namprd11.prod.outlook.com (2603:10b6:510:2fe::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.43; Fri, 19 Apr 2024 03:55:14 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99%6]) with mapi id 15.20.7472.037; Fri, 19 Apr 2024 03:55:14 +0000 From: "Wu, Jiaxin" To: "Chang, Abner" , "Ni, Ray" , "devel@edk2.groups.io" CC: "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Ard Biesheuvel , "Yao, Jiewen" , "Attar, AbdulLateef (Abdul Lateef)" , "Lendacky, Thomas" Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Thread-Topic: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Thread-Index: AQHakV2GkVjeKzZueEqpL2F3/efgwrFtqtmAgAFHVDCAAAOH34AAAcKA Date: Fri, 19 Apr 2024 03:55:14 +0000 Message-ID: References: <17C74D78B0B952AD.15491@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-19T03:46:53.2068797Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|PH7PR11MB8480:EE_ x-ms-office365-filtering-correlation-id: 8ee399ce-9cff-4ebc-7e82-08dc6024851a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: PqnRPQMj/XIbaBAlz9hjwhYITscyPPOxArdNjEKTUQRh4JjPlmGFWkPPYgJkVSvCjVj0jJocqkU0xin9yEWQGrrzMYabD4upc3eZtUZwRefKXqS0WnZurUtqE558BKZ3Y8MHb/GkKEhx7SiI5muu/G2CsY6Mcy2uAQjiLKPgQnPsjO8TjkH2oCv+jwc5AMLIWzUgnv2C/xxiuffbkBQhqdBhix3vdKbgMPS0/owImfWEIIcsRB8oUuJPbt3egzUT98fVaZoeb+k5+zgmYC5SXqR40/D7iKnV05gmcrNJNgQWc0niKKcnHL0/y2Gtm0bAMfaZNcD4LKHjZW0AO9Mre6zvvyfO4JBOzwjZI5hHPJj0XvZgQOmLR3e3krRiTdj+lGteEC856I+1avgkeOw8SNBKAegn+JSRqRUrRQdP40txSvXumPinIka2RT46wG5yU93kq157JXH6gtdRQGWX4+NkViZpxbw7/Eb4Cph3dICjCDpbH8kZu214colbddAGIo2QnG8zImFwP+1FoS0zfmLsb73s87bn1BZVoGdVTLKK1AZMwFFcbx+7nNwJ2nCQp1XwFjV8bc4ymsvyM9JRSKexNds7n8jDb2t/z90pr/6J5WGe9LsEImZXxRmy9+Im6HfR1lXCkCTT389H4uGF4dPq56OhbOUnXM9EkY2W/6cx/pBXEtboFOFIer+C8VkQpRkQD+YX0ITS6CzghlPHK07+uWZZUWIQkZR26N1A+7k= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s5NqkHX7OQm1VJL/C5lSYpIN4USRW+fIT4qJAk+a3AksEPRDM+2SV4zCn4ZK?= =?us-ascii?Q?C784Qf29Yoz7t7k52i7qZjcxJgQA4mpNlstFXQiWRF1EyGUgNWd/d/Rt0UIW?= =?us-ascii?Q?3mYPd6HEEegp4FI7DG3l63jQy1rwkTvxeWK6VgX4pBRq8/r8Mav3iq3ySJYj?= =?us-ascii?Q?Y+b4J7KMuR7IyZEMh0jk/1e1ZHlbEsDxY5bdGP1/O9D98caqe6hliSevv4x6?= =?us-ascii?Q?n++x9f1RjatKJ8EiDRuLa30UaQBD6KxKZmKZWakwU1ejOCFo8SNP+G8eDWs/?= =?us-ascii?Q?Z8pHsZXIWlSVIAnpsq6iMvx60hWIhRcSXUdYDxW8JlrbLtAjuGHA+xtX3a3Z?= =?us-ascii?Q?3YegATPp9BKRx3P1N3aC9yiI8dASKMyRHw6urwL4qoOYSu4acFeP97rJzJaz?= =?us-ascii?Q?DX9ZF5BEJfEZe15aCVrtnuY0fd+6K60XO2qSnhsRHZbV7foeyFoh6IcEzggH?= =?us-ascii?Q?TWHO/wiirUHa3Mojf/h60xu24L5wU7r6dvQcy2KM4SSxzxhNfGFcCZigh0DD?= =?us-ascii?Q?2STPs4L+aALHNREnMpzGIvC0rxTKtL6+FsO60lwYvV5PIixi8F6QqF3mZfXX?= =?us-ascii?Q?YY+QtyGRK5+F+NiJF63QG1p8Gq5orl9XwjPrGMPNMs2E+Iu5AJMnH2HfHFw8?= =?us-ascii?Q?/7lLGQybIqssuTLraiPoVLsbb/ezF5gMh6NR+Pvmiryr2Ku+3o+foQF2OPl7?= =?us-ascii?Q?81yVHOP+G013y+pMyj7P1N31tbvdnHeuqlq5p0N4zTSq/a2jbZ+dVyicSWhk?= =?us-ascii?Q?R0ch61MGPY6fZabLsVx+5QNmmNGwza/sACsDo4sXvDek/DGFVDaIxhwfuimY?= =?us-ascii?Q?/GbM0E/0/BhAizAlmqUbwdbSGFMGBO9wrvxusaKJMuhMw+JIflr0sxYGKQLv?= =?us-ascii?Q?Pni/ralDMVTFi2XBMSsW/wcQgJ2uvOlGr1x+Y+OEg4JWQMn7nNNTa4rGw5T7?= =?us-ascii?Q?BiCEtXgoVF2UebJ5VCmPoTljk5YS2+GweZ2AhtNOCvWATt56x0DfaINV/5q2?= =?us-ascii?Q?COLUWjTD2KjlLpN29TPYSdShD6LiKDGtoCLHCceFwLXvBzl6VSy+759+G4Jb?= =?us-ascii?Q?DmYj1WecwyEKzupsszqS25zBf/UXSoTr0fbdsnlNqMi9cgNHnY0fFSNPloId?= =?us-ascii?Q?EDcHr5sXFe0ZzuAWHLPt8JU5AUa2Uh+/ERSCPC4J17Y2qjELT9+zRK77KHtF?= =?us-ascii?Q?Lv40kMkzhBBgRqZppqIHuAMkqPF51yL51XjL+biBBmv1+OvL6LstsobXgbwl?= =?us-ascii?Q?Fs0mrLorZayMQictjih2RQmrDor1tw7MBFLf6P90xeene+tkkvckeGNUpimd?= =?us-ascii?Q?wrq2kzBks1RtTy6SnXtIcXTBWPM/pDSOI/ArYuor7S7sLhB2dFpD8JijLStU?= =?us-ascii?Q?a5HxpzMlqqoU3ge4v1iC/Etlj3F8OCmZW+pA4e03zTv0P0vH6JrS8JrTQvfg?= =?us-ascii?Q?Ifx2HomWC39ehaSpy18mWo4yoXK3zEeS4UGwqiab56caV8PQReI9VEzPSeSG?= =?us-ascii?Q?MtO7Hz0tpEt7bey+Vufnt5ub3kqwwrVZnSIC7r7YR2KDa4WJZD7AvL0iHSyt?= =?us-ascii?Q?N823m9/p4qb6tC2339V0//VgltiLNXwj8FpIkhCT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee399ce-9cff-4ebc-7e82-08dc6024851a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2024 03:55:14.7830 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7O2JV9nYrTD0Xrv32IIUpHE6xs004mC1oz2MVVouSdBxV7BBMf/mRT2HHS2bDWAsDeFQyP8FSsDDi7Qn7P+9bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8480 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 18 Apr 2024 20:55:24 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Fvx9VvZ05WtjeSu58AqbjiTox7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN0PR11MB61586636A957FFB8611ED931FE0D2MN0PR11MB6158namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=M6iDAj5k; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN0PR11MB61586636A957FFB8611ED931FE0D2MN0PR11MB6158namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oh, sorry, I missed the that email. If so, that's great! Thanks Ray & Abner= & Abdul. From: Chang, Abner Sent: Friday, April 19, 2024 11:47 AM To: Ni, Ray ; Wu, Jiaxin ; devel@edk= 2.groups.io Cc: Zeng, Star ; Gerd Hoffmann ; Ku= mar, Rahul R ; Dong, Guo ; Rho= des, Sean ; Lu, James ; Guo, Gua= ; Ard Biesheuvel ; Yao, Jiew= en ; Attar, AbdulLateef (Abdul Lateef) ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib [AMD Official Use Only - General] Right, Abdul's RB is sufficient! Thanks Abner ________________________________ From: Ni, Ray > Sent: Friday, April 19, 2024 11:35:17 AM To: Wu, Jiaxin >; devel@edk= 2.groups.io > Cc: Zeng, Star >; Gerd Hoff= mann >; Kumar, Rahul R >; Dong, Guo >; Rhodes, Sean >; Lu, James >; Guo, Gua >; Ard Bie= sheuvel >; Yao,= Jiewen >; Attar, AbdulLa= teef (Abdul Lateef) >; Chang, Abner >; Len= dacky, Thomas > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Jiaxin, I see Abdul from AMD has given R-B. I assume that's sufficient for merging = this patch. Thanks, Ray ________________________________ From: Wu, Jiaxin > Sent: Thursday, April 18, 2024 16:03 To: devel@edk2.groups.io >; Wu, Jiaxin > Cc: Ni, Ray >; Zeng, Star >; Gerd Hoffmann >; Kumar, Rahul R >; Dong, Guo >; Rhodes, Sean >; Lu, James >; Guo, Gua <= gua.guo@intel.com>; Ard Biesheuvel >; Yao, Jiewen >; Abdul Lateef Attar >; Abner Chang >; Tom Lendacky > Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Hi Tom & Abner, Could you help check & review AMD related patch? > UefiCpuPkg/SmmRelocationLib: Add library instance for AMD Thanks, Jiaxin > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Wu, > Jiaxin > Sent: Thursday, April 18, 2024 2:56 PM > To: devel@edk2.groups.io > Cc: Ni, Ray >; Zeng, Star >; Gerd > Hoffmann >; Kumar, Rahul R >; > Dong, Guo >; Rhodes, Sean <= sean@starlabs.systems>; > Lu, James >; Guo, Gua >; Ard > Biesheuvel >;= Yao, Jiewen > >; Abdul Lateef Attar <= AbdulLateef.Attar@amd.com>; > Abner Chang >; Tom Lendac= ky > > > Subject: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > PR: https://github.com/tianocore/edk2/pull/5546 > > Intel plans to separate the smbase relocation logic from > PiSmmCpuDxeSmm driver, and the related behavior will be > moved to the new interface defined by the SmmRelocationLib > class. > > The SmmRelocationLib class provides the SmmRelocationInit() > interface for platform to do the smbase relocation, which > shall provide below 2 functionalities: > 1. Relocate smbases for each processor. > 2. Create the gSmmBaseHobGuid HOB. > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > a later phase) can be simplfied as below for SMM init: > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > for each Processor. > 2. Execute the early SMM Init. > > Cc: Ray Ni > > Cc: Zeng Star > > Cc: Gerd Hoffmann > > Cc: Rahul Kumar > > Cc: Guo Dong > > Cc: Sean Rhodes > > Cc: James Lu > > Cc: Gua Guo > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Abdul Lateef Attar > > Cc: Abner Chang > > Cc: Tom Lendacky = > > Signed-off-by: Jiaxin Wu = > > > Jiaxin Wu (13): > UefiCpuPkg: Add SmmRelocationLib class > UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance > UefiCpuPkg/SmmRelocationLib: Rename global variables > UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation > UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable > UefiCpuPkg/SmmRelocationLib: Add library instance for AMD > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > OvmfPkg: Refine SmmAccess implementation > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not > OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib > UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 104 ++-- > .../Library/PlatformInitLib/PlatformInitLib.inf | 6 +- > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 33 +- > .../Library/SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > +++++++++++++++++++++ > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 60 +++ > .../SmmRelocationLib/SmramSaveStateConfig.c | 100 ++++ > .../Library/SmmRelocationLib}/X64/Semaphore.c | 13 +- > .../Library/SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/PlatformPei/Platform.c | 3 + > OvmfPkg/PlatformPei/Platform.h | 5 + > OvmfPkg/PlatformPei/PlatformPei.inf | 5 +- > OvmfPkg/PlatformPei/SmmRelocation.c | 80 +++ > OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 4 +- > OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 5 + > OvmfPkg/SmmAccess/SmmAccessPei.c | 88 +--- > OvmfPkg/SmmAccess/SmmAccessPei.inf | 7 +- > OvmfPkg/SmmAccess/SmramInternal.c | 73 +-- > OvmfPkg/SmmAccess/SmramInternal.h | 18 +- > UefiCpuPkg/Include/Library/SmmRelocationLib.h | 42 ++ > .../SmmRelocationLib/AmdSmmRelocationLib.inf | 60 +++ > .../SmmRelocationLib/AmdSmramSaveStateConfig.c | 125 +++++ > .../SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > .../SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > +++++++++++++++++++++ > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 61 +++ > .../SmmRelocationLib/SmramSaveStateConfig.c | 136 +++++ > .../SmmRelocationLib}/X64/Semaphore.c | 13 +- > .../SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 21 +- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 331 ++----------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 103 +--- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 - > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 69 --- > UefiCpuPkg/UefiCpuPkg.dec | 3 + > UefiCpuPkg/UefiCpuPkg.dsc | 2 + > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 + > 48 files changed, 2514 insertions(+), 794 deletions(-) > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/X64/Semaphore.c (78%) > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c > create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib.inf > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateConfig.c > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/X64/Semaphore.c (78%) > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > > -- > 2.16.2.windows.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118005): https://edk2.groups.io/g/devel/message/118005 Mute This Topic: https://groups.io/mt/105593568/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN0PR11MB61586636A957FFB8611ED931FE0D2MN0PR11MB6158namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Oh, sorry, I missed the that email. If so, that̵= 7;s great! Thanks Ray & Abner & Abdul.

 

 

From: Chang, Abner <Abner.Chang@amd.com>= ;
Sent: Friday, April 19, 2024 11:47 AM
To: Ni, Ray <ray.ni@intel.com>; Wu, Jiaxin <jiaxin.wu@intel= .com>; devel@edk2.groups.io
Cc: Zeng, Star <star.zeng@intel.com>; Gerd Hoffmann <kraxel= @redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo = <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu,= James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@i= ntel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.c= om>; Lendacky, Thomas <Thomas.Lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib=

 

[AMD Official Use Only - General]

 

Right, Abdul's RB is sufficient!

 

 

Thanks

Abner

From: Ni, Ray <ray= .ni@intel.com>
Sent: Friday, April 19, 2024 11:35:17 AM
To: Wu, Jiaxin <jiaxin.wu@= intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Zeng, Star <star.zeng@= intel.com>; Gerd Hoffmann <k= raxel@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo <guo.dong@intel.com>; Rhod= es, Sean <sean@starlabs.systems= >; Lu, James <james.lu@inte= l.com>; Guo, Gua <gua.guo@in= tel.com>; Ard Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Attar, AbdulLateef (Abdul Lateef) <<= a href=3D"mailto:AbdulLateef.Attar@amd.com">AbdulLateef.Attar@amd.com&g= t;; Chang, Abner <Abner.Chang@amd.co= m>; Lendacky, Thomas <= Thomas.Lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Jiaxin,

I see Abdul from AMD has given R-B. I assume that's suffic= ient for merging this patch.

 

Thanks,

Ray

From: Wu, Jiaxin <jiaxin.wu@intel.com>
Sent: Thursday, April 18, 2024 16:03
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Wu, Jiaxin <jiaxin.wu@intel.com>
Cc: Ni, Ray <ray.ni@intel.com= >; Zeng, Star <star.zeng@i= ntel.com>; Gerd Hoffmann <kr= axel@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo <guo.dong@intel.com= >; Rhodes, Sean <sean@starla= bs.systems>; Lu, James <jam= es.lu@intel.com>; Guo, Gua <= gua.guo@intel.com>; Ard Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Abner Chang <abner.chang@amd.com= >; Tom Lendacky <thoma= s.lendacky@amd.com>
Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

 

Hi Tom & Abner,
Could you help check & review AMD related patch?
 >   UefiCpuPkg/SmmRelocationLib: Add library instance fo= r AMD

Thanks,
Jiaxin

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Wu,
> Jiaxin
> Sent: Thursday, April 18, 2024 2:56 PM
> To: devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Zeng, Star <star.zeng@int= el.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Kumar, Rahul R <rahul.= r.kumar@intel.com>;
> Dong, Guo <guo.dong@intel.com= >; Rhodes, Sean <sean@st= arlabs.systems>;
> Lu, James <james.lu@intel.com= >; Guo, Gua <gua.guo@intel.c= om>; Ard
> Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com&g= t;; Abdul Lateef Attar <Abd= ulLateef.Attar@amd.com>;
> Abner Chang <abner.chang@amd= .com>; Tom Lendacky
> <thomas.lendacky@amd.com= >
> Subject: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib
>
> PR: https://gi= thub.com/tianocore/edk2/pull/5546
>
> Intel plans to separate the smbase relocation logic from
> PiSmmCpuDxeSmm driver, and the related behavior will be
> moved to the new interface defined by the SmmRelocationLib
> class.
>
> The SmmRelocationLib class provides the SmmRelocationInit()
> interface for platform to do the smbase relocation, which
> shall provide below 2 functionalities:
> 1. Relocate smbases for each processor.
> 2. Create the gSmmBaseHobGuid HOB.
>
> With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at
> a later phase) can be simplfied as below for SMM init:
> 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases
> for each Processor.
> 2. Execute the early SMM Init.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zeng Star <star.zeng@int= el.com>
> Cc: Gerd Hoffmann <kraxel@redh= at.com>
> Cc: Rahul Kumar <rahul1.k= umar@intel.com>
> Cc: Guo Dong <guo.dong@intel.= com>
> Cc: Sean Rhodes <sean@star= labs.systems>
> Cc: James Lu <james.lu@intel.= com>
> Cc: Gua Guo <gua.guo@intel.com= >
> Cc: Ard Biesheuvel <ar= db+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@= intel.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Abner Chang <abner.chang= @amd.com>
> Cc: Tom Lendacky <thomas= .lendacky@amd.com>
> Signed-off-by: Jiaxin Wu <ji= axin.wu@intel.com>
>
> Jiaxin Wu (13):
>   UefiCpuPkg: Add SmmRelocationLib class
>   UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library = instance
>   UefiCpuPkg/SmmRelocationLib: Rename global variables
>   UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allo= cation
>   UefiCpuPkg/SmmRelocationLib: Remove unnecessary global var= iable
>   UefiCpuPkg/SmmRelocationLib: Add library instance for AMD<= br> >   OvmfPkg/SmmRelocationLib: Add library instance for OVMF >   OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid
>   OvmfPkg: Refine SmmAccess implementation
>   OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done= or not
>   OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
>   UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLi= b
>   UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic=
>
>  OvmfPkg/AmdSev/AmdSevX64.dsc      =             &nb= sp;    |   1 +
>  OvmfPkg/CloudHv/CloudHvX64.dsc     &nbs= p;            &= nbsp;  |   1 +
>  OvmfPkg/Library/PlatformInitLib/MemDetect.c   &nb= sp;    | 104 ++--
>  .../Library/PlatformInitLib/PlatformInitLib.inf   = ; |   6 +-
>  .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c  |  = 33 +-
>  .../Library/SmmRelocationLib}/Ia32/Semaphore.c   =   |  13 +-
>  .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm   = ; |  83 +++-
>  .../SmmRelocationLib/InternalSmmRelocationLib.h   = ; | 127 +++++
>  .../Library/SmmRelocationLib/SmmRelocationLib.c   = ; | 549
> +++++++++++++++++++++
>  .../Library/SmmRelocationLib/SmmRelocationLib.inf  |  = 60 +++
>  .../SmmRelocationLib/SmramSaveStateConfig.c   &nb= sp;    | 100 ++++
>  .../Library/SmmRelocationLib}/X64/Semaphore.c   &= nbsp;  |  13 +-
>  .../Library/SmmRelocationLib}/X64/SmmInit.nasm   =   |  85 +++-
>  OvmfPkg/Microvm/MicrovmX64.dsc     &nbs= p;            &= nbsp;  |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc       = ;            &n= bsp;        |   1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc      &n= bsp;            = ;      |   1 +
>  OvmfPkg/OvmfPkgX64.dsc       =             &nb= sp;         |   1 +
>  OvmfPkg/PlatformPei/Platform.c     &nbs= p;            &= nbsp;  |   3 +
>  OvmfPkg/PlatformPei/Platform.h     &nbs= p;            &= nbsp;  |   5 +
>  OvmfPkg/PlatformPei/PlatformPei.inf     = ;           |  = 5 +-
>  OvmfPkg/PlatformPei/SmmRelocation.c     = ;           |  80 ++= +
>  OvmfPkg/SmmAccess/SmmAccess2Dxe.c     &= nbsp;            |&n= bsp;  4 +-
>  OvmfPkg/SmmAccess/SmmAccess2Dxe.inf     = ;           |  = 5 +
>  OvmfPkg/SmmAccess/SmmAccessPei.c     &n= bsp;            = ; |  88 +---
>  OvmfPkg/SmmAccess/SmmAccessPei.inf     =             | &= nbsp; 7 +-
>  OvmfPkg/SmmAccess/SmramInternal.c     &= nbsp;            |&n= bsp; 73 +--
>  OvmfPkg/SmmAccess/SmramInternal.h     &= nbsp;            |&n= bsp; 18 +-
>  UefiCpuPkg/Include/Library/SmmRelocationLib.h   &= nbsp;  |  42 ++
>  .../SmmRelocationLib/AmdSmmRelocationLib.inf   &n= bsp;   |  60 +++
>  .../SmmRelocationLib/AmdSmramSaveStateConfig.c   =   | 125 +++++
>  .../SmmRelocationLib}/Ia32/Semaphore.c    &n= bsp;        |  13 +-
>  .../SmmRelocationLib}/Ia32/SmmInit.nasm    &= nbsp;       |  83 +++-
>  .../SmmRelocationLib/InternalSmmRelocationLib.h   = ; | 127 +++++
>  .../Library/SmmRelocationLib/SmmRelocationLib.c   = ; | 549
> +++++++++++++++++++++
>  .../Library/SmmRelocationLib/SmmRelocationLib.inf  |  = 61 +++
>  .../SmmRelocationLib/SmramSaveStateConfig.c   &nb= sp;    | 136 +++++
>  .../SmmRelocationLib}/X64/Semaphore.c    &nb= sp;         |  13 +-
>  .../SmmRelocationLib}/X64/SmmInit.nasm    &n= bsp;        |  85 +++-
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c     &= nbsp;            |&n= bsp; 21 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c    &nb= sp;         |  10 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c   &nbs= p;     | 331 ++-----------
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h   &nbs= p;     | 103 +---
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf   &n= bsp;   |   4 -
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h    &nb= sp;         |   2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c   &nbs= p;     |  69 ---
>  UefiCpuPkg/UefiCpuPkg.dec      &nb= sp;            =        |   3 +
>  UefiCpuPkg/UefiCpuPkg.dsc      &nb= sp;            =        |   2 +
>  UefiPayloadPkg/UefiPayloadPkg.dsc     &= nbsp;            |&n= bsp;  2 +
>  48 files changed, 2514 insertions(+), 794 deletions(-)
>  copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D>
> OvmfPkg/Library/SmmRelocationLib}/Ia32/Semaphore.c (71%)
>  copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D>
> OvmfPkg/Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%)
>  create mode 100644
> OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h
>  create mode 100644
> OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c
>  create mode 100644
> OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf
>  create mode 100644
> OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c
>  copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D>
> OvmfPkg/Library/SmmRelocationLib}/X64/Semaphore.c (78%)
>  copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D>
> OvmfPkg/Library/SmmRelocationLib}/X64/SmmInit.nasm (59%)
>  create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c
>  create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h=
>  create mode 100644
> UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib.inf
>  create mode 100644
> UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateConfig.c
>  rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D>
> Library/SmmRelocationLib}/Ia32/Semaphore.c (71%)
>  rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D>
> Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%)
>  create mode 100644
> UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h
>  create mode 100644
> UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c
>  create mode 100644
> UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.inf
>  create mode 100644
> UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c
>  rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D>
> Library/SmmRelocationLib}/X64/Semaphore.c (78%)
>  rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D>
> Library/SmmRelocationLib}/X64/SmmInit.nasm (59%)
>
> --
> 2.16.2.windows.1
>
>
>
>
>

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118005) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN0PR11MB61586636A957FFB8611ED931FE0D2MN0PR11MB6158namp_--