From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6A3D5D80CA0 for ; Wed, 15 Nov 2023 11:30:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GsABVL81P+V7wi1Bi0ZuFxmLVu+yt5tRC3dS8hJ0bh8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700047814; v=1; b=iD5W7eO1LXC12dWoZKuW8/eqH1VlemDAONUt9QgUj8NU+WGrWa52Wgs3YW4c+IymWpBCFWDU cc0d3PIadUnO8G/mnlg+2fp6eHHJaENqOk1F2xfnF3uFd8C0ErI/l2Kp7c/xK94jVh5xY97FBy4 kV/JClmCfeQKC9PJJXrU4efQ= X-Received: by 127.0.0.2 with SMTP id K3hxYY7687511x878Ca0JSvo; Wed, 15 Nov 2023 03:30:14 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.10979.1700047812541918502 for ; Wed, 15 Nov 2023 03:30:13 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="3975333" X-IronPort-AV: E=Sophos;i="6.03,304,1694761200"; d="scan'208";a="3975333" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 03:30:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="835367409" X-IronPort-AV: E=Sophos;i="6.03,304,1694761200"; d="scan'208";a="835367409" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2023 03:30:11 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 15 Nov 2023 03:30:11 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 15 Nov 2023 03:30:10 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 15 Nov 2023 03:30:10 -0800 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 15 Nov 2023 03:30:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRv3RSVV9S4tJcSmt75jiTx024/dMkiwkkSjBwXShc/hmAmgS3Eibbt80rCU0CvpdfxB8Oi7L4Gx7XGXPLgYLVCGac5PpKhQGCByuyAR/CQUfb7enQd0fFVFuCjEhI3qRjHpOsRuwlorRt7UlfnhLeuW+JdEO+WeihuqtimRHWKU4EQX2lPcXTv3Ne/0/eJ9nFSc8GkxgH5ktSCzL00ODLsfQJztnbm3Azx38vGI3s+lhMvQAGEp9SWm7UIQKCR+V8pfvKRAu2hShHicWHDDhwihz8+zbk7gmy8IKi6oRKFjNUIa9nMIvIvahvj+LQhrkx1snU2O4tbhPxQK9Vm6oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1OCR3ASn03zLMCbl8rAq2PgY5FiP7O7v574C4/4VHFI=; b=QhH1YaPfTC31IGfO4CKXNPvFjb5tXFZy8AQYa+rsxg5HoL1jF0UMF4niUhe0TglLD2KSm3W0oDibB9GEPfCN2IyRpR3ZYbt+gZK7SwamODWidhtjsCJnxGzm//CI9izUbaR6HGpgLqFlCaLtlrkH5SxcSYrAaY3xj+0LJaRnvtwZmdzJQrRSftRRIAQPrILFK0ChilVQBpO/ycdWrbwMUZ0o0hxfvbssVLXGLuVrVzgPp+op/TzfjClH1OwqYfOwnYLMHc6gwYTWFxpf8amUnhkThH7fqjIwabIRiAYQZkLqaqigXtGg5kO6WThCTcotO87/v6Ygf6AIfna53QHrmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by CY8PR11MB7136.namprd11.prod.outlook.com (2603:10b6:930:60::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20; Wed, 15 Nov 2023 11:30:08 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::864d:d91a:4674:e0f7]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::864d:d91a:4674:e0f7%6]) with mapi id 15.20.6977.033; Wed, 15 Nov 2023 11:30:07 +0000 From: "Wu, Jiaxin" To: joeyli , "devel@edk2.groups.io" , "Zhang, Hongbin1" CC: "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , Gerd Hoffmann , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol Thread-Topic: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol Thread-Index: AQHZkfhybOurunSi102mO6zSHyNu5LB8CKgAgABBDVA= Date: Wed, 15 Nov 2023 11:30:07 +0000 Message-ID: References: <20230529063938.230-1-hongbin1.zhang@intel.com> <20231115073526.GV3859@linux-l9pv.suse> In-Reply-To: <20231115073526.GV3859@linux-l9pv.suse> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|CY8PR11MB7136:EE_ x-ms-office365-filtering-correlation-id: be770f1d-103c-4ac1-13ff-08dbe5ce382d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kiyBG1wdGTfzcN3detZnbTk3GZb9CL8pfxbjeB6v41HMyMidO3OTdp9eaSY1PzQaxcUevT0xuzy1N8ChHVfHqZBJOcICVb/Oh34Ib0XsOyWuDFLlqfG6uts1c6EDbCGI/LYIT5UJpWJFNYdbyer4tKuvg/CWRFvZ9HGaqd83N9YbcNzW6Yx3v5/aVa2FjhtYrgEA5iaxG5q2oZ+S1cHarlZO+bGuwzZJF0N7Mb1nKKeHekP/R91OM+DhSSvIdhqrNK3lQAx0Ywa3GvxnBmbsk6DrP1TAMlf8XGSoNrdLKFqK8bsb4n80wQBPkSAaKFQqSSA3GIzS7jZhlwC4RqhpWe7bvN4PQVCXOrglBNC8x6YMlI5d3ff/Gwo0dV0fqsn6GnwW/i8vypePlrItOm057TkWtiiCbv9bWYy+m9LXkxz3n6feG0G9XkQCrfCNFJq7H0WYTPc4BqKE6ATZ6bii/7pIa24/hi08RiAql7lAR7Drdrwi5h1UV5JMhIM5/arO7NyZIQoJvPEYhueBphaLBj4C6VHJ+cD7Gp0E9Sqe5u26LsFaeyA9mq/sAwtGDj5KSzJXxZbA8NRiDycz/tkMs3Cs0YHG85d481t2t6m3XFHLGiX/jMvt5wGvyBZVGfPsHjVlAh5oNg6KDdUrZqYM7A== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1UwspB6jKoDVDKbxikpr9/kbAiij7GzXGyEhl0PT9hKsWriMBjvjHsdlJgwj?= =?us-ascii?Q?hRWnnCqfKvIURETIxC/knhtuXB2FM4qQnm7XesSRiLGjHGDbVktc8rQIsvCy?= =?us-ascii?Q?5ouDCgtNz/Oo9KfXYv3hgSMkwzQGMDGc4o+JX3vPinXTfL4Gsx6tCPCbHVb4?= =?us-ascii?Q?uuEZMKf17Z3RthxKRuSYq/b/7SEKAB7O3jr6b6ko6BrklVq7F1z0m/5qhJkn?= =?us-ascii?Q?o7eBOXilchTofF1DMOI7LQmjvwONLgG111DuPAaX9T319IPjKiqjoglqroSC?= =?us-ascii?Q?3WtcmZpwbe+vgyKEkKGi3J+JcLlx67NF2ulwXB3HxtyDaUQPyO/0XR8n9RtT?= =?us-ascii?Q?5E9U02soujUx7oMtWsTNYZV5V9ynNdKvvfs5dhGYddDo1Zz22z5sIz6hP3+N?= =?us-ascii?Q?Ks5Z+pZ4bKAwp9wKAXltvwgqoOE8g/VTLXF4OpobjiD5xBtfdsUUkrOKQTxi?= =?us-ascii?Q?XRaagcI0xnEAKOZCGJmpcL/sNubnwhntCDscKSJeg+fOqFN/hCLwwHECjnZ0?= =?us-ascii?Q?o6mk84w8cZP1CGwHP1m246JX39WNMFiguLtbczlHmRAR7gar4Hy1WzX6lRhm?= =?us-ascii?Q?USQ///VILSC3Lx2OBML2X0VNaQnQDxlggCfzThTM0j7roNg8cKjo3w+ilzZV?= =?us-ascii?Q?TuQTddPoLmWZlpaFkdDCSZ/6EXrE16g63/3sjZ+ZUFC6evamYUzNvc97U6yj?= =?us-ascii?Q?hY2UsUK9ciD73EsA2NYaMUeBq2++C/bXdEGViBCv26DQ9NBg6cIZXXVjjY2/?= =?us-ascii?Q?zIqOMbGbKF6yXFDMBVl8AaLgJK7XJ1/Dxdyc2g+94TcqleOr758nadYjJlRv?= =?us-ascii?Q?PoAhTEScPNfCEhSrYwLRY/GKu2zeMPFMFCFs6GZ4wBXWYqqd5WrXhKxtU/xK?= =?us-ascii?Q?45EX0kosQICzUenxN04HJ2gD4BjiRPz1fl9GtlomPFmjr2Qq2XZz48GIOB/9?= =?us-ascii?Q?+cUF82eVMqcRcXrogpt8touGlNWspedBSZb6/O03cojOM4SB18o4Z1/ZD7ip?= =?us-ascii?Q?66ckQpWbbOBvlV5uGw8IuIDjmwy828TFUYekrWxoQxRchjC4vE6EdoQ859Qd?= =?us-ascii?Q?GNBhZJW9MqDGppt8sK2TvNpVnKVJYoIc3DI4RNg/f1ZU1HCVpSYBhRxx+/aQ?= =?us-ascii?Q?YkAN5Ua+oSqjeACc58yjB06KAAFMihSjaFHDQmG+fjATi6+S4Grd85oB0Pak?= =?us-ascii?Q?ea2QrDUOyGviffjzbM/NwRSy+6kqKUUqsWFokVSIdYHJkVrJ/LMAKBQSSxXs?= =?us-ascii?Q?SJtjUCUbcZDPFyk1IF/t+jnVe7qz2GDXUbiyTPRjxaCJ2euwS0X2mL/6IVYe?= =?us-ascii?Q?B+ETVQCt31GYQWCZVdhmH9uTw+VFsR/lB7YUrS6+yMn29YaHGYWVm4bmIXDS?= =?us-ascii?Q?CPZQ7QFFGenuHGYYkcra7t4/dk+528dSWbxKWwTXmCo5kKh76XZzBl9dVQZ+?= =?us-ascii?Q?cfKnHXzjNens2KTgrR3CQ9/qe2uk4xgkmlOqn2LMmXrIMw4SNKPKjk8czLP7?= =?us-ascii?Q?hmOsDWojJ68HE7IebWPUiYa4x+s5dvnM7IcgvDAqbdtquYkS3orLFwBIuCol?= =?us-ascii?Q?syqMAQSOpzuS5nojVtaCN9YJ0nB575qDekNeW48k?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be770f1d-103c-4ac1-13ff-08dbe5ce382d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 11:30:07.1186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MVTV4zM6Hxp/SKdthzqK78foPqPuZwh7ozD9atic4j0AG4moExy7doJ99TUgpc40dDdgH1CiogVS7j3SnGAeuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7136 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LvKk1HM921fwlVNezJBgpdgbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iD5W7eO1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Joey,=20 Please check your local code whether has the commit 170d4ce8e90abb1eff03852= 940a69c9d17f8afe5 from Gerd, Assert in 1478 means you don't have that patch. Besides, I'm also porting the change to BaseXApicLib, see patch: https://ed= k2.groups.io/g/devel/message/111257 Thanks, Jiaxin > -----Original Message----- > From: joeyli > Sent: Wednesday, November 15, 2023 3:35 PM > To: devel@edk2.groups.io; Zhang, Hongbin1 > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Zeng, Star ; Wu, Jiaxin > Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended > information for SmmCpuServiceProtocol >=20 > Hi Hongbin1, >=20 > On Mon, May 29, 2023 at 02:39:38PM +0800, Zhang, Hongbin1 via groups.io > wrote: > > Some features like RAS need to use processor extended information > > under smm, So add code to support it > > > > Signed-off-by: Hongbin1 Zhang >=20 > I got a ASSERT when booting edk2-stable202308 on a issue machine: >=20 > ASSERT /home/joeyli/source_code- > git/edk2/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c(147 > 8): (Index !=3D 0) || (LevelType =3D=3D 0x01) >=20 > And, the ASSERT can also be reproduced on edk2 master. After reverted thi= s > patch, the ASSERT is gone. >=20 > I have filed a bug here: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4598 >=20 > I have put some tracing information on bugzilla. >=20 > Thank a lot! > Joey Lee >=20 > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > Cc: Gerd Hoffmann > > Cc: Star Zeng > > Cc: Jiaxin Wu > > --- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > index c0e368ea94..8311c3b9de 100644 > > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > @@ -929,7 +929,7 @@ PiCpuSmmEntry ( > > gSmmCpuPrivate->Operation[Index] =3D SmmCpuNone; > > > > if (Index < mNumberOfCpus) { > > - Status =3D MpServices->GetProcessorInfo (MpServices, Index, > &gSmmCpuPrivate->ProcessorInfo[Index]); > > + Status =3D MpServices->GetProcessorInfo (MpServices, Index | > CPU_V2_EXTENDED_TOPOLOGY, &gSmmCpuPrivate->ProcessorInfo[Index]); > > ASSERT_EFI_ERROR (Status); > > mCpuHotPlugData.ApicId[Index] =3D gSmmCpuPrivate- > >ProcessorInfo[Index].ProcessorId; > > > > -- > > 2.37.0.windows.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111260): https://edk2.groups.io/g/devel/message/111260 Mute This Topic: https://groups.io/mt/99209786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-