public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Ni, Ray" <ray.ni@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH V2 1/6] UefiCpuPkg/CpuSmm: Add perf-logging for time-consuming BSP procedures
Date: Fri, 9 Jun 2023 13:42:20 +0000	[thread overview]
Message-ID: <MN0PR11MB61587A43670D8E7D56A9C825FE51A@MN0PR11MB6158.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230531113438.1797-2-ray.ni@intel.com>

> 
> The patch adds perf-logging for the following potential
> time-consuming BSP procedures:
> * PiCpuSmmEntry
>   - SmmRelocateBases
>     * ExecuteFirstSmiInit
> 

ExecuteFirstSmiInit is not belong to the SmmRelocateBases. Others good to me.

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>


> * BSPHandler
>   - SmmWaitForApArrival
>   - PerformRemainingTasks
>     * InitPaging
>     * SetMemMapAttributes
>     * SetUefiMemMapAttributes
>     * SetPageTableAttributes
>     * ConfigSmmCodeAccessCheck
>     * SmmCpuFeaturesCompleteSmmReadyToLock
> 

  reply	other threads:[~2023-06-09 13:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 11:34 [PATCH V2 0/6] Enable perf-logging in SMM environment Ni, Ray
2023-05-31 11:34 ` [PATCH V2 1/6] UefiCpuPkg/CpuSmm: Add perf-logging for time-consuming BSP procedures Ni, Ray
2023-06-09 13:42   ` Wu, Jiaxin [this message]
2023-06-12  5:16     ` [edk2-devel] " Ni, Ray
2023-06-12  5:31       ` Ni, Ray
2023-05-31 11:34 ` [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures Ni, Ray
2023-06-09 14:29   ` Wu, Jiaxin
2023-06-12  2:25     ` Ni, Ray
2023-05-31 11:34 ` [PATCH V2 3/6] MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures Ni, Ray
2023-06-09 14:36   ` Wu, Jiaxin
2023-06-12  5:14     ` Ni, Ray
2023-05-31 11:34 ` [PATCH V2 4/6] MdeModulePkg/SmmCore: Add perf-logging for SmmDriverDispatchHandler Ni, Ray
2023-06-09 14:37   ` Wu, Jiaxin
2023-05-31 11:34 ` [PATCH V2 5/6] MdeModulePkg/SmmPerformanceLib: Disable perf-logging after ExitBS Ni, Ray
2023-06-09 14:40   ` Wu, Jiaxin
2023-05-31 11:34 ` [PATCH V2 6/6] MdeModulePkg/SmmCorePerformanceLib: Disable perf-logging at runtime Ni, Ray
2023-06-09 14:43   ` Wu, Jiaxin
2023-06-09  3:22 ` [edk2-devel] [PATCH V2 0/6] Enable perf-logging in SMM environment Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN0PR11MB61587A43670D8E7D56A9C825FE51A@MN0PR11MB6158.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox