Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Hi Gerd,

AMD version is not work for IA32X64 ovmf.

I checked the detailed: CpuSaveState->x64 is always used for OVMF no matter IA32 or X64, while AMD is not, which is decided by the MSR EFER_ADDRESS LMA bit check.

There is a potential issue/open in OVMF why need use the X64 CpuSaveState for IA32. Before this open resolved, I still prefer to keep use the ovmf specific lib instance.

Thanks,
Jiaxin 

> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Tuesday, April 23, 2024 8:16 PM
> To: Gerd Hoffmann <kraxel@redhat.com>
> Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong,
> Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu,
> James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Abdul
> Lateef Attar <AbdulLateef.Attar@amd.com>; Abner Chang
> <abner.chang@amd.com>; Tom Lendacky <thomas.lendacky@amd.com>
> Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib
> 
> As I documented in the comment:
> 
> This patch provides the SmmRelocationLib library instance
> for OVMF to handle the logic difference, and it won't change
> the existing implementation code logic.
> 
> But as I said, it depends on you. I will drop the OvmfPkg/SmmRelocationLib
> since confirmed we can use the ADM version for OVMF.
> 
> Thanks,
> Jiaxin
> 
> > -----Original Message-----
> > From: Gerd Hoffmann <kraxel@redhat.com>
> > Sent: Tuesday, April 23, 2024 4:43 PM
> > To: Wu, Jiaxin <jiaxin.wu@intel.com>
> > Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Zeng, Star
> > <star.zeng@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong,
> > Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu,
> > James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>; Ard
> Biesheuvel
> > <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Abdul
> > Lateef Attar <AbdulLateef.Attar@amd.com>; Abner Chang
> > <abner.chang@amd.com>; Tom Lendacky <thomas.lendacky@amd.com>
> > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib
> >
> > On Tue, Apr 23, 2024 at 07:31:18AM +0000, Wu, Jiaxin wrote:
> > > Thanks Gerd, I will try the S3 on OVMF.
> > >
> > > And for AmdSmmRelocationLib usage in OVMF, do you prefer:
> > > 1. use the AmdSmmRelocationLib directly in this patch set? Or
> > > 2. still keep the original to create the OvmfPkg/SmmRelocationLib, and
> clean
> > the code in the future patch?
> >
> > Clear preference for (1), why introduce OvmfPkg/SmmRelocationLib only to
> > delete it shortly thereafter?
> >
> > take care,
> >   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118180): https://edk2.groups.io/g/devel/message/118180
Mute This Topic: https://groups.io/mt/105593568/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-