From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id ABE9D780091 for ; Wed, 24 Apr 2024 03:57:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zMg8076ZIZG9zaey7f7UYCjAacKGpgForqR5RdsGZFc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713931026; v=1; b=ngPk4KGtfrMsP9xBnvzmByOvcgNN24mg1C8DlLW96a7GVk7bJ4yoIxtMILPVXCAOZh6PEETb 7g0kes+qTBo9YPW4laUiqlxxWcKAk7F6FCQtD1h3PrfZvyYErOXtb/Skqmeq4oP5xmVhHGkBgUE OeM6IHiikjY/BxLcmyhbIbjM4ctphiCIJfCYt6fTR8QkUgiYsnlzCTR6pEi8NbLxw2F9ZAZfjii 2pc6dtmcFrYVlM6hPXwid3Jzuhu8h48zy4Cr/qcz1v+C5+7DrEekIBZ/pjzh3mo/eHW5eZ8u2e7 EMY/arh5jgqGO9o+47HFBnic2x5UZZlx/UDJWQnXMGtVA== X-Received: by 127.0.0.2 with SMTP id SzicYY7687511xZ90Pq0PCgF; Tue, 23 Apr 2024 20:57:06 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mx.groups.io with SMTP id smtpd.web10.8727.1713931024805322787 for ; Tue, 23 Apr 2024 20:57:05 -0700 X-CSE-ConnectionGUID: F4kgH1daQ4SplhWP6ZcdgA== X-CSE-MsgGUID: vkDymTnjQS2maw5WqwciDg== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9371869" X-IronPort-AV: E=Sophos;i="6.07,225,1708416000"; d="scan'208";a="9371869" X-Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 20:57:05 -0700 X-CSE-ConnectionGUID: tafO0cXOSfG9GqSq7Rx39g== X-CSE-MsgGUID: evV8V0b2R0CFRJRtunmJNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,225,1708416000"; d="scan'208";a="25091709" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Apr 2024 20:57:05 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 20:57:04 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Apr 2024 20:57:04 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Apr 2024 20:57:03 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by BL3PR11MB6459.namprd11.prod.outlook.com (2603:10b6:208:3be::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.21; Wed, 24 Apr 2024 03:56:56 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99%6]) with mapi id 15.20.7519.021; Wed, 24 Apr 2024 03:56:56 +0000 From: "Wu, Jiaxin" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Ni, Ray" , "Zeng, Star" , "Kumar, Rahul R" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Ard Biesheuvel , "Yao, Jiewen" , Abdul Lateef Attar , Abner Chang , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Thread-Topic: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Thread-Index: AQHakV2GkVjeKzZueEqpL2F3/efgwrFtqcSAgAZI9YCAAYbkEIAAGEAAgAA6z7CAAQM8kA== Date: Wed, 24 Apr 2024 03:56:56 +0000 Message-ID: References: <17C74D78B0B952AD.15491@groups.io> <3v4gqem2libtqyxyw6gzuqrifjxurj7lahdbrfn4474fvgkit2@kojgaroebe3o> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|BL3PR11MB6459:EE_ x-ms-office365-filtering-correlation-id: 6243b7cb-d717-4f80-cfb2-08dc641295b2 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?nBqAEdF1in5j/J8Kt4K8oZnQV805PbxRH72UOBep7itgFdv8zOhZbTpdwnJy?= =?us-ascii?Q?CC+sY9TTe3iGl7nn8byGzvgzaFgQzna8ARNyeh5oLzAdskwcX5RN+fI/9vX1?= =?us-ascii?Q?xmxJ5vCGbUV88aQ4TY3/hJdmyEYN6Fm5vmIbbwVCRyocia0gS6qhLLwAZJyA?= =?us-ascii?Q?aT979kuhl+rMZd74Py1jbN72z80QpIGoZkYL5sW2DvmtWgKGAVwa4p7PygGb?= =?us-ascii?Q?ztKxoazfj+1RnbTBnHOw6UPpV3Tn8eTHvybBiNSseQd9dPKMLWyBHddQRYma?= =?us-ascii?Q?5Ro7egGvkEPKFSAzYz8mCd83CWciZEJEDY+aWdppl7Mv93SGDsIZuL+V3zXi?= =?us-ascii?Q?ArGJ7R+HAT1cIHk5eTW1oRPCWGify1FasW+5aKF5L5LgZUXBsuA8rl39phvL?= =?us-ascii?Q?h3gH9lPpfNnUOD+Le6MVYj2wqHOj7b3n5JtF3TLHCAXOYpGoR4x+qzM1inJD?= =?us-ascii?Q?G/7706WpJKZOZDRvmYPzVGNiSy/bktlPo2St3oNvrNWwTTHibN/Sa2IRXO3q?= =?us-ascii?Q?Cy7beqrqVQ8Ru7ooOF7aOnmWB2ulCtivuk6WpkaTP5kPJmiKpNA2DG8qIa5s?= =?us-ascii?Q?dCvyI6jemQENSWOouqwtaedMeB3pN3vFGPiTA/xSRV6xuZI/gxa5Nltjl9/P?= =?us-ascii?Q?TmlKDRYfoFkR4duqzYHHLhbrb3ks+rcvRRXUzrMag5iRdOGcbR4o0vM6HK+c?= =?us-ascii?Q?JWsl6JtCPnX2+akLhTgUZ9BV9Edno7c7NHf4VbRZs/xBUBu4rgjYFtE5lM0j?= =?us-ascii?Q?NQM2VBfoNK9tZkfKosihhdKTjflVYsjlrWY3wYWDzs6iwCaVPA4kmXiI+8jc?= =?us-ascii?Q?qCrbHkYqQsgTxhzVH+ln5nx9OYzxFCelVUQ42gfpycvOhfRc0co+koZCtLtQ?= =?us-ascii?Q?mlwIbwDxiRAxv4VvW/Z4hg4AiHQE7Icg1ENbRa1N+C40tLT1j+VdyJkFxO5w?= =?us-ascii?Q?1bBOrXdV+0imISXZqCsKFgrSF3m1RVcz5qjvgX0LFd0AdPds1QzYl5a6mOkI?= =?us-ascii?Q?UD4pr7XU2wI14rE1AMoQY6x5QQFP8BZyddkg/lCqGMCeGBRF+ouQlf32KEGc?= =?us-ascii?Q?qC0bSasWrMaK06kdi22d5iz1sWBhtGSQ/ryam8l3JZJdXElC1ClrPKv8XVog?= =?us-ascii?Q?H/kB9uSw5JV/ObI53BFbl5IgWnloJigcmLftN0EwHpl/ORYj30nHqIP2u4Lx?= =?us-ascii?Q?PYe2DeUXV70RIjHyV7qE0QD71vE1p74KLHfHtPYC+qWxLiWMOr4lICgNvo81?= =?us-ascii?Q?3hba3YjqftrXUHRugFD9DW2YdwEmoY1Jcnak8dnlsjiCo6OIkxW6oS1R+A5W?= =?us-ascii?Q?ufGzP79byeerrwviNyaN4s66?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WagTA0KgotZ5aABhjBEr8g4IU0D06BZSF90AKNtKwAPd1ByctbS6RD7ARoXD?= =?us-ascii?Q?TQQ67Nm2iOpWKYTQrGMOtnPTUVAIQ7cw1IFJ8C/lwoKq5rKPx0TLm57zNxap?= =?us-ascii?Q?QrupGRioJ2fUSzonngmD4Tlsvg+rvqHsKUFkmtskhJA6D/0MP6xfy8zjwNEs?= =?us-ascii?Q?thsSzeZSrW78b5CQdNpu/KGYJXqT9/E9H+5hB41Cm6gChD1CbiYDcjD8FjNG?= =?us-ascii?Q?130tJaAY/ucG5Uzh6D7g9oirflgTG828Ku1vOudrU7At5SaEwbyOsUoXqN85?= =?us-ascii?Q?U7AG/qITy9xiKyVdUnwmeBEpzQG0bgWuA4bK+7WKEgu93Yz8m+gUetvS1vyf?= =?us-ascii?Q?BpWdRDP33p4edfwmR4LYr0Ml17Zh05Jb/XwwafV+NVOhMsvTdCbYZqvvLUBd?= =?us-ascii?Q?gbVUBK6N9Ejwbge8V5uZ2LMoNWui8q0+phs4alVumkp+yJAk5Zj7Ab5YvXR0?= =?us-ascii?Q?sI7gVw1+rfFDi+Xq1iScUik4zcZLc+ri/IvnwVCwnE7O4d2H3q0gaY5f+y9o?= =?us-ascii?Q?b7R0nyxotT9V1VQS/T+yTgoqabYerN6kjKOcX5OjMrZ7JWFgCS2tz+BOCqhK?= =?us-ascii?Q?wNIwJ+ggq1+yyhgWW/lVEvvO68ZivvnXWlQaX7JI+1K64jGAu3S/uPhSojp9?= =?us-ascii?Q?dYFtHDl7SZPfuIRMux6yqiIHMAdRHDLM8twJfn53ZMv01ktFnLTzmG/uqNn+?= =?us-ascii?Q?ZecsHLsl/OEjnck/fZOWNMCI40fmwcfxU8oXcPtj3Faz0iZsEArZAipm7V9A?= =?us-ascii?Q?4l32M6DHGwxaD88krhhyzcAt5VEcDTeV7ERQWnFX2Kx61hbR1T1cz7aY6z02?= =?us-ascii?Q?dI4QzaJCrEvyzCqjgQsTlowv0GPPZvRC0ALB0+LIBdXw0fCLHGUHv99KkMfV?= =?us-ascii?Q?BRpFGGVEHdN6CHQVksqcryGKf9j4JbUxPnBwKIpzqBjkqHP0e6eMP9lyBwKr?= =?us-ascii?Q?CMQC7c3YykxXR7eaHmVOe2Saca2iD3G/WSgq+22jEh1/c+95ldGqFN9pXlfj?= =?us-ascii?Q?CEC/7W6eX3e+sXB3K/OG74JCfRCd1fshOixf/I2y31HWn0cAaeQYzXyGGXWK?= =?us-ascii?Q?78LxGkMEK3kJ8fB6pcB0YeCgcWQ9JDBrzLOvnquP0fLKqhsKAzv2KvbGHaB3?= =?us-ascii?Q?XnIYY8DO/X1Nn3nJyfAovdbmhgo25RD+vLDk5emKmTMfq70rpTcCG2nsipli?= =?us-ascii?Q?TAFXnnzEG25SVr06dp2Fsd+6e9+DH0F5lvjZgA1ZXSNnwc6722oSQ6yew7Fm?= =?us-ascii?Q?Y62FMhnqXYP8aCDh1JHTULE9cC4SQ7ghvbgA8m57ls2g7Jch9OEp3rUXcUps?= =?us-ascii?Q?1cKBIx7EZDemv1WBQebLPJ2GXd9pED5L25F3EPC5yLiwROs+jDNU4DSOazct?= =?us-ascii?Q?CeYNLMy40lmVgRCjuQSlxOZDO0IaL0xl9ZSNzdf28GW6X1KfZbA2bCXqfZPi?= =?us-ascii?Q?CQIHtfBMjDh5TguGqABDt6KxgNRUce9wvWHiFSKI3dzHJc2a/XpRdXvbNJj7?= =?us-ascii?Q?D0SQiLdfn3tIuvdMoxbpXj5+f3YMTv4erU/cAraJum09/yHwkKfwYdEWLrFB?= =?us-ascii?Q?mENav3gf0mqHpW8x++OoS/u5u8sW+3I6H02RNbXu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6243b7cb-d717-4f80-cfb2-08dc641295b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2024 03:56:56.3240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tQz4TojabbB63XFNzWdjd0NNdRVzO0Wggj1DZV6CKU0JfY0LaEyTZenZHZu7QoDU6/Pbu045UUBFSacT7jYxvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6459 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 23 Apr 2024 20:57:05 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: t1YFM1CDqIYxXLXCaUxX6sfJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ngPk4KGt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Gerd, AMD version is not work for IA32X64 ovmf. I checked the detailed: CpuSaveState->x64 is always used for OVMF no matter= IA32 or X64, while AMD is not, which is decided by the MSR EFER_ADDRESS LM= A bit check. There is a potential issue/open in OVMF why need use the X64 CpuSaveState f= or IA32. Before this open resolved, I still prefer to keep use the ovmf spe= cific lib instance. Thanks, Jiaxin=20 > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, April 23, 2024 8:16 PM > To: Gerd Hoffmann > Cc: devel@edk2.groups.io; Ni, Ray ; Zeng, Star > ; Kumar, Rahul R ; Dong, > Guo ; Rhodes, Sean ; Lu, > James ; Guo, Gua ; Ard Biesheuvel > ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib >=20 > As I documented in the comment: >=20 > This patch provides the SmmRelocationLib library instance > for OVMF to handle the logic difference, and it won't change > the existing implementation code logic. >=20 > But as I said, it depends on you. I will drop the OvmfPkg/SmmRelocationLi= b > since confirmed we can use the ADM version for OVMF. >=20 > Thanks, > Jiaxin >=20 > > -----Original Message----- > > From: Gerd Hoffmann > > Sent: Tuesday, April 23, 2024 4:43 PM > > To: Wu, Jiaxin > > Cc: devel@edk2.groups.io; Ni, Ray ; Zeng, Star > > ; Kumar, Rahul R ; Dong, > > Guo ; Rhodes, Sean ; Lu, > > James ; Guo, Gua ; Ard > Biesheuvel > > ; Yao, Jiewen ; Abdul > > Lateef Attar ; Abner Chang > > ; Tom Lendacky > > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > > > On Tue, Apr 23, 2024 at 07:31:18AM +0000, Wu, Jiaxin wrote: > > > Thanks Gerd, I will try the S3 on OVMF. > > > > > > And for AmdSmmRelocationLib usage in OVMF, do you prefer: > > > 1. use the AmdSmmRelocationLib directly in this patch set? Or > > > 2. still keep the original to create the OvmfPkg/SmmRelocationLib, an= d > clean > > the code in the future patch? > > > > Clear preference for (1), why introduce OvmfPkg/SmmRelocationLib only t= o > > delete it shortly thereafter? > > > > take care, > > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118180): https://edk2.groups.io/g/devel/message/118180 Mute This Topic: https://groups.io/mt/105593568/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-