From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 22D6FD80078 for ; Tue, 7 May 2024 03:39:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hoblAHaC0sUfc0/pioB6D/3DtdWNRZKu/GvmTA4DX4w=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715053157; v=1; b=OX4x9UcZwDKpUBKIlKher/ZAJ+7SwMcKajNN9rDkeC+8jfQ6P/qlzPctUL61sgKYXvOyBu12 IA8CfcUFqBr11NMcyX9CO0nhcMWWez9SwoMOMbaL5iD6DhZKKFvghRY4DrcJnKyXme1J7AG7W3Q E+VFLB0LOPybW7+eS7/I+u7cFoM7X19XykO2WQgEICR9fuMYxbl7pl6mUARGt5AwoUt2vNYBXpX 7ovK1mDh8j+OiMJPsxkktzGcL/aRlPNz8V31G+4X1dz54DD8KqJ8Tsfn1fWRsFyZUqDNq/KjTGH wqthngQfaH38KilEjG4n6x6/5MHsT8S+fG+lVz/tSpXVQ== X-Received: by 127.0.0.2 with SMTP id fNXFYY7687511xmb2kpQ9CNA; Mon, 06 May 2024 20:39:17 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.3470.1715053155911044353 for ; Mon, 06 May 2024 20:39:16 -0700 X-CSE-ConnectionGUID: iOGxf6MxRFez5BMxM6XciQ== X-CSE-MsgGUID: Mhlt9D+DS0+nVGA236T5Tg== X-IronPort-AV: E=McAfee;i="6600,9927,11065"; a="13778857" X-IronPort-AV: E=Sophos;i="6.07,260,1708416000"; d="scan'208,217";a="13778857" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 20:39:13 -0700 X-CSE-ConnectionGUID: TpcJ5zOCTvap+9ylmhNQpQ== X-CSE-MsgGUID: 40JTeXNxQfeBI4AityVN+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,260,1708416000"; d="scan'208,217";a="28341129" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 May 2024 20:39:12 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 6 May 2024 20:39:11 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 6 May 2024 20:39:11 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 6 May 2024 20:39:11 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 6 May 2024 20:39:10 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by SA0PR11MB4749.namprd11.prod.outlook.com (2603:10b6:806:9a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 03:39:02 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::13cf:47a8:4737:84e9]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::13cf:47a8:4737:84e9%3]) with mapi id 15.20.7544.039; Tue, 7 May 2024 03:39:01 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , "devel@edk2.groups.io" , Ard Biesheuvel , "Yao, Jiewen" CC: "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Abdul Lateef Attar , Abner Chang , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib Thread-Topic: [PATCH v4 00/14] Add SmmRelocationLib Thread-Index: AQHal9PA9IGV4Fma0kKigj4l3IqtTrGAVyLRgABAhnCACpdQ4A== Date: Tue, 7 May 2024 03:39:01 +0000 Message-ID: References: <20240426121720.54308-1-jiaxin.wu@intel.com> Accept-Language: zh-CN, en-US X-Mentions: ardb+tianocore@kernel.org,jiewen.yao@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|SA0PR11MB4749:EE_ x-ms-office365-filtering-correlation-id: 19e664c9-600c-46af-628a-08dc6e473c43 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?VpM6cEh8qA7OTL5Zr+cFFM3ZQxqTMwIjVVLZsswxC9HJaT1ZSjUesGCXaUVE?= =?us-ascii?Q?sGLXGb/KmoOCgwMlL2nrVzhZipqRHTUV1E7DJMfZnO62ma8oTlSlhvlkqCWx?= =?us-ascii?Q?g7TPiYTuUPBrwvDdA+lEUdXH2S0Twddqv0hOB+6Mn8OXQaews0JllOgbf/Jp?= =?us-ascii?Q?xIJD8XM29YIWguNEL2pSpmHC/zYSx+LkCY2pSPYvc9VCefGVy46k1is9ZzSC?= =?us-ascii?Q?tLA1xOma6chgGNj33UqMe+uskeu3XcBcVC0XFhdkGEAWKbN5nDeHqmfiKskn?= =?us-ascii?Q?auxFM73sTo+EDr9zLS0ZIKVMT+95wd6WiGlmlvd+hMemapuBq4gmwV2R5j04?= =?us-ascii?Q?cJCCCPa3VkjKnv6U8EU+ZbyjMlmd89zanySvfXFbbSdSZkOqtfKWKv/tpHzs?= =?us-ascii?Q?f5r9xdiwwwYsktbhGN26/IWcBfdiFIcR7MHUt5TKvzrFpIkrc5Mg69gCtgna?= =?us-ascii?Q?2ykBoTCm8ap2n+v1LHrqdyl6t6ATDzGxbvtp+MqWKMUwCjaT9SfXnwYtcPVL?= =?us-ascii?Q?t6AXQExj0MaOceoaHh4mswBs9YnYPIHAv8VsJyR9UPTZqms0rhsJA/RiItcg?= =?us-ascii?Q?/cWEXBPmInPTZOpfEgCs8gLF4EfvrxCnaoFq6jZuVpFQdCxZzyczSi8xArmx?= =?us-ascii?Q?LKar+k71tUFDsE1NooO9DZu/4CWfPVX3dGZT2kPcN3/4MyqtvTUCCjRUD1NJ?= =?us-ascii?Q?pK8ORhQavZ2lgsEDFgJqSCYANs51BJ5R164uP6UqMEnU79VhX9Xf0KnURNtJ?= =?us-ascii?Q?jFaUyuRy3eR5nvOxUCudnh1AnJBwg0BwKqSLoqsLDiyd4ps7JPsanaJ+9Ti0?= =?us-ascii?Q?Tryh5hkRAxMJmFwHEiL6qslLJEBxjesWfE8jSDipHTGzaPChZA1vcA/21X/K?= =?us-ascii?Q?uhi2IfGZc121PWM3/NI5xQRiw+Ot+fgRsXt1LINtvCVwCj4Vh2OqqIWXHY/O?= =?us-ascii?Q?054LvxPBrH8wdby2Pg1TwjjYzqzEsn8G9GUIkEi8EUnW6HrpEdqI8EVJWmjy?= =?us-ascii?Q?pz26beiUGIMlI9E2mLH3Cy3WRTkTXvTQgxiWlxDRJmzNVVAZwJ0dGS1T/cmo?= =?us-ascii?Q?gfdIj9OVdyMonobkefZQEj8sZ4bfIkGWmNYi9frWHEpXM7rxU0cbZEPGDOXi?= =?us-ascii?Q?trUhTQj4Um6n4oona8I91RisemHLpjBZsCRNL7rJgz8D9q6vS8TICwtJ6eKD?= =?us-ascii?Q?JVEQsvddAXpXd/g9AnxK9ecXI3PdR3NMJRRpYRzSk+Q6Wmjv4ibpvFksG/qz?= =?us-ascii?Q?EMqMUk0X2E1kSQBJ77WZ63etWQoVb0wFUDXoip88TA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IxksFWjBT1IykJh6/8tUALq6V213E+fxSW/jmC7ZPC9PLdQLdXQy4rVGnvql?= =?us-ascii?Q?oOqaKw73qa96LHogi89FI7A4bI9FmBAKfOh4oU+HHtd0aHSIP01b9cyjeq3j?= =?us-ascii?Q?lo1jA+N4/ng56Y9MXDK42/eSBwRz6Y3Ygok8z6sLzvU4dWxEJfzQK4Zupv6u?= =?us-ascii?Q?iw44eKbOgCxNrcTpP2dn3KLZizp9Cx5Q/gKP1W5TyNRWDoc5zwa1Ztcp0WBh?= =?us-ascii?Q?ZZEw7gQs7wv7E9xubc6xnSSNirWxR6zfi9YRaFwMlo06K+5djokOeY12SJtC?= =?us-ascii?Q?KtjR17MF1Q2czDkQJyfqc0zbsgXh4wDVDmUPiPfIVsBGOA6lXOMnV3M//KhX?= =?us-ascii?Q?5EbbOHF5JaRSuDW/+/795UFRHjqqMaudN9cGGZYC2RJ3hbhREVocti90Wznx?= =?us-ascii?Q?x2exg5TXa22u/9c2OMIwTldBZjEP+C42wn9AYzHndKqFqvLXHjRzYKKrypxe?= =?us-ascii?Q?hHXBFjNRDRXDQsLef65mwLNMm3bg5BjEf246IzvcHWFK6T0Cv43cAFfc8wAw?= =?us-ascii?Q?QHFPiGPj+745nnyofvRFU8RTkd4iN41eXFAvw31vVJNkMH4CxWCKZW0W4Smv?= =?us-ascii?Q?8xLXtgwGzKT9IoLzah+3K7QEMMcCtNMdcezezI+eACqjyi/lUSBMoBEK95xW?= =?us-ascii?Q?5nRQmPDERJz744imVAfrZc+2gM2uU9Z/Vm7GHiv7ta6sqIuwtRy+j6JHKJOt?= =?us-ascii?Q?WhlG+ITfSFn2xTlRC9lYjOMtdWF9wewU52i6pr0IwUgKOZp85qup37ajNBvn?= =?us-ascii?Q?Ws4Y4O7OsfJ+vwYzKo4icFnHmBxc7LK+8NMcUusvTK1gzxhrs4ZWMe2YKW5R?= =?us-ascii?Q?kCL0TJDwhdpkDoDtfL6hOt1mZDJDU9EoKJCDX4obud7R3jM9+Ymun1Fi72UL?= =?us-ascii?Q?nSWH15VulJH79PDavO/C4o56v+dwO86ijHFbWnVIJVwt8HJoVdkP+b68bl4i?= =?us-ascii?Q?dz3m3fH9zhmYmPvS2j5w/7l+TiteD2+tBlsZC9eoSPgAXljeHm/kHJGt9dSs?= =?us-ascii?Q?h2qXt7uFQ9TyeWjm+eq34g0DeBACad9b1t6E1cKP57+1vgCiSGTBxxUqG2yv?= =?us-ascii?Q?+u4mQOPTMDbXGsyvNqv8n1DS36QGCOxAsZD6TaY7xPInW0siG+PyKhRr3ESE?= =?us-ascii?Q?QauBEGwuUNDGez8LQM0TeCdNUlWfc83II7e3U+qhQdd4wRLGi3N5n/mB1Fcn?= =?us-ascii?Q?AwO5UNVs4Nw7XmmBHzD2GUhUTWeuIkSkzwam6xO/SeV26eWLh5PqmQp8j4V9?= =?us-ascii?Q?sOnrivtoO86x+kRBS0/LdNFXt7YQ+5kjfQ3QhFTb04xb50Rs/0/6OPSrghRg?= =?us-ascii?Q?lADYU7mR0ZDRlPY9hPYyHxkdiuugo69jKJaY7YCNuc68+zRvIVkA2SIY6yXE?= =?us-ascii?Q?80xZ/r04vRUiS2yGTFM2UwwD6QbVMa5HYRD3zBj/ygKDkrqzfyoxkHjTFU3H?= =?us-ascii?Q?1uv0Qq2918yPhpuVW7WB1jl0kmmY/ZAUP3e+v36nDFTbUvXCsAxQCGLUJh9p?= =?us-ascii?Q?ql4QqXK72QB/wHpwsVGlkCft+c4PmjpD47weWu9NYmlPQFPyUqwPeMjr0Jth?= =?us-ascii?Q?iwXtqf4fABlSsJVW5olkEzYKvuhaOl0TCuIYzXm+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19e664c9-600c-46af-628a-08dc6e473c43 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2024 03:39:01.2221 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wTeCtJKIzwoVdaPb5e7PpBJgZqFj50x9zF+9jdnZDjDiurOelQ6+U0kMAtd8YC/9vIGUjnrxV0RWRcLu0OjtEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4749 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 06 May 2024 20:39:16 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IP0TYOHk29ga3566s0fPNdVdx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN0PR11MB6158A782B76215973B7555BFFEE42MN0PR11MB6158namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OX4x9UcZ; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_MN0PR11MB6158A782B76215973B7555BFFEE42MN0PR11MB6158namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiewen and Ard, @Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change related to OVMF package= since you are the OVMF maintainers. Please help check /review. The patches have been acked/tested by the Gerd. [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is do= ne or not [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase Thanks, Jiaxin From: Wu, Jiaxin Sent: Tuesday, April 30, 2024 6:14 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Zeng, Star ; Gerd Hoffmann ; Ku= mar, Rahul R ; Dong, Guo ; Rho= des, Sean ; Lu, James ; Guo, Gua= ; Ard Biesheuvel ; Yao, Jiew= en ; Abdul Lateef Attar ; = Abner Chang ; Tom Lendacky Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib Thanks Ray, I missed to add some already reviewed-by tag in v4. All V4 patc= hes are tested & acted by Gerd: Tested-by: Gerd Hoffmann > Acked-by: Gerd Hoffmann > For each one: listed as below, *so need Ray "reviewed-by" tag on the patch:= 05/06/14, need Gerd "reviewed-by" tag on the patch: 08/09/10/11/12* [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class Reviewed-by: Ray Ni > --> no cha= nge compared to V3 [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib librar= y instance Reviewed-by: Ray Ni > --> no chan= ge compared to V3 [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variables Reviewed-by: Ray Ni > --> no chan= ge compared to V3 [PATCH v4 04/14] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory al= location Reviewed-by: Ray Ni > --> no chan= ge compared to V3 [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary global v= ariable [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex * Change Based on Ray's comment on V3: split the removal of CpuIndex parame= ter in a new patch, so add the 06 patch in V4.* [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance for AM= D Reviewed-by: Abdul Lateef Attar > --> no change compared to V3 [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is do= ne or not [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase *Change Based on Gerd's comment on V3: 1. Creating the EFI_SMM_SMRAM_MEMOR= Y_GUID HOB should be moved to its own function. 2) refine the comment in S= mmAccess 3) refine the commit log.* [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocation= Lib Reviewed-by: Gua Guo > Reviewed-by: Guo Dong > [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation log= ic *Change Based on Ray's comment on V3: move the "TileSize" check just below = the original TileSize calculation logic* Thanks, Jiaxin From: Ni, Ray > Sent: Tuesday, April 30, 2024 2:01 PM To: Wu, Jiaxin >; devel@edk= 2.groups.io Cc: Zeng, Star >; Gerd Hoff= mann >; Kumar, Rahul R >; Dong, Guo >; Rhodes, Sean >; Lu, James >; Guo, Gua >; Ard Bie= sheuvel >; Yao,= Jiewen >; Abdul Lateef A= ttar >; Abner C= hang >; Tom Lendacky > Subject: Re: [PATCH v4 00/14] Add SmmRelocationLib Jiaxin, You need to add the missing Reviewed-by for each patch if the patch doesn't= change in V4. Can you reply to this mail to list what patches have already got Reviewed-b= y from whom? Thanks, Ray ________________________________ From: Wu, Jiaxin > Sent: Friday, April 26, 2024 20:17 To: devel@edk2.groups.io > Cc: Ni, Ray >; Zeng, Star >; Gerd Hoffmann >; Kumar, Rahul R >; Dong, Guo >; Rhodes, Sean >; Lu, James >; Guo, Gua <= gua.guo@intel.com>; Ard Biesheuvel >; Yao, Jiewen >; Abdul Lateef Attar >; Abner Chang >; Tom Lendacky > Subject: [PATCH v4 00/14] Add SmmRelocationLib PR: https://github.com/tianocore/edk2/pull/5546 Intel plans to separate the smbase relocation logic from PiSmmCpuDxeSmm driver, and the related behavior will be moved to the new interface defined by the SmmRelocationLib class. The SmmRelocationLib class provides the SmmRelocationInit() interface for platform to do the smbase relocation, which shall provide below 2 functionalities: 1. Relocate smbases for each processor. 2. Create the gSmmBaseHobGuid HOB. With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at a later phase) can be simplfied as below for SMM init: 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases for each Processor. 2. Execute the early SMM Init. Cc: Ray Ni > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Guo Dong > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Abdul Lateef Attar > Cc: Abner Chang > Cc: Tom Lendacky > Signed-off-by: Jiaxin Wu > Jiaxin Wu (14): UefiCpuPkg: Add SmmRelocationLib class UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance UefiCpuPkg/SmmRelocationLib: Rename global variables UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex UefiCpuPkg/SmmRelocationLib: Add library instance for AMD OvmfPkg/SmmRelocationLib: Add library instance for OVMF OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid OvmfPkg: Refine SmmAccess implementation OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not OvmfPkg/PlatformPei: Relocate SmBases in PEI phase UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + OvmfPkg/Library/PlatformInitLib/MemDetect.c | 135 +++-- .../Library/PlatformInitLib/PlatformInitLib.inf | 6 +- .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 33 +- .../Library/SmmRelocationLib}/Ia32/Semaphore.c | 13 +- .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 +++++++++++++++++= ++++ .../Library/SmmRelocationLib/SmmRelocationLib.inf | 60 +++ .../SmmRelocationLib/SmramSaveStateConfig.c | 100 ++++ .../Library/SmmRelocationLib}/X64/Semaphore.c | 13 +- .../Library/SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- OvmfPkg/Microvm/MicrovmX64.dsc | 1 + OvmfPkg/OvmfPkgIa32.dsc | 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/PlatformPei/Platform.c | 3 + OvmfPkg/PlatformPei/Platform.h | 5 + OvmfPkg/PlatformPei/PlatformPei.inf | 5 +- OvmfPkg/PlatformPei/SmmRelocation.c | 80 +++ OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 4 +- OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 5 + OvmfPkg/SmmAccess/SmmAccessPei.c | 116 ++--- OvmfPkg/SmmAccess/SmmAccessPei.inf | 11 +- OvmfPkg/SmmAccess/SmramInternal.c | 72 +-- OvmfPkg/SmmAccess/SmramInternal.h | 19 +- UefiCpuPkg/Include/Library/SmmRelocationLib.h | 42 ++ .../SmmRelocationLib/AmdSmmRelocationLib.inf | 60 +++ .../SmmRelocationLib/AmdSmramSaveStateConfig.c | 125 +++++ .../SmmRelocationLib}/Ia32/Semaphore.c | 13 +- .../SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 +++++++++++++++++= ++++ .../Library/SmmRelocationLib/SmmRelocationLib.inf | 61 +++ .../SmmRelocationLib/SmramSaveStateConfig.c | 136 +++++ .../SmmRelocationLib}/X64/Semaphore.c | 13 +- .../SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 21 +- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 334 ++----------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 103 +--- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 - UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 69 --- UefiCpuPkg/UefiCpuPkg.dec | 3 + UefiCpuPkg/UefiCpuPkg.dsc | 2 + UefiPayloadPkg/UefiPayloadPkg.dsc | 2 + 48 files changed, 2578 insertions(+), 796 deletions(-) copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/Ia3= 2/Semaphore.c (71%) copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/Ia3= 2/SmmInit.nasm (47%) create mode 100644 OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationL= ib.h create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/X64= /Semaphore.c (78%) copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/X64= /SmmInit.nasm (59%) create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib= .inf create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateCo= nfig.c rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/Ia32/Sema= phore.c (71%) rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/Ia32/SmmI= nit.nasm (47%) create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocati= onLib.h create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.in= f create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfi= g.c rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/X64/Semap= hore.c (78%) rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/X64/SmmIn= it.nasm (59%) -- 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118632): https://edk2.groups.io/g/devel/message/118632 Mute This Topic: https://groups.io/mt/105748911/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN0PR11MB6158A782B76215973B7555BFFEE42MN0PR11MB6158namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Jiewen and Ard,

 

@Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change related t= o OVMF package since you are the OVMF maintainers. Please help check /revie= w.

 

The patches have been acked/tested by the Gerd.=

 

  [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Ad= d library instance for OVMF
  [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryG= uid
  [PATCH v4 10/14]  OvmfPkg: Refine SmmAccess implementation
  [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation = is done or not
  [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase<= o:p>

 

Thanks,

Jiaxin

 

From: Wu, Jiaxin
Sent: Tuesday, April 30, 2024 6:14 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Cc: Zeng, Star <star.zeng@intel.com>; Gerd Hoffmann <kraxel= @redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo = <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu,= James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@i= ntel.com>; Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Abner C= hang <abner.chang@amd.com>; Tom Lendacky <thomas.lendacky@amd.com&= gt;
Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib

 

Thanks Ray, I missed to add some already reviewed-by= tag in v4. All V4 patches are tested & acted by Gerd:

Tested-by: Gerd Hoffmann <kraxel@redhat.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

 

For each one: listed as below, *so need Ray ̶= 0;reviewed-by” tag on the patch: 05/06/14, need Gerd “reviewed-= by” tag on the patch:  08/09/10/11/12*

 

  [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocatio= nLib class

Reviewed-by: Ray Ni <ray.ni@intel.com>  --> no change compared to V3=


  [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib l= ibrary instance

Reviewed-by: Ray Ni <ray.ni@intel.com> --> no change compared to V3


  [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variable= s

Reviewed-by: Ray Ni <ray.ni@intel.com> --> no change compared to V3


 [PATCH v4 04/14]  UefiCpuPkg/SmmRelocationLib: Avoid unnecessary= memory allocation

Reviewed-by: Ray Ni <ray.ni@intel.com> --> no change compared to V3


  [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary glo= bal variable
  [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary Cpu= Index

* Change Based on Ray’s comment on V3: = spl= it the removal of CpuIndex parameter in a new patch, so add the 06 patch in= V4.*


  [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance f= or AMD

Reviewed-by: Abdul Lateef Attar <AbdulLateef.Atta= r@amd.com> --> no change compared to V3


  [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for = OVMF
  [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryG= uid
  [PATCH v4 10/14]  OvmfPkg: Refine SmmAccess implementation
  [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation = is done or not
  [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase<= o:p>

*Change Based on Gerd’s  comment on V3= : 1. Creating the EFI_SMM_SMRAM_MEMORY_GUID HOB should be moved to its own = function.  2) refine the comment in SmmAccess 3) refine the commit log= .*


  [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmReloc= ationLib

Reviewed-by: Gua Guo <gua.guo@intel.com>

Reviewed-by: Guo Dong <guo.dong@intel.com><= o:p>


  [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocatio= n logic

*Change Based on Ray’s comment on V3: <= b>move= the "TileSize" check just below the original TileSize calculatio= n logic*

 

Thanks,

Jiaxin

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, April 30, 2024 2:01 PM
To: Wu, Jiaxin <jiaxin.wu@= intel.com>; devel@edk2.groups.io
Cc: Zeng, Star <star.zeng@= intel.com>; Gerd Hoffmann <k= raxel@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo <guo.dong@intel.com>; Rhod= es, Sean <sean@starlabs.systems= >; Lu, James <james.lu@inte= l.com>; Guo, Gua <gua.guo@in= tel.com>; Ard Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Abner Chang <abner.chang@amd.com= >; Tom Lendacky <thoma= s.lendacky@amd.com>
Subject: Re: [PATCH v4 00/14] Add SmmRelocationLib

 

Jiaxin,

You need to add the missing Reviewed-by for each patch if = the patch doesn't change in V4.

 

Can you reply to this mail to list what patches have alrea= dy got Reviewed-by from whom?

 

 

 

Thanks,

Ray

From: Wu, Jiaxin <jiaxin.wu@intel.com>
Sent: Friday, April 26, 2024 20:17
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: Ni, Ray <ray.ni@intel.com= >; Zeng, Star <star.zeng@i= ntel.com>; Gerd Hoffmann <kr= axel@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo <guo.dong@intel.com= >; Rhodes, Sean <sean@starla= bs.systems>; Lu, James <jam= es.lu@intel.com>; Guo, Gua <= gua.guo@intel.com>; Ard Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Abner Chang <abner.chang@amd.com= >; Tom Lendacky <thoma= s.lendacky@amd.com>
Subject: [PATCH v4 00/14] Add SmmRelocationLib

 

PR: https://github.com/tianocore/edk2/pull/5546

Intel plans to separate the smbase relocation logic from
PiSmmCpuDxeSmm driver, and the related behavior will be
moved to the new interface defined by the SmmRelocationLib
class.

The SmmRelocationLib class provides the SmmRelocationInit()
interface for platform to do the smbase relocation, which
shall provide below 2 functionalities:
1. Relocate smbases for each processor.
2. Create the gSmmBaseHobGuid HOB.

With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at
a later phase) can be simplfied as below for SMM init:
1. Consume the gSmmBaseHobGuid HOB for the relocated smbases
for each Processor.
2. Execute the early SMM Init.

Cc: Ray Ni <ray.ni@intel.com>=
Cc: Zeng Star <star.zeng@intel.co= m>
Cc: Gerd Hoffmann <kraxel@redhat.co= m>
Cc: Rahul Kumar <rahul1.kumar@= intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Sean Rhodes <sean@starlabs.= systems>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com&= gt;
Cc: Ard Biesheuvel <ardb+ti= anocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel= .com>
Cc: Abdul Lateef Attar <Abd= ulLateef.Attar@amd.com>
Cc: Abner Chang <abner.chang@amd.= com>
Cc: Tom Lendacky <thomas.lend= acky@amd.com>
Signed-off-by: Jiaxin Wu <jiaxin.= wu@intel.com>

Jiaxin Wu (14):
  UefiCpuPkg: Add SmmRelocationLib class
  UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance   UefiCpuPkg/SmmRelocationLib: Rename global variables
  UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation
  UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable
  UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex
  UefiCpuPkg/SmmRelocationLib: Add library instance for AMD
  OvmfPkg/SmmRelocationLib: Add library instance for OVMF
  OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid
  OvmfPkg: Refine SmmAccess implementation
  OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not   OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
  UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib
  UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic

 OvmfPkg/AmdSev/AmdSevX64.dsc       = ;            &n= bsp;   |   1 +
 OvmfPkg/CloudHv/CloudHvX64.dsc      &nb= sp;            =   |   1 +
 OvmfPkg/Library/PlatformInitLib/MemDetect.c    &n= bsp;   | 135 +++--
 .../Library/PlatformInitLib/PlatformInitLib.inf    |&n= bsp;  6 +-
 .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c  |  33 +-=
 .../Library/SmmRelocationLib}/Ia32/Semaphore.c    = ; |  13 +-
 .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm    |&n= bsp; 83 +++-
 .../SmmRelocationLib/InternalSmmRelocationLib.h    | 1= 27 +++++
 .../Library/SmmRelocationLib/SmmRelocationLib.c    | 5= 49 +++++++++++++++++++++
 .../Library/SmmRelocationLib/SmmRelocationLib.inf  |  60 ++= +
 .../SmmRelocationLib/SmramSaveStateConfig.c    &n= bsp;   | 100 ++++
 .../Library/SmmRelocationLib}/X64/Semaphore.c    =   |  13 +-
 .../Library/SmmRelocationLib}/X64/SmmInit.nasm    = ; |  85 +++-
 OvmfPkg/Microvm/MicrovmX64.dsc      &nb= sp;            =   |   1 +
 OvmfPkg/OvmfPkgIa32.dsc       &nbs= p;            &= nbsp;       |   1 +
 OvmfPkg/OvmfPkgIa32X64.dsc       &= nbsp;           &nbs= p;     |   1 +
 OvmfPkg/OvmfPkgX64.dsc        = ;            &n= bsp;        |   1 +
 OvmfPkg/PlatformPei/Platform.c      &nb= sp;            =   |   3 +
 OvmfPkg/PlatformPei/Platform.h      &nb= sp;            =   |   5 +
 OvmfPkg/PlatformPei/PlatformPei.inf     &nbs= p;          |   5 +-=
 OvmfPkg/PlatformPei/SmmRelocation.c     &nbs= p;          |  80 +++
 OvmfPkg/SmmAccess/SmmAccess2Dxe.c      =             | &= nbsp; 4 +-
 OvmfPkg/SmmAccess/SmmAccess2Dxe.inf     &nbs= p;          |   5 +<= br>  OvmfPkg/SmmAccess/SmmAccessPei.c      &= nbsp;            | 1= 16 ++---
 OvmfPkg/SmmAccess/SmmAccessPei.inf      = ;           |  11 +-=
 OvmfPkg/SmmAccess/SmramInternal.c      =             |  = 72 +--
 OvmfPkg/SmmAccess/SmramInternal.h      =             |  = 19 +-
 UefiCpuPkg/Include/Library/SmmRelocationLib.h    =   |  42 ++
 .../SmmRelocationLib/AmdSmmRelocationLib.inf    &= nbsp;  |  60 +++
 .../SmmRelocationLib/AmdSmramSaveStateConfig.c    = ; | 125 +++++
 .../SmmRelocationLib}/Ia32/Semaphore.c     &= nbsp;       |  13 +-
 .../SmmRelocationLib}/Ia32/SmmInit.nasm     =        |  83 +++-
 .../SmmRelocationLib/InternalSmmRelocationLib.h    | 1= 27 +++++
 .../Library/SmmRelocationLib/SmmRelocationLib.c    | 5= 49 +++++++++++++++++++++
 .../Library/SmmRelocationLib/SmmRelocationLib.inf  |  61 ++= +
 .../SmmRelocationLib/SmramSaveStateConfig.c    &n= bsp;   | 136 +++++
 .../SmmRelocationLib}/X64/Semaphore.c     &n= bsp;        |  13 +-
 .../SmmRelocationLib}/X64/SmmInit.nasm     &= nbsp;       |  85 +++-
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c      =             |  = 21 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c     &n= bsp;        |  10 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c    &nb= sp;    | 334 ++-----------
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h    &nb= sp;    | 103 +---
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf    &= nbsp;  |   4 -
 UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h     &n= bsp;        |   2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c    &nb= sp;    |  69 ---
 UefiCpuPkg/UefiCpuPkg.dec       &n= bsp;            = ;      |   3 +
 UefiCpuPkg/UefiCpuPkg.dsc       &n= bsp;            = ;      |   2 +
 UefiPayloadPkg/UefiPayloadPkg.dsc      =             | &= nbsp; 2 +
 48 files changed, 2578 insertions(+), 796 deletions(-)
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocation= Lib}/Ia32/Semaphore.c (71%)
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocation= Lib}/Ia32/SmmInit.nasm (47%)
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/InternalSmmReloca= tionLib.h
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.= c
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.= inf
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmramSaveStateCon= fig.c
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocation= Lib}/X64/Semaphore.c (78%)
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocation= Lib}/X64/SmmInit.nasm (59%)
 create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c
 create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocati= onLib.inf
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveSt= ateConfig.c
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/I= a32/Semaphore.c (71%)
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/I= a32/SmmInit.nasm (47%)
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRel= ocationLib.h
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationL= ib.c
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationL= ib.inf
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmramSaveState= Config.c
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/X= 64/Semaphore.c (78%)
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/X= 64/SmmInit.nasm (59%)

--
2.16.2.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118632) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN0PR11MB6158A782B76215973B7555BFFEE42MN0PR11MB6158namp_--