public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] UefiCpuPkg: Proposal to enable/disable AP parallel
@ 2024-11-20  7:12 Zhiguang Liu via groups.io
  2024-11-21  9:54 ` Wu, Jiaxin via groups.io
  0 siblings, 1 reply; 5+ messages in thread
From: Zhiguang Liu via groups.io @ 2024-11-20  7:12 UTC (permalink / raw)
  To: devel@edk2.groups.io, Ni, Ray, Wu, Jiaxin, Liu, Zhiguang,
	Tan, Dun, Kumar, Rahul R, Gerd Hoffmann, Kinney, Michael D,
	Gao, Liming
  Cc: Kumar, Chandana C, Zhao, Jason, Kuo, Donald

[-- Attachment #1: Type: text/plain, Size: 3313 bytes --]

Hi MdePkg and UefiCpuPkg maintainers and reviewers

Recently, we met a performance issue when waking up disabled APs.
There is usage where BIOS needs to disable all APs, do something and then enable all APs.
Now, we are using the MpService PPI/Protocol EnableDisableAP(). This function can only enable/disable one AP each time.
To enable one AP, MP service needs to send INIT-SIPI-SIPI, which takes around 10ms.
And now, we will have more than 10 APs in a client platform, and it will take more than 100ms.
The function definition of EnableDisableAP is:
typedef
EFI_STATUS
(EFIAPI *EFI_MP_SERVICES_ENABLEDISABLEAP)(
  IN  EFI_MP_SERVICES_PROTOCOL  *This,
  IN  UINTN                     ProcessorNumber,
  IN  BOOLEAN                   EnableAP,
  IN  UINT32                    *HealthFlag OPTIONAL
  );
The input parameter ProcessorNumber accepts a range from 0 to the total number of logical processors minus 1.

To support enable/disable AP parallel, I have below solutions:

Solution1:
Let input parameter ProcessorNumber accept a MAX_UINTN also. MAX_UINTN means to enable/disable all APs.
The draft PR is at https://github.com/tianocore/edk2/pull/6453 When the parameter is MAX_UINTN, EnableDisableAP() will enable/disable APs in a parallel way.
                However, we need to change below header files
                                MdePkg\Include\Protocol\MpService.h
                                MdePkg\Include\Ppi\MpServices.h
                                UefiCpuPkg\Include\Ppi\MpServices2.h
                The above two follow PI spec. We need to modify the PI spec first.

Solution2:
                Similar with solution1, but to avoid violating spec, add a new Protocol named MpServices2. Only change below header files.
                                UefiCpuPkg\Include\Ppi\MpServices2.h
UefiCpuPkg\Include\Protocol\MpServices2.h (new)
                The MdePkg part remains no change.

Solution3:
                MpService create new PPI/Protocol to only contain one function EnableDisableAllAps(), which will enable/disable all APs in a parallel way.

Solution4:
                Add PPI/Protocol notify in MpLib. The notify call back function will set WakeUpByInitSipiSipi to True. Similar code is removed in https://github.com/tianocore/edk2/pull/6303/commits/f1f8374381019169d421a65a896ab42ed5338c1e
                When users need to disable and then enable cores, the flow will be:

  1.  Send Init to all APs. (to disable all APs)
  2.  Do things that user need to do when all APs are disabled
  3.  Notify callback function
  4.  Use StartupAllAPs() from existing PPI/Protocol to wake up all APs.
The flow is similar with how S3 SMM code take control APs and then give the control back in old days.

Personally, I prefer solution1. It is simpler, but it does violate spec.
Please let me know your comments or any new idea, please share.

Thanks
Zhiguang



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120802): https://edk2.groups.io/g/devel/message/120802
Mute This Topic: https://groups.io/mt/109680758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 11438 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-04  4:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-20  7:12 [edk2-devel] UefiCpuPkg: Proposal to enable/disable AP parallel Zhiguang Liu via groups.io
2024-11-21  9:54 ` Wu, Jiaxin via groups.io
2024-11-21 12:03   ` Zhao, Jason via groups.io
2024-11-21 18:43     ` Michael D Kinney via groups.io
2024-11-26  7:47       ` Zhiguang Liu via groups.io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox