From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bounce+27952+118635+7686176+12367111@groups.io>
Received: from mail05.groups.io (mail05.groups.io [45.79.224.7])
	by spool.mail.gandi.net (Postfix) with ESMTPS id 27F60740032
	for <rebecca@openfw.io>; Tue,  7 May 2024 05:18:12 +0000 (UTC)
DKIM-Signature: a=rsa-sha256; bh=pNtSHZIspv49+xhnYVWaFBG0M4w6hX1mS0mddO0x94E=;
 c=relaxed/simple; d=groups.io;
 h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type;
 s=20240206; t=1715059091; v=1;
 b=YKYxg0dZkcejPO8DRWtnb6QkyreUEOWJJ5n9WL0P2St4Myf/Lh0BBgemyzyQ0I40FPuAUHs5
 f958oLu1AxwPVa3Tkkx3DBjhfhYTCiKRUnQgN3oYi+G1EltkXS2NnWv6KEFiugTE9L4nLChq2AK
 7fi7/k9NlOLkrIJk9X3De7qTh0ff0bvw39kf7Asjz3HMtrhyHaOZGrWk1sVMcmiswskXiqigXUI
 pilHbWntAT93ET4UsJ7Tk9Gc9CD15e4WT3M/unKFEI3lcpr5oKsewqxfP2th1EZdoigXh9tzqNR
 R2dUdbB/wfBzhXCPUqnlqrtqGajWOZX1LSetTu8PShVig==
X-Received: by 127.0.0.2 with SMTP id AHz8YY7687511xWps1DuvrUU; Mon, 06 May 2024 22:18:11 -0700
X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11])
 by mx.groups.io with SMTP id smtpd.web10.4592.1715059090004482845
 for <devel@edk2.groups.io>;
 Mon, 06 May 2024 22:18:10 -0700
X-CSE-ConnectionGUID: UGR8sN3yTYWyEYP5uzlJFg==
X-CSE-MsgGUID: BmBuDCnESvCg8Eu4eiKTzw==
X-IronPort-AV: E=McAfee;i="6600,9927,11065"; a="21383411"
X-IronPort-AV: E=Sophos;i="6.07,260,1708416000"; 
   d="scan'208,217";a="21383411"
X-Received: from fmviesa009.fm.intel.com ([10.60.135.149])
  by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 22:18:10 -0700
X-CSE-ConnectionGUID: MDoqhAHPRvOzgPW9EpxpPg==
X-CSE-MsgGUID: A0uwGDQfTXWW/gzi8BDpNA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.07,260,1708416000"; 
   d="scan'208,217";a="28363699"
X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
  by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 May 2024 22:18:09 -0700
X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35; Mon, 6 May 2024 22:18:08 -0700
X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35 via Frontend Transport; Mon, 6 May 2024 22:18:08 -0700
X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.35; Mon, 6 May 2024 22:18:08 -0700
X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18)
 by PH7PR11MB7450.namprd11.prod.outlook.com (2603:10b6:510:27e::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Tue, 7 May
 2024 05:18:04 +0000
X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com
 ([fe80::13cf:47a8:4737:84e9]) by MN0PR11MB6158.namprd11.prod.outlook.com
 ([fe80::13cf:47a8:4737:84e9%3]) with mapi id 15.20.7544.039; Tue, 7 May 2024
 05:18:03 +0000
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>, Ard Biesheuvel
	<ardb+tianocore@kernel.org>
CC: "Zeng, Star" <star.zeng@intel.com>, Gerd Hoffmann <kraxel@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>, "Dong, Guo" <guo.dong@intel.com>,
	"Rhodes, Sean" <sean@starlabs.systems>, "Lu, James" <james.lu@intel.com>,
	"Guo, Gua" <gua.guo@intel.com>, Abdul Lateef Attar
	<AbdulLateef.Attar@amd.com>, Abner Chang <abner.chang@amd.com>, Tom Lendacky
	<thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib
Thread-Topic: [PATCH v4 00/14] Add SmmRelocationLib
Thread-Index: AQHal9PA9IGV4Fma0kKigj4l3IqtTrGAVyLRgABAhnCACpdQ4IAAF9awgAAFUOA=
Date: Tue, 7 May 2024 05:18:03 +0000
Message-ID: <MN0PR11MB6158AB1BBF4D7536F99C983CFEE42@MN0PR11MB6158.namprd11.prod.outlook.com>
References: <20240426121720.54308-1-jiaxin.wu@intel.com>
 <MN6PR11MB82441132A3DF5296676C0FEB8C1A2@MN6PR11MB8244.namprd11.prod.outlook.com>
  <MN0PR11MB6158A782B76215973B7555BFFEE42@MN0PR11MB6158.namprd11.prod.outlook.com>
 <MW4PR11MB5872F1715272B1A188AB1CDE8CE42@MW4PR11MB5872.namprd11.prod.outlook.com>
In-Reply-To: <MW4PR11MB5872F1715272B1A188AB1CDE8CE42@MW4PR11MB5872.namprd11.prod.outlook.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
msip_labels: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|PH7PR11MB7450:EE_
x-ms-office365-filtering-correlation-id: cd3ecae2-c8fb-4637-0205-08dc6e55120c
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam-message-info: =?us-ascii?Q?iemDwLLh/Rsep+bKx7Q9HQ3DeVbtDSvefOdbBaJkoD7NlCzvfCDaz8a8azTP?=
 =?us-ascii?Q?AebHRfgkkQNOMxzTqQ+gb2DeSyaQfq/tUZTeRV4RpwbJH5ufJi07E2jq/2JM?=
 =?us-ascii?Q?RXTP/M9PzwS0ZvTRq6RHPxPKhX18NTxR/XUjC9q1Vkeore6Izc/U9Ld5qxck?=
 =?us-ascii?Q?x0oJhxGjnr4fpppUD/KLnyE7tXa0UAIbulvLxai6XiqDqIzRe0yN5AF4akJA?=
 =?us-ascii?Q?oAC+a3ZOwGKYDyT8HwQVCaBCJRWI4yZ0fbHhphiXK7hN+ZlZYfYpqrILETil?=
 =?us-ascii?Q?5bf8Mm3qOBuGk0Tp/v5k84FrY9E/iF4JhMy0zpQYgQajTMEBIJyTxtwu+HGR?=
 =?us-ascii?Q?HsVarFABiHhuKQ9j6FWxUl7lMav3v+Kw6Mz+VvRKW+MIHHDqHDZhl1cKeUZV?=
 =?us-ascii?Q?M6Tp+6nLpXzNdD8eAZUfl/Mwc2MYHSc9gMAf3yLodlujXv6tw1zGhAg9OARF?=
 =?us-ascii?Q?AVapCwOi5qzkp16ZP1YV+z3x9MUBB6CZq5yAN0Us83pCJ2TTdo4lfe7Gf/Kf?=
 =?us-ascii?Q?FqCv0Hne98S641FrcmbZm4GF9u/VmfkdlfgSM6u7RwP5LalSgyiq8rtlB1/T?=
 =?us-ascii?Q?OkiKYjz4V6QFDUGcnbZcSdCVl3Id8bEEEXcrQ9sGXg2UoZULJaeSWb3avKlx?=
 =?us-ascii?Q?KSpziB0Qwqei1vTvUYyfJ4BLlKg23TL7vIXfWnRGcNgTCoKUgddTFSV7442V?=
 =?us-ascii?Q?DKrsPsHVSXBj2oPr9FsrpZVbPVpXHk5S4jUrLZIYWnRvQlweCI2FLLjzpSZ9?=
 =?us-ascii?Q?u48TbJnGNa2hLFPsd4fhC18OeZ044jThlHZq3cmWW06SSDoXqLVPOPGAH5vG?=
 =?us-ascii?Q?I+hhlENWWALJWUWsS7EXFc3gAp/EIKmASP4xHcpT476dpA6w4XRK1IuZY9zf?=
 =?us-ascii?Q?PuJlCg8gn29ZSOcP06yip87FFFGOFiSQbXT9gug+ovn1qZefO6VKioqVWQad?=
 =?us-ascii?Q?lNHjfuqUZ51aQJn0VdBpiRKRAyIliseeirQdm9CyYyfe1Djc1Dbk2AsoTuIN?=
 =?us-ascii?Q?Rmr5DRRRy2559wG7azzJH04z4NajF1qVWL9a5G3Mp6hliGqFdeLXy0cTqtAW?=
 =?us-ascii?Q?Y716J8DSngYL56EZHPvrb0vFQ8839DXOeo9y4qB6YUXAf51tnMHukwvVuFNX?=
 =?us-ascii?Q?ozdGvSj/2TLMKM142QAFqsV5QWMv28fh9aPpWZyyWiWeEAc+M3oQcLNIPaLn?=
 =?us-ascii?Q?AGnia6NgfQLFT97CjX0s+hwGoZeHN3QJozcmX4Biqss8HWBEiW+/gNt4gFPD?=
 =?us-ascii?Q?6Rojzr6mzZadRP10YMHipKy2u/jlR1vBzzlBWrwKvg=3D=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?70FNhK590+GBTt9mN1P1TPXD3hZ8nvvj8gx/raUkTi3REVY8EOJbZUqMyiML?=
 =?us-ascii?Q?ZHOf6OOVwGzvzIhA27rCBCFON/ZgHRH8njmGHWnXdVAB/OIUD/GQBPr/lZLV?=
 =?us-ascii?Q?H3+V/rf3pWy8Sv/uMhqZhvpkzLowZGpUSSMUKIbp1oJWsxzaryMEcUD5KrCS?=
 =?us-ascii?Q?p010YjvBOdjlwfLm5/eEy1EceCLqt8wGlOcpDjkQbSRaPVwgVlnFsLlJ05Ry?=
 =?us-ascii?Q?rlzoIxxEWBojEXnj3zQqQ5+3H4cSqeD/1Q9CSa7wAAIOeAYlLhWBJ0P2L+xC?=
 =?us-ascii?Q?vYHLcC3dNfuJvNb0X4Wz4aKpx85yQU1xj2viZdGcm5RWsE4GazEr/Zk7lGws?=
 =?us-ascii?Q?9B95E3orcA9xCh7VUy8XW7c+hP1jJheubKRDzv+Od8umZ6Mj42kjleLWAz9F?=
 =?us-ascii?Q?M8XAJyIyQBFoje+oJwhZhc/FPyCohHrv/0iLYKmCaDGS4M9RaHVToCvyYqcK?=
 =?us-ascii?Q?oRvikOzMm6fYUZOT4Y13GosxqQKra0hJRl/FBHbYWauRwxpFd6wna/pTMs6o?=
 =?us-ascii?Q?a79Tj+ef0Grf4zgAGZbMSpb2Ie2yguifiPV7kWUT01pWLnuNWw30s2mqZe+Q?=
 =?us-ascii?Q?ClWt9tYGnTIsETbB4CrRqgLbsuVlGAjBhnlJS1R26wVLpVE9nif1A+DuOPkt?=
 =?us-ascii?Q?ojv7XVW+bHxXwXnhTWv0IrS0XIsFM6O5UN26p6BGKMU/bKXNGpZwXbKvHlEC?=
 =?us-ascii?Q?UYJFqZ6IXcHzlLvmwyKEGVxbk1w+pmpor2x+3DHsha6hPYw37esd6PrfvAQd?=
 =?us-ascii?Q?ymKYwsKD0isIoIzR53LgUhpIBceBdVQAdl9csOaTKonbavBgF7b+2/LogWDt?=
 =?us-ascii?Q?h8R++BV5eW6dPaR1vl77mIhqRG4zUJ57aJ083/C+169Bn0qcoe/4E/5/yCJF?=
 =?us-ascii?Q?UxwPW7Q306kCZIfCmvz5BHB7EZYn295Wfj2Q9PsGqUsJrKGCq8j7BOna2gqL?=
 =?us-ascii?Q?5XjP0x7nWbyvirWZgttppzJZsFomYdCIYjXn2PLYBo8WQlL33agRYMsQinWe?=
 =?us-ascii?Q?ksPQWd0KsWpgeC0eByZLbeJagWmOh+3hQ7i0CDKf7WDTVc4zpRkbxiKWwHpD?=
 =?us-ascii?Q?P6lPGRY/JNTyiSiVO3HgO5Ernakr+K25bXXy7ZxVRlQR054Wh1SiaHR08h5D?=
 =?us-ascii?Q?8VkigkDKNHTDM0TIpR/fXg81/a68QH8BtORebWOf084O1liVWzhI1JmUlce8?=
 =?us-ascii?Q?a6O42YfSfiJ3AC7dgXVogslm2TjqGz66l9NdrHU9a1UaalaewDr1OvAF1Me4?=
 =?us-ascii?Q?STfRbdMG7JIbFb4QXg/u2VUeK5HSumEi+rUhCP6I+qBFUiTwiZloNjHRunzW?=
 =?us-ascii?Q?YTraN1piNlbxJZkz935NYW3cPDt7EBgKmUGd+tqLfNlTILSzXYday2ANGfEQ?=
 =?us-ascii?Q?tGun7/euw6fOAsMMpCJCg3OCQigWSf6pyij2ycuGMqFa64m2x3kRhfP+Ynor?=
 =?us-ascii?Q?66nYr3zKTOeCTrKu+pvmmsyTqrZ4paBUp6yq+ONBU2N5DOj+NBozzLE61sOO?=
 =?us-ascii?Q?HKMwYKYv08nfpwC2n4ATg8EWgnQTYL6wNNQFoSqC9vnNF7nG8HoSCaefpw+t?=
 =?us-ascii?Q?yQ8kk3etTD2qAjuabF1YokLDTnftg1SENL0/hGzV?=
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd3ecae2-c8fb-4637-0205-08dc6e55120c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2024 05:18:03.3399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: heDS+gYWDb/CmVqYpbO4eD1eCuIBcejMI4jFF607D7UCumMBGgLRFAr1AhbMmgmS98LMMAo1bTLbyoSG9Mvxog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7450
X-OriginatorOrg: intel.com
Precedence: Bulk
List-Subscribe: <mailto:devel+subscribe@edk2.groups.io>
List-Help: <mailto:devel+help@edk2.groups.io>
Sender: devel@edk2.groups.io
List-Id: <devel.edk2.groups.io>
Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io
Resent-Date: Mon, 06 May 2024 22:18:10 -0700
Resent-From: jiaxin.wu@intel.com
Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com
List-Unsubscribe-Post: List-Unsubscribe=One-Click
List-Unsubscribe: <https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/plugh>
X-Gm-Message-State: 2MRdhEbfJwO607PC1YRjlpU7x7686176AA=
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_MN0PR11MB6158AB1BBF4D7536F99C983CFEE42MN0PR11MB6158namp_"
X-GND-Status: LEGIT
Authentication-Results: spool.mail.gandi.net;
	dkim=pass header.d=groups.io header.s=20240206 header.b=YKYxg0dZ;
	dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none);
	spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io

--_000_MN0PR11MB6158AB1BBF4D7536F99C983CFEE42MN0PR11MB6158namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Thanks Jiewen.



From: Yao, Jiewen <jiewen.yao@intel.com>
Sent: Tuesday, May 7, 2024 12:59 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; devel@edk=
2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Zeng, Star <star.zeng@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Ku=
mar, Rahul R <rahul.r.kumar@intel.com>; Dong, Guo <guo.dong@intel.com>; Rho=
des, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua=
 <gua.guo@intel.com>; Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Abner=
 Chang <abner.chang@amd.com>; Tom Lendacky <thomas.lendacky@amd.com>
Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib

Acked-by: Jiewen Yao <Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>>

From: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>
Sent: Tuesday, May 7, 2024 11:39 AM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.=
io<mailto:devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org<=
mailto:ardb+tianocore@kernel.org>>; Yao, Jiewen <jiewen.yao@intel.com<mailt=
o:jiewen.yao@intel.com>>
Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Gerd Hoff=
mann <kraxel@redhat.com<mailto:kraxel@redhat.com>>; Kumar, Rahul R <rahul.r=
.kumar@intel.com<mailto:rahul.r.kumar@intel.com>>; Dong, Guo <guo.dong@inte=
l.com<mailto:guo.dong@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mail=
to:sean@starlabs.systems>>; Lu, James <james.lu@intel.com<mailto:james.lu@i=
ntel.com>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Abdul L=
ateef Attar <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>; =
Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Tom Lendacky=
 <thomas.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib

Hi Jiewen and Ard,

@Yao, Jiewen<mailto:jiewen.yao@intel.com>, @Ard Biesheuvel<mailto:ardb+tian=
ocore@kernel.org>, do you agree we merge the change related to OVMF package=
 since you are the OVMF maintainers. Please help check /review.

The patches have been acked/tested by the Gerd.

  [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF
  [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid
  [PATCH v4 10/14]  OvmfPkg: Refine SmmAccess implementation
  [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is do=
ne or not
  [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase

Thanks,
Jiaxin

From: Wu, Jiaxin
Sent: Tuesday, April 30, 2024 6:14 PM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.=
io<mailto:devel@edk2.groups.io>
Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Gerd Hoff=
mann <kraxel@redhat.com<mailto:kraxel@redhat.com>>; Kumar, Rahul R <rahul.r=
.kumar@intel.com<mailto:rahul.r.kumar@intel.com>>; Dong, Guo <guo.dong@inte=
l.com<mailto:guo.dong@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mail=
to:sean@starlabs.systems>>; Lu, James <james.lu@intel.com<mailto:james.lu@i=
ntel.com>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ard Bie=
sheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; Yao,=
 Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Abdul Lateef A=
ttar <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>; Abner C=
hang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Tom Lendacky <thoma=
s.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib

Thanks Ray, I missed to add some already reviewed-by tag in v4. All V4 patc=
hes are tested & acted by Gerd:

Tested-by: Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>

Acked-by: Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>

For each one: listed as below, *so need Ray "reviewed-by" tag on the patch:=
 05/06/14, need Gerd "reviewed-by" tag on the patch:  08/09/10/11/12*

  [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class
Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>  --> no cha=
nge compared to V3

  [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib librar=
y instance
Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> --> no chan=
ge compared to V3

  [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variables
Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> --> no chan=
ge compared to V3

 [PATCH v4 04/14]  UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory al=
location
Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> --> no chan=
ge compared to V3

  [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary global v=
ariable
  [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex
* Change Based on Ray's comment on V3: split the removal of CpuIndex parame=
ter in a new patch, so add the 06 patch in V4.*

  [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance for AM=
D
Reviewed-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com<mailto:AbdulLate=
ef.Attar@amd.com>> --> no change compared to V3

  [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF
  [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid
  [PATCH v4 10/14]  OvmfPkg: Refine SmmAccess implementation
  [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is do=
ne or not
  [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
*Change Based on Gerd's  comment on V3: 1. Creating the EFI_SMM_SMRAM_MEMOR=
Y_GUID HOB should be moved to its own function.  2) refine the comment in S=
mmAccess 3) refine the commit log.*

  [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocation=
Lib
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>>

  [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation log=
ic
*Change Based on Ray's comment on V3: move the "TileSize" check just below =
the original TileSize calculation logic*

Thanks,
Jiaxin

From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Tuesday, April 30, 2024 2:01 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>; devel@edk=
2.groups.io<mailto:devel@edk2.groups.io>
Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Gerd Hoff=
mann <kraxel@redhat.com<mailto:kraxel@redhat.com>>; Kumar, Rahul R <rahul.r=
.kumar@intel.com<mailto:rahul.r.kumar@intel.com>>; Dong, Guo <guo.dong@inte=
l.com<mailto:guo.dong@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mail=
to:sean@starlabs.systems>>; Lu, James <james.lu@intel.com<mailto:james.lu@i=
ntel.com>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ard Bie=
sheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; Yao,=
 Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Abdul Lateef A=
ttar <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>; Abner C=
hang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Tom Lendacky <thoma=
s.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Subject: Re: [PATCH v4 00/14] Add SmmRelocationLib

Jiaxin,
You need to add the missing Reviewed-by for each patch if the patch doesn't=
 change in V4.

Can you reply to this mail to list what patches have already got Reviewed-b=
y from whom?



Thanks,
Ray
________________________________
From: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>
Sent: Friday, April 26, 2024 20:17
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io=
<mailto:devel@edk2.groups.io>>
Cc: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Zeng, Star <star.z=
eng@intel.com<mailto:star.zeng@intel.com>>; Gerd Hoffmann <kraxel@redhat.co=
m<mailto:kraxel@redhat.com>>; Kumar, Rahul R <rahul.r.kumar@intel.com<mailt=
o:rahul.r.kumar@intel.com>>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@=
intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.syste=
ms>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Guo, Gua <=
gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ard Biesheuvel <ardb+tianocor=
e@kernel.org<mailto:ardb+tianocore@kernel.org>>; Yao, Jiewen <jiewen.yao@in=
tel.com<mailto:jiewen.yao@intel.com>>; Abdul Lateef Attar <AbdulLateef.Atta=
r@amd.com<mailto:AbdulLateef.Attar@amd.com>>; Abner Chang <abner.chang@amd.=
com<mailto:abner.chang@amd.com>>; Tom Lendacky <thomas.lendacky@amd.com<mai=
lto:thomas.lendacky@amd.com>>
Subject: [PATCH v4 00/14] Add SmmRelocationLib

PR: https://github.com/tianocore/edk2/pull/5546

Intel plans to separate the smbase relocation logic from
PiSmmCpuDxeSmm driver, and the related behavior will be
moved to the new interface defined by the SmmRelocationLib
class.

The SmmRelocationLib class provides the SmmRelocationInit()
interface for platform to do the smbase relocation, which
shall provide below 2 functionalities:
1. Relocate smbases for each processor.
2. Create the gSmmBaseHobGuid HOB.

With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at
a later phase) can be simplfied as below for SMM init:
1. Consume the gSmmBaseHobGuid HOB for the relocated smbases
for each Processor.
2. Execute the early SMM Init.

Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Cc: Zeng Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>
Cc: Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Cc: Rahul Kumar <rahul1.kumar@intel.com<mailto:rahul1.kumar@intel.com>>
Cc: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>>
Cc: Sean Rhodes <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Cc: James Lu <james.lu@intel.com<mailto:james.lu@intel.com>>
Cc: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.=
org>>
Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@=
amd.com>>
Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
Cc: Tom Lendacky <thomas.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>

Jiaxin Wu (14):
  UefiCpuPkg: Add SmmRelocationLib class
  UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance
  UefiCpuPkg/SmmRelocationLib: Rename global variables
  UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation
  UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable
  UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex
  UefiCpuPkg/SmmRelocationLib: Add library instance for AMD
  OvmfPkg/SmmRelocationLib: Add library instance for OVMF
  OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid
  OvmfPkg: Refine SmmAccess implementation
  OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not
  OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
  UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib
  UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic

 OvmfPkg/AmdSev/AmdSevX64.dsc                       |   1 +
 OvmfPkg/CloudHv/CloudHvX64.dsc                     |   1 +
 OvmfPkg/Library/PlatformInitLib/MemDetect.c        | 135 +++--
 .../Library/PlatformInitLib/PlatformInitLib.inf    |   6 +-
 .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c  |  33 +-
 .../Library/SmmRelocationLib}/Ia32/Semaphore.c     |  13 +-
 .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm    |  83 +++-
 .../SmmRelocationLib/InternalSmmRelocationLib.h    | 127 +++++
 .../Library/SmmRelocationLib/SmmRelocationLib.c    | 549 +++++++++++++++++=
++++
 .../Library/SmmRelocationLib/SmmRelocationLib.inf  |  60 +++
 .../SmmRelocationLib/SmramSaveStateConfig.c        | 100 ++++
 .../Library/SmmRelocationLib}/X64/Semaphore.c      |  13 +-
 .../Library/SmmRelocationLib}/X64/SmmInit.nasm     |  85 +++-
 OvmfPkg/Microvm/MicrovmX64.dsc                     |   1 +
 OvmfPkg/OvmfPkgIa32.dsc                            |   1 +
 OvmfPkg/OvmfPkgIa32X64.dsc                         |   1 +
 OvmfPkg/OvmfPkgX64.dsc                             |   1 +
 OvmfPkg/PlatformPei/Platform.c                     |   3 +
 OvmfPkg/PlatformPei/Platform.h                     |   5 +
 OvmfPkg/PlatformPei/PlatformPei.inf                |   5 +-
 OvmfPkg/PlatformPei/SmmRelocation.c                |  80 +++
 OvmfPkg/SmmAccess/SmmAccess2Dxe.c                  |   4 +-
 OvmfPkg/SmmAccess/SmmAccess2Dxe.inf                |   5 +
 OvmfPkg/SmmAccess/SmmAccessPei.c                   | 116 ++---
 OvmfPkg/SmmAccess/SmmAccessPei.inf                 |  11 +-
 OvmfPkg/SmmAccess/SmramInternal.c                  |  72 +--
 OvmfPkg/SmmAccess/SmramInternal.h                  |  19 +-
 UefiCpuPkg/Include/Library/SmmRelocationLib.h      |  42 ++
 .../SmmRelocationLib/AmdSmmRelocationLib.inf       |  60 +++
 .../SmmRelocationLib/AmdSmramSaveStateConfig.c     | 125 +++++
 .../SmmRelocationLib}/Ia32/Semaphore.c             |  13 +-
 .../SmmRelocationLib}/Ia32/SmmInit.nasm            |  83 +++-
 .../SmmRelocationLib/InternalSmmRelocationLib.h    | 127 +++++
 .../Library/SmmRelocationLib/SmmRelocationLib.c    | 549 +++++++++++++++++=
++++
 .../Library/SmmRelocationLib/SmmRelocationLib.inf  |  61 +++
 .../SmmRelocationLib/SmramSaveStateConfig.c        | 136 +++++
 .../SmmRelocationLib}/X64/Semaphore.c              |  13 +-
 .../SmmRelocationLib}/X64/SmmInit.nasm             |  85 +++-
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c                  |  21 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c              |  10 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c         | 334 ++-----------
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h         | 103 +---
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf       |   4 -
 UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h              |   2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c         |  69 ---
 UefiCpuPkg/UefiCpuPkg.dec                          |   3 +
 UefiCpuPkg/UefiCpuPkg.dsc                          |   2 +
 UefiPayloadPkg/UefiPayloadPkg.dsc                  |   2 +
 48 files changed, 2578 insertions(+), 796 deletions(-)
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/Ia3=
2/Semaphore.c (71%)
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/Ia3=
2/SmmInit.nasm (47%)
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationL=
ib.h
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf
 create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/X64=
/Semaphore.c (78%)
 copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> OvmfPkg/Library/SmmRelocationLib}/X64=
/SmmInit.nasm (59%)
 create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c
 create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib=
.inf
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateCo=
nfig.c
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/Ia32/Sema=
phore.c (71%)
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/Ia32/SmmI=
nit.nasm (47%)
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocati=
onLib.h
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.in=
f
 create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfi=
g.c
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/X64/Semap=
hore.c (78%)
 rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> Library/SmmRelocationLib}/X64/SmmIn=
it.nasm (59%)

--
2.16.2.windows.1


-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118635): https://edk2.groups.io/g/devel/message/118635
Mute This Topic: https://groups.io/mt/105748911/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-



--_000_MN0PR11MB6158AB1BBF4D7536F99C983CFEE42MN0PR11MB6158namp_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:DengXian;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:DengXian;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:Aptos;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
	{mso-style-priority:99;
	mso-style-link:"Plain Text Char";
	margin:0in;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;
	mso-ligatures:standardcontextual;}
span.PlainTextChar
	{mso-style-name:"Plain Text Char";
	mso-style-priority:99;
	mso-style-link:"Plain Text";
	font-family:"Calibri",sans-serif;
	mso-ligatures:standardcontextual;}
span.EmailStyle23
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;
	mso-ligatures:none;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3D"EN-US" link=3D"blue" vlink=3D"purple" style=3D"word-wrap:brea=
k-word">
<div class=3D"WordSection1">
<p class=3D"MsoNormal">Thanks Jiewen.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<div style=3D"border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt">
<div>
<div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in =
0in 0in">
<p class=3D"MsoNormal"><b>From:</b> Yao, Jiewen &lt;jiewen.yao@intel.com&gt=
; <br>
<b>Sent:</b> Tuesday, May 7, 2024 12:59 PM<br>
<b>To:</b> Wu, Jiaxin &lt;jiaxin.wu@intel.com&gt;; Ni, Ray &lt;ray.ni@intel=
.com&gt;; devel@edk2.groups.io; Ard Biesheuvel &lt;ardb+tianocore@kernel.or=
g&gt;<br>
<b>Cc:</b> Zeng, Star &lt;star.zeng@intel.com&gt;; Gerd Hoffmann &lt;kraxel=
@redhat.com&gt;; Kumar, Rahul R &lt;rahul.r.kumar@intel.com&gt;; Dong, Guo =
&lt;guo.dong@intel.com&gt;; Rhodes, Sean &lt;sean@starlabs.systems&gt;; Lu,=
 James &lt;james.lu@intel.com&gt;; Guo, Gua &lt;gua.guo@intel.com&gt;; Abdu=
l
 Lateef Attar &lt;AbdulLateef.Attar@amd.com&gt;; Abner Chang &lt;abner.chan=
g@amd.com&gt;; Tom Lendacky &lt;thomas.lendacky@amd.com&gt;<br>
<b>Subject:</b> RE: [PATCH v4 00/14] Add SmmRelocationLib<o:p></o:p></p>
</div>
</div>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Acked-by: Jiewen Yao &lt;<a href=3D"mailto:Jiewen.ya=
o@intel.com">Jiewen.yao@intel.com</a>&gt;<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<div style=3D"border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt">
<div>
<div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in =
0in 0in">
<p class=3D"MsoNormal"><b>From:</b> Wu, Jiaxin &lt;<a href=3D"mailto:jiaxin=
.wu@intel.com">jiaxin.wu@intel.com</a>&gt;
<br>
<b>Sent:</b> Tuesday, May 7, 2024 11:39 AM<br>
<b>To:</b> Ni, Ray &lt;<a href=3D"mailto:ray.ni@intel.com">ray.ni@intel.com=
</a>&gt;; <a href=3D"mailto:devel@edk2.groups.io">
devel@edk2.groups.io</a>; Ard Biesheuvel &lt;<a href=3D"mailto:ardb+tianoco=
re@kernel.org">ardb+tianocore@kernel.org</a>&gt;; Yao, Jiewen &lt;<a href=
=3D"mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>&gt;<br>
<b>Cc:</b> Zeng, Star &lt;<a href=3D"mailto:star.zeng@intel.com">star.zeng@=
intel.com</a>&gt;; Gerd Hoffmann &lt;<a href=3D"mailto:kraxel@redhat.com">k=
raxel@redhat.com</a>&gt;; Kumar, Rahul R &lt;<a href=3D"mailto:rahul.r.kuma=
r@intel.com">rahul.r.kumar@intel.com</a>&gt;; Dong, Guo
 &lt;<a href=3D"mailto:guo.dong@intel.com">guo.dong@intel.com</a>&gt;; Rhod=
es, Sean &lt;<a href=3D"mailto:sean@starlabs.systems">sean@starlabs.systems=
</a>&gt;; Lu, James &lt;<a href=3D"mailto:james.lu@intel.com">james.lu@inte=
l.com</a>&gt;; Guo, Gua &lt;<a href=3D"mailto:gua.guo@intel.com">gua.guo@in=
tel.com</a>&gt;;
 Abdul Lateef Attar &lt;<a href=3D"mailto:AbdulLateef.Attar@amd.com">AbdulL=
ateef.Attar@amd.com</a>&gt;; Abner Chang &lt;<a href=3D"mailto:abner.chang@=
amd.com">abner.chang@amd.com</a>&gt;; Tom Lendacky &lt;<a href=3D"mailto:th=
omas.lendacky@amd.com">thomas.lendacky@amd.com</a>&gt;<br>
<b>Subject:</b> RE: [PATCH v4 00/14] Add SmmRelocationLib<o:p></o:p></p>
</div>
</div>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Hi Jiewen and Ard,<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal"><a id=3D"OWAAMA3ED3DC3F518444E8EDB06D9BD70EEBB" href=
=3D"mailto:jiewen.yao@intel.com"><span style=3D"font-family:&quot;Calibri&q=
uot;,sans-serif;text-decoration:none">@Yao, Jiewen</span></a>,
<a id=3D"OWAAM0DCBAD59383A4E7485208C750B3EDCA5" href=3D"mailto:ardb+tianoco=
re@kernel.org">
<span style=3D"font-family:&quot;Calibri&quot;,sans-serif;text-decoration:n=
one">@Ard Biesheuvel</span></a>, do you agree we merge the change related t=
o OVMF package since you are the OVMF maintainers. Please help check /revie=
w.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">The patches have been acked/tested by the Gerd.<o:p>=
</o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">&nbsp; [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Ad=
d library instance for OVMF<br>
&nbsp; [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryG=
uid<br>
&nbsp; [PATCH v4 10/14] &nbsp;OvmfPkg: Refine SmmAccess implementation<br>
&nbsp; [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation =
is done or not<br>
&nbsp; [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase<=
o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Thanks,<o:p></o:p></p>
<p class=3D"MsoNormal">Jiaxin <o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<div style=3D"border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt">
<div>
<div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in =
0in 0in">
<p class=3D"MsoNormal"><b>From:</b> Wu, Jiaxin <br>
<b>Sent:</b> Tuesday, April 30, 2024 6:14 PM<br>
<b>To:</b> Ni, Ray &lt;<a href=3D"mailto:ray.ni@intel.com">ray.ni@intel.com=
</a>&gt;; <a href=3D"mailto:devel@edk2.groups.io">
devel@edk2.groups.io</a><br>
<b>Cc:</b> Zeng, Star &lt;<a href=3D"mailto:star.zeng@intel.com">star.zeng@=
intel.com</a>&gt;; Gerd Hoffmann &lt;<a href=3D"mailto:kraxel@redhat.com">k=
raxel@redhat.com</a>&gt;; Kumar, Rahul R &lt;<a href=3D"mailto:rahul.r.kuma=
r@intel.com">rahul.r.kumar@intel.com</a>&gt;; Dong, Guo
 &lt;<a href=3D"mailto:guo.dong@intel.com">guo.dong@intel.com</a>&gt;; Rhod=
es, Sean &lt;<a href=3D"mailto:sean@starlabs.systems">sean@starlabs.systems=
</a>&gt;; Lu, James &lt;<a href=3D"mailto:james.lu@intel.com">james.lu@inte=
l.com</a>&gt;; Guo, Gua &lt;<a href=3D"mailto:gua.guo@intel.com">gua.guo@in=
tel.com</a>&gt;;
 Ard Biesheuvel &lt;<a href=3D"mailto:ardb+tianocore@kernel.org">ardb+tiano=
core@kernel.org</a>&gt;; Yao, Jiewen &lt;<a href=3D"mailto:jiewen.yao@intel=
.com">jiewen.yao@intel.com</a>&gt;; Abdul Lateef Attar &lt;<a href=3D"mailt=
o:AbdulLateef.Attar@amd.com">AbdulLateef.Attar@amd.com</a>&gt;;
 Abner Chang &lt;<a href=3D"mailto:abner.chang@amd.com">abner.chang@amd.com=
</a>&gt;; Tom Lendacky &lt;<a href=3D"mailto:thomas.lendacky@amd.com">thoma=
s.lendacky@amd.com</a>&gt;<br>
<b>Subject:</b> RE: [PATCH v4 00/14] Add SmmRelocationLib<o:p></o:p></p>
</div>
</div>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Thanks Ray, I missed to add some already reviewed-by=
 tag in v4. All V4 patches are tested &amp; acted by Gerd:<o:p></o:p></p>
<p class=3D"MsoPlainText">Tested-by: Gerd Hoffmann &lt;<a href=3D"mailto:kr=
axel@redhat.com">kraxel@redhat.com</a>&gt;<o:p></o:p></p>
<p class=3D"MsoPlainText">Acked-by: Gerd Hoffmann &lt;<a href=3D"mailto:kra=
xel@redhat.com">kraxel@redhat.com</a>&gt;<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">For each one: listed as below, *<b>so need Ray &#822=
0;reviewed-by&#8221; tag on the patch: 05/06/14, need Gerd &#8220;reviewed-=
by&#8221; tag on the patch: &nbsp;08/09/10/11/12</b>*<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">&nbsp; [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocatio=
nLib class<o:p></o:p></p>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Reviewed-by: Ray Ni &lt;<a href=3D"mailto:ray.ni@intel.com=
">ray.ni@intel.com</a>&gt;&nbsp; --&gt; no change compared to V3<o:p></o:p>=
</span></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib l=
ibrary instance<o:p></o:p></p>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Reviewed-by: Ray Ni &lt;<a href=3D"mailto:ray.ni@intel.com=
">ray.ni@intel.com</a>&gt; --&gt; no change compared to V3<o:p></o:p></span=
></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variable=
s<o:p></o:p></p>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Reviewed-by: Ray Ni &lt;<a href=3D"mailto:ray.ni@intel.com=
">ray.ni@intel.com</a>&gt; --&gt; no change compared to V3<o:p></o:p></span=
></p>
<p class=3D"MsoNormal"><br>
&nbsp;[PATCH v4 04/14] &nbsp;UefiCpuPkg/SmmRelocationLib: Avoid unnecessary=
 memory allocation<o:p></o:p></p>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Reviewed-by: Ray Ni &lt;<a href=3D"mailto:ray.ni@intel.com=
">ray.ni@intel.com</a>&gt; --&gt; no change compared to V3<o:p></o:p></span=
></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary glo=
bal variable<br>
&nbsp; [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary Cpu=
Index<o:p></o:p></p>
<p class=3D"MsoNormal">* <b>Change Based on Ray&#8217;s comment on V3: </b>=
<b><span style=3D"font-family:&quot;Aptos&quot;,sans-serif;color:black">spl=
it the removal of CpuIndex parameter in a new patch, so add the 06 patch in=
 V4.</span></b><span style=3D"font-family:&quot;Aptos&quot;,sans-serif;colo=
r:black">*</span><o:p></o:p></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance f=
or AMD<o:p></o:p></p>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Reviewed-by: Abdul Lateef Attar &lt;</span><span class=3D"=
MsoHyperlink"><a href=3D"mailto:AbdulLateef.Attar@amd.com">AbdulLateef.Atta=
r@amd.com</a></span><span style=3D"font-family:&quot;Aptos&quot;,sans-serif=
;color:black">&gt;
 --&gt; no change compared to V3<o:p></o:p></span></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for =
OVMF<br>
&nbsp; [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryG=
uid<br>
&nbsp; [PATCH v4 10/14] &nbsp;OvmfPkg: Refine SmmAccess implementation<br>
&nbsp; [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation =
is done or not<br>
&nbsp; [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase<=
o:p></o:p></p>
<p class=3D"MsoNormal">*<b>Change Based on Gerd&#8217;s&nbsp; comment on V3=
: 1. Creating the EFI_SMM_SMRAM_MEMORY_GUID HOB should be moved to its own =
function.&nbsp; 2) refine the comment in SmmAccess 3) refine the commit log=
.</b>*<o:p></o:p></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmReloc=
ationLib<o:p></o:p></p>
<p class=3D"MsoNormal">Reviewed-by: Gua Guo &lt;<span class=3D"MsoHyperlink=
"><a href=3D"mailto:gua.guo@intel.com">gua.guo@intel.com</a></span>&gt;<o:p=
></o:p></p>
<p class=3D"MsoNormal">Reviewed-by: Guo Dong &lt;<span class=3D"MsoHyperlin=
k"><a href=3D"mailto:guo.dong@intel.com">guo.dong@intel.com</a></span>&gt;<=
o:p></o:p></p>
<p class=3D"MsoNormal"><br>
&nbsp; [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocatio=
n logic<o:p></o:p></p>
<p class=3D"MsoNormal">*<b>Change Based on Ray&#8217;s comment on V3: </b><=
b><span style=3D"font-family:&quot;Aptos&quot;,sans-serif;color:black">move=
 the &quot;TileSize&quot; check just below the original TileSize calculatio=
n logic</span></b><span style=3D"font-family:&quot;Aptos&quot;,sans-serif;c=
olor:black">*</span><o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Thanks,<o:p></o:p></p>
<p class=3D"MsoNormal">Jiaxin <o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<div style=3D"border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt">
<div>
<div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in =
0in 0in">
<p class=3D"MsoNormal"><b>From:</b> Ni, Ray &lt;<a href=3D"mailto:ray.ni@in=
tel.com">ray.ni@intel.com</a>&gt;
<br>
<b>Sent:</b> Tuesday, April 30, 2024 2:01 PM<br>
<b>To:</b> Wu, Jiaxin &lt;<a href=3D"mailto:jiaxin.wu@intel.com">jiaxin.wu@=
intel.com</a>&gt;;
<a href=3D"mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>
<b>Cc:</b> Zeng, Star &lt;<a href=3D"mailto:star.zeng@intel.com">star.zeng@=
intel.com</a>&gt;; Gerd Hoffmann &lt;<a href=3D"mailto:kraxel@redhat.com">k=
raxel@redhat.com</a>&gt;; Kumar, Rahul R &lt;<a href=3D"mailto:rahul.r.kuma=
r@intel.com">rahul.r.kumar@intel.com</a>&gt;; Dong, Guo
 &lt;<a href=3D"mailto:guo.dong@intel.com">guo.dong@intel.com</a>&gt;; Rhod=
es, Sean &lt;<a href=3D"mailto:sean@starlabs.systems">sean@starlabs.systems=
</a>&gt;; Lu, James &lt;<a href=3D"mailto:james.lu@intel.com">james.lu@inte=
l.com</a>&gt;; Guo, Gua &lt;<a href=3D"mailto:gua.guo@intel.com">gua.guo@in=
tel.com</a>&gt;;
 Ard Biesheuvel &lt;<a href=3D"mailto:ardb+tianocore@kernel.org">ardb+tiano=
core@kernel.org</a>&gt;; Yao, Jiewen &lt;<a href=3D"mailto:jiewen.yao@intel=
.com">jiewen.yao@intel.com</a>&gt;; Abdul Lateef Attar &lt;<a href=3D"mailt=
o:AbdulLateef.Attar@amd.com">AbdulLateef.Attar@amd.com</a>&gt;;
 Abner Chang &lt;<a href=3D"mailto:abner.chang@amd.com">abner.chang@amd.com=
</a>&gt;; Tom Lendacky &lt;<a href=3D"mailto:thomas.lendacky@amd.com">thoma=
s.lendacky@amd.com</a>&gt;<br>
<b>Subject:</b> Re: [PATCH v4 00/14] Add SmmRelocationLib<o:p></o:p></p>
</div>
</div>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Jiaxin,<o:p></o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">You need to add the missing Reviewed-by for each patch if =
the patch doesn't change in V4.<o:p></o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black"><o:p>&nbsp;</o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Can you reply to this mail to list what patches have alrea=
dy got Reviewed-by from whom?<o:p></o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black"><o:p>&nbsp;</o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black"><o:p>&nbsp;</o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black"><o:p>&nbsp;</o:p></span></p>
</div>
<div id=3D"Signature">
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Thanks,<o:p></o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal"><span style=3D"font-family:&quot;Aptos&quot;,sans-se=
rif;color:black">Ray<o:p></o:p></span></p>
</div>
</div>
<div class=3D"MsoNormal" align=3D"center" style=3D"text-align:center">
<hr size=3D"2" width=3D"98%" align=3D"center">
</div>
<div id=3D"divRplyFwdMsg">
<p class=3D"MsoNormal"><b><span style=3D"color:black">From:</span></b><span=
 style=3D"color:black"> Wu, Jiaxin &lt;<a href=3D"mailto:jiaxin.wu@intel.co=
m">jiaxin.wu@intel.com</a>&gt;<br>
<b>Sent:</b> Friday, April 26, 2024 20:17<br>
<b>To:</b> <a href=3D"mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>=
 &lt;<a href=3D"mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>&gt;<b=
r>
<b>Cc:</b> Ni, Ray &lt;<a href=3D"mailto:ray.ni@intel.com">ray.ni@intel.com=
</a>&gt;; Zeng, Star &lt;<a href=3D"mailto:star.zeng@intel.com">star.zeng@i=
ntel.com</a>&gt;; Gerd Hoffmann &lt;<a href=3D"mailto:kraxel@redhat.com">kr=
axel@redhat.com</a>&gt;; Kumar, Rahul R &lt;<a href=3D"mailto:rahul.r.kumar=
@intel.com">rahul.r.kumar@intel.com</a>&gt;;
 Dong, Guo &lt;<a href=3D"mailto:guo.dong@intel.com">guo.dong@intel.com</a>=
&gt;; Rhodes, Sean &lt;<a href=3D"mailto:sean@starlabs.systems">sean@starla=
bs.systems</a>&gt;; Lu, James &lt;<a href=3D"mailto:james.lu@intel.com">jam=
es.lu@intel.com</a>&gt;; Guo, Gua &lt;<a href=3D"mailto:gua.guo@intel.com">=
gua.guo@intel.com</a>&gt;;
 Ard Biesheuvel &lt;<a href=3D"mailto:ardb+tianocore@kernel.org">ardb+tiano=
core@kernel.org</a>&gt;; Yao, Jiewen &lt;<a href=3D"mailto:jiewen.yao@intel=
.com">jiewen.yao@intel.com</a>&gt;; Abdul Lateef Attar &lt;<a href=3D"mailt=
o:AbdulLateef.Attar@amd.com">AbdulLateef.Attar@amd.com</a>&gt;;
 Abner Chang &lt;<a href=3D"mailto:abner.chang@amd.com">abner.chang@amd.com=
</a>&gt;; Tom Lendacky &lt;<a href=3D"mailto:thomas.lendacky@amd.com">thoma=
s.lendacky@amd.com</a>&gt;<br>
<b>Subject:</b> [PATCH v4 00/14] Add SmmRelocationLib</span> <o:p></o:p></p=
>
<div>
<p class=3D"MsoNormal">&nbsp;<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class=3D"MsoNormal" style=3D"margin-bottom:12.0pt">PR: <a href=3D"https:=
//github.com/tianocore/edk2/pull/5546">
https://github.com/tianocore/edk2/pull/5546</a><br>
<br>
Intel plans to separate the smbase relocation logic from<br>
PiSmmCpuDxeSmm driver, and the related behavior will be<br>
moved to the new interface defined by the SmmRelocationLib<br>
class.<br>
<br>
The SmmRelocationLib class provides the SmmRelocationInit()<br>
interface for platform to do the smbase relocation, which<br>
shall provide below 2 functionalities:<br>
1. Relocate smbases for each processor.<br>
2. Create the gSmmBaseHobGuid HOB.<br>
<br>
With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at<br>
a later phase) can be simplfied as below for SMM init:<br>
1. Consume the gSmmBaseHobGuid HOB for the relocated smbases<br>
for each Processor.<br>
2. Execute the early SMM Init.<br>
<br>
Cc: Ray Ni &lt;<a href=3D"mailto:ray.ni@intel.com">ray.ni@intel.com</a>&gt;=
<br>
Cc: Zeng Star &lt;<a href=3D"mailto:star.zeng@intel.com">star.zeng@intel.co=
m</a>&gt;<br>
Cc: Gerd Hoffmann &lt;<a href=3D"mailto:kraxel@redhat.com">kraxel@redhat.co=
m</a>&gt;<br>
Cc: Rahul Kumar &lt;<a href=3D"mailto:rahul1.kumar@intel.com">rahul1.kumar@=
intel.com</a>&gt;<br>
Cc: Guo Dong &lt;<a href=3D"mailto:guo.dong@intel.com">guo.dong@intel.com</=
a>&gt;<br>
Cc: Sean Rhodes &lt;<a href=3D"mailto:sean@starlabs.systems">sean@starlabs.=
systems</a>&gt;<br>
Cc: James Lu &lt;<a href=3D"mailto:james.lu@intel.com">james.lu@intel.com</=
a>&gt;<br>
Cc: Gua Guo &lt;<a href=3D"mailto:gua.guo@intel.com">gua.guo@intel.com</a>&=
gt;<br>
Cc: Ard Biesheuvel &lt;<a href=3D"mailto:ardb+tianocore@kernel.org">ardb+ti=
anocore@kernel.org</a>&gt;<br>
Cc: Jiewen Yao &lt;<a href=3D"mailto:jiewen.yao@intel.com">jiewen.yao@intel=
.com</a>&gt;<br>
Cc: Abdul Lateef Attar &lt;<a href=3D"mailto:AbdulLateef.Attar@amd.com">Abd=
ulLateef.Attar@amd.com</a>&gt;<br>
Cc: Abner Chang &lt;<a href=3D"mailto:abner.chang@amd.com">abner.chang@amd.=
com</a>&gt;<br>
Cc: Tom Lendacky &lt;<a href=3D"mailto:thomas.lendacky@amd.com">thomas.lend=
acky@amd.com</a>&gt;<br>
Signed-off-by: Jiaxin Wu &lt;<a href=3D"mailto:jiaxin.wu@intel.com">jiaxin.=
wu@intel.com</a>&gt;<br>
<br>
Jiaxin Wu (14):<br>
&nbsp; UefiCpuPkg: Add SmmRelocationLib class<br>
&nbsp; UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance<b=
r>
&nbsp; UefiCpuPkg/SmmRelocationLib: Rename global variables<br>
&nbsp; UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation<br>
&nbsp; UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable<br>
&nbsp; UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex<br>
&nbsp; UefiCpuPkg/SmmRelocationLib: Add library instance for AMD<br>
&nbsp; OvmfPkg/SmmRelocationLib: Add library instance for OVMF<br>
&nbsp; OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid<br>
&nbsp; OvmfPkg: Refine SmmAccess implementation<br>
&nbsp; OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not<br=
>
&nbsp; OvmfPkg/PlatformPei: Relocate SmBases in PEI phase<br>
&nbsp; UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib<br>
&nbsp; UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic<br>
<br>
&nbsp;OvmfPkg/AmdSev/AmdSevX64.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp; |&nbsp;&nbsp; 1 +<br>
&nbsp;OvmfPkg/CloudHv/CloudHvX64.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; |&nbsp;&nbsp; 1 +<br>
&nbsp;OvmfPkg/Library/PlatformInitLib/MemDetect.c&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp; | 135 +++--<br>
&nbsp;.../Library/PlatformInitLib/PlatformInitLib.inf&nbsp;&nbsp;&nbsp; |&n=
bsp;&nbsp; 6 +-<br>
&nbsp;.../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c&nbsp; |&nbsp; 33 +-=
<br>
&nbsp;.../Library/SmmRelocationLib}/Ia32/Semaphore.c&nbsp;&nbsp;&nbsp;&nbsp=
; |&nbsp; 13 +-<br>
&nbsp;.../Library/SmmRelocationLib}/Ia32/SmmInit.nasm&nbsp;&nbsp;&nbsp; |&n=
bsp; 83 +++-<br>
&nbsp;.../SmmRelocationLib/InternalSmmRelocationLib.h&nbsp;&nbsp;&nbsp; | 1=
27 +++++<br>
&nbsp;.../Library/SmmRelocationLib/SmmRelocationLib.c&nbsp;&nbsp;&nbsp; | 5=
49 +++++++++++++++++++++<br>
&nbsp;.../Library/SmmRelocationLib/SmmRelocationLib.inf&nbsp; |&nbsp; 60 ++=
+<br>
&nbsp;.../SmmRelocationLib/SmramSaveStateConfig.c&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp; | 100 ++++<br>
&nbsp;.../Library/SmmRelocationLib}/X64/Semaphore.c&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; |&nbsp; 13 +-<br>
&nbsp;.../Library/SmmRelocationLib}/X64/SmmInit.nasm&nbsp;&nbsp;&nbsp;&nbsp=
; |&nbsp; 85 +++-<br>
&nbsp;OvmfPkg/Microvm/MicrovmX64.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; |&nbsp;&nbsp; 1 +<br>
&nbsp;OvmfPkg/OvmfPkgIa32.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 1 +<br>
&nbsp;OvmfPkg/OvmfPkgIa32X64.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 1 +<br>
&nbsp;OvmfPkg/OvmfPkgX64.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 1 +<br>
&nbsp;OvmfPkg/PlatformPei/Platform.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; |&nbsp;&nbsp; 3 +<br>
&nbsp;OvmfPkg/PlatformPei/Platform.h&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; |&nbsp;&nbsp; 5 +<br>
&nbsp;OvmfPkg/PlatformPei/PlatformPei.inf&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 5 +-=
<br>
&nbsp;OvmfPkg/PlatformPei/SmmRelocation.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 80 +++<br>
&nbsp;OvmfPkg/SmmAccess/SmmAccess2Dxe.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&=
nbsp; 4 +-<br>
&nbsp;OvmfPkg/SmmAccess/SmmAccess2Dxe.inf&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 5 +<=
br>
&nbsp;OvmfPkg/SmmAccess/SmmAccessPei.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | 1=
16 ++---<br>
&nbsp;OvmfPkg/SmmAccess/SmmAccessPei.inf&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 11 +-=
<br>
&nbsp;OvmfPkg/SmmAccess/SmramInternal.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; =
72 +--<br>
&nbsp;OvmfPkg/SmmAccess/SmramInternal.h&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; =
19 +-<br>
&nbsp;UefiCpuPkg/Include/Library/SmmRelocationLib.h&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; |&nbsp; 42 ++<br>
&nbsp;.../SmmRelocationLib/AmdSmmRelocationLib.inf&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp; |&nbsp; 60 +++<br>
&nbsp;.../SmmRelocationLib/AmdSmramSaveStateConfig.c&nbsp;&nbsp;&nbsp;&nbsp=
; | 125 +++++<br>
&nbsp;.../SmmRelocationLib}/Ia32/Semaphore.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 13 +-<br>
&nbsp;.../SmmRelocationLib}/Ia32/SmmInit.nasm&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 83 +++-<br>
&nbsp;.../SmmRelocationLib/InternalSmmRelocationLib.h&nbsp;&nbsp;&nbsp; | 1=
27 +++++<br>
&nbsp;.../Library/SmmRelocationLib/SmmRelocationLib.c&nbsp;&nbsp;&nbsp; | 5=
49 +++++++++++++++++++++<br>
&nbsp;.../Library/SmmRelocationLib/SmmRelocationLib.inf&nbsp; |&nbsp; 61 ++=
+<br>
&nbsp;.../SmmRelocationLib/SmramSaveStateConfig.c&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp; | 136 +++++<br>
&nbsp;.../SmmRelocationLib}/X64/Semaphore.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 13 +-<br>
&nbsp;.../SmmRelocationLib}/X64/SmmInit.nasm&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 85 +++-<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; =
21 +-<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 10 +-<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp; | 334 ++-----------<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp; | 103 +---<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp; |&nbsp;&nbsp; 4 -<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 2 +-<br>
&nbsp;UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp; |&nbsp; 69 ---<br>
&nbsp;UefiCpuPkg/UefiCpuPkg.dec&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 3 +<br>
&nbsp;UefiCpuPkg/UefiCpuPkg.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 2 +<br>
&nbsp;UefiPayloadPkg/UefiPayloadPkg.dsc&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&=
nbsp; 2 +<br>
&nbsp;48 files changed, 2578 insertions(+), 796 deletions(-)<br>
&nbsp;copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D&gt; OvmfPkg/Library/SmmRelocation=
Lib}/Ia32/Semaphore.c (71%)<br>
&nbsp;copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D&gt; OvmfPkg/Library/SmmRelocation=
Lib}/Ia32/SmmInit.nasm (47%)<br>
&nbsp;create mode 100644 OvmfPkg/Library/SmmRelocationLib/InternalSmmReloca=
tionLib.h<br>
&nbsp;create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.=
c<br>
&nbsp;create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.=
inf<br>
&nbsp;create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmramSaveStateCon=
fig.c<br>
&nbsp;copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D&gt; OvmfPkg/Library/SmmRelocation=
Lib}/X64/Semaphore.c (78%)<br>
&nbsp;copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D&gt; OvmfPkg/Library/SmmRelocation=
Lib}/X64/SmmInit.nasm (59%)<br>
&nbsp;create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c<br>
&nbsp;create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h<br>
&nbsp;create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocati=
onLib.inf<br>
&nbsp;create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveSt=
ateConfig.c<br>
&nbsp;rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D&gt; Library/SmmRelocationLib}/I=
a32/Semaphore.c (71%)<br>
&nbsp;rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D&gt; Library/SmmRelocationLib}/I=
a32/SmmInit.nasm (47%)<br>
&nbsp;create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRel=
ocationLib.h<br>
&nbsp;create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationL=
ib.c<br>
&nbsp;create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationL=
ib.inf<br>
&nbsp;create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmramSaveState=
Config.c<br>
&nbsp;rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D&gt; Library/SmmRelocationLib}/X=
64/Semaphore.c (78%)<br>
&nbsp;rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D&gt; Library/SmmRelocationLib}/X=
64/SmmInit.nasm (59%)<br>
<br>
-- <br>
2.16.2.windows.1<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>


<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>


Groups.io Links:<p>


 =20
    You receive all messages sent to this group.
 =20
 =20


<p>
<a target=3D"_blank" href=3D"https://edk2.groups.io/g/devel/message/118635"=
>View/Reply Online (#118635)</a> |


 =20

|

  <a target=3D"_blank" href=3D"https://groups.io/mt/105748911/7686176">Mute=
 This Topic</a>


| <a href=3D"https://edk2.groups.io/g/devel/post">New Topic</a>

<br>




<a href=3D"https://edk2.groups.io/g/devel/editsub/7686176">Your Subscriptio=
n</a> |
<a href=3D"mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |

<a href=3D"https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>

 [rebecca@openfw.io]<br>
<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>


--_000_MN0PR11MB6158AB1BBF4D7536F99C983CFEE42MN0PR11MB6158namp_--