public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "kraxel@redhat.com" <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v6 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info
Date: Wed, 15 Feb 2023 08:49:13 +0000	[thread overview]
Message-ID: <MN0PR11MB6158ABA2040065AF3ABF9229FEA39@MN0PR11MB6158.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230214095659.sxvmwxmitwbp7qbq@sirius.home.kraxel.org>

> 
> So you essentially are hoping this will never ever change and hard-code
> the 8k in both PEI module and PiSmmCpuDxeSmm.  I'd suggest to add a

Yes, 8k is bigger than the real usage case.

> field to the HOB struct instead.  If you want stick to the hardcoded 8k
> please add a note saying so to the HOB struct description.
> 

I will add the reserved mem requirement for each cpu.




  reply	other threads:[~2023-02-15  8:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  8:44 [PATCH v6 0/6] Simplify SMM Relocation Process Wu, Jiaxin
2023-02-13  8:44 ` [PATCH v6 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Wu, Jiaxin
2023-02-13  9:25   ` Ni, Ray
2023-02-13  8:44 ` [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId Wu, Jiaxin
2023-02-13  9:33   ` Ni, Ray
2023-02-13 12:34   ` Gerd Hoffmann
2023-02-14  2:01     ` Wu, Jiaxin
2023-02-13  8:44 ` [PATCH v6 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Wu, Jiaxin
2023-02-13  9:34   ` Ni, Ray
2023-02-14  2:14     ` Wu, Jiaxin
2023-02-13  8:44 ` [PATCH v6 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Wu, Jiaxin
2023-02-13 13:16   ` Gerd Hoffmann
2023-02-14  1:54     ` [edk2-devel] " Wu, Jiaxin
2023-02-14  9:56       ` Gerd Hoffmann
2023-02-15  8:49         ` Wu, Jiaxin [this message]
2023-02-13  8:44 ` [PATCH v6 5/6] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Wu, Jiaxin
2023-02-13  9:38   ` Ni, Ray
2023-02-13  8:44 ` [PATCH v6 6/6] OvmfPkg/SmmCpuFeaturesLib: Check SmBase relocation supported or not Wu, Jiaxin
2023-02-13  9:37   ` [edk2-devel] " Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN0PR11MB6158ABA2040065AF3ABF9229FEA39@MN0PR11MB6158.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox