From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.10888.1676450961365224233 for ; Wed, 15 Feb 2023 00:49:21 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CsHA6RDJ; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676450961; x=1707986961; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uhCPy2npMqUqmV80k5fu73KFNqJV155oVzR39Kgbvvg=; b=CsHA6RDJ1d+suZ49nHdcUNTBr4XbUcVRqkEIlNHfa3nSsTB5fEO1erWP 0+FQcVFgQ1Yv/BKkFbaGcYCMMRI0MwL9NX4XN3txt5VW/0ONwNOOrHSaP /77zw22pMLM72z1WCrr06C41gC71YQxFACFv4WpGMQtCDhe/onn5mWmdF gYhOWtE8qhp9wWBTsNPEANkp4e1c4W7XvNaX/gpyJBhiMTx27WdWKmp26 rsdsO3xqaCLdfMpF8AtBzbkKAxvAROeXlMHn+wJzZjTrHn3dAHIPsYwsv +R4p6MibhgLDkkGoXZI6lG3R9jxE76BBHo/sE8oCRMn3xTFMi++lGBybr A==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="311743549" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="311743549" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 00:49:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="758325467" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="758325467" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 15 Feb 2023 00:49:17 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 00:49:17 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 00:49:16 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 15 Feb 2023 00:49:16 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 15 Feb 2023 00:49:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFGmD38DlkRrbpXIm1zpwiF10lLpiu3Xw/DT5YaBsB3YTra/jbjIEvtZHZYZlr1hJ8pTAZwp4rlMBlr4Gqil42l0rd7KisH10UhaCLk22qIpD5WvH9eOoyLhjangfwI+xukI1mTrlOW5jiVw/URRm5iQgm+fpoMX1M414De48sp/5u7hDioCqlOpUaMHiiXvoR9YDgpXwBfDaqz6F+Ch8tVM7aeP+Ovqd8gpOj4THsGaH7r/Sdam7LfkPYr1P0NrQH4Wr0VGx71Sv2UggXgfMk4zXK4ST8rz+gWl2HyLS/ujnNV5u4IA+sKgejeA7zOgySCb+79EpTRBVP83eKMSsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q1Mr85xvSJkuCT0gDtva2zizCDEQaLHkWpwm1YGSYkY=; b=Q3igsg87rA6iRdfHFYkbowIq3xaTrEgnmZAUGYeZ7NFoiaSGVOUmQ4RUgtPSWMUGhFNh6V+0J42GypDVl7f4CiMKtdd+xkjFdOL/Ul+TEEF8vMYJ4MOMCPPJVeVz8mAzm6+iIBtv09oGbkao2vS0e2ima9f6epx669eGCKYBlhSKYwOa61R4yalMTII41a3h4Bh4sKGjH7TpchcYie/WE4y4gcYrOx5RuxBv159rNNZ3eXA+ns1s5Bpo4o+gK+W8OI6lDN4XvCOjHCMpn+5FEqZqL1xp3BpqenJEP3GcxaK3KmNnHYslW09WPDaemXFSKYf9HgGZSVs3bqTBOou//g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by PH7PR11MB6427.namprd11.prod.outlook.com (2603:10b6:510:1f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 08:49:14 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01%3]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 08:49:14 +0000 From: "Wu, Jiaxin" To: "kraxel@redhat.com" CC: "devel@edk2.groups.io" , "Dong, Eric" , "Ni, Ray" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v6 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Topic: [edk2-devel] [PATCH v6 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Index: AQHZP61ZveQEWNsjIkGMEnmwLtmWb67Nm96ggACaIoCAAX0ggA== Date: Wed, 15 Feb 2023 08:49:13 +0000 Message-ID: References: <20230213084417.9232-1-jiaxin.wu@intel.com> <20230213084417.9232-5-jiaxin.wu@intel.com> <20230213131614.3vw4q233wtkqkpmv@sirius.home.kraxel.org> <20230214095659.sxvmwxmitwbp7qbq@sirius.home.kraxel.org> In-Reply-To: <20230214095659.sxvmwxmitwbp7qbq@sirius.home.kraxel.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|PH7PR11MB6427:EE_ x-ms-office365-filtering-correlation-id: 5b05f096-e3ec-42b9-f8db-08db0f31838a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k+Kusht0Xw78cbY66dWjySKPZplnEQGgTgaGNrgRm6QnH5uoGW5KILnwe/tYJTVhe/mb3Pl4B8i3OU9Kgls+SXrScM5fLA5IHvi/RzggoqPXYM1+mQCpzWQZtFd0baNoZCWPN+8fykh10KQDMfcCboosf4lSRfajQsPZgPjwf3zkYDHTKcPheFJBq/eEy6uzfxxxTdnW4/BMEaH4jsSo+aBDyoe5Tg9+UUSMsdj77inaTpDInXf7bmpo4hmdYwVK+N4J/C+dLsV3d9XMRoTqnafjYCJvFJ4rjVQ+S/baZxS4ElBDvvSe8y/GIShv6WEjLhY3mRyfOzHAl5K/e2z6pQFoi6K/d3N2oQ3bMPkKcy0JQU5yJzSo97KAvX8hW/k/pwMIMb6ZeAgHEkyjhDxNcmpU9hHUZm67dZ8GbH8O1n4eflUgANiRzDNsxp09Yg4o/ojmR+YNq4dMUuSZrKTukZ8v3u9bSfzVGbYjbv79jYQ8xsncbd+P+9E2VW6SWpYLES5TR+v9L/Wk4XHGYdGTvqorOd9OtNUE5gb5haSXId3NrrbBJwORb7TY+NT0TgYZny40Ugo+LpVyZRKeDgPyWVJsNSMtGltHFMWD6wW6GSBLVNPc5DpidyyT5tsfhssmoFWLzESOXK7dwQ1/u903+Hs5Z7glIFGMcqDI92Ld1o1onYXCtX7UlX2Meq/Zeu6Z x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(346002)(366004)(136003)(39860400002)(396003)(376002)(451199018)(5660300002)(8936002)(52536014)(4744005)(41300700001)(66446008)(66556008)(66476007)(66946007)(76116006)(4326008)(6916009)(8676002)(64756008)(316002)(54906003)(71200400001)(2906002)(7696005)(478600001)(186003)(26005)(6506007)(9686003)(107886003)(55016003)(33656002)(122000001)(86362001)(38070700005)(82960400001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fD7zQEQvEj1Kwcn0udiJMaOrLrt5RQ3Bk4Q7JZwYl/7p3pqZmSkpub5G5iH/?= =?us-ascii?Q?i9TjYLPsvqK+u84/s23BvWIP1kWX62EXiIc2fAu/yN80rErM+3AE+JScjEz8?= =?us-ascii?Q?FXKyDp+FRE9Uhg6TyrKJQbU38pe/Nz7kKbQCA0+ylLSYwmw4KjEARu+2SKUV?= =?us-ascii?Q?ZhTU3fS7x8zVPbS0ivvgpuPNHmKun4FSGAlAQ+bgamhrrv+U+F5O0lnw42YC?= =?us-ascii?Q?1jdLxmBLP+KQKqb9A3oysGLK2OSEbfeU2kyV/Ml4dH8rtiMDTOUA1uO9piJ2?= =?us-ascii?Q?1+v26eE7BVEuBmeDK2MAGzp2C/mzGUjvNtky4tTd8M4d4RWp9UY5uQ/5F7Yv?= =?us-ascii?Q?Byn/vYKtCLXhvSeZDGZRsf4Ktceqd4JfWsehscDdJdcAo8P2wmVN9+du1hVu?= =?us-ascii?Q?adK5ZRmnn1uQZmqoWz0Aa7XDCBf6yYveCWwvgqeUrtGoIdd1YGFyvVr35TfN?= =?us-ascii?Q?yhhTgNRNjDyz2++OJcd8ChZjlBebMiVXh5I9mNQaLsPqZoGkWLFYos98fyQY?= =?us-ascii?Q?+2IcouXj3PJnBMCvZVObBrWyLMb6WET7H/surVXptKSKoj8Vra3X+oexPC8M?= =?us-ascii?Q?sFNBDeGwKHngAhf24aGL+pXPIxnFE2Dh2mBXK3ZFumDPQhc1P1lwKp1VPYOY?= =?us-ascii?Q?KjSQbvukiyuoaZZRqQlyGf5xKaT7g/asGWJsYQR9bYZJsAexEVEndsa+MPJb?= =?us-ascii?Q?K4fOfXnnCpuq/DL6xWnzLCLghPCJCtCALxA9a92PYYG/x9A1AVFwDfmkQbbd?= =?us-ascii?Q?fYIBpzJTAG22M5Zyt/E+dD+GE6IQ7sySGfGP0OUIGabMOJTlaJ9qr5Wwn7p4?= =?us-ascii?Q?S4pz70N2Vws+4WaZ0PtdE25Ow1mxIiDE00sj71a/6RH7Q4AHJrMXLzZJ0KC4?= =?us-ascii?Q?0vVC6WCDXbOo43UfgJQ/nySBTZrPCOM/fruuzmmfGXPsvflO47KfFmZEsj7Q?= =?us-ascii?Q?Zs48raGFX+s0LwCj8C5rip4OO2tzDf9rIDgX0x3TawEf59RwAcHasZbiWORv?= =?us-ascii?Q?APSzWAoqW2G/e38d4NP7MAdG/8dY3IvErxiNDkqATiVuXyedcLERFIh7HwCy?= =?us-ascii?Q?hoq23dRlt6gwhTCPOB2iRJBCLym7+0ItLgCK/19g52vaFeAxvlpQXIbGMKu5?= =?us-ascii?Q?t63JE9QcUVRk3rnN2o/dTG1agexDe2O8Qf8a53HFYdTrk5AZIGQsvelGlmrp?= =?us-ascii?Q?7ztCbYPV/TpNo/Ha5WCyAesNzFuGXfTLI02zcef0ZVDkFzrDO5Ztw4qMA8jb?= =?us-ascii?Q?zoKTOnHfiuxVxyLvkpZ1jpzHxb0QCVTV8Dl9xVqZZuuGXpd9/Z6NRL2q5b+y?= =?us-ascii?Q?+7689hAOTLgfsK0HOXRWnGbprcmqEklXBpP/004UmQHdvsXzqUyTwd8CJmXw?= =?us-ascii?Q?Jrsb9+tna4xK90fntOV/ogRZoavyrGIVW+2faADQgkV40jddfrjEtu/DnnYi?= =?us-ascii?Q?bFtBeYKPOQWHqguMmngdKeehb0CLz5tgptEfRSTmF8fh32AgWymams4C0PWc?= =?us-ascii?Q?1Fu7P9/fHOrTIh3fccecZRX7Q4w+RLa8QhZeT3JF0AuoEZl/QXr1496m7jR6?= =?us-ascii?Q?ECgmw12muV1DMb4U01ebmZxYqJMZvJc1b4U8HxAk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b05f096-e3ec-42b9-f8db-08db0f31838a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2023 08:49:13.7638 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ram3aiXp45x2Sp2In/UXKXoKD+SdSmmDCFT+03oK7lUKdZw89bQnTPt+5oi5B0KXoqsIpS62Dk3TRsbWnQdAng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6427 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >=20 > So you essentially are hoping this will never ever change and hard-code > the 8k in both PEI module and PiSmmCpuDxeSmm. I'd suggest to add a Yes, 8k is bigger than the real usage case. > field to the HOB struct instead. If you want stick to the hardcoded 8k > please add a note saying so to the HOB struct description. >=20 I will add the reserved mem requirement for each cpu.