From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"Rhodes, Sean" <sean@starlabs.systems>,
"Lu, James" <james.lu@intel.com>, "Guo, Gua" <gua.guo@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
Abner Chang <abner.chang@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib
Date: Tue, 23 Apr 2024 12:16:10 +0000 [thread overview]
Message-ID: <MN0PR11MB6158BA87AC057D028205F808FE112@MN0PR11MB6158.namprd11.prod.outlook.com> (raw)
In-Reply-To: <yyfqyxkmmhm4zse4zudk3ls2qv5zj4nqfemri4mbzcqgqnytp7@utiiolx257tw>
As I documented in the comment:
This patch provides the SmmRelocationLib library instance
for OVMF to handle the logic difference, and it won't change
the existing implementation code logic.
But as I said, it depends on you. I will drop the OvmfPkg/SmmRelocationLib since confirmed we can use the ADM version for OVMF.
Thanks,
Jiaxin
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Tuesday, April 23, 2024 4:43 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>
> Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Dong,
> Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu,
> James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Abdul
> Lateef Attar <AbdulLateef.Attar@amd.com>; Abner Chang
> <abner.chang@amd.com>; Tom Lendacky <thomas.lendacky@amd.com>
> Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib
>
> On Tue, Apr 23, 2024 at 07:31:18AM +0000, Wu, Jiaxin wrote:
> > Thanks Gerd, I will try the S3 on OVMF.
> >
> > And for AmdSmmRelocationLib usage in OVMF, do you prefer:
> > 1. use the AmdSmmRelocationLib directly in this patch set? Or
> > 2. still keep the original to create the OvmfPkg/SmmRelocationLib, and clean
> the code in the future patch?
>
> Clear preference for (1), why introduce OvmfPkg/SmmRelocationLib only to
> delete it shortly thereafter?
>
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118137): https://edk2.groups.io/g/devel/message/118137
Mute This Topic: https://groups.io/mt/105593568/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-04-23 12:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17C74D78B0B952AD.15491@groups.io>
2024-04-18 8:02 ` [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Wu, Jiaxin
2024-04-22 7:57 ` Gerd Hoffmann
2024-04-23 7:31 ` Wu, Jiaxin
2024-04-23 8:43 ` Gerd Hoffmann
2024-04-23 12:16 ` Wu, Jiaxin [this message]
2024-04-24 3:56 ` Wu, Jiaxin
2024-04-24 11:29 ` Gerd Hoffmann
2024-04-25 0:54 ` Wu, Jiaxin
2024-04-25 5:50 ` Ni, Ray
2024-04-25 6:58 ` Gerd Hoffmann
2024-04-26 6:07 ` Ni, Ray
2024-04-26 13:18 ` Lendacky, Thomas via groups.io
2024-04-18 8:03 ` Wu, Jiaxin
2024-04-19 3:35 ` Ni, Ray
2024-04-19 3:47 ` Chang, Abner via groups.io
2024-04-19 3:55 ` Wu, Jiaxin
2024-04-18 6:55 Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR11MB6158BA87AC057D028205F808FE112@MN0PR11MB6158.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox