From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.160171.1673848355118763381 for ; Sun, 15 Jan 2023 21:52:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=l3dOjjOI; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673848355; x=1705384355; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zUPdEMlraHx2i1RLycrFKUfma2dhohNdgp8RGVnOryA=; b=l3dOjjOInBdVhoaYHVClw9sLlEgbJlykrd/2J3usNt9BXV1rNfEWhtaK LMC2E9k4tvhJ5kJWEPAY6HSDy0bD/i10RXJoX7Ej4Ohg7DbYbKsLw9LzJ yUf0j2ACPj5oSeZ660h2yDEE20jYasCeHukUM7IRLnUHuVf7IX9vj7zlI Sl8pxuJ4q0uEwYzyLTAMaccIDlm1lyna7C5ppkD/eEljDWfx0aVobCPci +RQfi8knHsbliAKf4UFp7Wgx6+5B3bukNuKmoIlhlbhCSxVEZDpUjvXyL X+FGOHcvn2SvJ4LdmnXSBJWfxu3KdSKXUjgU0UJF11bB4NdcLZ1BGfx7p A==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="312243875" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="312243875" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 21:52:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="652159833" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="652159833" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 15 Jan 2023 21:52:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 15 Jan 2023 21:52:34 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 15 Jan 2023 21:52:34 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 15 Jan 2023 21:52:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mr4MO7XQwz76F0nqDuNSFm6UxYchWzxEaYloJqPenCIlqVB9ZQJ+aqWdKfZzbugZ6/gjgBssOmNsU7cRMDdVe/kW5myhCw8PYPMoH2uxEpCXxPJp30fnLlLgsqTCxe2nBsR9+Z8EeQWmN1A4ZCdFDoJywozJgUcNBaPOLG/5nlveyswDPVcZW+URIbA0SsVV6VDpYnfaOrDJkm3pyJlmUGEx1QuxfWy6Ss36B9OF7ift5e0l/wP3pvaF+prB1SNt+FZTojTCQyyBpKIdFcGAPnGEKFd4GzmQDWq8SOzlw/j70fkeI9szzDHuZ/zkV1g/KY52UQrOQKHjFLJ4y6w5FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xnPe3y8qg++Kosdy5ogKTCMVVVynoVv4zFcatBMc1D8=; b=jU8BsSJxrk6HDU0jOmjmTYnv4AmHd7WH3OGujk8Tr8LpyTRYfG6bGrC7GpD8BIgM6pkLU96MfSNkcH1r5v2xvfRDiwMdfkT7VypG5iZAYnAJKrnnKVk5o4BDVh1fo8mV4m+ZU3hyGy82N6eRjxP86kTDzZxGcLul2KDZxPY048DYrAmASGQz8JxgOmd9z1FwUtrVSVu0oaFdaYy4MK+fWZDIDtivH8Vz+Y4m9Q5nQ0rbYcORzIRoOcdGQzk8G3EBS7qRAdpS8jBjQ9GN8k1tPgOCeykU2PRZ7+vhJCBUfDYamOx28gmwHF21qjy+pYY6ecM0qpg6rdRbjs1w/bjD/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by DS7PR11MB6198.namprd11.prod.outlook.com (2603:10b6:8:9a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Mon, 16 Jan 2023 05:52:26 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01%4]) with mapi id 15.20.5986.018; Mon, 16 Jan 2023 05:52:26 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [PATCH v2 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Topic: [PATCH v2 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Index: AQHZJ2QKHZr+rPC89ECnYhSOxrubNK6gSDZggABFcAA= Date: Mon, 16 Jan 2023 05:52:26 +0000 Message-ID: References: <20230113153045.13060-1-jiaxin.wu@intel.com> <20230113153045.13060-3-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|DS7PR11MB6198:EE_ x-ms-office365-filtering-correlation-id: 08904202-4136-44ba-48c6-08daf785d8c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +176pqXA3q1HcZXESTn4oOR1dNozCLSR06BnPnaRenajb2i8W1jQq6dWEaBfrWZdiPBpPMjoIho567ignqkEusMyxUA2U9akJoyidTZAqtXcLj7BaAYJYb9Bt4v+mcSvjjkgOlNalAC9uVTkKQhY6ztAWtwAIbwAMriYWLH1BX+ZSkvMKM13xt24tEj/S89/rfor5SlxH1Aq0EDCJr8RkdiBxQ26lgpAbbhDO+UfuUZXoUKDki/7T3hcGRWnIMy2aY+ej38bOdCIv+7+UiyItp5ZgA7fI5xUr0MjUxgNuOhrFw91dHW124obo14kKITbQ+xUFUrbyDmvlZYiaLzD9tYImgQ6y4hMfHZnCTi2gdmznOnRmd6g0nRlGWmHmHT/kQ01/kR464LS8+IHDzeUjLoJEyVhBT1mswPKdE+OK5+ye54xoKNIQuX3r+WwHdAv4nfaccaOsLRAyY7VqXHOKdxMpz0AXkhirX6eU8jqjpawyHl/UvQh3K2APTa8MkuKQqgdrWCSdGeNKm7VZR0SLdBRBEb48iF+ovwMHs1+lR+Z7X/ZebDeenCROSYT1Pm+3HVNLxzn97osGC/cSET0xufNP6AA8GX1X3HDo+3lTJB1Ai2Ci7vRsLy77LQNBPIZv5c4L5aW/Y1MUf/m2mXQZjRtWm1aiSfbhJtmiigqWHQkPteuG0ZN4u1q0XTaCcKGaoscRX6/cIChWaDCpW491Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(82960400001)(122000001)(38100700002)(33656002)(38070700005)(86362001)(66476007)(64756008)(5660300002)(8936002)(2906002)(66446008)(66946007)(66556008)(83380400001)(76116006)(8676002)(55016003)(4326008)(52536014)(41300700001)(6506007)(186003)(9686003)(26005)(110136005)(54906003)(107886003)(478600001)(71200400001)(316002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?krcWxvMSXInp74QfxKQZmqpASXk/0EZTPucPgKN5rm5BaYnPUSxmwHiyLK+A?= =?us-ascii?Q?ItwpwPK+5C7XS48gIOvxtdwzrDTdrmslEuyHDiHkhFQyDxUTV5adgOWqCnU1?= =?us-ascii?Q?Ey+iZPKQ5dHf6rn4SmMYR+GW56ZVLxSjVJEjM/l6yw8RaAJYiq8N1bziKJnS?= =?us-ascii?Q?uIp7YHpV9AFLvpcJ5N9aXoQqmKiTR9JGStPReP5zZVzvt+jB9K0IMoZvIZrg?= =?us-ascii?Q?hR7u0ahVZWHeK7o0LAG4YJD1mzXdZPjDjbZ4Fv763qLJePVHy1majJC8IXjj?= =?us-ascii?Q?T5FhwMexANT792PH3FKlky1NPvnRRdtsXLeQHbGPjzxxYFeUoIPbDduBU9Zg?= =?us-ascii?Q?4WcFhYhcjvJrPMed5cNmVydTDfEyd3iIU+zaOAWBWMnSkJ0gFsthTkUkl8Qr?= =?us-ascii?Q?Lii6GENJa2tkO9mL8Ul09Ru9Nj7V0Adq2dK523eV+v7/jH9bFpQ00sNW2MSy?= =?us-ascii?Q?3ox3h7XV9N1lnwQPfDHzkj/HUpM7ISuRQlQGCWeOqOtoBJINF6qyfHGoMFLi?= =?us-ascii?Q?XMAZNw92uIzas3SYrWp1+GfGra0RwHncO5Cdz+n/fHzUCvEuoojYrq5Ov7kd?= =?us-ascii?Q?IjlVCOcCM7UNU098MVG6biXWrFfb/MH4/bJRWauV04jmijKuU4xfA5I1z6b7?= =?us-ascii?Q?wh3z9GhsEO+K2RWZ3LOWrWuZE7lbz4Jbkk8FUEbMJY9eQsdxOPJIwIXls4Dw?= =?us-ascii?Q?wiXgBuplQUipxgyxOnfmMYyP+YItIQV8+W1KRSNfsb7Lg655Jae8qrcz0HzW?= =?us-ascii?Q?y3xlqN09LfWmhhb27Kr/LZ93M9s4wLcXBcgenyzAjpgzy8ffv96WSB+4RtVS?= =?us-ascii?Q?MjUwJuq57ZJfPzCEWUWLiWrxiro8UvApj9Ypq+eJ4vdOsaqIufEQUDRqtd+W?= =?us-ascii?Q?4R95pny4YM5gTrIASyadog4v7QO/cWlW+NwQt81QCahYyUK66st75xC9oNe/?= =?us-ascii?Q?Pd7ao2z+J53eQoaSiE+fApePPs9h/AZ/Vc7oigFRdb2aE3AO9bOZQ+iNa6MP?= =?us-ascii?Q?YI0Kh8obbplYxh5tyxB6939jVkoMlhUK5WiX3mfUlb9SE+XXfTZi5Wm1t0c3?= =?us-ascii?Q?HgxyeJOoHcIDx0PajBSwaNU53UJctd0GXfrPgobzSgZ0bLd+qfRKn86K8tDQ?= =?us-ascii?Q?g2W/Y+hgqv7XnUQabTAAJgxuQ2rGmz1fyq2ZPR/paOWkXYIR5W2njnwTI2ZJ?= =?us-ascii?Q?hXpYeup5eTHInKUXoD5PAFdL+nx5XgRF503GtCPepi4ufUD3NQuCaCggCP4p?= =?us-ascii?Q?4iy/wKI2Wdl+g4cj0M3NHQR+0mMhBOw2qBzNfnwSMnd4sflHh5ZE1bEbChgY?= =?us-ascii?Q?usPAZmseagXisewplTILTPwqYQZmJ3iYFb4/qQYJU1M8rTuzJRfYiTwPv0PY?= =?us-ascii?Q?rHusle8J/w4GyUZrHWlrpRQaAgeYJWG50Wd37eTWJnXmu1mTJuK0PYuIooJ4?= =?us-ascii?Q?0XLyjIoh4ELbA4kz1L+jskuD2zo0a/6+QXqv86TBzRo3qBeCHgryCtbZNgwI?= =?us-ascii?Q?O5kMoQAY/GchNEYDS30jBmXSdDXO34/CnoN9j33rim0PPaRasPosX93vyCV/?= =?us-ascii?Q?jmFBD2ccqzty+A4XdGkx6EZmUbKv4yECpXL7gOOO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08904202-4136-44ba-48c6-08daf785d8c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 05:52:26.5109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rX8UNLdCQQZ0PBeiFe3GvzjQ//mh/fJMfcJ12UksdXUKikPC+YW6y2JMaJhSl+ccOMlTqYj2wX/dzRCuxCmMFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6198 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >=20 > > // > > - SmmRelocateBases (); > > + mSmmRelocated =3D (BOOLEAN)(GetFirstGuidHob > (&gSmmBaseHobGuid) !=3D NULL); >=20 > Do we support the case when the HOB is produced in normal boot but is not > in S3 boot? > To keep code flow simple and not to support unnecessary configuration > combinations, I prefer no. > Then, since mSmmRelocated is initialized in normal boot already. How abou= t > only adding > check here to make sure the HOB existence status is the same between > normal and s3 boot. > This also helps to catch platform bugs that the HOB is only produced in > normal boot. >=20 > ASSERT (mSmmRelocated =3D=3D (BOOLEAN)(GetFirstGuidHob > (&gSmmBaseHobGuid) !=3D NULL)); > If (mSmmRelocated !=3D (BOOLEAN)(GetFirstGuidHob > (&gSmmBaseHobGuid) !=3D NULL)) { > DEBUG (( > DEBUG_ERROR, > "SmmBase HOB %a produced in normal boot but %a in S3 boot", > mSmmRelocated ? "is" : "is not", > mSmmRelocated ? "is not" : "is" > )); > CpuDeadLoop (); > } > > Agree, thanks Ray. Will refine the code in next patch. > > /** > > - Initialize PackageBsp Info. Processor specified by > mPackageFirstThreadIndex[PackageIndex] > > - will do the package-scope register programming. Set default CpuIndex= to > (UINT32)-1, which > > - means not specified yet. > > + Initialize mPackageFirstThreadIndex Info. Processor specified by > mPackageFirstThreadIndex[PackageIndex] > > + will do the package-scope register programming. Set default CpuIndex= to > (UINT32)-1, which means not > > + specified yet. >=20 > The comments update is good. Can you separate in another patch? Okay, thanks Ray, I should never add any smuggled items even it's very sim= ple change:). >=20 > > - if (mIsBsp) { > > + } else if (IsBsp) { > I agree with this change. But it changes the old logic. > Old logic calls below function even in non-S3 path. > If we want to change the behavior, can we separate in a new patch? >=20 > > +VOID > > +EFIAPI > > +ExecuteFirstSmiInit ( >=20 > Can you remove the EFIAPI? >=20 Okay