From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.15028.1686321396076894189 for ; Fri, 09 Jun 2023 07:36:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FHb4pG1r; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686321396; x=1717857396; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PsCc/TF1Em5buuV2njXeJbYDzWnuAjltiqbr9j4AY/o=; b=FHb4pG1rQRyfCVY2DkGqlnD6fKFUgfPcwdzxuqxYbG+17zvBc1NeN6Aq rSLKXNpUNU4dE1pc23KdctKmQ5/o5lxB64uMvfO9lsIhLOyxNtTZ/gusn u/21ByHaAI27QnT02uNE+iccCKmIConH2O7UxnIrK6PhKArEPXkCP89fp 7U0UruLBm/dDKzTQVET02gXw7e808u1RAR6EmhZO7ASjgi09pv19LYkSx gMaoeMRXt07gMhRXi/PS80swUgfxj3FBHFiK2Jtmh6mPh7vd7TBn2UJfY Qf+2RWw4sEXolM1j+Zu6ICD6bWKHYQnvjCdE7FlxGt0YSBBFhDx1ty5wC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="385974787" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="385974787" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 07:36:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="687763066" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="687763066" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 09 Jun 2023 07:36:06 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 07:36:05 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 07:36:05 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 9 Jun 2023 07:36:05 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 9 Jun 2023 07:36:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cKYilPvn7C0j8RUW7YtzUn2NWRYmZ8Rmbr1tQ1FAlePhsx+U+6SGa2ib75PArWdKve0pm7nDASH+swfdGbDjoA+Uus2H2+K6P56ZnQ1f1i1uqec0Y/CTdR89KtFx7EiQ0jjaEiF/Fd8fj3lXFB8k5vPwhkynwwoszfIPftVlPlPd1ToxbE56xjqrRHPJmCip8H77KnvCwNouKSBffsdGrArNRYeaBd8HG+q2kyUrAsLoacvCye4drIltzhZKO2PwcEFylbpZtBcKX60NWoYfiiJ5rRYq6FYCdr1YS5yLZfCwyjSI21mfQtn3jEQ9KSygpXLce6WDyHtuxkXsIYu/5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MJA8AQ9alKaEgBMOJFz2IPAXgVAIK7UwzsA3rf0WQmk=; b=bGNIJVWZ/cnNZg3gPiZLdoiApGStsOm0dmvcYtEOiIVlAymVFEZBkfki+bh1J8GWRLf3ijs5y+e/aEfoMtmKM95y3g69XsYoO58x0wgRTxXuItJYvCx51QbUBdy6HelhpuumdwSD3RFxD1haTicjWCDdqFoZvcnauuDDuFolWDoiRdqFkoRENYS9t1aASjRHq7XUDXVXjmZBruGSxS2rU22FKTB5cKHZswa+w+nkhrX0OEMZo5XgoDgPUhgzXpAKr0H5i7K1Xo8woFM3jCYSAI9bOXf7BQc7hi2MRWdcR6S0o6wsvif8mO3Z+4cdPe6Vejl/MxNvWT1eMZZuUo58ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by MN0PR11MB6033.namprd11.prod.outlook.com (2603:10b6:208:374::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.38; Fri, 9 Jun 2023 14:36:05 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::a50f:27de:660a:544d]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::a50f:27de:660a:544d%4]) with mapi id 15.20.6455.037; Fri, 9 Jun 2023 14:36:04 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [PATCH V2 3/6] MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures Thread-Topic: [PATCH V2 3/6] MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures Thread-Index: AQHZk7PveIujdOXDBkSgsDggy5qzZ6+Clxtw Date: Fri, 9 Jun 2023 14:36:04 +0000 Message-ID: References: <20230531113438.1797-1-ray.ni@intel.com> <20230531113438.1797-4-ray.ni@intel.com> In-Reply-To: <20230531113438.1797-4-ray.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|MN0PR11MB6033:EE_ x-ms-office365-filtering-correlation-id: 9bb0af4f-22b9-4cee-8f55-08db68f6db0b x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VDd+inIRAAdbfBl5CN4ZIwAx+7pfEfCiEMrjugfexjQgjsCqBnT/lb1iZvlNr+QRIxILEinCS+X3/MOqSnz2d7bSkVdZgF4z/mJS0f3NOBY/n0IH0NTVSqQtB5HH6AetmvFc2j5zpqFx5+Y2ijcAFba0oBeZU6wAlzM7HTOxklmeIYQrZKs7g3YDqqnjprLF6ey1G6D9XDrzQr1VCkqM37rxATwCP+aHgyQP5B30mmGZedD6l6sZg3C99+Xqm8YBdDxvMkPJXWslvvLj9uMcoTm0MOmD4M0GkhAHltZ3LfnZZlNOG4Txy2/ZwFM1v5dMcaxJYcaeDgwTrk/qrgrOKq3byOn5BNP5ahAQ85Fndn1wwRPp0Jf3JGoQnimMHLHP6tyoICesYgf6c4JM75pOZl0VglyWlgb1MZK1BrqMR8h71+Pyh7ahcQVZUVmczsU5tM3Ef6v0I9AV+l1YPTtWN4vqpz3U/cHkXLiHmb1xSElweUfGWJcjEPyrLCn1EVQjNHTHqqEj+sWbjxcdk1Jf+B7tSJKxxKGATQI9NgpGkugIj6VdTn2MqJOfLCFVf3MJTRpHR807KHtR+ZyhrYdMGWbUUd0DbKRdCklUEZPybs9PCEmIOcNmxYjvwNIKH+my x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199021)(66446008)(7696005)(2906002)(76116006)(6506007)(9686003)(53546011)(4326008)(41300700001)(71200400001)(66556008)(66946007)(478600001)(52536014)(66476007)(26005)(55016003)(64756008)(186003)(316002)(33656002)(38070700005)(5660300002)(86362001)(82960400001)(122000001)(38100700002)(83380400001)(8936002)(54906003)(8676002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7vEXftIOqgakHav0j4LIiV/CQ9unX8UPTXRD1PoVeYAbk9M2A5d9ZwPfLVZs?= =?us-ascii?Q?TGt/S3W3mGK14Ca1yPCu1PM7CYLi3YiuJCRrlfeEG2ZdzwpeQfQeYaEP8dLU?= =?us-ascii?Q?ezkK1TkV1vN3yeit8L7Mf8fRZXdu7L9YeVjEDz6HcZIRnUElkuKyjsbk4IWu?= =?us-ascii?Q?6XW6jcNfYmya0TlTnvulwBrUnoysr+CHy3xQCy+dm8OjEvEWQtRYO8o8+Bco?= =?us-ascii?Q?xmjSDNXUiJbWk4U3fXEf1O3O/Q9SjgreLYzaBMheZQtyMJ56VlNPqPNQHq0l?= =?us-ascii?Q?98NQMkafE1coOEuVRO8cqMVhHC2bZ2AutQtyzCkGsuCwm2jdiNgDhYdg8KwA?= =?us-ascii?Q?xvy+vr0+jWFRFsYVFwFhMFURcG3DI1nVTirTDq4KEHXdD2K/slB3TRRpcl2z?= =?us-ascii?Q?0epEZedn6NItLc0UQ2qnrUco/9A9SQb7izWbhx54sAd9xhDu3j9IuCs0P/J1?= =?us-ascii?Q?nrTKaUS5+gKfIm17htjdW6vWOBKZ1fecP+GMu8UHpmdFoijiPBkKqqxJ42H2?= =?us-ascii?Q?UxJjPCR4VRPwRytPRy0UvRQ/Wu2OFbxunC2dGNIHaX0UhCwQde5du2f2cNLv?= =?us-ascii?Q?RAI8iVivqAnmg2llcJFG4XLxKhH9HBMJ4PXUDAakHtQTI6ysN4zVWExEuryk?= =?us-ascii?Q?ku+VtHs5dg+79W9FsX/gAcFOUaaefBYzY8RJqQYvcyhbKlOD0ySbbsXcDeHu?= =?us-ascii?Q?KCZogDGuZKESn8l8GoRzCncvfKxNzr/iZn91fGjCJSMe3pH0WMGmJUnYN4oP?= =?us-ascii?Q?Or8QPrzx6O15VCoKnhuuyiNy0JlB3+8t28iB/MEivOokF1+OCIjkD+8GVbb6?= =?us-ascii?Q?pzlEH5yVSAA0twIN5YsxQTFpfuhvxqPKKDKJBJHUzKtb84yISnUX7XAKOBYk?= =?us-ascii?Q?JGJL7lklBWixaJPPninoMkcRQSalFgOhFLO4ctL7nWqS+wp58hj/SLE2uzCZ?= =?us-ascii?Q?euFdMSwBps2wZPszH8PXWQgBnDLiFIdGkc6Vk55JFQm02Tzq/xtFIb6mXFIp?= =?us-ascii?Q?v9uquVByUUybg1BjoqBMMfo4esstgdVCpQpbPBAFJ6kUIbH3+bCDAFKCL8lO?= =?us-ascii?Q?pTF+p4wdD7U9PD+v6IzSkp6Olx0C8YxfUwfE7D7FkN5xnSzpLM92IwPf+S92?= =?us-ascii?Q?FOSedaq34vD00iuqrK7jnCbOfFhxCCzjf+8VernvgACSw1Rd2dsNnjke8JNd?= =?us-ascii?Q?d2SpVYSPelfsrsLRXBz4zeRol6bvP30WvS/crXx/WmuhB02cvr34Lm0gA5QA?= =?us-ascii?Q?jlGEPCZ/EQKI5/ZINYtcWK1kAVvrzDD8wxAG+NfymFTeBV0cWS4JoBXwHeR+?= =?us-ascii?Q?IqyHADYgu8NoCVLTiHciw4RhMqGHFGL6PDJeCGzgR9YUjOSGVf0j8oTHwQ7l?= =?us-ascii?Q?FgbxpHuYR+3nnFwAkOAo7Vg2GnMrCyDWImDfCq2EYkkdEnSHYubr2/85b7Re?= =?us-ascii?Q?faSs7owUA5MjVtxnndnpMkgI9yIgVB3PiBeOR2OnGV68jgPKYMNEskQRez/z?= =?us-ascii?Q?zkfztqt5Ee5fjdjjii/1cTw+uLA7Pa+eCX7bJ1OY6QWDtonlkuEVxSLFtAIc?= =?us-ascii?Q?Zbc0v3zWwqOX/wOy2i0vzWR+3Z3JFhYSHJghFMRF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bb0af4f-22b9-4cee-8f55-08db68f6db0b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 14:36:04.9266 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ED3ctxbup2o7t4FQ7ATdKIDhhDYRhcxePTl4gCAFBA5TtP8+Wp7aBw9dGalQ1j3ElYfxM1rOY8GFXjcU54Jf+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6033 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Could we also make below perf-logged?=20 PlatformHookBeforeSmmDispatch & PlatformHookAfterSmmDispatch=20 Others good to me. Reviewed-by: Jiaxin Wu Thanks, Jiaxin=20 > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, May 31, 2023 7:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Jiaxin > Subject: [PATCH V2 3/6] MdeModulePkg/SmmCore: Add perf-logging for > time-consuming procedures >=20 > Following procedures are perf-logged: > * SmmReadyToBootHandler > * SmmReadyToLockHandler > * SmmEndOfDxeHandler > * SmmEntryPoint > (It's the main routine run in BSP when SMI happens.) > * SmiManage >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: Jiaxin Wu > --- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 14 +++++++++++++- > MdeModulePkg/Core/PiSmmCore/Smi.c | 6 ++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > index 875c7c0258..a15afa8dd6 100644 > --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > @@ -1,7 +1,7 @@ > /** @file >=20 > SMM Core Main Entry Point >=20 >=20 >=20 > - Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
>=20 > + Copyright (c) 2009 - 2023, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -304,6 +304,7 @@ SmmReadyToBootHandler ( > { >=20 > EFI_STATUS Status; >=20 > EFI_HANDLE SmmHandle; >=20 > + PERF_CALLBACK_BEGIN (&gEfiEventReadyToBootGuid); >=20 >=20 >=20 > // >=20 > // Install SMM Ready To Boot protocol. >=20 > @@ -318,6 +319,7 @@ SmmReadyToBootHandler ( >=20 >=20 > SmiHandlerUnRegister (DispatchHandle); >=20 >=20 >=20 > + PERF_CALLBACK_END (&gEfiEventReadyToBootGuid); >=20 > return Status; >=20 > } >=20 >=20 >=20 > @@ -352,6 +354,8 @@ SmmReadyToLockHandler ( > EFI_HANDLE SmmHandle; >=20 > VOID *Interface; >=20 >=20 >=20 > + PERF_CALLBACK_BEGIN (&gEfiDxeSmmReadyToLockProtocolGuid); >=20 > + >=20 > // >=20 > // Unregister SMI Handlers that are no required after the SMM driver > dispatch is stopped >=20 > // >=20 > @@ -408,6 +412,7 @@ SmmReadyToLockHandler ( >=20 >=20 > SmramProfileReadyToLock (); >=20 >=20 >=20 > + PERF_CALLBACK_END (&gEfiDxeSmmReadyToLockProtocolGuid); >=20 > return Status; >=20 > } >=20 >=20 >=20 > @@ -442,6 +447,8 @@ SmmEndOfDxeHandler ( >=20 >=20 > DEBUG ((DEBUG_INFO, "SmmEndOfDxeHandler\n")); >=20 >=20 >=20 > + PERF_CALLBACK_BEGIN (&gEfiEndOfDxeEventGroupGuid); >=20 > + >=20 > // >=20 > // Install SMM EndOfDxe protocol >=20 > // >=20 > @@ -479,6 +486,7 @@ SmmEndOfDxeHandler ( > } >=20 > } >=20 >=20 >=20 > + PERF_CALLBACK_END (&gEfiEndOfDxeEventGroupGuid); >=20 > return EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > @@ -669,6 +677,8 @@ SmmEntryPoint ( > VOID *CommunicationBuffer; >=20 > UINTN BufferSize; >=20 >=20 >=20 > + PERF_FUNCTION_BEGIN (); >=20 > + >=20 > // >=20 > // Update SMST with contents of the SmmEntryContext structure >=20 > // >=20 > @@ -769,6 +779,8 @@ SmmEntryPoint ( > // >=20 > gSmmCorePrivate->InSmm =3D FALSE; >=20 > } >=20 > + >=20 > + PERF_FUNCTION_END (); >=20 > } >=20 >=20 >=20 > /** >=20 > diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c > b/MdeModulePkg/Core/PiSmmCore/Smi.c > index 6d13969979..2985f989c3 100644 > --- a/MdeModulePkg/Core/PiSmmCore/Smi.c > +++ b/MdeModulePkg/Core/PiSmmCore/Smi.c > @@ -109,6 +109,8 @@ SmiManage ( > BOOLEAN SuccessReturn; >=20 > EFI_STATUS Status; >=20 >=20 >=20 > + PERF_FUNCTION_BEGIN (); >=20 > + >=20 > Status =3D EFI_NOT_FOUND; >=20 > SuccessReturn =3D FALSE; >=20 > if (HandlerType =3D=3D NULL) { >=20 > @@ -125,6 +127,7 @@ SmiManage ( > // >=20 > // There is no handler registered for this interrupt source >=20 > // >=20 > + PERF_FUNCTION_END (); >=20 > return Status; >=20 > } >=20 > } >=20 > @@ -148,6 +151,7 @@ SmiManage ( > // no additional handlers will be processed and > EFI_INTERRUPT_PENDING will be returned. >=20 > // >=20 > if (HandlerType !=3D NULL) { >=20 > + PERF_FUNCTION_END (); >=20 > return EFI_INTERRUPT_PENDING; >=20 > } >=20 >=20 >=20 > @@ -160,6 +164,7 @@ SmiManage ( > // additional handlers will be processed. >=20 > // >=20 > if (HandlerType !=3D NULL) { >=20 > + PERF_FUNCTION_END (); >=20 > return EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > @@ -194,6 +199,7 @@ SmiManage ( > Status =3D EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > + PERF_FUNCTION_END (); >=20 > return Status; >=20 > } >=20 >=20 >=20 > -- > 2.39.1.windows.1