From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F120A740034 for ; Tue, 5 Dec 2023 23:58:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=u03R26Cgp+noTjTB93boZPVceSxEM30xYu2jRjS7A6k=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701820724; v=1; b=KhsrwCOD+Yn1nxKfOA9f4xXsGdbOlAU/ZxcDf3AgrjwBzSj0VJ7yx4TDNiiy16liidHSgLEv eHn0LzP0LcIcHnrsF/fGM+EDFNQFaGhaR1sIbzHek4fJ1jVa4G2ve2t+MCFYTDoHMQn40GViyrf YHz6+RNkpHmJ0l+cs9CHwXPQ= X-Received: by 127.0.0.2 with SMTP id cHmgYY7687511xQ15Z5sbvG2; Tue, 05 Dec 2023 15:58:44 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web11.16931.1701820723521859553 for ; Tue, 05 Dec 2023 15:58:43 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="815784" X-IronPort-AV: E=Sophos;i="6.04,253,1695711600"; d="scan'208";a="815784" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 15:58:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="914981547" X-IronPort-AV: E=Sophos;i="6.04,253,1695711600"; d="scan'208";a="914981547" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Dec 2023 15:58:42 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 15:58:41 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Dec 2023 15:58:41 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 5 Dec 2023 15:58:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fItyOIXzoWpOiieWKttfz+KabgTeceBF7J4kJHhlHJwjmjUdOKvmIQWt1lFgkiCyyQwW45/0pbd0m+St2BX+H/k2QQkyPUJlT5RT5NKs3pOzBVoTm85K3QLcI4f6k5Kq1jYmTMrsDU53aV+BT0LH96rbXvLRcLBjcc+J0+7GO93qYlD7ffxg0UcbqfH2RyhoANLMP3Z82eiWIk1V1IKSXlKDgCJLTWV/XI39PdCnoaZK68NjQrsYKPkYALybzMKE/eoZhpodu0UCPDzapadvx8tU1aOcoWV2k9H9NerKtPTFrPbfUxlKZX8fbLOkvLgutfRGqQZ5rl3dphmDHJ928Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mr+PfY+msw4NHQEVErb606TKGtvJ5xHecN6uF0fAaXU=; b=OSh1DkQ/m+8Nocfdd5+rG2PMko9vfh7Ojpt69Wl6GfSszIwY0UMtftssQ7UdscqmC79rcYZfjhz3y8StvY9eR2xsAGqzhusIsiZPgqqSG952xauxYPckbrBt2aRU07ZUTW/scP+x4qkP3czY7zFeUI/5QHgumYGCyYFJAWEWt4h+/NhA7cfze6DhdlXkPX/aYYjbZ0Gyeee0J1f5CK5fcc9va0+xTLCdili+Ak8d9gHQPnETOBaw318+UVb9eAO0roMqReCIPVD7CmCO5uLJbXPaL+r3W5q/g1X309hGvr+HfR7QwjhhoepsjHV7Y2mXpindEHDr5opVilrQG6Vf0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by MN0PR11MB6207.namprd11.prod.outlook.com (2603:10b6:208:3c5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 23:58:32 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::864d:d91a:4674:e0f7]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::864d:d91a:4674:e0f7%7]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 23:58:26 +0000 From: "Wu, Jiaxin" To: "devel@edk2.groups.io" , "Wu, Jiaxin" CC: Laszlo Ersek , "Dong, Eric" , "Ni, Ray" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Ard Biesheuvel" , "Yao, Jiewen" , "Justen, Jordan L" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" Subject: Re: [edk2-devel] [PATCH v2 0/6] Refine SMM CPU Sync flow and abstract SmmCpuSyncLib Thread-Topic: [edk2-devel] [PATCH v2 0/6] Refine SMM CPU Sync flow and abstract SmmCpuSyncLib Thread-Index: AQHaI1dce7qoOtYf50OyJY4TuTLt4bCbZpHw Date: Tue, 5 Dec 2023 23:58:26 +0000 Message-ID: References: <179C52E5E4412CF2.11889@groups.io> In-Reply-To: <179C52E5E4412CF2.11889@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|MN0PR11MB6207:EE_ x-ms-office365-filtering-correlation-id: a9f46a03-b3d6-415d-05e6-08dbf5ee1248 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: P/eK2bthwlUrUKfvc8Z0WRv2VI3XnVWAiOh5bjt33XOXyjI0xbFhdTGrGN2aFpU4jDVoJ7NnGIBzLV6oxjHYNEI5REa1hID2X+JYQezccA9Q79Lald0ySzThSkPo6BaoDJ+SaTrANPhP8nqxWD6nWg9sTaDU2EDUZ1uGlq5P+FwqB2ow1IxYzsQ1+EzB2MZjY6R1iny7EE9ohZRi8+8Usxva1vMn5qu+3OaDwPqrVcK1QcJn3EqgUaqedPtbIY/1lo8QRKv7wZlE7xA2kzNbsZlWge7t+SKWi6WD18s2xjZn3xuctz4X45Ra/h7XVC9t8TWjdR0NUdT1vJ0Iyay4dB2Kiz2wJ6gBdBZt33nqo11PK5O77cvVqjipXVh0MVk1JJOTacpqFluVQnotgEpoVjGDkiusAX0VQ15zQSJuMzTWEwCmud7fx0Tvz8+CLbEhQTPXhheVFTEjJLQpbxSm/ulJCXorQCDtLBgEt5kfQXqV6DNk2Y8jgckSXx9gOVps382t9/v7W4xoZ270HNQ3hQWrmPH3oQFrcRW1NfEsKMl4VAVZP+RohOO4Ql3202CQuQJYbq9Dh9/HsGVxeuXS9xV5cLTvAntcplhlNCcVca2dpJI2hFJ+tl2mTDnCAvPLtWObCBS67YlWTTI1mdVCmg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jCiVTkLE+tZua4gkQRs+GPSZmIAqFfGJLA0gMSduNnFkBZn+vzpEqH3vDTMo?= =?us-ascii?Q?BzfpVJZtE9PKhG0VFNbkLekwCaAWhW1bAazPdvxieIfXiNWcCTPO3MKMnNxV?= =?us-ascii?Q?13nHBcBuBbg+Chsf6oUb1CwNSU9IeDEAbAVlUg3ipr3TcQhMiEnuOnawZxgR?= =?us-ascii?Q?ZbggoNoSSmikueNBxaSMtyTMXRQqtf7IAvygmIMKdXD1Y1yKtJYrMsXqResv?= =?us-ascii?Q?85ZiExWKW+SWmFdqlwieykmJLokSPvRq1qQXh0SQNhn077HIuWY/8LNkNCxw?= =?us-ascii?Q?qpN217RMKbs/f48omWoCDOI9djm9tc0pdYKVZWpP8Pf/9PCkHvG4afc2mGWY?= =?us-ascii?Q?nIYwRxcqXH+HIDCY4DzeJF5zjM2rsIpf+Zl0HaigdRTP5Boaws4z4TWu3HEB?= =?us-ascii?Q?XgmW2LYPEIcGskW9hIEKQB1HXo06V5TrfJW+/WLxfEmF33lHlyGBK5GsNh70?= =?us-ascii?Q?fCo1mS+mqrAJvNU57MYP7P62o5/MNWKLU8utdFEZtYH2ewg898zygw8grjH6?= =?us-ascii?Q?8SFxXMcRswSvMGp0JnQG/G6VfB7BreK2yCD8LR7rH1fyW9Bybv7Sj0fSgodz?= =?us-ascii?Q?/uA7R6H5x0yTKdW04gAwFWINJrkIy7pZMjq8Gbr7qHEeNGKvByvxX7gP9F5o?= =?us-ascii?Q?XD/4Usp0mKpX40TYxx7Zw7xRpVvSeUenPfLhsqfI+d3oUono9vQnFeSuDlmD?= =?us-ascii?Q?S+y/vx4hVDQCr1uIXcy0fHbBvXT2i/w8q9L47wQ/LwSgyMQUcjntlZwviZ/5?= =?us-ascii?Q?SNp9m/+yogknH5qE2VhXDyjTSvRgmTA00Ofi7UbskovnsWki+/i2EclDxURU?= =?us-ascii?Q?BRnwpL377ksIy/j8TKiS705D6cGA4gL8CylXlMMrG3lSvtnjYg6JEP9t7lq/?= =?us-ascii?Q?IVGfc6GfZRgpVEHDD9px1KsNb2KIHxMDIh6KN8ExlGfG2uVqDNzZCDEBM9lF?= =?us-ascii?Q?8gKqU/a/6AhmMmIQC1JqbHO1zQrTx1AHGzIi28JPq+d7nwYHyHxqMi8XSpvf?= =?us-ascii?Q?2HHekflqwcC0zck0w+sP3zAeMwfM2W9Tbh+a17OCy7aqcvaIWjORiB1XKDk+?= =?us-ascii?Q?AyQH0T7qy8f/00RDMh2oYHzruQ/jkZJrqyjezdImk7pgU4Feh9PaavixlbQW?= =?us-ascii?Q?W2HFBQxunNRtu5p2gubAgV4LWoSN93vDWYNjwsX17hycpiAtaOVDKJTijy7w?= =?us-ascii?Q?9G+DBO5XJchVlWLActCH9ECKPMCW1e1QMsbzxj6Y64D4XHwsGMbxy+/60k8v?= =?us-ascii?Q?6AgECMTfx49faiwpVRYq3rE2+z9iqac4t2pb6PQ/yu5N2AO+D7o0HipSB+Ys?= =?us-ascii?Q?2J0LSurH7WWvUCpnwylAWZjiyQHCvWY3PVcSH9DxbpZ0usD+0EpjlZS8jvyn?= =?us-ascii?Q?dWAejkcgR347iK2aBIHHjRk56foyxC3rjYbQl78o86TqITtB9gT6ntpg6YUC?= =?us-ascii?Q?dv/KrZMPXwYzbkd6Wel7oLTHsbrxFLpNtq7/ns6xdbOAD1HfdxMBjpR+CBrB?= =?us-ascii?Q?RxVM+E7ra3An6oVf4dCcatWz42Hs/biqBwb1ukhx9xiSlLZAL5VpWY8Ith/5?= =?us-ascii?Q?Np+E+lMqnbZp/LxflTbzn5Z6aUg6c90Lk2WeNPI+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9f46a03-b3d6-415d-05e6-08dbf5ee1248 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2023 23:58:26.0296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DuZgrNODmp65+LxyW7FdUPWlF9KKhX0OjQreeQ2S/OB6+Y5y5TjDlebuJZY75uRLFHXXKgSmNKG2g114mMWJYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6207 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1ZOFNfc5MshrscjKcGzzIQdpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KhsrwCOD; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi All,=20 Could you help review the series patches in v2?=20 Thank you very much! Jiaxin=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Thursday, November 30, 2023 2:32 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Dong, Eric ; N= i, > Ray ; Zeng, Star ; Gerd Hoffmann > ; Kumar, Rahul R ; Ard > Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; Don= g, > Guo ; Rhodes, Sean ; Lu, > James ; Guo, Gua > Subject: [edk2-devel] [PATCH v2 0/6] Refine SMM CPU Sync flow and abstrac= t > SmmCpuSyncLib >=20 > The series patches are to refine SMM CPU Sync flow. > After the refinement, SmmCpuSyncLib is abstracted for > any user to provide different SMM CPU Sync implementation. >=20 > Compared to V1, has following refinement & changes: > 1. Remove below patch from this series patches: > UefiCpuPkg/PiSmmCpuDxeSmm: Reduce times of BSP and AP Sync for SMM > Exit > Reason: Plan to separate that patch into another patch set. > 2. Refine the patch according Laszlo & Ray's comments: > a. Removed Change-Id in the patches > b. Optimized the description to avoid the confusing. > c. Fixed wrong function comment to make it correct and understandable. > d. Use an incomplete structure type to aviod the VOID*. > e. Corrected all functions params "in" & "out". > f. Added lots of comments for the library to explain the > operation & behavior. > g. Fixed inconsistent return types from lib APIs. > h. Use SafeIntLib for all calculations to prevent overflows. > i. Remove the UefiCpuPkg/UefiCpuLibs.dsc.inc >=20 > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Guo Dong > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo > Signed-off-by: Jiaxin Wu >=20 >=20 > Jiaxin Wu (6): > UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP > and AP > UefiCpuPkg: Adds SmmCpuSyncLib library class > UefiCpuPkg: Implements SmmCpuSyncLib library instance > OvmfPkg: Specifies SmmCpuSyncLib instance > UefiPayloadPkg: Specifies SmmCpuSyncLib instance > UefiCpuPkg/PiSmmCpuDxeSmm: Consume SmmCpuSyncLib >=20 > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 + > OvmfPkg/OvmfPkgIa32.dsc | 2 + > OvmfPkg/OvmfPkgIa32X64.dsc | 2 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > UefiCpuPkg/Include/Library/SmmCpuSyncLib.h | 278 +++++++++ > UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c | 690 > +++++++++++++++++++++ > UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf | 39 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 275 ++++---- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 1 + > UefiCpuPkg/UefiCpuPkg.dec | 3 + > UefiCpuPkg/UefiCpuPkg.dsc | 3 + > UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + > 13 files changed, 1132 insertions(+), 171 deletions(-) > create mode 100644 UefiCpuPkg/Include/Library/SmmCpuSyncLib.h > create mode 100644 > UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c > create mode 100644 > UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112084): https://edk2.groups.io/g/devel/message/112084 Mute This Topic: https://groups.io/mt/102889290/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-