From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.8311.1675423119303974342 for ; Fri, 03 Feb 2023 03:18:39 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ACslo6g8; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675423119; x=1706959119; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=C0RCShK7SptRhh1FkU32Sc0l/J6TyhS5dOXN1u45UQI=; b=ACslo6g8UT6XmxNJph1Ou2Q8kcVSlFWIbTzkSVhDKjcXFh7YhbdBcfsP /AHFCMYQR6J5URghXxRSpz6jQcfv5bHpJ7Iz8xbhuNp3gCa8mSt4Lny17 dixMC5UlwozMi1mFrmTFiLKvmRBFVp8zMQKmQbXbvPUooYIgbEEzuAo5N 0cUx2pljHzcDhOkwKzd5F2YE5iWu7W7RaBFwgY7n4AGpDZdmBUJy+y25J YVc1FF5wajRNIw07O9vCKPtAG1Ujhk8P4LBBejSVXoTF8/qX2Wbv02l64 Ub5nYwpaeLoem7ijLpbU9cHY68+8HLwFaxU9u6GezGmUVI1lc2xjdKlTG Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="328738958" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="328738958" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2023 03:18:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="839585989" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="839585989" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 03 Feb 2023 03:18:38 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 03:18:38 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 03:18:38 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 3 Feb 2023 03:18:38 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 3 Feb 2023 03:18:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BmypVnm15+ZNvEuAOOo0lzrAu7oXIS1avsf2KZsHGcHeQHznzn58spBPx/IZpCNfmC2vmxXhpjDB3vzyAa4nDJpSOfKutvar6ozgMXuo94M8IU2gMhErx/1XW9oGInVeqFjSSeLhXwQ691eY9lGcgEd6iqLWaoVeicD9SxQl2IOzSmD37LqzlkUpS3aWmYemXaIdEb8t+Tg6ZZq6XqX+/GKx8KFwvCMaSonGcubUw2OegYZPY+0VRJJp0saWspCWwo1yAcjP7tg4Y4CaV4ZC/CRl6KYlj0wwCVXyWjROfxlO7MdPcs9tJSW9ZlRqUYY2CQBOaF6CJXj/jZZnQv6XFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TIiT1hflXStHnVllr4Zumf4xvnabV81DcdCtYfNQAPE=; b=ITr7LYZ2tlUyPq5sX7Ffb4/AezkmC6AhK19qIgS5dTWobq/Zj4SPcmvmoCUhvz+DopESEAyzbL/L2cPnVhxoOGkZhCsY1Krju/+SyoyH5zMga3trWPYNShScjJPsz1Buf5eKmY4DZIN7S3sN7m2OZfXkuFQM3TmN7nifoSgNcgZMytkBZW9i7v5Jq24JZLCGu5tubaoQ7HC54dp6VHsjUEpbpj+ZYUx6/f9VdhX3xNMIkXhZMV1vdrCAkDQE1jKGHWX5r7QEu1tB9iz0VG96ALDDetvKWbsQc3/8VqFcM2ZCpSC00N05zkYQ1WmEqybLwSPGC8KDmJdNH/PZ8h0MLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by MW4PR11MB6863.namprd11.prod.outlook.com (2603:10b6:303:222::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Fri, 3 Feb 2023 11:18:36 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01%3]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 11:18:36 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , Gerd Hoffmann CC: Laszlo Ersek , "devel@edk2.groups.io" , "Dong, Eric" , "Zeng, Star" , "Kumar, Rahul R" Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Topic: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Index: AQHZKzdA9HccjY1A/kmC90tX3dYbUK6kPkSAgAEha4CAD46lQIAFQNaAgAC5UoCAAIqOgIAALrsAgAELywCAAD8iAIAAAzwAgAA7YgA= Date: Fri, 3 Feb 2023 11:18:36 +0000 Message-ID: References: <20230118095620.9860-6-jiaxin.wu@intel.com> <20230118121958.cxbfh3fljedvebis@sirius.home.kraxel.org> <20230119075303.nkyno36h25xscwkn@sirius.home.kraxel.org> <20230201134051.7jlc7a74cogcskw5@sirius.home.kraxel.org> <20230202090003.5vmmeyhsv4zn7wn4@sirius.home.kraxel.org> <00b01cd3-7ed2-b0f1-e2ef-1d48930a0083@redhat.com> <20230203073144.pdrwf7logbgbow3c@sirius.home.kraxel.org> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|MW4PR11MB6863:EE_ x-ms-office365-filtering-correlation-id: b05eb068-9e31-4940-4415-08db05d8648a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kk7378QliNVsU/du1qeNRVqMwnV3mjMIchRL8EGiddD82o7znFL0Ib+BmETrMiPce3FNyc5/7LKSwzi2uPUkYPPNUypwgD4i64AO5vCN1VFJOT75365tazIjD4vwThRuHILbMbKw/9PkvxYi92dFnn4rR8EpEt6O+wA79Mfnh8Vl37b9Ns2jVfta777n8+6zDSs2UZIeGNQGi4UfhESrdbs27XQPi2AEglPuCosUxpaW1pkBMjgfLHWF6RCQxYD+TMqwP+IgkyhYpfDwZ+hC5e5/s7U+Lpevl2wKTiw60y6xA4mPUNNv6GRBMlMWWtulP1VB8S2dxfnU5bZ/bWW9hGgruM6dfmfdEissPOtLVxKZXLO4grqwLCgN0Yp995aXCHGrrd8qnWiK1olffjfUQnZ4bI2qtjXXL0h28k2si4GThmo815THReudFyb7KGs2MDoGJXEF0Q2vIw8SVOE+c1gFCEh9ulwTXHyH865ifB8B5lZWNLZtB4QaJ9SMDA2L6KuN9nz+iqhywpWjFLBKVags2Rn+4lqaXbKfo4AuEnjma06h3ynnIUufIGZha+GFldtaJ8kWnD4tZ2dhsdJ8NA8qhkifcYR47GNHBSg6ms9UqmgZOeEanFdGyxKTcrFMUAH5XpyfHpIE88sjkTGAJgu/ZDRM6PV1RPRsATLmLCtEiIkvJht7UDdglnv4HSJ+20iFZ1d3pc4nGxdYdQ6nBw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199018)(33656002)(38070700005)(86362001)(82960400001)(38100700002)(122000001)(64756008)(316002)(41300700001)(8936002)(66446008)(5660300002)(66556008)(66476007)(52536014)(110136005)(4326008)(76116006)(66946007)(54906003)(8676002)(55016003)(2906002)(83380400001)(478600001)(71200400001)(186003)(7696005)(9686003)(26005)(107886003)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wd1Yf9ADmOUUO+D3fdwqkcZnkYUwawk+udzvEUD0EiWEVlo1mss5ITh3BWaO?= =?us-ascii?Q?H3dXNrsNHkU+m+/Oh7DiswLK16Oa3f2GFn3rZI9hG0FlumZ3kbZ/DWBHYFqM?= =?us-ascii?Q?yTpyO3z/6tDV04SBnlblKRLnW8PjYgn3e0jYIrN6gKds/Kxl0LyYEJVlSoky?= =?us-ascii?Q?HNTM/O7HHYlWq12K1DGjg73ojOGRMaTTU+ktVpW9XqXaABok0uNz/goSE70x?= =?us-ascii?Q?Kzl92DFiFBX3KC8Ly4V5lG7lVBkGV6t+buLSEUa9QtfFBgHUI7VbHKhIswBL?= =?us-ascii?Q?FFWlB5ofvxEdlPZDpK1nBgYpQ+1F3K1xTmXz8u1Qz1JXAiR92Axh2JkaA6lL?= =?us-ascii?Q?/RdMOWWAZOQ1DqNX6MNsDpkddu6Y3TX8tpKO9plVv4TAc4IlNkpBq5a+KXPo?= =?us-ascii?Q?FJV89NXtEHtxl31geMQ03YA8gAXzi1VTosO/WbKAuX5fUXlHds8sY3/CIar4?= =?us-ascii?Q?aR9Rr+ZO0PmqXWZYM8iCW35EMLzATwYa7HxbpWUoZKgB49vPpevTlM6rSQvA?= =?us-ascii?Q?vluwRHPW1/2dsLX2zBRsgAVUzzNeDwfX3F91saJYfu3mEjtZ9vnHZ0wgoKBy?= =?us-ascii?Q?jEtwuyoClthGlrfhEJ6/IWPQW2rHVlNWmvjUFrQuHTos9c4W8rwaUWrIkVX9?= =?us-ascii?Q?ZlZUhjj5Pfyt4Lmd0JQcPHUiRNKWVwmMG5Mw19gmBtjBH4zGTdHGgBGGJHPz?= =?us-ascii?Q?e/fHwdJ0ypEuoeT19eGpYIc1JXVQMFxfOwhyU4Wxw/IDAJyDN4EoNiVcBE1l?= =?us-ascii?Q?dXXBWLI+8tSKt0lltxcJLr0CJP3UCPUPxFiiJfpNUV4MF+QFA66caPXWSeLa?= =?us-ascii?Q?V/HGiRlU6Thn6JgkItw53TNIFepFEKlLHfbtXLVdVCLRIBXbvvgqELZuHAZA?= =?us-ascii?Q?ihdDjz22eynoQWZ7mp7Ax/3qLI7ymfbwXDdQsdlzYSstLkaAxVBMwTD6uIPB?= =?us-ascii?Q?fek9wdZfevvgYJEhh0DVT2xcmrivkts2LrGIOVO53weDFO/qaXNljkIo3fTK?= =?us-ascii?Q?P7/O1c92OmJPIpJafQSStAh/KXQJN3puWS9g662t6K/Skad1Ptmvqaoxh2hH?= =?us-ascii?Q?PbOFMAoq0hgTFYJJx9eKO/ZxQCStu/weGaGqCWlbN5mW/O9uKIS7Q8C3QUhx?= =?us-ascii?Q?nT80eFWTInHNbMfWrTMdxUDk6BF9snTsSgjNpz7ElKnqAxIqz3KKLPAWH5R0?= =?us-ascii?Q?w63GzXoTeFrmj+W1nI5PZIAxH9VrpdeQxRuyOUi9cMktwd+0TF6mTSt/iri8?= =?us-ascii?Q?+OmRwymI+pN7h5sfpLR3NqxtYT/qtjJOLAdTh+OI236Bv2ZScpmbbIklbXfW?= =?us-ascii?Q?RKP1NK3fp1akLuxwIa/SJKPo9XbHAwqC6Ku4V9MVw3viRpIJ9MBGIb21dW76?= =?us-ascii?Q?9O30E5DBGJsNbSkQYZqCxa92DkXp5ef3bNVNZvlQiVlZFsgn487prn4FLQYp?= =?us-ascii?Q?oSYEVU0q/Y8ZjuLO2HgPRvhP72nSmLIrKgNgRyfIypYPWFJ29kzsfcofm/nL?= =?us-ascii?Q?oM9aJ4HY37Teb94E/eolhEyox9GTNeDb3I99dB+qWEDLF13bbm8bji4BFcdC?= =?us-ascii?Q?hlkKnti6J8coIaDffeAzJmD+CqqFO2Vzv5uCVgNT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b05eb068-9e31-4940-4415-08db05d8648a X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 11:18:36.0602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tE8pkIw6aVLliIUhCYaBNI1X2fWRf/kUz021jQh9hL7xRMij+IG+QJA25hmefy1l+gE5odpjSZk7Lt6R5xHweg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6863 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > > > > > It's doable to program the hardware interface using DXE MP service > > protocol in > > > CpuSmm driver's entry point. > > > But, considering the standalone MM environment where the CpuMm > > driver runs > > > in a isolated environment and it cannot invoke any DXE or PEI MP serv= ice, > > you could > > > understand that why we choose to put the hardware interface > > programming in a separate > > > PEI module. This is the major reason. > > > > Ok, *that* finally makes sense to me. Can you please add a source code > > comment explaining this to the patch series? Patch #1 (which adds the > > interface) is the best place I think. >=20 > Sure. Jiaxin, please. >=20 Ok, I will follow this suggestion. >=20 > > > > > I admit that a minor benefit of this design is we can isolate the > > > private hardware interface programming in a close-source module. > > > Otherwise, the SmmCpuFeaturesLib might need to expose a new API for > > > the hardware interface programming. > > > > "benefit" and "closed-source" in one sentence while discussion patches > > for an open source project. > > > > And you are wondering (see parallel mail by Jiaxin) why outsiders get > > the impression you are trying to hide information. > > > > No further questions. >=20 > Gerd, the benefit is to have a better modular design (separate PEIM inste= ad of > extending existing SmmCpuFeaturesLib), NOT "close-source" module. > I don't have the power to argue with you why not open source the PEIM. So= rry:( > I like open source world and the open-discussions here. It's the open-dis= cussions > that help to produce better design/code. > Please don't imagine that "I" want to hide something. If I cannot tell yo= u > something, > that's because the information cannot be public for now required by > the company policy. Maybe people like you working on all open-source code > cannot understand the difficulty of mixing open source and close source c= ode. >=20 > > > > > Though this new HOB is not in PI spec, you remind me that we might > > > need to add more fields to the HOB so a way to distinguish between > > > different versions of the HOB should be considered. The way could be > > > to introduce a new GUID for new version of HOB, or add a field > > > (version?) in the HOB. I prefer the second. > > > > Established practice is to use a new GUID. We should stick to that. > No concern from my side to have a new GUID once the HOB format changes. Agree, it's fine to have a new GUID.