From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5D88394112C for ; Tue, 23 Apr 2024 07:31:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BgwLrhb0nTAg1yjEorx46MWEMtTZ+bmczD02Av18d/8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713857482; v=1; b=eQceJB8oarrkAfy8DG9R6VNJZG7q9ZQxti4l3KQTP/EL1KBxFHgKE2LeHgEOGms6OmbBJ3zQ G8YUou5PC78LK2inNJRe9L8U3NsuUmgYJjAbJ8bW8/oX2nxbW4PfYoAplByr/odUgdIP2ciGklJ GerGHUnmeGD+AXw0tuWKoD2drvlwtzdgRm58H/gcK0bidN5MIicQDxWil30z81dNN8d9qEed03I zOt3MLmaGMKpYcjcrQ26LJ32SQdKPCqYqmqWhHs/s6YaH2BK++gYUOZYnZVVhE+8XZBgihlE8TC q10nxSL5Wk5ehKuY/wETeM24SN09ySPPF3/PjrOFt/UAw== X-Received: by 127.0.0.2 with SMTP id HygoYY7687511x6MMIVkbrHg; Tue, 23 Apr 2024 00:31:22 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.13016.1713857481765303176 for ; Tue, 23 Apr 2024 00:31:22 -0700 X-CSE-ConnectionGUID: XuhgJryrQYaCVHf+kocrtA== X-CSE-MsgGUID: eb5QWuWCTMiJp4WJcASZqQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="26941746" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="26941746" X-Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 00:31:21 -0700 X-CSE-ConnectionGUID: WnsW2wRtTfCvGnpX+JT2/Q== X-CSE-MsgGUID: FLFA0hEjRtylnaQ533fjEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="29086860" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Apr 2024 00:31:21 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 00:31:20 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Apr 2024 00:31:20 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Apr 2024 00:31:20 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by CYXPR11MB8754.namprd11.prod.outlook.com (2603:10b6:930:dc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Tue, 23 Apr 2024 07:31:18 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99%6]) with mapi id 15.20.7519.018; Tue, 23 Apr 2024 07:31:18 +0000 From: "Wu, Jiaxin" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Ni, Ray" , "Zeng, Star" , "Kumar, Rahul R" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Ard Biesheuvel , "Yao, Jiewen" , Abdul Lateef Attar , Abner Chang , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Thread-Topic: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Thread-Index: AQHakV2GkVjeKzZueEqpL2F3/efgwrFtqcSAgAZI9YCAAYbkEA== Date: Tue, 23 Apr 2024 07:31:18 +0000 Message-ID: References: <17C74D78B0B952AD.15491@groups.io> <3v4gqem2libtqyxyw6gzuqrifjxurj7lahdbrfn4474fvgkit2@kojgaroebe3o> In-Reply-To: <3v4gqem2libtqyxyw6gzuqrifjxurj7lahdbrfn4474fvgkit2@kojgaroebe3o> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|CYXPR11MB8754:EE_ x-ms-office365-filtering-correlation-id: 5a2857ef-f04c-4cd6-7358-08dc63675dd4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?JCCVOulmm93Sa6gdG+ioiorYIv73rAbGHbzs1CDEh7tSvDdm2ISPQuN8Nd4k?= =?us-ascii?Q?3xTS1zzMQUmPZ3BF5w4IPopXvbRHWGUlnELbXrfjED427VgP2lUHGbD7W1of?= =?us-ascii?Q?Q7xFyO67u36SP7GeE0B/2gUKtJx2P11WprscLC6U/le9v/DSuCmkORY+2yJD?= =?us-ascii?Q?cKUBX3Q0jwzxWlcZmhhkSB82wQ0/Uh9BZy7UUu2l1VxKZYrfKp99t+IGIOlr?= =?us-ascii?Q?+VhZ4L1jrPOVIuYm+RZV3oyKJxCcDUWbLL7srfJn5XS09SqUs6ZRC1bmWkJ0?= =?us-ascii?Q?/CC1T/AYFZ7wUyJTaCVaouCIJHmIovV5i0qxFQjPhnanxlxy5ypQMcaYHOGF?= =?us-ascii?Q?UztfCDuHKLArx8o05b9umakpjZBBKO/n5TgteqjdV3D5SPM5eFnFii1EoBfa?= =?us-ascii?Q?KPbMSoCG2e7buFpj2ge9CPqFS5Q8/5LiWmENit1cAuPZWYJk4gxSCiKc4man?= =?us-ascii?Q?baLOOpDv7xTnQ5N1I6kzSeap2LZeRD7URMN8HkayuTdjab7ipGlAwSe2G48u?= =?us-ascii?Q?FLpbfSf9rEramW+jeufwa/YNdd+U0hWO1QflYMew40LOdQXsWOqTvqVuKXsG?= =?us-ascii?Q?7zAeFm+bPYfD2xk2YbEsi5BQRK5SpezuYHBIV1vvQE6p17FOrlHZiV8/kmat?= =?us-ascii?Q?WNW2bNhYzCO1LRg92pB4h5AhRhdpVgO/t2NXX8+bc0fECnDl/H2C36sCQTE2?= =?us-ascii?Q?APx56IH9jy4bGgxEQ36gTWJrfmjIKPTjNrDgciIvDsWd3cT5EtmvPxmdgn83?= =?us-ascii?Q?+9FtPIsvFIbNnPFjFuW2h8dcN3NJe79sMt14SSDlAJtcxhLHKZJvR8kY04ox?= =?us-ascii?Q?CSJp3JUhJtj9zrUtKvldYASug/n2GzFNsxFPyiXwpu1qya3ja1UZvH6sBFQB?= =?us-ascii?Q?FGhoXKq8FHD23tR/XpnFq5d185HeM5hDKbBW81k9hHJga2D7Bpo4rxPkLmsN?= =?us-ascii?Q?VD36VU+Ta5wNXR79JPVoa1O7buhXAq5OtmLkS+Cxk5rTZ78fH81aqRVeHoFH?= =?us-ascii?Q?VZMgtYfqMRkq1B7Tr1ZB4bhRI9qe50xdIwamlcARBL83gV6Q6B8WXXiHfK9v?= =?us-ascii?Q?RFMJa6H4vXsB9J13WvC0SlhmejwVcYhLwS2AhNDJwumuIz+eBj0wBrQCEGqK?= =?us-ascii?Q?MK3riEve0s6zSTvSLcYm3Q3ECUdmEEujB1eerLgHD8K4VniofN18B7az7H3I?= =?us-ascii?Q?RHxqELhh3ZCh1PO+lg0PvuJQRRxCqM4x1eDDjLTodvkSl6TTej+fACqPRk3h?= =?us-ascii?Q?Oo7kDAP9VnXv4zToHFJSHqcHXZ6fTKVt5isN1pgGwOSiaHFT4YfxHwQEz6jr?= =?us-ascii?Q?of1Aqqx47MPUEkPtk8QuYeBpMSanimE6DsnQPUvq1GUrjw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oG1+BrJqu5jt1IJH8Grc/hS8dtklQRvUMQ+slFnFjkWqmdsydswWBc1TC7wS?= =?us-ascii?Q?GrGpVdYRTYY6IesNNoI+BLbU/IoRAJ/3dqwPlBaa/iN7hZfX/VA4FuovY5mB?= =?us-ascii?Q?Z06PaOqUZX6eY6KAtlhd1gFBft1spbCbmEpDu4JvcrIizFsMbAgmtU+U6X3t?= =?us-ascii?Q?5z8bAOMDSAmnc2QhgAxQ/wg88qJJwQ0KH6e4Qijax2+qbq0HDBbBwXtJE30f?= =?us-ascii?Q?MKUkECtW0cAibI/JE4uxt0RoxRbnjm47a7RAG0K7IRydZtCIp9Biz3Ehb/jt?= =?us-ascii?Q?KW4rcA+MhRIWzUcRznvJKxegAILBm1BhoLGpgJTczNEHzv9HUjo/3quKo67j?= =?us-ascii?Q?KQLCHQy+gI/wt60RinEgdFAqovMfhnt5qtsieWxBCm5iQj2YQW/cxToguqu9?= =?us-ascii?Q?+purGfsY3UZ9MMtpEJBf5fO/hpuYXf34jrzMffEgZ63Mdn9fOW4gjzB+HS+6?= =?us-ascii?Q?xrkiE2K6VxEoSy3YRFcFFQXGtSROMeegiG6sBc3duvB6JOzaO+dqFRiKwiDT?= =?us-ascii?Q?otv2C9PSTbLk5xTvb4TtS90OEc8VkSe8ljtlX17HyEg3n0+ly3JdHiuiPJjc?= =?us-ascii?Q?5eebCrwiq1pR0eOEb3JcHJThUL5RqJgB6sIaIuBhM55ljz6C2ulHKVqoWizi?= =?us-ascii?Q?t0zViLnFa2tVKtT/xSx8qfGldhTQnz5CZQOj2WEdCyU4xIs2pyjuyKzj2Rnh?= =?us-ascii?Q?kzdZgMGc1N2nj7CBMf1tSV/rq05vk9lWmNkE6MVqhyHiM813SkqrYlHUM76c?= =?us-ascii?Q?4CmY8u2tCblY8az/qdcsuGtQYrjPhlIRVChGLOzgxlbYbegASju1LpXg4oov?= =?us-ascii?Q?h4JODYyd3CKsQeyY14ALAhf8NMx/H296eqW4T5EUsZ912MPYD4is5ulCC369?= =?us-ascii?Q?canwkqCjTqPQBbb+Jf2oR5ZV+5m1e+9s9oFwkN3/ZGSG5c2dzhi10e/kYV16?= =?us-ascii?Q?md4qVzLjCuVLAw6uclzgbV97fXokdQojggCXaQ+ItNkbRv2uXEDcbo9H0WPh?= =?us-ascii?Q?F5FLSBXB8w5Md9WfeUXEFkgq53OahLDzKa+9bcMN5N31vNGt3KEjdSC7CVu9?= =?us-ascii?Q?K+uCk9ZJE8v2xgDYge2Icxj0a5pcOEuAoB32hJhGXt32F6aAcx2KZ1BqRq13?= =?us-ascii?Q?zlczXDqgYeNGrvmCUf+ugSw2r8IPcLakvZiEwY+/LDQ/aSOi8eZ1ArBqfrM8?= =?us-ascii?Q?gSWS4yiNB353/F4lIOBf7Rh0ETpOU7qXgqkEwhx1VkFU9GTMib0EOgAVaEMw?= =?us-ascii?Q?melDK3v/1RZfIvaU5AMQcwBXlkGsr9YMqPdzBhvi/iKFTmTRTbAcyoK5aeFi?= =?us-ascii?Q?mGRj70Ha4uaupsInPHYclFmrb/z6C0os3sC6zHReMM+EQrXYhJp7J6XjMfMg?= =?us-ascii?Q?C1XFQMb9wy/lveY164Rfsp7If30+M11n0nacAt501GXEJE5ThBypMiG2Y9qI?= =?us-ascii?Q?s6Oxi7oRn4/Q1HlDDjjr7Yc4VBjHiGpFk3tKr3cbcRQfv6Kxup08jIcGHWyb?= =?us-ascii?Q?c/HZQdAvRpReuPsYHa74Hfheb5GMjcUH8L46KqjWYCmchghgAYa4Uce3M6Qd?= =?us-ascii?Q?hs9k1h6hcfMRDrW3yJ9L16O++OoSI8E/E9oi3OpI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a2857ef-f04c-4cd6-7358-08dc63675dd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2024 07:31:18.6627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qqfUpk4NWZr9AY6xHAKF9SxBouDRKYX/or/xNCKx53ZDJQ8/liip/FWq80BJbdLjTI7U364t4bWwfXHPczK5kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8754 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 23 Apr 2024 00:31:22 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: myImCaseBrwuEpPKFt2faAP6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=eQceJB8o; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Gerd, I will try the S3 on OVMF. And for AmdSmmRelocationLib usage in OVMF, do you prefer: 1. use the AmdSmmRelocationLib directly in this patch set? Or 2. still keep the original to create the OvmfPkg/SmmRelocationLib, and clea= n the code in the future patch? Both are fine to me, depends on you. Thanks, Jiaxin > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, April 22, 2024 3:58 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Ni, Ray ; Zeng, Star > ; Kumar, Rahul R ; Dong, > Guo ; Rhodes, Sean ; Lu, > James ; Guo, Gua ; Ard Biesheuvel > ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib >=20 > On Thu, Apr 18, 2024 at 08:02:43AM +0000, Wu, Jiaxin wrote: > > Hi Gerd, > > > > Could you help review & check below OVMF related patches? > > > > > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > > > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > > > OvmfPkg: Refine SmmAccess implementation > > > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not > > > OvmfPkg/PlatformPei: Relocate SmBases in PEI phase >=20 > Patch series breaks S3 suspend support in OVMF. >=20 > On a quick check (OvmfPkgX64 only) using AmdSmmRelocationLib.inf for > OVMF seems to work fine (S3 is broken too though). >=20 > take care, > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118128): https://edk2.groups.io/g/devel/message/118128 Mute This Topic: https://groups.io/mt/105593568/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-