From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C98167803CC for ; Fri, 19 Apr 2024 02:07:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FZRdXgYPIfdts37Rez4G/eWTOj73UVBOplLuTk4A32g=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1713492419; v=1; b=Zpa92mdX+vr0Ad0atdoHL+JszQhGTWEGY+vlQ5NGo6XWC/oxeDO8Zoo92BgpW3Eo9YVWX84P lAraM419+82binWGx1FxfG+SeZ0EboCsLc2DxSsJDvlqCFIksU3qMsNu4TmyJUTJCHMrzh5+kO/ gbMjomalivUrbvNnrP9j7+UV4mI4G1q9OXu7o84+566Q3uhnJYVdz7zhJ728ma4NiQsV3yYJUfG XrJZQV/eiWaV7A7X/9oNC+eXPy4dOMqAtu7JkLNtfjxdp71yQIKFiUTzixF+xhIuSFb4VVQaDKr FopAA4qZ5SjR5VutWxxHVZO6McI5M7XhAJtCudFVW4VTg== X-Received: by 127.0.0.2 with SMTP id nMBzYY7687511xVcL48RMvMK; Thu, 18 Apr 2024 19:06:59 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web10.11050.1713492418631384120 for ; Thu, 18 Apr 2024 19:06:58 -0700 X-CSE-ConnectionGUID: 5G89Hp74Qy6PVs0Z9Y1QSw== X-CSE-MsgGUID: xjxyayygRUKhqtyZYtTXow== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="12860757" X-IronPort-AV: E=Sophos;i="6.07,213,1708416000"; d="scan'208,217";a="12860757" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 19:06:58 -0700 X-CSE-ConnectionGUID: NWpsjRmEQBm9SK+gfQkEYQ== X-CSE-MsgGUID: YOb41nVdQN2MbbSC7rJT0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,213,1708416000"; d="scan'208,217";a="23257364" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Apr 2024 19:06:58 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Apr 2024 19:06:57 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Apr 2024 19:06:57 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Apr 2024 19:06:57 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 19:06:57 -0700 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by PH7PR11MB6055.namprd11.prod.outlook.com (2603:10b6:510:1d3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.37; Fri, 19 Apr 2024 02:06:53 +0000 X-Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::b0c8:dcaf:59ea:9e99%6]) with mapi id 15.20.7472.037; Fri, 19 Apr 2024 02:06:53 +0000 From: "Wu, Jiaxin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v3 13/13] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic Thread-Topic: [PATCH v3 13/13] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic Thread-Index: AQHakV2SyGjvJ0Dg90a9fnXG0xvogbFtqjKagAEvZmA= Date: Fri, 19 Apr 2024 02:06:53 +0000 Message-ID: References: <20240418065556.5696-1-jiaxin.wu@intel.com> <20240418065556.5696-14-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|PH7PR11MB6055:EE_ x-ms-office365-filtering-correlation-id: 83fbef5d-4418-4a27-9e45-08dc60156204 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /tCztiK6jWUCfYq9Q8ZA320CJ3HzKXiWsBRQxgXUCy4Y+77J8ITY2iR+w13CaQy6lMYDs2OLSpHXhcqY3sOT1HmKynRzMLjRrsDpeOo2ZgKdHwNWG9G9QTLXVPEqs4qG2xy6+yZ1qstx7Ll95kZM6gU5uuihxOePufOvWasQhkXdLBsrICpyQjwvLhER9Ix+ee1GqA8RUJWtNUcpiYnsuva8Ikw+hhxQmBUlFpyHKHdKqKzQ2Y0X3zlAw5YDcOKmBvSLps9mWi8dwAs7f906be9apf/f1bISp3IMNh0lW9dedijC2pdfabjYUfhtFAI2YbhrtGQJtTW5zObX0Ml1AQ/jfNiSLQqg551eNI6vWF8+i7LQl02l0NMTmiNxJl9y5pjFDmrpMZL3x24vjfRpyEhC+Uh0Mu+58bKo0DXrjs4ldkoGvpMCph/CqMWxUgJHJOO+ACRdKqwwVEd1FgOLmStTXa9jgF23wxmAtMaAoyz09RJrnftSxKaoVNu8VoFiXf+gokWk7LAkRarBk7vTuqCUT+MMrzwqI+YmTG2uPDujYtTRYZmjQ5dsVnFGWq88jNN17PtZb1UU20e/y0mSbxJe1I9qbbKgIAHYJ1BgJFews3cPmVWm6rU7J1MuqDORhhcFOWkQposThJzQ5+mzTAd4ypMX8WV6981iz3lbl7ar3uJc8mNuKQf1O3qVTaiJliA7n8sM/26qppGrH6Q1nEYth75Wq/j/J5JjSYGEJ40= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ea1SB/jpIdXMzeMuo7pZhPHfuHiQOdKhHiu8KsL/Dzg1VsBuVXEyMY7fsWpn?= =?us-ascii?Q?h6Hm9P9dXkj0GmouqAMPbOwW9mqtSwgTacZhzm3+qQTxBE4Udeg5jqBMmImY?= =?us-ascii?Q?Ttd12amJUIJESoKT8LC4h/1zB3uywuBHDUrD41A5rE69KcSpL8L06PkGHFXl?= =?us-ascii?Q?m6hOqRtmWOE8iVwCTBPcIyd/Aba9BW9+qmO3sRi8mrELaGjvchVv8Q17vZfo?= =?us-ascii?Q?sArwUjnYgpcWaletpBSR4WVpCOlGluVSlCZZx8IdAXjUoiG1nORjxQWxvrgj?= =?us-ascii?Q?1k2YrbqfQVQUo8WvYGBmoLhfXIU4KGYcS4YQxsg/9eH/fEK6DUh4xPy2q0xt?= =?us-ascii?Q?mFBlmibhHH9wNJ5y1Mfh3epgYTyMX+PYt7FEhXhKQXVjjDesf+Wfq8tdfzoU?= =?us-ascii?Q?EqIO4Nf6k0kmEu37JOWmfPhccScLMDPxSJiFmJHfXVfvF7rMG+1elmvNokKV?= =?us-ascii?Q?vF6vp2sleXe9NL831D4VOBCDA22K8imfjw11MDZ0jQk8DXhlvi6HGD4Emnn6?= =?us-ascii?Q?WuAd8rCV7O+szOJIsHNX2wT5wI8UU2Yj5xKMqXfvNugfS7ODHaNg0EG6qP0t?= =?us-ascii?Q?NmLVDnTvHOD+9LkxiMhld9zimyZmS076FCvA7CBCZH6hPA3mKsVd9BArrDxS?= =?us-ascii?Q?ZSTDh/3eAndAwKrr5WjPp1okLII5Vh4BfN44RIBrLbyPfe5pLdjlqvjra9RS?= =?us-ascii?Q?JGarDK1aGWTjuRd7CSHTRezhiUXOtuFt0UhFT4LSLgGAX/5bjR/nMP8an62r?= =?us-ascii?Q?W85LmvoztICRfMkZ2C2smyRhFofEOj0yydwf6jFvzUI9art+yir3vch2Y1Mb?= =?us-ascii?Q?s42CmzPYl2rN4oFhRFHjPlRuHh96sRUFvM+fCHuS7C7ZorHneWYMhoRIqiRR?= =?us-ascii?Q?t2oFRRyyB2MS+V6L12oS+cYdICGqYTZ9vNtU3Ni4yu7lObcUz0PeOcAE9VVm?= =?us-ascii?Q?P7P8AW7o/Q/riZ3xa8ExxF87/gO68guj3PiM9jF9BfJel+4bQaRKlWtKzDOG?= =?us-ascii?Q?iKY3W0r8apWDr+Fx4udgIeZADiY/n8Kroi9DIM1I1It2kyZcq2OtzwpBTw2G?= =?us-ascii?Q?UQb/LiMU624Lpd2J1SxYYYsB7v8Snvg3kUr/sZVWLOOYsb4VHD3k8RWD+fKA?= =?us-ascii?Q?173QuwIH7InmBcSqKc2EcaQbtcRU5c39gSO9+4GznLwfZl3RCN3kOg9Bc6IS?= =?us-ascii?Q?s/Z/QJDupv04CmyMZOtCErQPHSqSPaN40viDfJpA639oxivVKnB+LWr/l1x5?= =?us-ascii?Q?zoURagI6QraCcDYlgiRqCCsU2q8O0+l8YgImWbic8OcxhbKVm1yEFkA0Y4sd?= =?us-ascii?Q?sGZEMYv8KCo6ddNRZXJCusaXDoRMUWPGdXYkSQFSDJ2wwnHE4X0SYmbVqJ8v?= =?us-ascii?Q?CkVIJ/IHrl87pjgbvoyf9v/cgndb+TqO1zlNNKWoAlNaLWPI6MnFRlONmIBl?= =?us-ascii?Q?Yi6OTUPLFkZfgbvRe2IkR0DUyCVr4AkhRAsKqd5yVAqvZPrydhJ9zXR/057r?= =?us-ascii?Q?hvYmi3aOJxq6BZ8TZC+rNFvx/KccfBob9mZvO0NYGxzocN6nL5KLgsjb0h/w?= =?us-ascii?Q?nV+aEFZ9o5I1vnmLm6G35v/PWuNdacRLT3y5UVRN?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83fbef5d-4418-4a27-9e45-08dc60156204 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2024 02:06:53.4447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GfvE7emzb+skD8pPBJ8rvQXopcGCQrqwvHHCpX5ZtCVE3HRx+dUMoWV/NxKVhLs2rMGv4rTGtG2EvmqTdvsxXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6055 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 18 Apr 2024 19:06:58 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hYavboszamiJJ51GhSKosA4px7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN0PR11MB6158D482F62F0FBFA7F6181CFE0D2MN0PR11MB6158namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Zpa92mdX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN0PR11MB6158D482F62F0FBFA7F6181CFE0D2MN0PR11MB6158namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok, thanks Ray, I will follow the change in next version. From: Ni, Ray Sent: Thursday, April 18, 2024 4:15 PM To: Wu, Jiaxin ; devel@edk2.groups.io Cc: Zeng, Star ; Gerd Hoffmann ; Ku= mar, Rahul R Subject: Re: [PATCH v3 13/13] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases rel= ocation logic + // + // Check whether the Required TileSize is enough. + // + if (TileSize > SIZE_8KB) { + DEBUG ((DEBUG_ERROR, "The Range of Smbase in SMRAM is not enough -- Re= quired TileSize =3D 0x%08x, Actual TileSize =3D 0x%08x\n", TileSize, SIZE_8= KB)); + FreePool (mCpuHotPlugData.SmBase); + FreePool (gSmmCpuPrivate->ProcessorInfo); + CpuDeadLoop (); + return RETURN_BUFFER_TOO_SMALL; } [Ray] Can you move the "TileSize" check just below the original TileSize ca= lculation logic? Others look good to me. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118002): https://edk2.groups.io/g/devel/message/118002 Mute This Topic: https://groups.io/mt/105593584/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN0PR11MB6158D482F62F0FBFA7F6181CFE0D2MN0PR11MB6158namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Ok, thanks Ray, I will follow the change in next ver= sion.

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, April 18, 2024 4:15 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com>; devel@edk2.groups.io
Cc: Zeng, Star <star.zeng@intel.com>; Gerd Hoffmann <kraxel= @redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: Re: [PATCH v3 13/13] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBa= ses relocation logic

 


+  //
+  // Check whether the Required TileSize is enough.
+  //
+  if (TileSize > SIZE_8KB) {
+    DEBUG ((DEBUG_ERROR, "The Range of Smbase in SMRAM= is not enough -- Required TileSize =3D 0x%08x, Actual TileSize =3D 0x%08x\= n", TileSize, SIZE_8KB));
+    FreePool (mCpuHotPlugData.SmBase);
+    FreePool (gSmmCpuPrivate->ProcessorInfo);
+    CpuDeadLoop ();
+    return RETURN_BUFFER_TOO_SMALL;
   }

 

[Ray] Can you move the "TileSize" check just bel= ow the original TileSize calculation logic? Others look good to me.

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118002) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN0PR11MB6158D482F62F0FBFA7F6181CFE0D2MN0PR11MB6158namp_--