public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* PcdLib instance for OVMF SecMain
@ 2023-03-13  7:13 Wu, Jiaxin
  2023-03-13  8:40 ` [edk2-devel] " Gerd Hoffmann
  0 siblings, 1 reply; 2+ messages in thread
From: Wu, Jiaxin @ 2023-03-13  7:13 UTC (permalink / raw)
  To: kraxel@redhat.com
  Cc: devel@edk2.groups.io, Ni, Ray, Zeng, Star, Laszlo Ersek,
	Kumar, Rahul R

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Another issue exposed during boot OVMF:



SecCoreStartupWithStack(0xFFFCC000, 0x820000)

ASSERT [SecMain] c:\dev\code\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): ((BOOLEAN)(0==1))



I WA it as below fix by overriding PcdLib for SecMain driver:



  #

  # SEC Phase modules

  #

  OvmfPkg/Sec/SecMain.inf {

    <LibraryClasses>

      PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf

      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf

  }



Is it another bug in OVMF?



Thanks,

Jiaxin


[-- Attachment #2: Type: text/html, Size: 3425 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [edk2-devel] PcdLib instance for OVMF SecMain
  2023-03-13  7:13 PcdLib instance for OVMF SecMain Wu, Jiaxin
@ 2023-03-13  8:40 ` Gerd Hoffmann
  0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2023-03-13  8:40 UTC (permalink / raw)
  To: devel, jiaxin.wu; +Cc: Ni, Ray, Zeng, Star, Laszlo Ersek, Kumar, Rahul R

On Mon, Mar 13, 2023 at 07:13:39AM +0000, Wu, Jiaxin wrote:
> Another issue exposed during boot OVMF:
> 
> 
> 
> SecCoreStartupWithStack(0xFFFCC000, 0x820000)
> 
> ASSERT [SecMain] c:\dev\code\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): ((BOOLEAN)(0==1))

All PCDs SecMain reads are fixed, so they should be evaluated at compile
time and PcdLib should not be needed.  I also don't see that happening
locally (current master branch).

take care,
  Gerd


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-13  8:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-13  7:13 PcdLib instance for OVMF SecMain Wu, Jiaxin
2023-03-13  8:40 ` [edk2-devel] " Gerd Hoffmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox