Re: [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

It's hard to say the motivation for this change if we leave the patch series. Standing in a single patch, it's optional change. That's the reason I didn't want to separate this. It's hard to say the benefits of too small granularity patches. But it's fine to me also, I can explain more background why need this.

Thanks,
Jiaxin

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Monday, February 13, 2023 8:34 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>
> Cc: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Zeng, Star <star.zeng@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: Re: [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace
> mIsBsp by mBspApicId
> 
> On Mon, Feb 13, 2023 at 04:44:13PM +0800, Jiaxin Wu wrote:
> > This patch is to replace mIsBsp by mBspApicId.
> 
> ... and mIsBsp becomes the local variable IsBsp ...
> 
> >  EFIAPI
> >  SmmInitHandler (
> >    VOID
> >    )
> >  {
> > -  UINT32  ApicId;
> > -  UINTN   Index;
> > +  UINT32   ApicId;
> > +  UINTN    Index;
> > +  BOOLEAN  IsBsp;
> 
> ... which allows running SmmInitHandler in parallel.  Which is the
> motivation for the change.  The commit message should explain that.
> 
> The code changes are fine.
> 
> take care,
>   Gerd