From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.34422.1676340094497662857 for ; Mon, 13 Feb 2023 18:01:34 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ls7qFqup; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiaxin.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676340094; x=1707876094; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=axTPoe7KFLY+DpMEKq5mYcA4IjcX7Ab3HoR4qVkLKhg=; b=ls7qFqupyn773mKZ4MVjzpYToxfOv18an9IxMR3Gl+Z/u8TAJPzicJgU gNs9tKu/NSvxHfv7mSsQRfeaYNj+hasuoUTH/TeckHJQZZ/CMHLvaLRuA 9LIu3KTz2RcOS0rs8IbLahijrCHs9PkcGpWt1/wYb8ab3BCLUP1P0WsKd hfVxPf+42/eZRWW8rzF8YtrSEaGAYW07wnw/jKaZMHpchGE4fNOY+qTMa dtCMffTBiCoiPSfXUryuquf50ZN1mXYB4OT8o3KNJU86ICF74Jc2XdryP xUBpsRitxNf6Yf+2sJjd/AtvXglcvKnj8TP3j8KdDbdY9zBlQMSXgzr5f w==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="310688083" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="310688083" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 18:01:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="662398042" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="662398042" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 13 Feb 2023 18:01:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 13 Feb 2023 18:01:33 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Feb 2023 18:01:33 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 13 Feb 2023 18:01:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WE2WIkl8c+nM86DdhZi2J4TWC9a375G3hrldkrcg5NnEiITUKXS5nZ6wiOw01omOfuEqLp8WiI8rPhaLynQ87cxDLKMkPOm4yF8DwY7jyuwWlZrhieti3vi1qsXvX/D8QgHumddPve6b6zK2q2xdVCMeo/ytv9aljSCe3SA1Vn5Ji8cA45apuOPQ0mQIKPmBUrTpc8sxm3n+XYCVifFbSam9OQI6J+hQjvzrRZ2Tci/8I59Z6hWgqbKYpOJyiem54DcGQ7ihsYY6cS2wZap5txs7ba0i/bjlB4L9cNtE+w5ZcUaFMkvTVelijH+kNiKskXBV8t+9HzgT7i8BiCe/zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uplmRzOdi+uXiGvcr8IQ74zsBGiopX1BoBolOtRXTI0=; b=PgQ5Nvp+T3DlcrVrGAiHV4iLB21sJdVDOdTVhy4K1oMOMstoFnKUlR/tD/oHuA7f0UAwWjPd3Wvgk4X2fOvlSNM2ii2SpNV4h1x+cbNhJpIYkjsb8s6oNOM7dr4vznQyrwZWJfjBFPELO0T5KIbMTYR99bJXwKMCC0bMQB2ByD+Ph2qdu0vsPDE3r1nh0K6EMIxcqvAGSbF9fUZMocdMQI4Uzjcn9uMuHp6/ISAk4/Er85DWNr82DGMFYqBj175CATNHeNbgjyS4m8AfEqxOgjLLDfjR4UHwWvvZ42/8wBSuG1sQuCsx9ZUC0noQ9m4QQGm4W9rMZ7ZeI13MSwuJrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6158.namprd11.prod.outlook.com (2603:10b6:208:3ca::18) by SN7PR11MB8067.namprd11.prod.outlook.com (2603:10b6:806:2e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Tue, 14 Feb 2023 02:01:30 +0000 Received: from MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01]) by MN0PR11MB6158.namprd11.prod.outlook.com ([fe80::e5d9:d16e:172b:aa01%3]) with mapi id 15.20.6086.022; Tue, 14 Feb 2023 02:01:30 +0000 From: "Wu, Jiaxin" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Dong, Eric" , "Ni, Ray" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId Thread-Topic: [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId Thread-Index: AQHZP6d1emNhxpNPe0+lmXeZk6lQSa7Nr74g Date: Tue, 14 Feb 2023 02:01:30 +0000 Message-ID: References: <20230213084417.9232-1-jiaxin.wu@intel.com> <20230213084417.9232-3-jiaxin.wu@intel.com> <20230213123405.cqc57thibrjpsjaz@sirius.home.kraxel.org> In-Reply-To: <20230213123405.cqc57thibrjpsjaz@sirius.home.kraxel.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6158:EE_|SN7PR11MB8067:EE_ x-ms-office365-filtering-correlation-id: d04fac4d-a0d9-4543-0084-08db0e2f63ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v0DVAQFcaPZpfamWYM1NSS1KrG9BirWi+U9S+hbbPkIjWAaVaNoRPSST+4argMm7OTPrCS0ySH8jKzEE+JYVOH5CegFC0JpRmWzfSRbyCri4hJFyf99z4BzdAY5bRNITuOoVccJHa22JsqKMLmOB3xX4yYxVUQtSn5XSUyC0rk+hbD09tRVGZ7tmgkWVNDj5HOeljQiNYlG9Wrhv+dxLS7PyLR9KxCRJgnNGux1toCe/dHxletBettUZO2cLrl9++f0JhPZ02uroWYgHspPxR+hCt3vpx0MVjgh3dLtjIP6iyh4D906C2mQXcem3G0OuoUEF0fPmpUclyA5Oww2j8vOObKapl0YfK0pq858EDoOD8b/rwoIl7oeNxqZW+L2cVbnixelZxlFVEYaRuMNRYl70lNoX2Lpucs9dsYeZ5k3hoTl1XQ28590UJ9ox/ZCkPHuEOffsqLmBIRQg9T/Wa1uq4O0DMxQEj59JpvRjT63tYayTEG5VlcBE+Ay73xXf/CuRzptrq7FDKf13w49bf/UhLNqdsgfZhFb0+LRZ6dE0BdNX2a9ZwJ5OIm2idIieemxIqgjRE2BRfpMcXcfbgJCnN6y1BqeuXY5qUvfSaW3dk9est9XsolSqICvmPYV4N+YR40yT9+X2jQ8111/m0S5rki/z2DpXbnVeAjnmMj2Sr01D/vQm/iKw6+tthJbqzPeANDI8t0JjEbTAb31XEeYcDtPYYCpP5HTc4R54081MJJG6zqPHqF95XAFwtBR5 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6158.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199018)(71200400001)(2906002)(7696005)(83380400001)(33656002)(55016003)(38070700005)(82960400001)(86362001)(38100700002)(122000001)(478600001)(9686003)(186003)(26005)(53546011)(107886003)(41300700001)(66946007)(8936002)(52536014)(316002)(54906003)(76116006)(66476007)(64756008)(66446008)(6916009)(66556008)(4326008)(8676002)(6506007)(5660300002)(145543001)(145603002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jDgSWL6jG3k7co+1nEu1SSTJVjIQeJQvR908ng7xlAXH1pzoTVIoCuynGRoE?= =?us-ascii?Q?Fm7JVIRmHw9Qd1IPRYvC8dscipjsGHkkJY00fRwLL2SP9JQ4GvXCZ+NOsiym?= =?us-ascii?Q?8oCko/yoMqL/kVmctqpqB5JDeUVYocURCRfLngy1gCi+91Pyj6sXZSrXBVAO?= =?us-ascii?Q?n3xNL5nsEFIlAvAGL+4hf2WDp7tZHcJRxJHrNMaRyptMuZ6tsixMSOFoGls0?= =?us-ascii?Q?kKGEyEHITfeR9mrvsvBpYtJI/1x6T9ExT1bnRmJbngZoJJJScRO+yPUGHoow?= =?us-ascii?Q?3Ie9AKIzMnIgRzF0DTJKJIRLMjYLltw6kZ0RhFOh+PuSGX0nx8tEfRPlSoTo?= =?us-ascii?Q?Ob95sG0s+j/xUfB/+dN01ME9xRqPUabZx01ardoE4Lz6e7hGYyIkxGfnPuIR?= =?us-ascii?Q?YSS3x0BIXU80ByQGCGPgEUsiu2WQtd2csd+FI0oGQyRDZuD7GRTQlAkLlftI?= =?us-ascii?Q?1q0BYNdNuD/qH38HfyP5HP1HQlywAa3n8gdJ4cJGYKS4AbzGD/ueWk6bJ6LS?= =?us-ascii?Q?0HXnUcK0SDjOe9K7IEXKdQt7q9XwGuUdWs/zRgrqmYbCHyulBmfBWaOR06dQ?= =?us-ascii?Q?0bSS4X9YBwBVMHGfar132U10+gLFWlwwtAzXHsOPBA3MPO4h7AbIMGKPZ0nw?= =?us-ascii?Q?V+eeVynGcOt3mFnaOe7DCBhU7PfDpW72jQzDCHNJ+a0MO3yUAMRLYMAnRgaD?= =?us-ascii?Q?ZQ4vh2wINImfGw0un+ZY6aQYHEM9Om4SxAgVtxOAeaJMPFwESbPKFPyo66Sv?= =?us-ascii?Q?7IbXBi9MZ5Pd7AFcqk7NBxhrtMPS/XVSwUFxtnQZU64M5WmRdFVwLRthprln?= =?us-ascii?Q?wILC1cWnnJtKuXKhoKY3KpQFABhCqCw3G0iXw6hI5QuGtpHT2OPwm1cOQV4C?= =?us-ascii?Q?tcuFEgZcksFHd+zaG421Swf/jnOVu/mgJ61L447SlSAjdNxp8AEwdkdkd1HL?= =?us-ascii?Q?+iilUhRSzWP8KfFjKgl72Y/YdQBMVzx86vE2Si+lSmfDRxRPYnr3Z+wJ+Xkc?= =?us-ascii?Q?orYNbgBKOT4kXeQcpUHgz1As1yN4L5MMhVUg7+D+54WpadEMY8QRCD/hZ6Ek?= =?us-ascii?Q?JE+mBD+sgfySxey2Drl83O3FsicCWu8zX+Pyrdfzu8xMiwBqJgbN91FY4JNg?= =?us-ascii?Q?2+t10TkBqB6oGlOGLtlXsWU//BFlt8/tcPoUzbC1yvHrio/VkEMeFARk+nSs?= =?us-ascii?Q?6220CVD1z5qCI2fnk1xnVGSCK+JAJ4XHjTDrAQqwiDyOZgiPDy2Dlu4O4UQQ?= =?us-ascii?Q?heZJItXEAO671twlPkjcuPdi+5kPCQfOwKbQK6Sq1KDz4VqHezDkezIQljL/?= =?us-ascii?Q?J1rXhlmz2o8i4JTXlQU2Lnr6nneehB6S4TQNTvnTqqRCOj+meooxT4Y6ImK8?= =?us-ascii?Q?wLU+X3gAmPededVFw1HRe0FrLdEif0s8Q05pS8AsN0xVvGs3AiW9MnqbWHIq?= =?us-ascii?Q?GBHi9/qTFpuQvMrv2/pmci2B1WgevU/dgSPIfsF4TMvtUrMy9D7j51UqJtNq?= =?us-ascii?Q?B3ADr/RkWbyDOB1ue1DAdMeaTC2HkoFAWBYlgcK5+OJVh4InLhGqidJ5pE4E?= =?us-ascii?Q?43fSnDpRvi8fbwpreaTX8eh421XiqLItFYw2wP/6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d04fac4d-a0d9-4543-0084-08db0e2f63ae X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 02:01:30.1031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eB0F9x6eRZpU4buNfxwExy/8fMSlTJ9Mc2xePa2/eot/JJTpNpAG+af2Pn8SAyyo7o3gPzayGPqSW/SiRwC49Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8067 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It's hard to say the motivation for this change if we leave the patch serie= s. Standing in a single patch, it's optional change. That's the reason I di= dn't want to separate this. It's hard to say the benefits of too small gran= ularity patches. But it's fine to me also, I can explain more background wh= y need this. Thanks, Jiaxin > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, February 13, 2023 8:34 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace > mIsBsp by mBspApicId >=20 > On Mon, Feb 13, 2023 at 04:44:13PM +0800, Jiaxin Wu wrote: > > This patch is to replace mIsBsp by mBspApicId. >=20 > ... and mIsBsp becomes the local variable IsBsp ... >=20 > > EFIAPI > > SmmInitHandler ( > > VOID > > ) > > { > > - UINT32 ApicId; > > - UINTN Index; > > + UINT32 ApicId; > > + UINTN Index; > > + BOOLEAN IsBsp; >=20 > ... which allows running SmmInitHandler in parallel. Which is the > motivation for the change. The commit message should explain that. >=20 > The code changes are fine. >=20 > take care, > Gerd