From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D730E740032 for ; Mon, 23 Oct 2023 05:48:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kXJwfn0lDrHxHZAAJpG3dhKYTB33beBsYnDQ/bTELuQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698040099; v=1; b=R0J/LAKSCo2JE+3OoKHAq8EMpKtazmROIVIjvUoW3/ftaP5iFg7LMekj7iYm1o3FT4EYD2y7 RPfJK/9vmFtZzruxFFLfD25fFaH+FuBSB/OqNtcnz31Y6fuPfoZHov6RkbHyp78Dcabyn4+emAZ Q086ROomkg/mRiT1jK7Q1mm4= X-Received: by 127.0.0.2 with SMTP id 5GoZYY7687511xvAkgEfZ2Fe; Sun, 22 Oct 2023 22:48:19 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.114504.1698040098045073794 for ; Sun, 22 Oct 2023 22:48:18 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="385652432" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="385652432" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2023 22:48:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="793010543" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="793010543" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Oct 2023 22:48:17 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 22 Oct 2023 22:48:16 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 22 Oct 2023 22:48:15 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Sun, 22 Oct 2023 22:48:15 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Sun, 22 Oct 2023 22:48:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqCwmSRdNslAIV4ygwmbAK7gPi6XCmvvbsIJztVuFCjl1Od821sGeYIK5Asj526u2AoyFB3wq0/z2qbNigbTb/eKGSoN5js4Y73sidBD3juWOw8msshVyS2M76LoRHjR2jGZdbPRK1DavtMr3xygtAy6cTy7sx627tesM4ZuGYrpr10zqePAaCeIaq6JuwET53Sj7iB83l9HOjDQ2RkBCB42gtPueOJSgfhH4ElfDAy3AtJmZWpDJQjkKsjfvIF5NfU7eiJlI4YkzF1fw/Fra/0TZxbBNB9aPJ2hUtyf5n9IVJn+BajWTzDDD2o5xIdyAkX/V1M9npWxfBTLxmURsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MA/BzVLeoRUSoAEOmh1p3iC35XqBu89Pque+aEgCsso=; b=nKQXdNAyHLSvArRNtsKuI6Nx4KuzXNEu7r0jcc0f+AXl5FZBEcIX5oJuqBM1pbOuqQgtSPFoAvAwPF5Sg5hDOnmHdQSkOSVayfUGaT6/i86FFdURdc3sSqG2sJ6sgLCeltlUfO8vssUfiGKI/tOtXkYWO4Al5v+Z/YvbRRl1WvIfmahJLcU0+weeV8Fke1v4Hg5ZLvNfltblnEF6nEToA5wHArsoJvPRyrTmaIDFewbasp4ajjzNmnLBXdu+OdXmQaw2HuYs3cUhZs++nOTd1O+a+0KYihBAL/BGZgdLPQaTQ5VkmvNLIz1LWU80Ka5muoD7J8e3YqV3YLltfCW+uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN0PR11MB6301.namprd11.prod.outlook.com (2603:10b6:208:3c3::8) by PH7PR11MB7004.namprd11.prod.outlook.com (2603:10b6:510:20b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Mon, 23 Oct 2023 05:48:12 +0000 X-Received: from MN0PR11MB6301.namprd11.prod.outlook.com ([fe80::ed98:9bae:2cc0:bf32]) by MN0PR11MB6301.namprd11.prod.outlook.com ([fe80::ed98:9bae:2cc0:bf32%5]) with mapi id 15.20.6907.032; Mon, 23 Oct 2023 05:48:12 +0000 From: "Huang, Li-Xia" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Isaac Oram , "Desimone, Nathaniel L" , "Wu, Yidong" , "Xu, Wei6" Subject: Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaAyEmQZRi0Xh2AE2Iy6Gd4leWvrBUSH3AgAJVdjA= Date: Mon, 23 Oct 2023 05:48:11 +0000 Message-ID: References: <20231020064616.6637-1-lisa.huang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f5680497-faff-4ef9-95fb-0d394246569a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-21T14:03:32Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6301:EE_|PH7PR11MB7004:EE_ x-ms-office365-filtering-correlation-id: b6751a21-e256-4ab1-1d95-08dbd38ba44b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 3lJ6I+uHuJR+m4VGVcZaZ99QHMq7hQRvsKU6OfGjwxgf0IdES8zbYcSSM/TPUY50OtK6SWm7aytROPzSIR54xm6HmrawUU1u4QpaRdi8O3q0FtNa+5KeMboKvh3F+VGjxLkwcloaMW4Y+G69yEtJtVUbVTWVG6zguUi/0LUGSENX7ati4ghW6836ssiiH2UTmGsIsJ3F34L3UngvgxeRJPPGaTZadjaorpnr9WHlipsjrjz893nAvfi1XDf37ugpHCNbqLfkVq1cvFDIO5EGOom8XWOFOJceAweE1LSgkDLuCIU7261s/Q06ZW8+uNlH8zLK5Nn4L2b1sqwHJWZJqShIQigkRgoBslV6+7oAol+NwUiiTVJ6a3nx7HzPxTPNVlhDAQlwlfyuRwFZd1vUVmH12uIgeu7dd+l72JBz3QOaJ5t5l+S86Phsfn1GuBgQE0QaKiIDLApf7d0H4dDON/4+MTKxl/0Kggf8ntRVH4Ce+AeDSfNCpY25Ct51utBcjjVHBNPN9+GKHN5uAAjOvp5QvCyb60jSWOz0hLj5o/JKMCi4RH9r0Sbby4HSGtqvifwToHmirJMHfWyaME8PSR4mMZJy8nrfjFNytkeGuA05Bpt7Wvo/9lpPE7PilGWqNCrCULL1h7Go4NQDZuFNSw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e0xzBkHLkzknzIe7AtQenhy7qK05OoviyoPLaj8jsfkbzccVc/uIIEN4UsjP?= =?us-ascii?Q?Ffys3p0IY8okStzLE0X5JTU8EaEIo8AbGWrBmyMx4RF4vZjTPcQABjBZic8e?= =?us-ascii?Q?vU8SgOYzPLV7Rf4DP9+53oP3gm80NYBSd4j6Bi0MW30xO0M4MjFsaYoZLwcn?= =?us-ascii?Q?dPqJyB35466ZuGSDGxsw+zzNiE7CO+gcVm59PE/cjdRQpPTi7jfILuAAWSdz?= =?us-ascii?Q?3QqkPVLQBmO8LegSllzyNlQPDvv8lqqHM0Gm2atL/8Qd5ey7ojTlapvtqyTD?= =?us-ascii?Q?tT6gPIFh9+6oWHfELRNhM2bAeYvdmNLDGHPjnqevE0puCXa4Kl8SY2eq2xAI?= =?us-ascii?Q?y/ECUaXRBVD0VvYisiK22Pc3n7vuECsu24ZPOwNKHsEYXw5L5v/pw650znH9?= =?us-ascii?Q?dUkXZmxqFaM4PrmpKsxo34sfTvOpbEKbCx/IWQSqAelov22O+5HcI5786XNh?= =?us-ascii?Q?QY1cLxp2oi03dAFJ22rt2qy/OMX9pPUyvzVdWjSw6ih9MoemG2U9zmOuthlc?= =?us-ascii?Q?I4hqJTnZ2V7S5MM4KzdTWi4s+7u5wRDVKVcqc1EOuJoVsT8Fkjjgo+JcKM1V?= =?us-ascii?Q?pEppb5bHMLd+ECZ5SjErzGT1XbXchOZCdnwYihQ0k6kZjLJigs4Z0Qvs8Lit?= =?us-ascii?Q?cla7vaP5bte8sqBCVF68rh9EXvazBUfp3LXclECocEfONkZGMVYHtFjnmv5L?= =?us-ascii?Q?WRKtIkP44DQgH+U1hHBxFEed+ElbZQHQut9ZSQ0wremjASTEf651QSQPYi76?= =?us-ascii?Q?uUHTMzfGWRNodWWq0lmhkQSuOHq5C/VWZQUuysxP46Xhd/vW5p9hbvJrq3t1?= =?us-ascii?Q?vV9GH07kSN7Ei+7RYnYwOaEB1M2hO1Gi2PccL2X5CIiqZP2i1nptH90dNDOX?= =?us-ascii?Q?qAD7nm0n8D5rIzPds66jF72Zau2leYifphhIOrguTi17h3FL6qhjY1gdDSk/?= =?us-ascii?Q?oVM9sELEjqCnsJEMABSR3kjXKB8YELdLwaKAQ+pvc7pvTyOUSJA3AV1V2wg1?= =?us-ascii?Q?SYCLkj4s3UVZF3Vc8IGbvMnMA91XGbMkoSGUqVGpT6q5UmLIT7kr9yiQZSsR?= =?us-ascii?Q?l7FM1ELN8SyxcXNjXJD4Jtx4eQRSZr61r+P+2HflL03Z2vcH1fEr4Zy4GrwH?= =?us-ascii?Q?6QJD0N7Ng43f2FD2XXUJDj/xcR5Y3nVJK+tS9yeUVh9DvHhfmUE1rj8Y9q3B?= =?us-ascii?Q?DSv9PrvmewanhSUb4ZUIRpb1za20tVuSL+a0C92hcvyH1D9rqQcJBJlGMUJz?= =?us-ascii?Q?MwMeHPd+Q6Gk2wDhf1Yb8lbm5BgyVjI/L8GMZ+2sykUPdpegkslU2cCr+PFB?= =?us-ascii?Q?yRbswbaS+5GTr4YyYyaeiLYkERmRzL6B8GYcJNFntgzwfcR4ktmUGyqjhDPO?= =?us-ascii?Q?zB14Feg1Ebn/Q1jLKfF0/d/pkKRXPQ7aN4kTbo0IjZEIhWk6ZqEa/ANfN9c4?= =?us-ascii?Q?w1vYCOIaeF0cTE5f6pbU9gaiYidlWsptzQvAnsDsleBkCwEedZ8sq8TC5h26?= =?us-ascii?Q?a53y0AS2OGLy3+os18g339E5QndI686w35FUpo8gjNFydiwS+joMt4pCb1wS?= =?us-ascii?Q?m20qt+FHxk9+JjCuUxv1JOD0VUsXt11ZnVB573Xn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6751a21-e256-4ab1-1d95-08dbd38ba44b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2023 05:48:11.3303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DdBYxzYT6UXrcJhP/SCzOv20ST/wL+rlLUM7GfwwlkK6u5d37bAMol5zwIoenAequ56UdwCmHBNWDwSj7zg2Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7004 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lisa.huang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1kZ55y666huAiYPHr9WgpMyDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="R0J/LAKS"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Abner, Thanks for your feedback. Since the IPMI implementation in these two packages are diverging now, and = my patch has some dependency with common code in IpmiFeaturePkg , it will b= e better to resend this patch after the diverging is done. Our target schedule is '23 WW51', could you let me know what's the schedul= e for these two packages'(IpmiFeaturePkg and ManageabilityPkg) diverging? T= hanks. Regards, Lisa -----Original Message----- From: Chang, Abner =20 Sent: Saturday, October 21, 2023 10:15 PM To: devel@edk2.groups.io; Huang, Li-Xia Cc: Isaac Oram ; Desimone, Nathaniel L Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Suppor= t Standalone MM [AMD Official Use Only - General] Hi Lisa, Issac was no longer the maintainer of IpmiFeaturePkg as he was retired. Nat= e had sent the maintainers update for review. As the conversation I had with Issac, we all agreed IpmiFeaturePkg should b= e deprecated as the IPMI related drivers are now located under Manageabilit= yPkg in edk2-platforms. The IPMI implementation in these two packages are d= iverging now, which is not good. Could you please send this patch against ManageabilityPkg? I can help to re= view it, so does Nate as he also proposed himself as the maintainers of Man= ageabilityPkg. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Huang,=20 > Li-Xia via groups.io > Sent: Friday, October 20, 2023 2:46 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Nate DeSimone=20 > > Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi:=20 > Support Standalone MM > > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > Cc: Isaac Oram > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 202 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..52d8d2abdd0d > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,148 @@ > +/** @file > > + Generic StandaloneMm IPMI stack driver > > + > > + @copyright > > + Copyright 2023 Intel Corporation.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > +**/ > > + > > +// > > +// Statements that include other files > > +// > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include "IpmiHooks.h" > > +#include "IpmiBmcCommon.h" > > +#include "IpmiBmc.h" > > +#include > > + > > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > > +EFI_HANDLE mHandle; > > + > > +EFI_STATUS > > +SmmInitializeIpmiKcsPhysicalLayer ( > > + VOID > > + ) > > +/*++ > > + > > +Routine Description: > > + Setup and initialize the BMC for the SMM phase. In order to verify=20 > + the BMC > is functioning > > + as expected, the BMC Selftest is performed. The results are then=20 > + checked > and any errors are > > + reported to the error manager. Errors are collected throughout=20 > + this routine > and reported > > + just prior to installing the driver. If there are more errors than > MAX_SOFT_COUNT, then they > > + will be ignored. > > + > > +Arguments: > > + ImageHandle - Handle of this driver image > > + SystemTable - Table containing standard EFI services > > + > > +Returns: > > + EFI_SUCCESS - Successful driver initialization > > + > > +--*/ > > +{ > > + EFI_STATUS Status; > > + > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > > + > > + Status =3D gMmst->MmAllocatePool ( > > + EfiRuntimeServicesData, > > + sizeof (IPMI_BMC_INSTANCE_DATA), > > + (VOID **)&mIpmiInstance); > > + > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > > + return Status; > > + } else { > > + > > + // > > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > > + // > > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > KCS_DELAY_UNIT; > > + > > + // > > + // Initialize IPMI IO Base, we still use SMS IO base to get=20 > + device ID and > Seltest result since SMM IF may have different cmds supported > > + // > > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > > + > > + mHandle =3D NULL; > > + Status =3D gMmst->MmInstallProtocolInterface ( > > + &mHandle, > > + &gSmmIpmiTransportProtocolGuid, > > + EFI_NATIVE_INTERFACE, > > + &mIpmiInstance->IpmiTransport > > + ); > > + ASSERT_EFI_ERROR (Status); > > + > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > > + > > + return EFI_SUCCESS; > > + } > > +} > > + > > +/** > > + The module Entry Point of driver. > > + > > + @param ImageHandle The firmware allocated handle for the EFI image= . > > + @param SystemTable A pointer to the MM System Table. > > + > > + @retval EFI_SUCCESS The entry point is executed successfully. > > + @retval Other Some error occurs when executing this entry poi= nt. > > + > > +**/ > > +EFI_STATUS > > +InitializeGenericIpmiStandaloneMm ( > > + IN EFI_HANDLE ImageHandle, > > + IN EFI_MM_SYSTEM_TABLE *SystemTable > > + ) > > +{ > > + SmmInitializeIpmiKcsPhysicalLayer (); > > + return EFI_SUCCESS; > > +} > > + > > +/** > > + Unloads an image. > > + > > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > > + > > + @retval EFI_SUCCESS The image has been unloaded. > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +GenericIpmiStandaloneMmUnload ( > > + IN EFI_HANDLE ImageHandle > > + ) > > +{ > > + EFI_STATUS Status; > > + > > + Status =3D EFI_SUCCESS; > > + if (mIpmiInstance !=3D NULL) { > > + if (mHandle !=3D NULL) { > > + Status =3D gMmst->MmUninstallProtocolInterface ( > > + mHandle, > > + &gSmmIpmiTransportProtocolGuid, > > + &mIpmiInstance->IpmiTransport > > + ); > > + ASSERT_EFI_ERROR (Status); > > + } > > + gMmst->MmFreePool (mIpmiInstance); > > + } > > + > > + return Status; > > +} > \ No newline at end of file > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..336e28368ed6 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,52 @@ > +## @file > > +# StandaloneMm Generic IPMI SMM Driver. > > +# > > +# @copyright > > +# Copyright 2023 Intel Corporation.
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +## > > + > > +[Defines] > > + INF_VERSION =3D 0x00010017 > > + BASE_NAME =3D StandaloneMmGenericIpmi > > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > > + MODULE_TYPE =3D MM_STANDALONE > > + VERSION_STRING =3D 1.0 > > + PI_SPECIFICATION_VERSION =3D 0x00010032 > > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > > + > > +[Sources] > > + ../Common/IpmiHooks.h > > + ../Common/IpmiHooks.c > > + ../Common/IpmiBmcCommon.h > > + ../Common/KcsBmc.c > > + ../Common/KcsBmc.h > > + ../Common/IpmiBmc.c > > + ../Common/IpmiBmc.h > > + StandaloneMmGenericIpmi.c > > + > > +[Packages] > > + MdePkg/MdePkg.dec > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > + > > +[LibraryClasses] > > + MemoryAllocationLib > > + BaseLib > > + MmServicesTableLib > > + DebugLib > > + StandaloneMmDriverEntryPoint > > + IoLib > > + ReportStatusCodeLib > > + TimerLib > > + > > +[Protocols] > > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > > + > > +[Guids] > > + > > +[Pcd] > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > > + > > +[Depex] > > + gIpmiTransportProtocolGuid > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > @@ -129,4 +129,6 @@ > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 > > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > > + > > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > > -- > 2.26.2.windows.1 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#109823): > https://edk2.groups.io/g/devel/message/109823 > Mute This Topic: https://groups.io/mt/102076516/7039027 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [abner.chang@amd.com] > -=3D-=3D-=3D-=3D-=3D-=3D > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109887): https://edk2.groups.io/g/devel/message/109887 Mute This Topic: https://groups.io/mt/102076516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-