From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4CC5F740039 for ; Thu, 26 Oct 2023 05:50:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=96i96oyTBZqo50y5XVmPG63z1bvoO+iaT9ZmpkvMUsg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698299406; v=1; b=kAGCJbLIejCnBc69iKnUEx8Q70Fwy5BdeMHrM6tvDqXwLtiRKvSFyA+Xl92WMEvlMzPHDzfu 5e4kN7yJitGdZmc9pi3FJmxeH7C2YKeuwUB6Bx58D71Ru+TIjHMy5VYiagpN5CwbHsCh+G8hTao J1VxuPYzk4Ice9i3cttaQ224= X-Received: by 127.0.0.2 with SMTP id 4SvAYY7687511x92m2KsWdsS; Wed, 25 Oct 2023 22:50:06 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.193796.1698299405837169599 for ; Wed, 25 Oct 2023 22:50:06 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="384672144" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="384672144" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 22:50:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="759082545" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="759082545" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2023 22:50:04 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 25 Oct 2023 22:50:04 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 25 Oct 2023 22:50:04 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 25 Oct 2023 22:50:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUHOvrdHN3MSrG+UZYPLZk1zGeLWqdfG/bTMttednKpxRLGgcfWRxGJ9lbalJgW2M8l8GN5gzZ/eh97GSKbUdAIjOyRxVTaUeYIRHM+Mqlz9vJRaW8KA35K3nxsGJHo2IMi9ZiI77dNLk9BJyfRmmyN103v64cmk3N1jzafr7K4F9hG/0GgbcMFQSW6SI7fp8So+cK1WykyjZLY7bH1jF8hM7vWnTp8nQ+O5ZGy/oNUcQDLQsWN11BziiDogD2gW5RiiPhMsJMFQVo7yboSVYQS8N7FzV6wwSplRQu2l/DFDdkQFzcTQh3UU8iJsO055DqiKY/BcEi8rn0SU5UBTOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/LuYdjQ8DBDh6v4UZnDMRNuPoatM3nCHKi5dnq61JM=; b=gBjbaJ0trIc5cbN3B+O9uu0N+EqHNHqo/oIQFxbbX3PCN02ja4G6BdtU/cpfzWSKICNNlnEmN7vg8cT5agkbnypKpRrb4FFgIAJLw6ZbFKaMXveqKGB93A5+AwtomrbOPd+H0SS9rF0qzpOhryRCbpgTWyL7jdyBA2sCHQ18Z8Jb+diN2j8Qy0R50v5eKGoutqXyXIZkoNA6eioOHhhZDxWg4rRy9FoCP1giJjsR4Z91mxdxsj0N1qOYCc42snRnfavQLh56orJw+jkIT4RlHc11wucUSXMiLlCfyRiR4nzocnrIjwsvXzGN5iUWC9syDNbcVNXM6cr+v92lTtOSFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN0PR11MB6301.namprd11.prod.outlook.com (2603:10b6:208:3c3::8) by SJ0PR11MB6816.namprd11.prod.outlook.com (2603:10b6:a03:485::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Thu, 26 Oct 2023 05:49:56 +0000 X-Received: from MN0PR11MB6301.namprd11.prod.outlook.com ([fe80::ed98:9bae:2cc0:bf32]) by MN0PR11MB6301.namprd11.prod.outlook.com ([fe80::ed98:9bae:2cc0:bf32%5]) with mapi id 15.20.6907.032; Thu, 26 Oct 2023 05:49:56 +0000 From: "Huang, Li-Xia" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Isaac Oram , "Desimone, Nathaniel L" , "Wu, Yidong" , "Xu, Wei6" Subject: Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaAyEmQZRi0Xh2AE2Iy6Gd4leWvrBUSH3AgAJVdjCAAihEsIACh8Jg Date: Thu, 26 Oct 2023 05:49:55 +0000 Message-ID: References: <20231020064616.6637-1-lisa.huang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f5680497-faff-4ef9-95fb-0d394246569a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-21T14:03:32Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6301:EE_|SJ0PR11MB6816:EE_ x-ms-office365-filtering-correlation-id: c41d6505-a450-4774-a9b8-08dbd5e761f0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Kdj4qcFozhaiFlAQVoqbnvjawZGS+YE5n4Z3xrJrGPNtCH4Iuf/1nDGSIGYoJn7/RHr11BndK9RN5QFUQzsZIbX8ETLJZYZhVYBhFIwNIcPWXnNYbpOJ/0QlhAaJIVHwOP+wOKygC+XcK8D3X7MGjz3hK/m/G4S92HsNAItOkSZpdXf4qwYA+JpAdXW0vxDRFi2hWH9WiwW4bpJUxeZ/VniALil/lxzrMZrzHJ30dc56hLvv+fekTE9uTC//VRKCDIa9IsCP3XcDFxHgHOMGmqfNbGXFjHlFWIhXMj2SC4geuxj/+4WGQdhdH2Mhj+H0F2R0jzs3aKtUL14O4OsO5UtX1ICtB2rZcpDu0UK7PkTAYvC7OIO24lZWk8ZN4QkO7o9yT5iVS1tFikDyM5UbUOe+ibWFCy6oEw27FFcJReBa5GGyfvQKlETbtzYNlbzD6sCq13LuT/zSXXFS2q9n/0KaID0N1NePEBHl1h/T0i1XPf/BaUOgZvkRkPP0zEbdDFXUPqs4QDZUcxu/xD/B0FK8uupJ58I2cUsSqCpC+16WfE7OFNSxE1pFpoiRoe30r/bYiEc/0rbZLgDWaVuEx5UYj7aQuDgJBT6X93XZ1Op8UIA9BDVQ2477oxTfsMLlb+C0Q8EokS/FeiO0J5k9tQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tCQIkZzJLebOHl+2T9tnSE+YPNQII2KKN5TnK7g/qtj+UCMDvHID0F/Lkxkm?= =?us-ascii?Q?fhFko4KpL795ienTUTQivEkwms4IVR7wVaFgqwqqK6Z+i1ZfqsxP8boSmpla?= =?us-ascii?Q?cykXJBMkS8t8ga5aUSg4wcUnwXZv40Zb3rhdAizhzb0BJv6c3F7hWQCW1UUC?= =?us-ascii?Q?ncNWsv2TqcN1oyactYcyzPo71MfDIWX4zxjshNNcmCgx2L73qI60Bn09bUKF?= =?us-ascii?Q?qSR+BcuvG0fa9gikUkwvlqzvfUP7dzeRwqd1gsIdpwuHhkECP9FxKg+QPTlQ?= =?us-ascii?Q?tPPpaJPVjdFVnrqRZ1jiiJrHS5Ao5u4AGBMYH8WUBeFfqTS0XbDocZiAxHfG?= =?us-ascii?Q?II3IIK/YttypCK8g75BE6faZarNLKWQ7LyFxW0zcs5dTTONP/q54G0iP6VIZ?= =?us-ascii?Q?iCmGotnd2/Nan9v57hTuDu7jfEX8uKfHDFCKajprrJvWAr/7lCczsZFg08UZ?= =?us-ascii?Q?s1VM5tm0NO3p7RI5kD5PAx2FPqDUAgrMS/ZhD83OwYWohDIUiU3719bWtyHh?= =?us-ascii?Q?NBgmzO1CkK1+DWwSdsWIIb/5fa32tqXRk06Dkp3hWauk5YYd6YbPPGStje3Y?= =?us-ascii?Q?S2YC68GbYoH3cSJGjMdIwFI2nTpoGnRDhEoykCdACN6BbWVigu3HFc1MSl+Y?= =?us-ascii?Q?fKnPIT5mdrQgyQG0Gz1ORDymMLzrb9vQWrt3CoNuVeg16h54MYPjK2AC9Bgg?= =?us-ascii?Q?u6ImYqCsYUSx03tFUcuCj8puEDsqTBWnlzuUNVbq+Cr+ZDzK66duODkjTbrN?= =?us-ascii?Q?MCNBTyr79xgR7T4eb+kR6Bg8Z87f0U6PNgJW9Hb7e8M/yquV5IokO9cPshrF?= =?us-ascii?Q?Qs9UJ9hLID2ZHkt1btEbJsn48ryl5ZyuJeTrLwRBocr0uVMUsxjOrmFHH0U2?= =?us-ascii?Q?NMZZzt82wZLImB9DEM+Ga7hJHlFRhtGyJKgr0vee6x4QTCPYzsWLDRIrTtb5?= =?us-ascii?Q?dAwi/rPYa0nQXDKNy4xID+T4Ec2hdFjBIh3wUakHAx/RKU73+0rognsJnfkH?= =?us-ascii?Q?+bgmTBmXEINdlVz5k6HSPiC17aVs44px1aeq2XUniDZzZBMQudOGEeX2R71P?= =?us-ascii?Q?pLeryV6YiAtl7TIyq1ScUiiKocXnm6f978OX+DvW+pSMqM4itPtXTk+8C1Zk?= =?us-ascii?Q?hDMLOVkMaWpnTKYkTF6vTZjZX9ouq6gequuB67kKvKShOq46YrvTash8QYI7?= =?us-ascii?Q?/yaih3vE6tPC1hhAj66ThqXanxz8Jbjihl50M6v3uCAGimfBKhhMb55AQyK5?= =?us-ascii?Q?rQZREBbLwc0troG1McnuyRmnTkTjQJ5wUmLS5K0QyQWU8ralHdu3753GH23U?= =?us-ascii?Q?gWzypcZSzgsYhcV69jovFIk1cfLiriKVUkWhmKby7zjwjdjUDpYD7Z9YFL0u?= =?us-ascii?Q?EJQ43bEPNDzwSfkDgEbEP0s7hsefUDgaFpwRev3wfQwZDh+45v8ep1X85KIN?= =?us-ascii?Q?L5kMrr7dmiIGVpEBQi2pWk1ZavIpLe3z74526JogWuBBA4XVnLvUc/CAjUgr?= =?us-ascii?Q?hYTzSk9HfRIzvsZUO3FIvlkXcQD9LqRf76oOwzGPdJ5YDEp4MIipp1w/0XUj?= =?us-ascii?Q?7/GdbzWKO6Iepybc94tS5erm5SE1aeK9Ih0d2Jd3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c41d6505-a450-4774-a9b8-08dbd5e761f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 05:49:55.9805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wqrNdkRUnkI9sMTu4PfreLp1uZbBVm87MWnCw45tCbfXRRYXH29p/RdAOETXkPE4ZLQa+taEPX/y0rceRzyp6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6816 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lisa.huang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QZbRey0ZGg14Y4qnaB94KQAYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kAGCJbLI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Abner, FAST_VIDEO_SUPPORT exists in GenericIPMI Dxe driver, my patch focuses on St= andaloneMm support, and will not touch other drivers. BTW, the patch format is also updated and pass all check. Could you help to review again? Thanks. Regards, Lisa -----Original Message----- From: Chang, Abner =20 Sent: Tuesday, October 24, 2023 6:43 PM To: Huang, Li-Xia ; devel@edk2.groups.io Cc: Isaac Oram ; Desimone, Nathaniel L ; Wu, Yidong ; Xu, Wei6 Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Suppor= t Standalone MM [AMD Official Use Only - General] BTW Lisa, As Issac told me the implementation which Intel upstream to IpmiFeaturePkg = was from a pretty old intel code base. Also, something like FAST_VIDEO_SUPP= ORT, BmcSlaveAddress and GetBmcStatus seems not used. I think those code sh= ould be removed as well. Abner > -----Original Message----- > From: Huang, Li-Xia > Sent: Monday, October 23, 2023 1:48 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Isaac Oram ; Desimone, Nathaniel L=20 > ; Wu, Yidong ;=20 > Xu, > Wei6 > Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > Support Standalone MM > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. > > > Hi Abner, > > Thanks for your feedback. > Since the IPMI implementation in these two packages are diverging now,=20 > and my patch has some dependency with common code in IpmiFeaturePkg ,=20 > it will be better to resend this patch after the diverging is done. > > Our target schedule is '23 WW51', could you let me know what's the=20 > schedule for these two packages'(IpmiFeaturePkg and ManageabilityPkg) div= erging? > Thanks. > > Regards, > Lisa > > -----Original Message----- > From: Chang, Abner > Sent: Saturday, October 21, 2023 10:15 PM > To: devel@edk2.groups.io; Huang, Li-Xia > Cc: Isaac Oram ; Desimone, Nathaniel L=20 > > Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > Support Standalone MM > > [AMD Official Use Only - General] > > Hi Lisa, > Issac was no longer the maintainer of IpmiFeaturePkg as he was=20 > retired. Nate had sent the maintainers update for review. > As the conversation I had with Issac, we all agreed IpmiFeaturePkg=20 > should be deprecated as the IPMI related drivers are now located under=20 > ManageabilityPkg in edk2-platforms. The IPMI implementation in these=20 > two packages are diverging now, which is not good. > Could you please send this patch against ManageabilityPkg? I can help=20 > to review it, so does Nate as he also proposed himself as the=20 > maintainers of ManageabilityPkg. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of=20 > > Huang, Li-Xia via groups.io > > Sent: Friday, October 20, 2023 2:46 PM > > To: devel@edk2.groups.io > > Cc: Isaac Oram ; Nate DeSimone=20 > > > > Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > > Support Standalone MM > > > > Caution: This message originated from an External Source. Use proper=20 > > caution when opening attachments, clicking links, or responding. > > > > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > > > Cc: Isaac Oram > > Cc: Nate DeSimone > > Signed-off-by: Lixia Huang > > --- > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > > | 2 + > > 3 files changed, 202 insertions(+) > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > new file mode 100644 > > index 000000000000..52d8d2abdd0d > > --- /dev/null > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > @@ -0,0 +1,148 @@ > > +/** @file > > > > + Generic StandaloneMm IPMI stack driver > > > > + > > > > + @copyright > > > > + Copyright 2023 Intel Corporation.
> > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +**/ > > > > + > > > > +// > > > > +// Statements that include other files > > > > +// > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include "IpmiHooks.h" > > > > +#include "IpmiBmcCommon.h" > > > > +#include "IpmiBmc.h" > > > > +#include > > > > + > > > > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > > > > +EFI_HANDLE mHandle; > > > > + > > > > +EFI_STATUS > > > > +SmmInitializeIpmiKcsPhysicalLayer ( > > > > + VOID > > > > + ) > > > > +/*++ > > > > + > > > > +Routine Description: > > > > + Setup and initialize the BMC for the SMM phase. In order to=20 > > + verify the BMC > > is functioning > > > > + as expected, the BMC Selftest is performed. The results are then=20 > > + checked > > and any errors are > > > > + reported to the error manager. Errors are collected throughout=20 > > + this routine > > and reported > > > > + just prior to installing the driver. If there are more errors=20 > > + than > > MAX_SOFT_COUNT, then they > > > > + will be ignored. > > > > + > > > > +Arguments: > > > > + ImageHandle - Handle of this driver image > > > > + SystemTable - Table containing standard EFI services > > > > + > > > > +Returns: > > > > + EFI_SUCCESS - Successful driver initialization > > > > + > > > > +--*/ > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry=20 > > + \n")); > > > > + > > > > + Status =3D gMmst->MmAllocatePool ( > > > > + EfiRuntimeServicesData, > > > > + sizeof (IPMI_BMC_INSTANCE_DATA), > > > > + (VOID **)&mIpmiInstance); > > > > + > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > > Status)); > > > > + return Status; > > > > + } else { > > > > + > > > > + // > > > > + // Initialize the KCS transaction timeout. Assume delay unit is 10= 00 us. > > > > + // > > > > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) > / > > KCS_DELAY_UNIT; > > > > + > > > > + // > > > > + // Initialize IPMI IO Base, we still use SMS IO base to get=20 > > + device ID and > > Seltest result since SMM IF may have different cmds supported > > > > + // > > > > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > > (PcdIpmiSmmIoBaseAddress); > > > > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SI= GNATURE; > > > > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDR= ESS; > > > > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > > > > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > > IpmiSendCommand; > > > > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStat= us; > > > > + > > > > + mHandle =3D NULL; > > > > + Status =3D gMmst->MmInstallProtocolInterface ( > > > > + &mHandle, > > > > + &gSmmIpmiTransportProtocolGuid, > > > > + EFI_NATIVE_INTERFACE, > > > > + &mIpmiInstance->IpmiTransport > > > > + ); > > > > + ASSERT_EFI_ERROR (Status); > > > > + > > > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit=20 > > + \n")); > > > > + > > > > + return EFI_SUCCESS; > > > > + } > > > > +} > > > > + > > > > +/** > > > > + The module Entry Point of driver. > > > > + > > > > + @param ImageHandle The firmware allocated handle for the EFI ima= ge. > > > > + @param SystemTable A pointer to the MM System Table. > > > > + > > > > + @retval EFI_SUCCESS The entry point is executed successfully. > > > > + @retval Other Some error occurs when executing this entry p= oint. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +InitializeGenericIpmiStandaloneMm ( > > > > + IN EFI_HANDLE ImageHandle, > > > > + IN EFI_MM_SYSTEM_TABLE *SystemTable > > > > + ) > > > > +{ > > > > + SmmInitializeIpmiKcsPhysicalLayer (); > > > > + return EFI_SUCCESS; > > > > +} > > > > + > > > > +/** > > > > + Unloads an image. > > > > + > > > > + @param[in] ImageHandle Handle that identifies the image to be > > unloaded. > > > > + > > > > + @retval EFI_SUCCESS The image has been unloaded. > > > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image > handle. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +GenericIpmiStandaloneMmUnload ( > > > > + IN EFI_HANDLE ImageHandle > > > > + ) > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + Status =3D EFI_SUCCESS; > > > > + if (mIpmiInstance !=3D NULL) { > > > > + if (mHandle !=3D NULL) { > > > > + Status =3D gMmst->MmUninstallProtocolInterface ( > > > > + mHandle, > > > > + &gSmmIpmiTransportProtocolGuid, > > > > + &mIpmiInstance->IpmiTransport > > > > + ); > > > > + ASSERT_EFI_ERROR (Status); > > > > + } > > > > + gMmst->MmFreePool (mIpmiInstance); > > > > + } > > > > + > > > > + return Status; > > > > +} > > \ No newline at end of file > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > new file mode 100644 > > index 000000000000..336e28368ed6 > > --- /dev/null > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > @@ -0,0 +1,52 @@ > > +## @file > > > > +# StandaloneMm Generic IPMI SMM Driver. > > > > +# > > > > +# @copyright > > > > +# Copyright 2023 Intel Corporation.
> > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +## > > > > + > > > > +[Defines] > > > > + INF_VERSION =3D 0x00010017 > > > > + BASE_NAME =3D StandaloneMmGenericIpmi > > > > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f= 00f81060 > > > > + MODULE_TYPE =3D MM_STANDALONE > > > > + VERSION_STRING =3D 1.0 > > > > + PI_SPECIFICATION_VERSION =3D 0x00010032 > > > > + ENTRY_POINT =3D InitializeGenericIpmiStandal= oneMm > > > > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnloa= d > > > > + > > > > +[Sources] > > > > + ../Common/IpmiHooks.h > > > > + ../Common/IpmiHooks.c > > > > + ../Common/IpmiBmcCommon.h > > > > + ../Common/KcsBmc.c > > > > + ../Common/KcsBmc.h > > > > + ../Common/IpmiBmc.c > > > > + ../Common/IpmiBmc.h > > > > + StandaloneMmGenericIpmi.c > > > > + > > > > +[Packages] > > > > + MdePkg/MdePkg.dec > > > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > + > > > > +[LibraryClasses] > > > > + MemoryAllocationLib > > > > + BaseLib > > > > + MmServicesTableLib > > > > + DebugLib > > > > + StandaloneMmDriverEntryPoint > > > > + IoLib > > > > + ReportStatusCodeLib > > > > + TimerLib > > > > + > > > > +[Protocols] > > > > + gSmmIpmiTransportProtocolGuid # PROTOCOL > > ALWAYS_PRODUCED > > > > + > > > > +[Guids] > > > > + > > > > +[Pcd] > > > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > > > > + > > > > +[Depex] > > > > + gIpmiTransportProtocolGuid > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > index 5df71300cbd1..73dca30caae9 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > @@ -129,4 +129,6 @@ > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > > D0000003 > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > > |0xD0000004 > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > > 0xD0000005 > > > > + > > > > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > > 6|0xD0000006 > > > > -- > > 2.26.2.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#109823): > > https://edk2.groups.io/g/devel/message/109823 > > Mute This Topic: https://groups.io/mt/102076516/7039027 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [abner.chang@amd.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110073): https://edk2.groups.io/g/devel/message/110073 Mute This Topic: https://groups.io/mt/102076516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-